Question about JMC-5604: Check bytecode verification flags

[Mario Torre]

On Fri, 2018-10-26 at 10:41 -0400, Elliott Baron wrote:
> Hi,
> 
> I started looking at this bug, and ran into some difficulty trying
> to 
> distinguish between -noverify and -Xverify:none. It seems the former
> is 
> a Java launcher argument which is converted to the latter before the
> JVM 
> is started. Thus, no matter which option the user specifies, the JVM 
> arguments will show -Xverify:none.
> 
> Any advice on how to proceed with this issue? JFR doesn't record 
> launcher arguments does it? (Please bear with me, I'm just getting 
> started with JMC development.)

Hi Elliott,

That doesn't seem to be a bug to me.

src/share/bin/java.c: 1153 (taken from a jdk8u)

} else if (JLI_StrCmp(arg, "-noverify") == 0) {
  AddOption("-Xverify:none", NULL);

I don't think there's any way for JMC to know that the original
argument was -noverify other than parsing command line options for the
pid, like:

cat /proc/<pid>/cmdline

I don't know if there's a cross platform way to do that, but I don't
think this information warrants this level of complication.

For all intent and purpouses the two options are equivalent.

Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898