JMC-6100 and JMC-6152 Trigger Alerts

[Marcus Hirt]

Agree with Ken. You select what action you want to take place if the rule is 
triggered. If you want a triggered rule to be displayed in the alert dialog,
then that is the action you should select. If you want something else to 
happen, you select another action. We route errors to the dialog to make them 
discoverable, as there is was no apparent place to place them that would
make people discover them. That does not mean we should always have the 
trigger dialog as a parallel, always on, action for everything.

It may mean that we should log problems somewhere else in the future...

Kind regards,
Marcus

On 2018-10-30, 10:53, "jmc-dev on behalf of Guru" <jmc-dev-bounces at openjdk.java.net on behalf of guru.hb at oracle.com> wrote:

    Thank you Ken,
    
    Yes, JMC-6100 is duplicate of JMC-6152. I have made one of the duplicate.
    Defect is about the Trigger Dialog not promoted even though the intended event had encountered. There will be a One Dialog for one trigger events (which also dumps hprof ). 
    
    Thanks,
    Guru
    > On 30-Oct-2018, at 11:06 PM, Ken Dobson <kdobson at redhat.com> wrote:
    > 
    > Hi All,
    > 
    > I was having a quick look at
    > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be
    > a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 .
    > It seems as if that is actually how it is intended to work as of right now,
    > as dumping an hprof file shouldn't provide an alert in JMC, just dump the
    > file to the location you've chosen which occurs correctly. The alert that
    > occurs the second time you turn the trigger on is an error for trying to
    > create a file that already exists as you had previously created it.
    > 
    > I was wondering if someone could provide some insight into whether we would
    > like to change this in some way, such as appending a timestamp to the hprof
    > to ensure file names aren't duplicated in case a user wanted to dump an
    > hprof more than once.
    > As well, logging a a trigger alert to a text file currently overwrites the
    > previous file so that is another option. That being said it seems odd to me
    > to keep just the most recent trigger alert rather than appending an alert
    > so that there's a log of the previous alerts.
    > 
    > Any insight into whether this is intended and why or whether this requires
    > changes would be appreciated.
    > 
    > Thanks,
    > 
    > Ken Dobson