JMC-6100/6152

Ken Dobson kdobson at redhat.com
Wed Oct 31 19:51:02 UTC 2018


Hi All,

This is a small patch to allows multiple HPROF dumps if a trigger is
triggered multiple times, rather than throwing an error when it tries to
create a file that already exists. This is done by appending a timestamp to
the end of the filename if it already exists.

Thanks,

Ken Dobson

diff -r b3a23786ef23
application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java
---
a/application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java
Wed Oct 10 16:43:35 2018 -0400
+++
b/application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java
Wed Oct 31 15:26:38 2018 -0400
@@ -44,6 +44,7 @@
 import org.openjdk.jmc.rjmx.RJMXPlugin;
 import org.openjdk.jmc.rjmx.triggers.TriggerAction;
 import org.openjdk.jmc.rjmx.triggers.TriggerEvent;
+import org.openjdk.jmc.ui.common.util.Filename;

 /**
  * This notification action triggers a hprof dump.
@@ -70,7 +71,7 @@
      */
     @Override
     public void handleNotificationEvent(TriggerEvent e) throws Exception {
-        String fileName = getSetting("filename").getString(); //$NON-NLS-1$
+        String fileName =
Filename.splitFilename(getSetting("filename").getString()).asRandomFilename().toString();
//$NON-NLS-1$
         Boolean onlyLive = getSetting("only_live").getBoolean();
//$NON-NLS-1$
         if (onlyLive == null) {
             onlyLive = Boolean.TRUE;


More information about the jmc-dev mailing list