Thoughts on code reviews.

[Marcus Hirt]

Goodie! I have e-mailed the OpenJDK registrar regarding Miro. For anything 
infrastructure/release engineering related, Guru can be considered a reviewer, 
effective immediately.

Kind regards,
Marcus

On 2018-09-07, 09:54, "jmc-dev on behalf of Mario Torre" <jmc-dev-bounces at openjdk.java.net on behalf of neugens at redhat.com> wrote:

    On 09/07/2018 12:45 AM, Marcus Hirt wrote:
    > Hi all,
    > 
    > The JMC project does not formally require code reviews, in the OpenJDK bylaws
    > sense of the term. That said, we still have the notion of reviewers, and each 
    > check-in must have been reviewed by someone else. We only have one active 
    > reviewer on the project today (me), and this has proven quite limiting.
    > 
    > I am suggesting that we do three things:
    > 
    > 1. We appoint Guru reviewer. Especially for all things infrastructure and 
    >    release engineering, a review by Guru is enough to push.
    >    
    > 2. We appoint Miro author (has two sponsored commits).
    > 
    > 3. Two authors together (with experience in the area of the code) can together 
    >    perform a review. At least for the foreseeable future. (Continuing the 
    >    summer's temporary policy.)
    > 
    > What do you think?
    
    Makes sense for me as well.
    
    Cheers,
    Mario
    
    
    -- 
    Mario Torre
    Associate Manager, Software Engineering
    Red Hat GmbH <https://www.redhat.com>
    9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898