Subject: Review request for JMC-6135: Cannot run core tests on JDK 11

Guru guru.hb at oracle.com
Wed Sep 12 15:16:59 UTC 2018


+1 Looks good to me 
Tested with 8u172b07 and 11eab20 , Both on 8 and 11 JDK tests compilation succeeded. 

Thanks,
Guru
> On 12-Sep-2018, at 8:33 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this fix to make core buildable (and testable) with JDK 11.
> 
> Jira: https://bugs.openjdk.java.net/browse/JMC-6135
> 
> Fix:
> diff -r 726d0b963dbb core/tests/pom.xml
> --- a/core/tests/pom.xml        Fri Sep 07 05:16:57 2018 +0530
> +++ b/core/tests/pom.xml        Wed Sep 12 07:58:34 2018 -0700
> @@ -117,7 +117,7 @@
>                                <artifactId>maven-surefire-plugin</artifactId>
>                                <version>2.22.0</version>
>                                <configuration>
> -                                       <argLine>-Duser.language=en -Duser.region=nl -Djava.locale.providers=JRE,CLDR</argLine>
> +                                       <argLine>-Duser.language=en -Duser.region=nl -Djava.locale.providers=COMPAT</argLine>
>                                        <includes>${test.includes}</includes>
>                                        <excludes>${test.excludes}</excludes>
>                                        <failIfNoTests>${fail.if.no.tests}</failIfNoTests>
> 
> 
> Kind regards,
> Marcus
> 
> 



More information about the jmc-dev mailing list