JMC-5639: Can't resolve event type names without Recording Settings event

[Marcus Hirt]

Thanks gents. The change has been pushed!

Kind regards,
Marcus

On 2018-09-20, 08:35, "jmc-dev on behalf of Miro Wengner" <jmc-dev-bounces at openjdk.java.net on behalf of miro.wengner at gmail.com> wrote:

    The patch looks good to me, I’ve it tested and I go proper messages
    Cheers,
    Miro
    
    > On Sep 20, 2018, at 5:25 PM, Mario Torre <neugens at redhat.com> wrote:
    > 
    > On 09/20/2018 04:29 PM, Marcus Hirt wrote:
    >> Took a closer look at this just now, and realized that there is one additional
    >> 
    >> change required:
    >> 
    >> 
    >> 
    >> http://cr.openjdk.java.net/~hirt/JMC-5663/webrev.03/
    > 
    > The patch looks good, I would like a test added though.
    > 
    > Perhaps, that could be the start of a shared repository of records for
    > tests, like we discussed over IRC?
    > 
    > Cheers,
    > Mario
    > 
    > --
    > Mario Torre
    > Associate Manager, Software Engineering
    > Red Hat GmbH <https://www.redhat.com>
    > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898