Review request for JMC-6123: Mission Control not recognising itself when running inside of Eclipse running on JDK 11

[Guru]

Hi Marcus, 

Changes look good to me, It works as expected if I run / launch the eclipse from my work space (i.e from project built from eclipse IDE) , But with one exception (Or it might be a problem mentioned in JMC-4455) i.e 
1. I built JMC project from terminal 
2. Launched eclipse with Latest JDK 11eab28 (using -vm /PATH_TO/JDK_11eab28/bin) 
3. Installed JMC to the eclipse which is running with JDK 11 (using “Install new Software” and path to my locally build Jmc ide update sites)
4. Restarted the eclipse 
5. JVM browser shows “[11] Local (PID)” installed of “[11] The JVM Running Mission Control (PID)”

After relaunching the eclipse (Step 2 : ) with "-vmargs -Djdk.attach.allowAttachSelf=true “ Then Eclipse shows the running JMC as “[11] The JVM Running Mission Control(PID)”.

Thanks,
Guru

> On 26-Sep-2018, at 10:42 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Please review this fix to make JMC recognize itself when launched in Eclipse 
> from within Eclipse. (Just adding -Djdk.attach.allowAttachSelf=true to the 
> Eclipse launchers.)
> 
> Jira: https://bugs.openjdk.java.net/browse/JMC-6123
> Diff:
> 
> diff -r 896f9586d4c6 configuration/ide/eclipse/launchers/JMC Eclipse plug-ins.launch
> --- a/configuration/ide/eclipse/launchers/JMC Eclipse plug-ins.launch   Thu Sep 20 08:32:13 2018 -0700
> +++ b/configuration/ide/eclipse/launchers/JMC Eclipse plug-ins.launch   Wed Sep 26 10:05:28 2018 -0700
> @@ -60,6 +60,7 @@
> <stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
> <stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
> +<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Djdk.attach.allowAttachSelf=true"/>
> <stringAttribute key="pde.version" value="3.3"/>
> <stringAttribute key="product" value="org.eclipse.platform.ide"/>
> <setAttribute key="selected_features">
> diff -r 896f9586d4c6 configuration/ide/eclipse/launchers/JMC Eclipse.launch
> --- a/configuration/ide/eclipse/launchers/JMC Eclipse.launch    Thu Sep 20 08:32:13 2018 -0700
> +++ b/configuration/ide/eclipse/launchers/JMC Eclipse.launch    Wed Sep 26 10:05:28 2018 -0700
> @@ -60,6 +60,7 @@
> <stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
> <stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
> +<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Djdk.attach.allowAttachSelf=true"/>
> <stringAttribute key="pde.version" value="3.3"/>
> <stringAttribute key="product" value="org.eclipse.platform.ide"/>
> <setAttribute key="selected_features">
> 
> Kind regards,
> Marcus
> 
>