Review Request for JMC-4469: Adding a page from the properties view

Ken Dobson kdobson at redhat.com
Tue Apr 2 20:02:32 UTC 2019


Thanks for the review, here's the webrev with trailing spaces removed.

http://cr.openjdk.java.net/~kdobson/addpagefromproperties1/webrev/

Thanks,

Ken Dobson

On Mon, Apr 1, 2019 at 9:44 PM Marcus Hirt <marcus.hirt at datadoghq.com>
wrote:

> Hi Ken!
>
> There are some trailing spaces that should be removed, but other than that
> it looks good!
>
> Kind regards,
> Marcus
>
> On Mon, Apr 1, 2019 at 7:14 PM Ken Dobson <kdobson at redhat.com> wrote:
>
>> Hi all,
>> please review this patch for JMC-4469 to allow for adding a page with the
>> events selected in the property view.
>>
>> bug: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-4469
>> webrev: http://cr.openjdk.java.net/~kdobson/addpagefromproperties/webrev/
>>
>> Thanks,
>>
>> Ken Dobson
>>
>


More information about the jmc-dev mailing list