RFR: 8185525: [Event Request] Add Tracing event for DictionarySizes

[coleen.phillimore at oracle.com]

On 4/11/19 1:08 PM, gerard ziemski wrote:
>
>
> On 4/10/19 5:01 PM, coleen.phillimore at oracle.com wrote:
>>
>> http://cr.openjdk.java.net/~gziemski/8185525_rev5/src/hotspot/share/utilities/tableStatistics.cpp.html
>>
>> Sorry I didn't notice this before but these constructors should have 
>> initializers like:
>>
>>    31 TableRateStatistics::TableRateStatistics() {
>>    32   _added_items = 0;
>>    33   _removed_items = 0;
>>    34
>>    35   _time_stamp = 0;
>>    36   _seconds_stamp = 0.0;
>>    37   _added_items_stamp = 0;
>>    38   _added_items_stamp_prev = 0;
>>    39   _removed_items_stamp = 0;
>>    40   _removed_items_stamp_prev = 0;
>>    41 }
>> Should be:
>>    31 TableRateStatistics::TableRateStatistics() :
>>    32   _added_items(0), _removed_items(0), _time_stamp(0), etc. {}
>> Kim could tell you why this is better but he's on vacation.
>
> Done.
>
> I also went back to src/hotspot/share/jfr/periodic/jfrPeriodic.cpp and 
> changed TableEventFiller::fill() to be static, since we don't actually 
> need an instance of TableEventFiller to do its job.
>
> webrev: http://cr.openjdk.java.net/~gziemski/8185525_rev6
>
>

Yes, this looks really good!
Thanks,
Coleen
> cheers