Review request for JM-6544: Add support to parse Java internal version of Zulu JVM

[Mario Torre]

On 05/08/2019 10:31, Florian David wrote:
> I have been told that the patch was removed from the previous mail.
> Please find a web review instead:
> 
> JIRA: https://bugs.openjdk.java.net/browse/JMC-6544
> Webrev: http://cr.openjdk.java.net/~fdavid/JMC-6544/webrev.0/

Hi Florian,

To be honest, I already expressed concerns about this
FlightRecordingSupportRule, I don't think it's a good idea to make JMC
know every single java vendor out there in the world.

I would rather prefer such patches are either internal to vendors and
not exposed in the upstream project, but more generally we should rework
this mechanisms in order to be vendor-agnostic rather than add more
special cases.

Cheers,
Mario

> On Sun, Aug 4, 2019 at 6:12 PM Florian David <florian.david at datadoghq.com>
> wrote:
> 
>> Hi,
>>
>>
>> Please find attached a patch to solve an error that arise when parsing
>> Zulu internal version [0]. I also added a test with a representative set of
>> Java internal versions of the Zulu JVM, even if it's far from covering
>> every single case.
>>
>>
>> Regards,
>>
>> Florian
>>
>>
>> [0] https://bugs.openjdk.java.net/browse/JMC-6544
>>
>>
>>
>>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898