Review request for JMC-6548: Duplicated Flags rule somewhat naive

Florian David florian.david at datadoghq.com
Tue Aug 6 12:40:36 UTC 2019


Hi,

Please find attached a webrev to solve JMC-6548.

I have also corrected a small bug on line 123 (String[] split =
fullArgument.split("[=:]",
2);). In case fullArgument contains more than one ':' (for instance
"-javaagent:C:/mypath"), split[1] does not contain the exact option
argument (in this case only "C"), which could give inconsistent results.

JIRA: https://bugs.openjdk.java.net/browse/JMC-6548
Webrev: http://cr.openjdk.java.net/~fdavid/JMC-6548/webrev.0/

Thanks,
Florian


More information about the jmc-dev mailing list