JMC-5640: Used Heap After GC Chart
Mario Torre
neugens at redhat.com
Wed Aug 7 14:22:27 UTC 2019
On Wed, Aug 7, 2019 at 4:13 PM Henrik Dafgård <hdafgard at gmail.com> wrote:
>
> Hi all,
>
> I agree that there should be a better way to do this, but for now this looks good with the minor change of moving the Attribute and Query to the GarbageCollectionsPage instead of having them in core. I think it's far too confusing to have an attribute called HEAP_USED_POST_GC that's a duplicate of HEAP_USED in the core APIs, this is just going to lead to hard to identify bugs for downstream applications in the future.
>
Right, this is a good point. It also make it more difficult to
refactor in the future if they are "officially" visible.
Ken, once you fix this, can you please file a new bug report to track
the refactoring?
Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jmc-dev
mailing list