JMC-5640: Used Heap After GC Chart

[Henrik Dafgård]

Hi all,

This looks good to me!


Cheers,
Henrik Dafgård


On Wed, 7 Aug 2019 at 17:37, Ken Dobson <kdobson at redhat.com> wrote:

> Hi all,
>
> Thanks for the review, I've moved the attribute and query to the Garbage
> Collection Page which should certainly be less confusing.
>
> Yes I'll open a bug report for refactoring the attributes.
>
> webrev: http://cr.openjdk.java.net/~kdobson/JMC-5640/webrev.01/
>
> Cheers,
>
> Ken Dobson
>
> On Wed, Aug 7, 2019 at 10:23 AM Mario Torre <neugens at redhat.com> wrote:
>
>> On Wed, Aug 7, 2019 at 4:13 PM Henrik Dafgård <hdafgard at gmail.com> wrote:
>> >
>> > Hi all,
>> >
>> > I agree that there should be a better way to do this, but for now this
>> looks good with the minor change of moving the Attribute and Query to the
>> GarbageCollectionsPage instead of having them in core. I think it's far too
>> confusing to have an attribute called HEAP_USED_POST_GC that's a duplicate
>> of HEAP_USED in the core APIs, this is just going to lead to hard to
>> identify bugs for downstream applications in the future.
>> >
>>
>> Right, this is a good point. It also make it more difficult to
>> refactor in the future if they are "officially" visible.
>>
>> Ken, once you fix this, can you please file a new bug report to track
>> the refactoring?
>>
>> Cheers,
>> Mario
>>
>>
>> --
>> Mario Torre
>> Associate Manager, Software Engineering
>> Red Hat GmbH <https://www.redhat.com>
>> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>>
>