JMC-6553 Update error message when JFR is not available

Mon Aug 26 13:58:40 UTC 2019

Looks good to me, but I'd like someone from Oracle to weigh in, especially
on the change to JVMSupport_FLIGHT_RECORDER_NOT_ENABLED. Guru?

Kind regards,
Marcus

On Mon, Aug 26, 2019 at 3:11 PM Salman Siddiqui <sasiddiq at redhat.com> wrote:

> Hi Marcus,
>
> Thanks for the correction. Fixed below.
>
> Regards,
> Salman
>
>
> diff -r cc07a1f270e9
>
> application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
> ---
>
> a/application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
>    Mon Aug 19 11:57:12 2019 -0400
> +++
>
> b/application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
>    Fri Aug 23 15:29:46 2019 -0400
> @@ -45,7 +45,7 @@
>  JVMSupport_TITLE_TOO_OLD_JVM_CONSOLE=Too Old JVM
> JVMSupport_MESSAGE_NOT_A_KNOWN_JVM=You are attempting to connect to an
> unknown JVM. This will most likely not succeed unless you're running the
> JMX Console, and even then functionality will be limited. \n\nAre you sure
> you want to continue?
>  JVMSupport_MESSAGE_JROCKIT_NOT_SUPPORTED=You are attempting to connect to
> a JRockit JVM. To connect to a JRockit JVM, please use JRockit Mission
> Control 4.1 for JRockit R28, and JRockit Mission Control 3.1 for JRockit
> R27. \nIf you connect to a JRockit, functionality will be limited. \n\nAre
> you sure you want to continue?
> -JVMSupport_MESSAGE_TOO_OLD_JVM_CONSOLE=The JVM you are connecting to is
> not recent enough for full functionality in the JMX Console. For full
> functionality you need to connect to a Java 7u40 or later JVM. Do you still
> want to connect?
> +JVMSupport_MESSAGE_TOO_OLD_JVM_CONSOLE=The JVM you are connecting to is
> not recent enough for full functionality in the JMX Console. For full
> functionality you need to connect to an Oracle JDK 7u40 or later JVM or an
> OpenJDK 11+ JVM. Do you still want to connect?
>  JVMSupport_JROCKIT_NOT_LONGER_SUPPORTED=JRockit is no longer supported.
> Use a 4.x version of Mission Control when connecting to a JRockit.
>  JVMSupport_JROCKIT_NOT_LONGER_SUPPORTED_SHORT=JRockit is no longer
> supported  JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_OLD_HOTSPOT=Flight
> Recorder is not supported for JVMs with Java versions below 7u4 @@ -54,7
> +54,7 @@
> JVMSupport_FLIGHT_RECORDER_NOT_FULLY_SUPPORTED_OLD_HOTSPOT_SHORT=Flight
> Recorder is not fully supported for JVMs with Java versions below 7u40
> JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_NOT_HOTSPOT=Flight Recorder is not
> supported for non HotSpot JVMs
> JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_NOT_HOTSPOT_SHORT=Flight Recorder
> is not supported for non HotSpot JVMs
> -JVMSupport_FLIGHT_RECORDER_NOT_ENABLED=Flight Recorder features are not
> enabled. To enable this you need to use a Java 7u4 or later JVM started
> with -XX:+UnlockCommercialFeatures -XX:+FlightRecorder.
> +JVMSupport_FLIGHT_RECORDER_NOT_ENABLED=Flight Recorder features are not
> enabled. To enable this you need to use an Oracle JDK 7u4 or later JVM
> started with -XX:+UnlockCommercialFeatures -XX:+FlightRecorder or an
> OpenJDK 11+ JVM.
>  JVMSupport_FLIGHT_RECORDER_NOT_ENABLED_SHORT=Flight Recorder features are
> not enabled  JVMSupport_FLIGHT_RECORDER_DISABLED=Flight Recorder is
> explicitly disabled. To enable the Flight Recorder, remove
> -XX:-FlightRecorder from the command line.
>  JVMSupport_FLIGHT_RECORDER_DISABLED_SHORT=Flight Recorder is explicitly
> disabled
>
> On Fri, Aug 23, 2019 at 4:30 PM Marcus Hirt <marcus at hirt.se> wrote:
>
> > Hi Salman,
> >
> > I believe the Oracle JDK has a space between Oracle and JDK
> > (as opposed to OpenJDK, which is written together).
> >
> > Kind regards,
> > Marcus
> >
> > -----Ursprungligt meddelande-----
> > Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Salman Siddiqui
> > Skickat: den 23 augusti 2019 21:31
> > Till: jmc-dev at openjdk.java.net
> > Ämne: RFR: JMC-6553 Update error message when JFR is not available
> >
> > Hi all,
> >
> > Please review edit to error message for unavailable JFR below.
> >
> > JIRA: https://bugs.openjdk.java.net/browse/JMC-6553
> >
> > Thanks,
> > Salman
> >
> >
> > diff -r cc07a1f270e9
> >
> >
> application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
> > ---
> >
> >
> a/application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
> >    Mon Aug 19 11:57:12 2019 -0400
> > +++
> >
> >
> b/application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties
> >    Fri Aug 23 15:29:46 2019 -0400
> > @@ -45,7 +45,7 @@
> >  JVMSupport_TITLE_TOO_OLD_JVM_CONSOLE=Too Old JVM
> > JVMSupport_MESSAGE_NOT_A_KNOWN_JVM=You are attempting to connect to an
> > unknown JVM. This will most likely not succeed unless you're running the
> > JMX Console, and even then functionality will be limited. \n\nAre you
> sure
> > you want to continue?
> >  JVMSupport_MESSAGE_JROCKIT_NOT_SUPPORTED=You are attempting to connect
> to
> > a JRockit JVM. To connect to a JRockit JVM, please use JRockit Mission
> > Control 4.1 for JRockit R28, and JRockit Mission Control 3.1 for JRockit
> > R27. \nIf you connect to a JRockit, functionality will be limited.
> \n\nAre
> > you sure you want to continue?
> > -JVMSupport_MESSAGE_TOO_OLD_JVM_CONSOLE=The JVM you are connecting to is
> > not recent enough for full functionality in the JMX Console. For full
> > functionality you need to connect to a Java 7u40 or later JVM. Do you
> still
> > want to connect?
> > +JVMSupport_MESSAGE_TOO_OLD_JVM_CONSOLE=The JVM you are connecting to is
> > not recent enough for full functionality in the JMX Console. For full
> > functionality you need to connect to an OracleJDK 7u40 or later JVM or an
> > OpenJDK 11+ JVM. Do you still want to connect?
> >  JVMSupport_JROCKIT_NOT_LONGER_SUPPORTED=JRockit is no longer supported.
> > Use a 4.x version of Mission Control when connecting to a JRockit.
> >  JVMSupport_JROCKIT_NOT_LONGER_SUPPORTED_SHORT=JRockit is no longer
> > supported  JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_OLD_HOTSPOT=Flight
> > Recorder is not supported for JVMs with Java versions below 7u4 @@ -54,7
> > +54,7 @@
> > JVMSupport_FLIGHT_RECORDER_NOT_FULLY_SUPPORTED_OLD_HOTSPOT_SHORT=Flight
> > Recorder is not fully supported for JVMs with Java versions below 7u40
> > JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_NOT_HOTSPOT=Flight Recorder is
> not
> > supported for non HotSpot JVMs
> > JVMSupport_FLIGHT_RECORDER_NOT_SUPPORTED_NOT_HOTSPOT_SHORT=Flight
> Recorder
> > is not supported for non HotSpot JVMs
> > -JVMSupport_FLIGHT_RECORDER_NOT_ENABLED=Flight Recorder features are not
> > enabled. To enable this you need to use a Java 7u4 or later JVM started
> > with -XX:+UnlockCommercialFeatures -XX:+FlightRecorder.
> > +JVMSupport_FLIGHT_RECORDER_NOT_ENABLED=Flight Recorder features are not
> > enabled. To enable this you need to use an OracleJDK 7u4 or later JVM
> > started with -XX:+UnlockCommercialFeatures -XX:+FlightRecorder or an
> > OpenJDK 11+ JVM.
> >  JVMSupport_FLIGHT_RECORDER_NOT_ENABLED_SHORT=Flight Recorder features
> are
> > not enabled  JVMSupport_FLIGHT_RECORDER_DISABLED=Flight Recorder is
> > explicitly disabled. To enable the Flight Recorder, remove
> > -XX:-FlightRecorder from the command line.
> >  JVMSupport_FLIGHT_RECORDER_DISABLED_SHORT=Flight Recorder is explicitly
> > disabled
> >
> >
>