Sv: RFR: JMC-6534 String deduplication rule assumes only G1 has feature

[Marcus Hirt]

Hi David,

Would you perhaps be able to verify the Japanese translations?

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Jie Kang
Skickat: den 29 augusti 2019 19:04
Till: Henrik Dafgård <hdafgard at gmail.com>; Marcus Hirt <marcus.hirt at datadoghq.com>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: RFR: JMC-6534 String deduplication rule assumes only G1 has feature

On Fri, Aug 16, 2019 at 10:17 AM Henrik Dafgård <hdafgard at gmail.com> wrote:
>
> Hi Jie,
>
> This change looks good to me!

Thanks for reviewing this! I have found some volunteers to offer translations (non-professional) for Chinese and Japanese. Marcus, what needs to be done to get these translations accepted? I have also switched some links to https instead of http.

Updated Webrev:
https://cr.openjdk.java.net/~jkang/jmc-6534/webrev.02/
JIRA:
https://bugs.openjdk.java.net/browse/JMC-6534


Regards,


>
>
> Cheers,
> Henrik Dafgård
>
>
> On Fri, 16 Aug 2019 at 16:11, Jie Kang <jkang at redhat.com> wrote:
>>
>> Hi,
>>
>> Please review this update to the String Deduplication rule. It now 
>> also checks for Shenandoah GC and the messages have been updated 
>> appropriately. I would also like to request translation assistance 
>> for said messages for Chinese and Japanese. Specifically:
>>
>> StringDeduplicationRule_RESULT_LONG_DESCRIPTION
>> StringDeduplicationRule_RESULT_GC_LONG
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jkang/jmc-6534/webrev.01/
>> JIRA:
>> https://bugs.openjdk.java.net/browse/JMC-6534
>>
>>
>> Regards,