[Rev 01] RFR: 5660: Lazy initialize timestamp unit description

Marcus Hirt hirt at openjdk.java.net
Wed Dec 11 17:48:55 UTC 2019


On Wed, 11 Dec 2019 17:48:55 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> Creating a string description for each timestamp unit instance is far too expensive since we have to create a new unit for e.g. each duration comparison. So rules that perform such comparisons cause a lot of unnecessary allocations, on my local machine I estimate that this will reduce total allocations by around 50% for rules evaluations.
>> 
>> This doesn't really fix JMC-5660, but will reduce the performance cost until we get a more proper fix for this bug.
> 
> The pull request has been updated with 1 additional commit.



-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/15


More information about the jmc-dev mailing list