Sv: RFR: 6554: Support JFR in OpenJDK 8

[Marcus Hirt]

Hi Mario,

Yep, it's tested against various Oracle JDKs and Shipilev's build of the incubator (on Windows).

Kind regards,
Marcus 

-----Ursprungligt meddelande-----
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Mario Torre
Skickat: den 14 december 2019 08:47
Till: Marcus Hirt <hirt at openjdk.java.net>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: RFR: 6554: Support JFR in OpenJDK 8

Hi Marcus,

The patch looks good.

I can’t test it right now but I assume you tested with the JFR-incubator so it should be ok to push.

Cheers,
Mario

On Saturday, December 14, 2019, Marcus Hirt <hirt at openjdk.java.net> wrote:

> > This is for OpenJDK 8 implementations that have backported JFR, e.g.
> Azul's JDK. There is also a backport effort for OpenJDK 8 in general.
>
> The pull request has been updated with 1 additional commit.
>
> -------------
>
> Added commits:
>  - 963d159c: Fixing tests and supporting vendor classification without 
> JVMDescriptor
>
> Changes:
>   - all: https://git.openjdk.java.net/jmc/pull/19/files
>   - new: 
> https://git.openjdk.java.net/jmc/pull/19/files/017555a4..963d159c
>
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jmc/19/webrev.05
>  - incr: https://webrevs.openjdk.java.net/jmc/19/webrev.04-05
>
>   Stats: 49 lines in 3 files changed: 21 ins; 4 del; 24 mod
>   Patch: https://git.openjdk.java.net/jmc/pull/19.diff
>   Fetch: git fetch https://git.openjdk.java.net/jmc 
> pull/19/head:pull/19
>
> PR: https://git.openjdk.java.net/jmc/pull/19
>
>

--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com><br>9704 A60C B4BE A8B8 0F30
9205 5D7E 4952 3F65 7898