RFR: 5721: Reintroduce the Percentage column

Dmitry Popov github.com+7112604+dmnm at openjdk.java.net
Mon Dec 16 16:07:39 UTC 2019


On Tue, 10 Dec 2019 10:36:28 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This patch addresses [JMC-5721](https://bugs.openjdk.java.net/browse/JMC-5721): Reintroduce the Percentage column.
>> 
>> 1. StacktraceView has been amended to display Percentage column as well it displays stack trace and count ones. Percentage format is #.## (up-to 2 decimal points), it will also arbitrarily round the number.
>> 2. Tool tip with frame fraction and sibling groups info has been moved from Count column to Percentage.
>> 3. Currently Background drawer decorates Percentage column instead of Count.
> 
> Hi Dmitry! Have you, or the company you are working for, signed the OCA?

> Hi Dmitry! Have you, or the company you are working for, signed the OCA?

Hi,
No, but I can do that if necessary. BTW, are there any comments about the PR, approach, code style, commit message, etc?

-------------

PR: https://git.openjdk.java.net/jmc/pull/12


More information about the jmc-dev mailing list