RFR: 6658: Remove unnecessary storing of pre-instrumented bytecode

Marcus Hirt hirt at openjdk.java.net
Fri Dec 20 19:02:27 UTC 2019


On Thu, 19 Dec 2019 19:52:39 GMT, Jessye Coleman-Shapiro <github.com+29706926+jessyec-s at openjdk.org> wrote:

> This patch addresses [JMC-6658](https://bugs.openjdk.java.net/browse/JMC-6658) and removes the unnecessary storing of pre-instrumented bytecode that was implemented in [JMC-5458](https://bugs.openjdk.java.net/browse/JMC-5458).

Hi Jessye! Looks good, but the testClearAllTransforms tests should really validate that the byte code no longer contains the events. Also, since test execution can't be known, the clear all transforms test should first attempt to transform. Also - the JMX API should really, really not return (potentially serialize) classes, but I will open a separate issue for this, as it is not related to this PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/23


More information about the jmc-dev mailing list