JMC-6367 - Improve Thread graph tooltip

[Marcus Hirt]

Hi Alex,

Excellent! Looks exactly like we discussed. :) Feel free to push!

Kind regards,
Marcus

On 2019-02-15, 16:29, "jmc-dev on behalf of Langer, Christoph" <jmc-dev-bounces at openjdk.java.net on behalf of christoph.langer at sap.com> wrote:

    Hi Alex,
    
    I had a look at your change. As I'm quite new to JMC it was merely to learn something ��
    
    However, I could verify that your fix works and improves things in the thread lanes. I also couldn't find obvious mistakes.
    
    But as newbie and since I'm no reviewer here I have to defer the real review to the JMC experts.
    
    Best regards
    Christoph
    
    > -----Original Message-----
    > From: jmc-dev <jmc-dev-bounces at openjdk.java.net> On Behalf Of Alex
    > Macdonald
    > Sent: Donnerstag, 14. Februar 2019 22:22
    > To: jmc-dev at openjdk.java.net
    > Subject: RFR: JMC-6367 - Improve Thread graph tooltip
    > 
    > Hi,
    > 
    > The following webrev [0] addresses issue JMC-6367 [1], in which the thread
    > lane tooltips should display descriptive information (thread & lane names)
    > pertaining to the highlighted lane.
    > 
    > The information to be displayed in the tooltip had to be carried in the
    > Span object which is passed to the ChartToolTipProvider. There was an
    > unused String description argument in the QuantitySpanRenderer which fits
    > this need, and allows for the passing of the tooltip title from the
    > ThreadGraphLanes through the QuantitySpanRenderer to the
    > QuantitySpanRendering. This change was also mirrored in the SpanRenderer.
    > If the Span obj has a description when it hits the ChartToolTipProvider, a
    > title will be appended to the tooltip.
    > 
    > I've created an imgur album [2] to show some examples. Some images
    > illustrate the before and after of this patch when viewing tooltips for a
    > thread [3][4], and viewing a thread that corresponds to an active filter
    > (e.g., Java Latencies lane) [5][6].
    > 
    > Thoughts?
    > 
    > Cheers,
    > 
    > Alex
    > 
    > [0] http://cr.openjdk.java.net/~aptmac/JMC-6367/webrev.00/
    > [1] https://bugs.openjdk.java.net/browse/JMC-6367
    > [2] https://imgur.com/a/TOuq1ez
    > [3] https://imgur.com/ueAbwHz
    > [4] https://imgur.com/OOqYZ4I
    > [5] https://imgur.com/K7JCa66
    > [6] https://imgur.com/mPe3ah3