Review request for JMC-6418: Possible null dereference in LocalJVMToolkit

[Marcus Hirt]

Hi all,

Please review this fix for a possible null dereference in LocalJVMToolkit.

JBS:  https://bugs.openjdk.java.net/browse/JMC-6418

diff -r c4a293a6be19 application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java
--- a/application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java
      Tue Feb 19 15:49:59 2019 -0500
+++ b/application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java
      Fri Feb 22 11:04:26 2019 +0100
@@ -391,7 +391,9 @@
                                                connectable = NO;
                                        } finally {
                                                // Always detach. Releases one process handle on Windows.
-                                               vm.detach();
+                                               if (vm != null) {
+                                                       vm.detach();
+                                               }
                                        }
                                        if (connectable.isAttachable()) {
                                                connDesc = createDescriptor(javaArgs, jvmArgs, Integer.parseInt(vmd.id()), connectable, jvmType, jvmArch,

Kind regards,
Marcus