From marcus.hirt at oracle.com Wed Jan 2 19:34:06 2019 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Wed, 02 Jan 2019 19:34:06 +0000 Subject: hg: jmc/jmc7: JMC-5888: Splash screen with updated copyright year Message-ID: <201901021934.x02JY6mJ009506@aojmv0008.oracle.com> Changeset: 0077a4cc7e9e Author: hirt Date: 2019-01-02 20:33 +0100 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/0077a4cc7e9e JMC-5888: Splash screen with updated copyright year Reviewed-by: ghb ! application/org.openjdk.jmc.rcp.application/splash.bmp From guru.hb at oracle.com Thu Jan 3 07:18:06 2019 From: guru.hb at oracle.com (Guru) Date: Thu, 3 Jan 2019 12:48:06 +0530 Subject: Review request : JMC-6307 : Incorrect Index in Update site Toolkit Message-ID: <52E204FA-A86C-4845-A688-A77DCA1CE295@oracle.com> Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6307 Diff : diff -r 8504b6bb4899 application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java --- a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java Thu Dec 20 22:20:26 2018 +0100 +++ b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java Thu Jan 03 12:43:14 2019 +0530 @@ -68,7 +68,7 @@ do { site = props.getProperty("updatesite." + i++); //$NON-NLS-1$ if (site != null) { - updateSites.add(MessageFormat.format(site, ApplicationPlugin.FULL_VERSION)); + updateSites.add(MessageFormat.format(site, ApplicationPlugin.VERSION)); } } while (site != null); } Solution update in JBS. Thanks, Guru From sharath.ballal at oracle.com Thu Jan 3 09:09:51 2019 From: sharath.ballal at oracle.com (Sharath Ballal) Date: Thu, 3 Jan 2019 01:09:51 -0800 (PST) Subject: Review request : JMC-6307 : Incorrect Index in Update site Toolkit In-Reply-To: <52E204FA-A86C-4845-A688-A77DCA1CE295@oracle.com> References: <52E204FA-A86C-4845-A688-A77DCA1CE295@oracle.com> Message-ID: +1 Thanks, Sharath -----Original Message----- From: Guru Sent: Thursday, January 03, 2019 12:48 PM To: jmc-dev at openjdk.java.net Subject: Review request : JMC-6307 : Incorrect Index in Update site Toolkit Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6307 Diff : diff -r 8504b6bb4899 application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java --- a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java Thu Dec 20 22:20:26 2018 +0100 +++ b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java Thu Jan 03 12:43:14 2019 +0530 @@ -68,7 +68,7 @@ do { site = props.getProperty("updatesite." + i++); //$NON-NLS-1$ if (site != null) { - updateSites.add(MessageFormat.format(site, ApplicationPlugin.FULL_VERSION)); + updateSites.add(MessageFormat.format(site, ApplicationPlugin.VERSION)); } } while (site != null); } Solution update in JBS. Thanks, Guru From guru.hb at oracle.com Thu Jan 3 09:42:22 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 03 Jan 2019 09:42:22 +0000 Subject: hg: jmc/jmc: JMC-6307: Incorrect Index in Update site Toolkit Message-ID: <201901030942.x039gNnH028735@aojmv0008.oracle.com> Changeset: 0e5e6d991b09 Author: ghb Date: 2019-01-03 15:12 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/0e5e6d991b09 JMC-6307: Incorrect Index in Update site Toolkit Reviewed-by: sballal ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java From guru.hb at oracle.com Thu Jan 3 10:29:40 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 03 Jan 2019 10:29:40 +0000 Subject: hg: jmc/jmc7: JMC-6307: Incorrect Index in Update site Toolkit Message-ID: <201901031029.x03ATebX016082@aojmv0008.oracle.com> Changeset: d9ed72161cd1 Author: ghb Date: 2019-01-03 15:12 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/d9ed72161cd1 JMC-6307: Incorrect Index in Update site Toolkit Reviewed-by: sballal ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/UpdateSiteURLToolkit.java From guru.hb at oracle.com Thu Jan 3 11:24:28 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 03 Jan 2019 11:24:28 +0000 Subject: hg: jmc/jmc: JMC-6287: Missing Third Party ReadMe(TPRM) in JMC 7.0.0 installer and bundle Message-ID: <201901031124.x03BOTXs005461@aojmv0008.oracle.com> Changeset: 80f49c3226cb Author: ghb Date: 2019-01-03 16:54 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/80f49c3226cb JMC-6287: Missing Third Party ReadMe(TPRM) in JMC 7.0.0 installer and bundle Reviewed-by: ghb Contributed-by: Tejpal Rebari + license/COPYRIGHT ! pom.xml From guru.hb at oracle.com Thu Jan 3 11:27:08 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 03 Jan 2019 11:27:08 +0000 Subject: hg: jmc/jmc7: JMC-6287: Missing Third Party ReadMe(TPRM) in JMC 7.0.0 installer and bundle Message-ID: <201901031127.x03BR8xb006861@aojmv0008.oracle.com> Changeset: 244fd63c6c84 Author: ghb Date: 2019-01-03 16:54 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/244fd63c6c84 JMC-6287: Missing Third Party ReadMe(TPRM) in JMC 7.0.0 installer and bundle Reviewed-by: ghb Contributed-by: Tejpal Rebari + license/COPYRIGHT ! pom.xml From prem.balakrishnan at oracle.com Thu Jan 3 13:11:10 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Thu, 3 Jan 2019 05:11:10 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Message-ID: Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From jkang at redhat.com Thu Jan 3 14:37:10 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 3 Jan 2019 09:37:10 -0500 Subject: Review Request: Fix 2018-09 Platform Definition Message-ID: Hi, The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts? diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target +++ b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target @@ -34,9 +34,11 @@ - - + + + + Regards, From prem.balakrishnan at oracle.com Thu Jan 3 16:05:42 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Thu, 3 Jan 2019 08:05:42 -0800 (PST) Subject: Review Request: Fix 2018-09 Platform Definition In-Reply-To: References: Message-ID: Hi Jie, Thank you for bringing this to our attention. We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch. Request you to create a bug for the same and update the review thread. Regards, Prem -----Original Message----- From: Jie Kang Sent: Thursday, January 03, 2019 8:07 PM To: jmc-dev at openjdk.java.net Subject: Review Request: Fix 2018-09 Platform Definition Hi, The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts? diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target +++ b/releng/platform-definitions/platform-definition-2018-09/platform-d +++ efinition-2018-09.target @@ -34,9 +34,11 @@ - - + + + + Regards, From jkang at redhat.com Thu Jan 3 16:49:05 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 3 Jan 2019 11:49:05 -0500 Subject: Review Request: Fix 2018-09 Platform Definition In-Reply-To: References: Message-ID: On Thu, Jan 3, 2019 at 11:07 AM Prem Balakrishnan wrote: > > Hi Jie, > > Thank you for bringing this to our attention. > > We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch. > > Request you to create a bug for the same and update the review thread. Hi Prem, Thanks for taking a look at this! I am not an Author so I can't create bugs for JMC; I have asked Alex to create one for me and it's: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6309 Regards, > > > Regards, > Prem > > -----Original Message----- > From: Jie Kang > Sent: Thursday, January 03, 2019 8:07 PM > To: jmc-dev at openjdk.java.net > Subject: Review Request: Fix 2018-09 Platform Definition > > Hi, > > The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the > 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts? > > diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > +++ b/releng/platform-definitions/platform-definition-2018-09/platform-d > +++ efinition-2018-09.target > @@ -34,9 +34,11 @@ > > > includeConfigurePhase="true" includeMode="planner" > includeSource="true" type="InstallableUnit"> > - > - > + > > + > + > + > > > > > > Regards, From kdobson at redhat.com Thu Jan 3 19:44:13 2019 From: kdobson at redhat.com (Ken Dobson) Date: Thu, 3 Jan 2019 14:44:13 -0500 Subject: JMC-6223- Visualize the PID from JVM Information Event Message-ID: Hi all, Here's a patch adding the PID to the JVM Internals page because I saw that https://bugs.openjdk.java.net/browse/JDK-8213617 had been completed so this ticket was no longer blocked. I've just posted it verbatim below as I'm still waiting on my OpenJDK registration email. Thanks, Ken Dobson diff -r abb4b7f54009 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Dec 06 19:12:44 2018 +0100 +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Jan 03 11:57:09 2019 -0500 @@ -162,6 +162,7 @@ infoViewer = new ItemAggregateViewer(jvmInfSection, toolkit); infoViewer.addAggregate(JdkAggregators.JVM_START_TIME); infoViewer.addAggregate(JdkAggregators.JVM_NAME); + infoViewer.addAggregate(JdkAggregators.JVM_PID); infoViewer.addAggregate(JdkAggregators.JVM_VERSION); infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS); infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Jan 03 11:57:09 2019 -0500 @@ -113,6 +113,8 @@ // VM Info public static final IAggregator JVM_NAME = distinctAsString(VM_INFO, JdkAttributes.JVM_NAME); + public static final IAggregator JVM_PID = min(JdkAttributes.JVM_PID.getName(), null, + VM_INFO, JdkAttributes.JVM_PID); public static final IAggregator JVM_START_TIME = min(JdkAttributes.JVM_START_TIME.getName(), null, VM_INFO, JdkAttributes.JVM_START_TIME); public static final IAggregator JVM_VERSION = distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Jan 03 11:57:09 2019 -0500 @@ -441,6 +441,8 @@ Messages.getString(Messages.ATTR_JVM_START_TIME), TIMESTAMP); public static final IAttribute JVM_NAME = attr("jvmName", Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$ PLAIN_TEXT); + public static final IAttribute JVM_PID = attr("pid", Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$ + NUMBER); public static final IAttribute JVM_VERSION = attr("jvmVersion", //$NON-NLS-1$ Messages.getString(Messages.ATTR_JVM_VERSION), PLAIN_TEXT); public static final IAttribute JVM_ARGUMENTS = attr("jvmArguments", //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Jan 03 11:57:09 2019 -0500 @@ -314,6 +314,7 @@ public static final String ATTR_JAVA_ARGUMENTS = "ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_ARGUMENTS = "ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME"; //$NON-NLS-1$ + public static final String ATTR_JVM_PID = "ATTR_JVM_PID"; //$NON-NLS-1$ public static final String ATTR_JVM_START_TIME = "ATTR_JVM_START_TIME"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM_DESC = "ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Jan 03 11:57:09 2019 -0500 @@ -53,6 +53,7 @@ ATTR_REC_SETTING_VALUE=Setting Value ATTR_JVM_START_TIME=JVM Start Time ATTR_JVM_NAME=JVM Name +ATTR_JVM_PID = JVM PID ATTR_JVM_VERSION=JVM Version ATTR_JVM_ARGUMENTS=JVM Arguments ATTR_JAVA_ARGUMENTS=JVM Application Arguments From marcus.hirt at oracle.com Thu Jan 3 20:06:47 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 3 Jan 2019 21:06:47 +0100 Subject: Review Request: Fix 2018-09 Platform Definition In-Reply-To: References: Message-ID: I have a fix which fixes this as part of the upgrade to Eclipse 2018-12. Let me check how far along the Jakarta-approval is first. Kind regards, Marcus - Excuse me if terse; sent from my phone. > On 3 Jan 2019, at 17:49, Jie Kang wrote: > > On Thu, Jan 3, 2019 at 11:07 AM Prem Balakrishnan > wrote: >> >> Hi Jie, >> >> Thank you for bringing this to our attention. >> >> We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch. >> >> Request you to create a bug for the same and update the review thread. > > Hi Prem, > > Thanks for taking a look at this! I am not an Author so I can't create > bugs for JMC; I have asked Alex to create one for me and it's: > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6309 > > > Regards, > >> >> >> Regards, >> Prem >> >> -----Original Message----- >> From: Jie Kang >> Sent: Thursday, January 03, 2019 8:07 PM >> To: jmc-dev at openjdk.java.net >> Subject: Review Request: Fix 2018-09 Platform Definition >> >> Hi, >> >> The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the >> 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts? >> >> diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target >> b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target >> --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target >> +++ b/releng/platform-definitions/platform-definition-2018-09/platform-d >> +++ efinition-2018-09.target >> @@ -34,9 +34,11 @@ >> >> >> > includeConfigurePhase="true" includeMode="planner" >> includeSource="true" type="InstallableUnit"> >> - >> - >> + >> >> + >> + >> + >> >> >> >> >> >> Regards, From jkang at redhat.com Thu Jan 3 20:24:40 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 3 Jan 2019 15:24:40 -0500 Subject: Review Request: Fix 2018-09 Platform Definition In-Reply-To: References: Message-ID: On Thu, Jan 3, 2019 at 3:06 PM Marcus Hirt wrote: > > I have a fix which fixes this as part of the upgrade to Eclipse 2018-12. Let me check how far along the Jakarta-approval is first. Oh nice! I have also been doing some testing of JMC with Eclipse 2018-12. There is an issue with Wayland where the JMC charts are black (tested on F29 Wayland GNOME Desktop). I will be trying to find the root cause; it could be JMC needs an update in the chart library or it could be something in the underlying Eclipse libraries (SWT maybe?). This behaviour is not exhibited when using 2018-09 or Photon platform definitions. Is anyone possibly looking at this already? I also read the bug for upgrading to 2018-12 [1] just now and just in case, for org.eclipse.equinox.ds, the migration suggestion is to replace it with org.apache.felix.scr [2]. I haven't come across any issues doing this in manual user testing but of course that covers very little... [1] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6274 [2] https://git.eclipse.org/r/#/c/130458/1/bundles/org.eclipse.platform.doc.isv/porting/4.10/faq.html Regards, > > Kind regards, > Marcus > > - Excuse me if terse; sent from my phone. > > > On 3 Jan 2019, at 17:49, Jie Kang wrote: > > > > On Thu, Jan 3, 2019 at 11:07 AM Prem Balakrishnan > > wrote: > >> > >> Hi Jie, > >> > >> Thank you for bringing this to our attention. > >> > >> We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch. > >> > >> Request you to create a bug for the same and update the review thread. > > > > Hi Prem, > > > > Thanks for taking a look at this! I am not an Author so I can't create > > bugs for JMC; I have asked Alex to create one for me and it's: > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6309 > > > > > > Regards, > > > >> > >> > >> Regards, > >> Prem > >> > >> -----Original Message----- > >> From: Jie Kang > >> Sent: Thursday, January 03, 2019 8:07 PM > >> To: jmc-dev at openjdk.java.net > >> Subject: Review Request: Fix 2018-09 Platform Definition > >> > >> Hi, > >> > >> The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the > >> 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts? > >> > >> diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > >> b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > >> --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target > >> +++ b/releng/platform-definitions/platform-definition-2018-09/platform-d > >> +++ efinition-2018-09.target > >> @@ -34,9 +34,11 @@ > >> > >> > >> >> includeConfigurePhase="true" includeMode="planner" > >> includeSource="true" type="InstallableUnit"> > >> - > >> - > >> + > >> > >> + > >> + > >> + > >> > >> > >> > >> > >> > >> Regards, > From kdobson at redhat.com Thu Jan 3 20:30:43 2019 From: kdobson at redhat.com (Ken Dobson) Date: Thu, 3 Jan 2019 15:30:43 -0500 Subject: JMC-6223- Visualize the PID from JVM Information Event In-Reply-To: References: Message-ID: Seems like there was a spacing issue in the patch that made it the patch unable to be applied. Here's a working version. Just a reminder you require the latest version of http://hg.openjdk.java.net/jdk/jdk to see the pid otherwise it will be displayed as N/A. diff -r abb4b7f54009 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Dec 06 19:12:44 2018 +0100 +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Jan 03 14:43:53 2019 -0500 @@ -162,6 +162,7 @@ infoViewer = new ItemAggregateViewer(jvmInfSection, toolkit); infoViewer.addAggregate(JdkAggregators.JVM_START_TIME); infoViewer.addAggregate(JdkAggregators.JVM_NAME); + infoViewer.addAggregate(JdkAggregators.JVM_PID); infoViewer.addAggregate(JdkAggregators.JVM_VERSION); infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS); infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Jan 03 14:43:53 2019 -0500 @@ -113,6 +113,8 @@ // VM Info public static final IAggregator JVM_NAME = distinctAsString(VM_INFO, JdkAttributes.JVM_NAME); + public static final IAggregator JVM_PID = min(JdkAttributes.JVM_PID.getName(), null, + VM_INFO, JdkAttributes.JVM_PID); public static final IAggregator JVM_START_TIME = min(JdkAttributes.JVM_START_TIME.getName(), null, VM_INFO, JdkAttributes.JVM_START_TIME); public static final IAggregator JVM_VERSION = distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Jan 03 14:43:53 2019 -0500 @@ -441,6 +441,8 @@ Messages.getString(Messages.ATTR_JVM_START_TIME), TIMESTAMP); public static final IAttribute JVM_NAME = attr("jvmName", Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$ PLAIN_TEXT); + public static final IAttribute JVM_PID = attr("pid", Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$ + NUMBER); public static final IAttribute JVM_VERSION = attr("jvmVersion", //$NON-NLS-1$ Messages.getString(Messages.ATTR_JVM_VERSION), PLAIN_TEXT); public static final IAttribute JVM_ARGUMENTS = attr("jvmArguments", //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Jan 03 14:43:53 2019 -0500 @@ -314,6 +314,7 @@ public static final String ATTR_JAVA_ARGUMENTS = "ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_ARGUMENTS = "ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME"; //$NON-NLS-1$ + public static final String ATTR_JVM_PID = "ATTR_JVM_PID"; //$NON-NLS-1$ public static final String ATTR_JVM_START_TIME = "ATTR_JVM_START_TIME"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM_DESC = "ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Jan 03 14:43:53 2019 -0500 @@ -53,6 +53,7 @@ ATTR_REC_SETTING_VALUE=Setting Value ATTR_JVM_START_TIME=JVM Start Time ATTR_JVM_NAME=JVM Name +ATTR_JVM_PID = JVM PID ATTR_JVM_VERSION=JVM Version ATTR_JVM_ARGUMENTS=JVM Arguments ATTR_JAVA_ARGUMENTS=JVM Application Arguments On Thu, Jan 3, 2019 at 2:44 PM Ken Dobson wrote: > Hi all, > > Here's a patch adding the PID to the JVM Internals page because I saw that > https://bugs.openjdk.java.net/browse/JDK-8213617 had been completed so > this ticket was no longer blocked. I've just posted it verbatim below as > I'm still waiting on my OpenJDK registration email. > > Thanks, > > Ken Dobson > > diff -r abb4b7f54009 > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > --- > a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -162,6 +162,7 @@ > infoViewer = new > ItemAggregateViewer(jvmInfSection, toolkit); > > infoViewer.addAggregate(JdkAggregators.JVM_START_TIME); > infoViewer.addAggregate(JdkAggregators.JVM_NAME); > + infoViewer.addAggregate(JdkAggregators.JVM_PID); > > infoViewer.addAggregate(JdkAggregators.JVM_VERSION); > > infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS); > > infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS); > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -113,6 +113,8 @@ > > // VM Info > public static final IAggregator JVM_NAME = > distinctAsString(VM_INFO, JdkAttributes.JVM_NAME); > + public static final IAggregator JVM_PID = > min(JdkAttributes.JVM_PID.getName(), null, > + VM_INFO, JdkAttributes.JVM_PID); > public static final IAggregator JVM_START_TIME = > min(JdkAttributes.JVM_START_TIME.getName(), null, > VM_INFO, JdkAttributes.JVM_START_TIME); > public static final IAggregator JVM_VERSION = > distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION); > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -441,6 +441,8 @@ > Messages.getString(Messages.ATTR_JVM_START_TIME), > TIMESTAMP); > public static final IAttribute JVM_NAME = attr("jvmName", > Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$ > PLAIN_TEXT); > + public static final IAttribute JVM_PID = attr("pid", > Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$ > + NUMBER); > public static final IAttribute JVM_VERSION = > attr("jvmVersion", //$NON-NLS-1$ > Messages.getString(Messages.ATTR_JVM_VERSION), > PLAIN_TEXT); > public static final IAttribute JVM_ARGUMENTS = > attr("jvmArguments", //$NON-NLS-1$ > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -314,6 +314,7 @@ > public static final String ATTR_JAVA_ARGUMENTS = > "ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$ > public static final String ATTR_JVM_ARGUMENTS = > "ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$ > public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME"; > //$NON-NLS-1$ > + public static final String ATTR_JVM_PID = "ATTR_JVM_PID"; > //$NON-NLS-1$ > public static final String ATTR_JVM_START_TIME = > "ATTR_JVM_START_TIME"; //$NON-NLS-1$ > public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM"; > //$NON-NLS-1$ > public static final String ATTR_JVM_SYSTEM_DESC = > "ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$ > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > Thu Jan 03 11:57:09 2019 -0500 > @@ -53,6 +53,7 @@ > ATTR_REC_SETTING_VALUE=Setting Value > ATTR_JVM_START_TIME=JVM Start Time > ATTR_JVM_NAME=JVM Name > +ATTR_JVM_PID = JVM PID > ATTR_JVM_VERSION=JVM Version > ATTR_JVM_ARGUMENTS=JVM Arguments > ATTR_JAVA_ARGUMENTS=JVM Application Arguments > > From kdobson at redhat.com Mon Jan 7 20:53:44 2019 From: kdobson at redhat.com (Ken Dobson) Date: Mon, 7 Jan 2019 15:53:44 -0500 Subject: JMC-5002: Put JVM Start Time in perspective Message-ID: Hi all, This is just a small patch that adds how long a flight recording was started after the JVM was started to the rule text for the IncreasingLiveSetRule. The wording of the rule text feels a little choppy now so if anyone has suggestions they would be appreciated. https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5002 Thanks, Ken Dobson diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java @@ -57,6 +57,7 @@ import org.openjdk.jmc.common.item.IMemberAccessor; import org.openjdk.jmc.common.item.ItemFilters; import org.openjdk.jmc.common.unit.BinaryPrefix; +import org.openjdk.jmc.common.unit.DecimalPrefix; import org.openjdk.jmc.common.unit.IQuantity; import org.openjdk.jmc.common.unit.UnitLookup; import org.openjdk.jmc.common.util.IPreferenceValueProvider; @@ -134,11 +135,13 @@ EventAvailability ea = RulesToolkit.getEventAvailability(items, JdkTypeIDs.OLD_OBJECT_SAMPLE); // FIXME: Should construct an message using memoryIncrease, not use a hard limit if (score >= 25 && (ea == EventAvailability.DISABLED || ea == EventAvailability.UNKNOWN)) { + IQuantity timeAfterJVMStart = items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); String shortMessage = MessageFormat.format( Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); String longMessage = shortMessage + "

" //$NON-NLS-1$ - + Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); + + MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), + timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); return new Result(this, score, shortMessage, longMessage, JdkQueries.HEAP_SUMMARY_AFTER_GC); } else if (score < 25) { return new Result(this, score, Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties @@ -368,7 +368,7 @@ IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend # {0} is a number denoted in Mebibytes per second IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems to increase with a speed of about {0} per second during the recording. -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began {0} after the JVM was started. More information can be gathered by using the 'Old Object Sample' event, if available. IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set Trend IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems to increase constantly in the metaspace during the recording. IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may indicate a memory leak in the metaspace, this could be due to the application not unloading classes as needed. From marcus.hirt at oracle.com Mon Jan 7 21:22:55 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 07 Jan 2019 22:22:55 +0100 Subject: Review request for JMC-6277: Supporting new JavaFX 12 events Message-ID: <12532DB2-5A27-4502-8232-72B53F904D1A@oracle.com> Hi all, Please review this fix to support the new JavaFX 12 events. See: https://bugs.openjdk.java.net/browse/JDK-8088418 Included are also some fixes for minor warnings and mounting the metadata and g1 optional pages plug-ins in better places. Jira: https://bugs.openjdk.java.net/browse/JMC-6277 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6277/webrev.01/ Kind regards, Marcus From guru.hb at oracle.com Tue Jan 8 06:08:37 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 8 Jan 2019 11:38:37 +0530 Subject: Review request: JMC-6318 : Update Copyright year Message-ID: Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6318 Webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.0/ Thanks, Guru From guru.hb at oracle.com Tue Jan 8 06:37:23 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Tue, 08 Jan 2019 06:37:23 +0000 Subject: hg: jmc/jmc: JMC-6311: JMC7.0 THIRDPARTYREADME.txt need update Message-ID: <201901080637.x086bNDm006656@aojmv0008.oracle.com> Changeset: d96709511300 Author: ghb Date: 2019-01-08 12:07 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/d96709511300 JMC-6311: JMC7.0 THIRDPARTYREADME.txt need update Reviewed-by: hirt Contributed-by: pkbalakr ! license/THIRDPARTYREADME.txt From guru.hb at oracle.com Tue Jan 8 06:51:15 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Tue, 08 Jan 2019 06:51:15 +0000 Subject: hg: jmc/jmc7: JMC-6311: JMC7.0 THIRDPARTYREADME.txt need update Message-ID: <201901080651.x086pFvW011836@aojmv0008.oracle.com> Changeset: 74cb25db1ec1 Author: ghb Date: 2019-01-08 12:07 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/74cb25db1ec1 JMC-6311: JMC7.0 THIRDPARTYREADME.txt need update Reviewed-by: hirt Contributed-by: pkbalakr ! license/THIRDPARTYREADME.txt From guru.hb at oracle.com Tue Jan 8 07:01:39 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 8 Jan 2019 12:31:39 +0530 Subject: Review request for JMC-6277: Supporting new JavaFX 12 events In-Reply-To: <12532DB2-5A27-4502-8232-72B53F904D1A@oracle.com> References: <12532DB2-5A27-4502-8232-72B53F904D1A@oracle.com> Message-ID: 1. Please update ?JfxVersionUtil.java? with copyright header. 2. (Not a must) Nit : JavaFxEventAvailability.JavaFx12 to JavaFxEventAvailability.OpenJFXModule or JavaFxEventAvailability.JavaFxModule We can encounter None(Which I believe its for idk9, 10 and 11) , Javafx from JDK 8, and JavaFx12 (i.e OpenJfx which is based on version 12 and above). Other than the above, others changes looks good to me. Thanks, Guru > On 08-Jan-2019, at 2:52 AM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to support the new JavaFX 12 events. > See: https://bugs.openjdk.java.net/browse/JDK-8088418 > > Included are also some fixes for minor warnings and mounting > the metadata and g1 optional pages plug-ins in better places. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6277 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6277/webrev.01/ > > Kind regards, > Marcus > > > > > From prem.balakrishnan at oracle.com Tue Jan 8 07:00:09 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Mon, 7 Jan 2019 23:00:09 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: Message-ID: Gentle Reminder! -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From marcus.hirt at oracle.com Tue Jan 8 08:01:33 2019 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Tue, 08 Jan 2019 08:01:33 +0000 Subject: hg: jmc/jmc: JMC-6277: Supporting new JavaFX 12 events (also fixing various warnings and mounting optional pages in better places) Message-ID: <201901080801.x0881XBa008310@aojmv0008.oracle.com> Changeset: ce3c2d25fc44 Author: hirt Date: 2019-01-08 09:00 +0100 URL: http://hg.openjdk.java.net/jmc/jmc/rev/ce3c2d25fc44 JMC-6277: Supporting new JavaFX 12 events (also fixing various warnings and mounting optional pages in better places) Reviewed-by: ghb ! application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java ! application/org.openjdk.jmc.flightrecorder.ext.g1/pages.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pages.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxConstants.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java + application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxVersionUtil.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/Messages.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages.properties ! application/org.openjdk.jmc.flightrecorder.metadata/pages.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/DataPageDescriptor.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ClassLoadingPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/HotSpot24DiagnosticCommandService.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/AwtCanvas.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java From marcus.hirt at oracle.com Tue Jan 8 08:14:37 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 09:14:37 +0100 Subject: Review request: JMC-6318 : Update Copyright year In-Reply-To: References: Message-ID: Hi Guru, Should likely be ?2018, 2019,?. Kind regards, Marcus From: Guru Date: Tuesday, 8 January 2019 at 07:08 To: Cc: Marcus Hirt Subject: Review request: JMC-6318 : Update Copyright year Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6318 Webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.0/ Thanks, Guru From marcus.hirt at oracle.com Tue Jan 8 08:23:32 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 09:23:32 +0100 Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: <7B6D49FB-3EE9-4FD7-B74E-891EE767BB93@oracle.com> References: <7B6D49FB-3EE9-4FD7-B74E-891EE767BB93@oracle.com> Message-ID: <7B924F37-F051-44E5-A2F3-1BDBFFB9AAD7@oracle.com> Hi Prem, Strictly speaking we still have oxygen as a buildable platform. The idea was to have JMC 7.0.0 support oxygen (4.7.0) and later. Kind regards, Marcus ?On 2019-01-08, 08:02, "jmc-dev on behalf of Prem Balakrishnan" wrote: Gentle Reminder! -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From marcus.hirt at oracle.com Tue Jan 8 08:31:46 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 09:31:46 +0100 Subject: JMC-5002: Put JVM Start Time in perspective In-Reply-To: <6F97263B-43D3-4A66-ADCB-75E01AFDEAA5@redhat.com> References: <6F97263B-43D3-4A66-ADCB-75E01AFDEAA5@redhat.com> Message-ID: Hi Ken, I think it's fine. Please go ahead. Kind regards, Marcus ?On 2019-01-07, 21:54, "jmc-dev on behalf of Ken Dobson" wrote: Hi all, This is just a small patch that adds how long a flight recording was started after the JVM was started to the rule text for the IncreasingLiveSetRule. The wording of the rule text feels a little choppy now so if anyone has suggestions they would be appreciated. https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5002 Thanks, Ken Dobson diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java @@ -57,6 +57,7 @@ import org.openjdk.jmc.common.item.IMemberAccessor; import org.openjdk.jmc.common.item.ItemFilters; import org.openjdk.jmc.common.unit.BinaryPrefix; +import org.openjdk.jmc.common.unit.DecimalPrefix; import org.openjdk.jmc.common.unit.IQuantity; import org.openjdk.jmc.common.unit.UnitLookup; import org.openjdk.jmc.common.util.IPreferenceValueProvider; @@ -134,11 +135,13 @@ EventAvailability ea = RulesToolkit.getEventAvailability(items, JdkTypeIDs.OLD_OBJECT_SAMPLE); // FIXME: Should construct an message using memoryIncrease, not use a hard limit if (score >= 25 && (ea == EventAvailability.DISABLED || ea == EventAvailability.UNKNOWN)) { + IQuantity timeAfterJVMStart = items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); String shortMessage = MessageFormat.format( Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); String longMessage = shortMessage + "

" //$NON-NLS-1$ - + Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); + + MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), + timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); return new Result(this, score, shortMessage, longMessage, JdkQueries.HEAP_SUMMARY_AFTER_GC); } else if (score < 25) { return new Result(this, score, Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties @@ -368,7 +368,7 @@ IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend # {0} is a number denoted in Mebibytes per second IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems to increase with a speed of about {0} per second during the recording. -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began {0} after the JVM was started. More information can be gathered by using the 'Old Object Sample' event, if available. IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set Trend IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems to increase constantly in the metaspace during the recording. IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may indicate a memory leak in the metaspace, this could be due to the application not unloading classes as needed. From marcus.hirt at oracle.com Tue Jan 8 08:33:20 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 09:33:20 +0100 Subject: JMC-6223- Visualize the PID from JVM Information Event In-Reply-To: <692D0666-B28C-4341-97B9-F2F64A0D9F69@redhat.com> References: <692D0666-B28C-4341-97B9-F2F64A0D9F69@redhat.com> Message-ID: Looks good Ken! /M ?On 2019-01-03, 21:31, "jmc-dev on behalf of Ken Dobson" wrote: Seems like there was a spacing issue in the patch that made it the patch unable to be applied. Here's a working version. Just a reminder you require the latest version of http://hg.openjdk.java.net/jdk/jdk to see the pid otherwise it will be displayed as N/A. diff -r abb4b7f54009 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Dec 06 19:12:44 2018 +0100 +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java Thu Jan 03 14:43:53 2019 -0500 @@ -162,6 +162,7 @@ infoViewer = new ItemAggregateViewer(jvmInfSection, toolkit); infoViewer.addAggregate(JdkAggregators.JVM_START_TIME); infoViewer.addAggregate(JdkAggregators.JVM_NAME); + infoViewer.addAggregate(JdkAggregators.JVM_PID); infoViewer.addAggregate(JdkAggregators.JVM_VERSION); infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS); infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java Thu Jan 03 14:43:53 2019 -0500 @@ -113,6 +113,8 @@ // VM Info public static final IAggregator JVM_NAME = distinctAsString(VM_INFO, JdkAttributes.JVM_NAME); + public static final IAggregator JVM_PID = min(JdkAttributes.JVM_PID.getName(), null, + VM_INFO, JdkAttributes.JVM_PID); public static final IAggregator JVM_START_TIME = min(JdkAttributes.JVM_START_TIME.getName(), null, VM_INFO, JdkAttributes.JVM_START_TIME); public static final IAggregator JVM_VERSION = distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION); diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Thu Jan 03 14:43:53 2019 -0500 @@ -441,6 +441,8 @@ Messages.getString(Messages.ATTR_JVM_START_TIME), TIMESTAMP); public static final IAttribute JVM_NAME = attr("jvmName", Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$ PLAIN_TEXT); + public static final IAttribute JVM_PID = attr("pid", Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$ + NUMBER); public static final IAttribute JVM_VERSION = attr("jvmVersion", //$NON-NLS-1$ Messages.getString(Messages.ATTR_JVM_VERSION), PLAIN_TEXT); public static final IAttribute JVM_ARGUMENTS = attr("jvmArguments", //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Thu Jan 03 14:43:53 2019 -0500 @@ -314,6 +314,7 @@ public static final String ATTR_JAVA_ARGUMENTS = "ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_ARGUMENTS = "ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$ public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME"; //$NON-NLS-1$ + public static final String ATTR_JVM_PID = "ATTR_JVM_PID"; //$NON-NLS-1$ public static final String ATTR_JVM_START_TIME = "ATTR_JVM_START_TIME"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM"; //$NON-NLS-1$ public static final String ATTR_JVM_SYSTEM_DESC = "ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$ diff -r abb4b7f54009 core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Dec 06 19:12:44 2018 +0100 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Thu Jan 03 14:43:53 2019 -0500 @@ -53,6 +53,7 @@ ATTR_REC_SETTING_VALUE=Setting Value ATTR_JVM_START_TIME=JVM Start Time ATTR_JVM_NAME=JVM Name +ATTR_JVM_PID = JVM PID ATTR_JVM_VERSION=JVM Version ATTR_JVM_ARGUMENTS=JVM Arguments ATTR_JAVA_ARGUMENTS=JVM Application Arguments On Thu, Jan 3, 2019 at 2:44 PM Ken Dobson wrote: > Hi all, > > Here's a patch adding the PID to the JVM Internals page because I saw that > https://bugs.openjdk.java.net/browse/JDK-8213617 had been completed so > this ticket was no longer blocked. I've just posted it verbatim below as > I'm still waiting on my OpenJDK registration email. > > Thanks, > > Ken Dobson > > diff -r abb4b7f54009 > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > --- > a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -162,6 +162,7 @@ > infoViewer = new > ItemAggregateViewer(jvmInfSection, toolkit); > > infoViewer.addAggregate(JdkAggregators.JVM_START_TIME); > infoViewer.addAggregate(JdkAggregators.JVM_NAME); > + infoViewer.addAggregate(JdkAggregators.JVM_PID); > > infoViewer.addAggregate(JdkAggregators.JVM_VERSION); > > infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS); > > infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS); > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -113,6 +113,8 @@ > > // VM Info > public static final IAggregator JVM_NAME = > distinctAsString(VM_INFO, JdkAttributes.JVM_NAME); > + public static final IAggregator JVM_PID = > min(JdkAttributes.JVM_PID.getName(), null, > + VM_INFO, JdkAttributes.JVM_PID); > public static final IAggregator JVM_START_TIME = > min(JdkAttributes.JVM_START_TIME.getName(), null, > VM_INFO, JdkAttributes.JVM_START_TIME); > public static final IAggregator JVM_VERSION = > distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION); > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -441,6 +441,8 @@ > Messages.getString(Messages.ATTR_JVM_START_TIME), > TIMESTAMP); > public static final IAttribute JVM_NAME = attr("jvmName", > Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$ > PLAIN_TEXT); > + public static final IAttribute JVM_PID = attr("pid", > Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$ > + NUMBER); > public static final IAttribute JVM_VERSION = > attr("jvmVersion", //$NON-NLS-1$ > Messages.getString(Messages.ATTR_JVM_VERSION), > PLAIN_TEXT); > public static final IAttribute JVM_ARGUMENTS = > attr("jvmArguments", //$NON-NLS-1$ > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java > Thu Jan 03 11:57:09 2019 -0500 > @@ -314,6 +314,7 @@ > public static final String ATTR_JAVA_ARGUMENTS = > "ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$ > public static final String ATTR_JVM_ARGUMENTS = > "ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$ > public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME"; > //$NON-NLS-1$ > + public static final String ATTR_JVM_PID = "ATTR_JVM_PID"; > //$NON-NLS-1$ > public static final String ATTR_JVM_START_TIME = > "ATTR_JVM_START_TIME"; //$NON-NLS-1$ > public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM"; > //$NON-NLS-1$ > public static final String ATTR_JVM_SYSTEM_DESC = > "ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$ > diff -r abb4b7f54009 > core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > Thu Dec 06 19:12:44 2018 +0100 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties > Thu Jan 03 11:57:09 2019 -0500 > @@ -53,6 +53,7 @@ > ATTR_REC_SETTING_VALUE=Setting Value > ATTR_JVM_START_TIME=JVM Start Time > ATTR_JVM_NAME=JVM Name > +ATTR_JVM_PID = JVM PID > ATTR_JVM_VERSION=JVM Version > ATTR_JVM_ARGUMENTS=JVM Arguments > ATTR_JAVA_ARGUMENTS=JVM Application Arguments > > From guru.hb at oracle.com Tue Jan 8 08:46:08 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 8 Jan 2019 14:16:08 +0530 Subject: Review request: JMC-6318 : Update Copyright year In-Reply-To: References: Message-ID: <423683D6-3C91-46B2-AEC8-D2D2DD93CD9E@oracle.com> Hi Marcus, Please find updated webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.1/ Thanks, Guru > On 08-Jan-2019, at 1:44 PM, Marcus Hirt wrote: > > Hi Guru, > > Should likely be ?2018, 2019,?. > > Kind regards, > Marcus > > From: Guru > > Date: Tuesday, 8 January 2019 at 07:08 > To: > > Cc: Marcus Hirt > > Subject: Review request: JMC-6318 : Update Copyright year > > Hi, > > Please review the fix for > JBS : https://bugs.openjdk.java.net/browse/JMC-6318 > Webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.0/ > > Thanks, > Guru From marcus.hirt at oracle.com Tue Jan 8 09:14:00 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 10:14:00 +0100 Subject: Review request: JMC-6318 : Update Copyright year In-Reply-To: References: Message-ID: <919BA119-918A-40AB-AB1D-4635F0A25BC4@oracle.com> Looks good! /M From: Guru Date: Tuesday, 8 January 2019 at 09:46 To: Marcus Hirt Cc: Subject: Re: Review request: JMC-6318 : Update Copyright year Hi Marcus, Please find updated webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.1/ Thanks, Guru On 08-Jan-2019, at 1:44 PM, Marcus Hirt wrote: Hi Guru, Should likely be ?2018, 2019,?. Kind regards, Marcus From: Guru Date: Tuesday, 8 January 2019 at 07:08 To: Cc: Marcus Hirt Subject: Review request: JMC-6318 : Update Copyright year Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6318 Webrev : http://cr.openjdk.java.net/~ghb/6318/webrev.0/ Thanks, Guru From guru.hb at oracle.com Tue Jan 8 10:28:35 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Tue, 08 Jan 2019 10:28:35 +0000 Subject: hg: jmc/jmc: JMC-6318: Update Copyright year Message-ID: <201901081028.x08ASZOm009677@aojmv0008.oracle.com> Changeset: f8a214df14d4 Author: ghb Date: 2019-01-08 15:58 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/f8a214df14d4 JMC-6318: Update Copyright year Reviewed-by: hirt ! application/l10n/org.openjdk.jmc.feature.ja/feature.properties ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.properties ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.properties ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.properties ! application/l10n/org.openjdk.jmc.ide.ui.ja/nl/ja/html/title.htm ! application/l10n/org.openjdk.jmc.rcp.application.ja/plugin_ja.properties ! application/org.openjdk.jmc.commands/schema/command.exsd ! application/org.openjdk.jmc.console.jconsole/schema/jconsolePlugin.exsd ! application/org.openjdk.jmc.console.ui/schema/consolepage.exsd ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.properties ! application/org.openjdk.jmc.feature.console/feature.properties ! application/org.openjdk.jmc.feature.core/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder/feature.properties ! application/org.openjdk.jmc.feature.ide.launch/feature.properties ! application/org.openjdk.jmc.feature.ide/feature.properties ! application/org.openjdk.jmc.feature.jconsole/feature.properties ! application/org.openjdk.jmc.feature.joverflow/feature.properties ! application/org.openjdk.jmc.feature.license/feature.properties ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.pde/feature.properties ! application/org.openjdk.jmc.feature.rcp.update/feature.properties ! application/org.openjdk.jmc.feature.rcp/feature.properties ! application/org.openjdk.jmc.feature.twitter/feature.properties ! application/org.openjdk.jmc.flightrecorder.configuration/schema/storageProvider.exsd ! application/org.openjdk.jmc.flightrecorder.ui/schema/datapage.exsd ! application/org.openjdk.jmc.ide.ui/html/title.htm ! application/org.openjdk.jmc.rcp.application/plugin.properties ! application/org.openjdk.jmc.rcp.product.feature/feature.properties ! application/org.openjdk.jmc.rcp.product/feature.properties ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/schema/jmxProtocols.exsd ! application/org.openjdk.jmc.rjmx/schema/actionProvider.exsd ! application/org.openjdk.jmc.rjmx/schema/attributeTransformation.exsd ! application/org.openjdk.jmc.rjmx/schema/descriptorProvider.exsd ! application/org.openjdk.jmc.rjmx/schema/metadataprovider.exsd ! application/org.openjdk.jmc.rjmx/schema/service.exsd ! application/org.openjdk.jmc.rjmx/schema/syntheticattribute.exsd ! application/org.openjdk.jmc.rjmx/schema/syntheticnotification.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerActionExceptionHandlers.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerActions.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerConstraints.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerEvaluators.exsd ! application/org.openjdk.jmc.ui.common/schema/idesupport.exsd ! application/org.openjdk.jmc.ui.common/schema/labelingRules.exsd ! application/org.openjdk.jmc.ui/schema/filetypeopener.exsd ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! core/org.openjdk.jmc.agent/license/LICENSE.txt ! core/org.openjdk.jmc.flightrecorder.rules/schema/ruleProvider.exsd ! license/COPYRIGHT From guru.hb at oracle.com Tue Jan 8 07:12:58 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 8 Jan 2019 12:42:58 +0530 Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: Message-ID: <8D5FDB93-AA1A-4CD6-8C1C-16810B163E6C@oracle.com> 1. org.openjdk.jmc.updatesite.ide/src/main/resources/index.html --> "Key Features" "Supports HotSpot VM, JDK 8 and later (including JDK 9)." Might need to add (including JDK 9,10) 2. org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html --> "bannertitle" needs some padding (please ref IDE page style sheet) Thanks, Guru > On 08-Jan-2019, at 12:30 PM, Prem Balakrishnan wrote: > > Gentle Reminder! > > -----Original Message----- > From: Prem Balakrishnan > Sent: Thursday, January 03, 2019 6:41 PM > To: jmc-dev at openjdk.java.net > Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's > > Hi All, > > > > Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 > > Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ > > > > updated "Mission control" to "JDK Mission control" and JMC download location. > > > > Regards, > > Prem > > From guru.hb at oracle.com Tue Jan 8 10:36:05 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Tue, 08 Jan 2019 10:36:05 +0000 Subject: hg: jmc/jmc7: JMC-6318: Update Copyright year Message-ID: <201901081036.x08Aa5jA011871@aojmv0008.oracle.com> Changeset: c7fadcfaa578 Author: ghb Date: 2019-01-08 15:58 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/c7fadcfaa578 JMC-6318: Update Copyright year Reviewed-by: hirt ! application/l10n/org.openjdk.jmc.feature.ja/feature.properties ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.properties ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.properties ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.properties ! application/l10n/org.openjdk.jmc.ide.ui.ja/nl/ja/html/title.htm ! application/l10n/org.openjdk.jmc.rcp.application.ja/plugin_ja.properties ! application/org.openjdk.jmc.commands/schema/command.exsd ! application/org.openjdk.jmc.console.jconsole/schema/jconsolePlugin.exsd ! application/org.openjdk.jmc.console.ui/schema/consolepage.exsd ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.properties ! application/org.openjdk.jmc.feature.console/feature.properties ! application/org.openjdk.jmc.feature.core/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.properties ! application/org.openjdk.jmc.feature.flightrecorder/feature.properties ! application/org.openjdk.jmc.feature.ide.launch/feature.properties ! application/org.openjdk.jmc.feature.ide/feature.properties ! application/org.openjdk.jmc.feature.jconsole/feature.properties ! application/org.openjdk.jmc.feature.joverflow/feature.properties ! application/org.openjdk.jmc.feature.license/feature.properties ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.pde/feature.properties ! application/org.openjdk.jmc.feature.rcp.update/feature.properties ! application/org.openjdk.jmc.feature.rcp/feature.properties ! application/org.openjdk.jmc.feature.twitter/feature.properties ! application/org.openjdk.jmc.flightrecorder.configuration/schema/storageProvider.exsd ! application/org.openjdk.jmc.flightrecorder.ui/schema/datapage.exsd ! application/org.openjdk.jmc.ide.ui/html/title.htm ! application/org.openjdk.jmc.rcp.application/plugin.properties ! application/org.openjdk.jmc.rcp.product.feature/feature.properties ! application/org.openjdk.jmc.rcp.product/feature.properties ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/schema/jmxProtocols.exsd ! application/org.openjdk.jmc.rjmx/schema/actionProvider.exsd ! application/org.openjdk.jmc.rjmx/schema/attributeTransformation.exsd ! application/org.openjdk.jmc.rjmx/schema/descriptorProvider.exsd ! application/org.openjdk.jmc.rjmx/schema/metadataprovider.exsd ! application/org.openjdk.jmc.rjmx/schema/service.exsd ! application/org.openjdk.jmc.rjmx/schema/syntheticattribute.exsd ! application/org.openjdk.jmc.rjmx/schema/syntheticnotification.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerActionExceptionHandlers.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerActions.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerConstraints.exsd ! application/org.openjdk.jmc.rjmx/schema/triggerEvaluators.exsd ! application/org.openjdk.jmc.ui.common/schema/idesupport.exsd ! application/org.openjdk.jmc.ui.common/schema/labelingRules.exsd ! application/org.openjdk.jmc.ui/schema/filetypeopener.exsd ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! core/org.openjdk.jmc.agent/license/LICENSE.txt ! core/org.openjdk.jmc.flightrecorder.rules/schema/ruleProvider.exsd ! license/COPYRIGHT From sharath.ballal at oracle.com Tue Jan 8 11:34:06 2019 From: sharath.ballal at oracle.com (Sharath Ballal) Date: Tue, 8 Jan 2019 03:34:06 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: Message-ID: <42aff96a-a89a-4138-b584-7f328e9bb692@default> Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -

  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From sasiddiq at redhat.com Tue Jan 8 15:05:52 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Tue, 8 Jan 2019 10:05:52 -0500 Subject: Review Request: JMC 6314 - Default JMC binaries for Linux reference odd "-vm ../../bin" Message-ID: Hi all, This is a patch to use the default Java on Linux systems instead of searching for a JDK in the non-existent "../../bin" directory. Thanks, Salman diff -r 80f49c3226cb application/org.openjdk.jmc.rcp.product/jmc.product --- a/application/org.openjdk.jmc.rcp.product/jmc.product Thu Jan 03 16:54:12 2019 +0530 +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Tue Jan 08 09:59:09 2019 -0500 @@ -48,7 +48,7 @@ --launcher.appendVmargs - -vm ../../bin/ + -vm /usr/bin/java -ws cocoa -vm ../jdk/Contents/Home/bin/ From guru.hb at oracle.com Tue Jan 8 15:15:27 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 8 Jan 2019 20:45:27 +0530 Subject: Review Request: JMC 6314 - Default JMC binaries for Linux reference odd "-vm ../../bin" In-Reply-To: References: Message-ID: +1 Looks good to me. Note: https://bugs.openjdk.java.net/browse/JMC-6314 is still ?Unassigned? and its state is in ?Triage?. Please request any of your team member who has JBS Account to assign to them self and sponsor the changes. Thanks, Guru > On 08-Jan-2019, at 8:35 PM, Salman Siddiqui wrote: > > Hi all, > > This is a patch to use the default Java on Linux systems instead of > searching for a JDK in the non-existent "../../bin" directory. > > Thanks, > Salman > > > diff -r 80f49c3226cb application/org.openjdk.jmc.rcp.product/jmc.product > --- a/application/org.openjdk.jmc.rcp.product/jmc.product Thu Jan 03 > 16:54:12 2019 +0530 > +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Tue Jan 08 > 09:59:09 2019 -0500 > @@ -48,7 +48,7 @@ > > --launcher.appendVmargs > > - -vm ../../bin/ > + -vm /usr/bin/java > > -ws cocoa -vm ../jdk/Contents/Home/bin/ > From prem.balakrishnan at oracle.com Tue Jan 8 16:58:51 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Tue, 8 Jan 2019 08:58:51 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: <42aff96a-a89a-4138-b584-7f328e9bb692@default> References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> Message-ID: Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -
  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From marcus.hirt at oracle.com Tue Jan 8 18:39:16 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 08 Jan 2019 19:39:16 +0100 Subject: Updating the Docs In-Reply-To: References: Message-ID: <970E04FC-FA3D-44D0-A340-F3B0C023FAB3@oracle.com> Looks good Ken! Feel free to work with Mario to push it into the jmc mainline repo. Guru, once it is in, I think we should consider taking it into jmc7 - it doesn't touch code. Kind regards, Marcus ?On 2018-12-18, 09:34, "jmc-dev on behalf of Ken Dobson" wrote: Hi all, This is a list of issues that I have come across while updating the docs. Please let me know the best way to handle them. Regarding Broken Links it would be good to know whether to delete it or whether we'd like that page to exist. I've attached the patch with changes I've made thus far so feel free to comment on any changes I've made to the docs if any of them aren't correct. Also if there's any questions that are received often that you would like added to the FAQs I can do that as well. Thanks, Ken Dobson Issues: 1. There is no doc for the Live Objects, should this be added? 2.* Accessibility in JDK Mission Control -> Accessibility Known Issues and Workarounds* - Unsure about when this document was written so these issues may no longer exist but there may be new ones 3.* About the JMX Console->Using the JMX Console->Working with Graphs* -The paragraphs near the beginning regarding converting graphs to a table to make them compatible with screen readers should probably be moved/copied to the Accessibility Issues and Workarounds page to make it easier to find 4. *Using the Flight Recorder Plugin->Viewing Recordings->Working with the Outline->Using the Java Application Page* -It appears we're able to modify the Method Profiling Rule in the Java Application Page configuration as well as the Method Profiling Page configuration. I think it should only exist in the Profiling configuration and we should remove it from the Java Application configuration as it doesn't really belong there given it has it's own page. Please let me know what you think about this. 5. *Using the Flight Recorder Plugin->Viewing Recordings->Working with the Outline->Using the JVM Internals Page -> Using the GC Configuration Page* -I've added definitions for a few of the terms that were missing them in the patch below however I'm unable to find a clear definition for TLAB Refill Waste Limit so if someone could send one to me so I could add it that would be great thanks. 6. *Using the Flight Recorder Plugin->Viewing Recordings->Working with the Outline->Using the JVM Internals Page -> Using the Compilations Page* -The Compilations ID is not currently enabled by default for the Compilations tab however it is for Failed Compilations. Generally the values defined in the docs have been those that are enabled by default so should it be enabled? This also leads to the question of should we also be defining values that aren't enabled by default? 7. *Using the Flight Recorder Plugin->Viewing Recordings->Working with the Outline->Using the JVM Internals Page -> Using the Code Cache Page* -Looking for a definition for Sweep Fraction Index 8. *Using the Flight Recorder Plugin->Viewing Recordings->Working with the Stacktrace* -There doesn't seem to be any reason to keep the Group Stacktraces From option that is accessible from the View Menu icon as the options for Grouping Stacktraces is available on the toolbar. I propose that we remove it from the menu. The same applies to the Layout Options as showing as a tree is already available from the toolbar. 9. *Using the Flight Recorder Plugin -> Frequently Asked Questions* -"Ensure that you are using the same version of the JVM that you want to monitor as is being used by the JVM running the JMC client." This is no longer true correct? I can run JMC on JDK 8 as long as the JVM I'd like to record is JDK11 and up. -I've removed the lines referring to using JAVA_HOME/bin/jmc to start JMC, is there anything we should replace this with? Broken Links: 10. *Using the Flight Recorder Plugin* This page states "For more information about enabling JFR, see *Enabling Flight Recorder*". *Enabling Flight Recorder* isn't a link but is clearly referring to a page, which in this case doesn't exist. It seems there shouldn't be any special steps to enabling JFR as it's available by default in JDK11 but there may be steps required for those that use the OracleJDK that I am unaware of. Should we create this page or remove this sentence? 11. *About the JVM Browser -> JDK Mission Control Communications* -*The Monitoring and Management using JMX Technology* hyperlink at the page is broken, it attempts to link to a JMC Help page that does not exist 12. *About the JMX Console->Using the JMX Console->Customizing JMX Console Settings->JMX Data Persistence Settings / About the JMX Console->Using the JMX Console->Using the Overview Tab->Graphs* -The *Working with Attributes* hyperlink is broken, topic not found. Links to an "unresolvable-reference.htm" -*Working with Attributes *is also referenced in *Using the Thread Tab* however is unlinked there. 13. *Using the Flight Recorder Plugin->Viewing Recordings* -References a *Flight Recorder Tab Reference* but is unlinked. I think we can comfortably remove this as all the tab help pages are nested underneath the *Viewing Recordings *page. 14. *About the JVM Browser -> Adding a Custom JVM Connection* *-**Storing Credentials in Settings File *is unlinked but refers to some page that doesn't exist. From prem.balakrishnan at oracle.com Wed Jan 9 06:02:13 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Tue, 8 Jan 2019 22:02:13 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> Message-ID: <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> Hi All, GA hosting location is not yet finalized. Will update the patch once I receive the link and send it out for review. Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Tuesday, January 08, 2019 10:29 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -
  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From prem.balakrishnan at oracle.com Wed Jan 9 14:30:06 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Wed, 9 Jan 2019 06:30:06 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> Message-ID: Hi Marcus/Guru/Sharath, I have update patch as per review comments please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.02/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 11:32 AM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, GA hosting location is not yet finalized. Will update the patch once I receive the link and send it out for review. Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Tuesday, January 08, 2019 10:29 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -
  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From erik.gahlin at oracle.com Wed Jan 9 16:59:01 2019 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 9 Jan 2019 17:59:01 +0100 Subject: RFR: 8216283,Allow shorter method sampling interval than 10 ms Message-ID: <5C362855.30400@oracle.com> Hi, Could I have a review of a fix that removes the 10 ms limit for the Method sampling event? The .jfc-files are updated so instead of "Off", "Normal" and "Maximum," there will now be four alternatives "Off", "Normal", "High" and "Very High", where "High" corresponds to "Maximum" (10 ms) and "Very High" is a sampling rate of 1 ms. In benchmarks we see little impact on throughput if we use "1 ms", but a loss about 3% on max-jOPS on SpecJBB2015. This only happens if user opts-in on the "Very High" sampling rate. The default intervals are still 20 ms for default.jfc and 10 ms for profile.jfc. Webrev: http://cr.openjdk.java.net/~egahlin/8216283/ Bug: https://bugs.openjdk.java.net/browse/JDK-8216283 Testing: test/jdk/jdk/jfr/* Thanks Erik From jmatsuok at redhat.com Wed Jan 9 19:36:36 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Wed, 09 Jan 2019 19:36:36 +0000 Subject: hg: jmc/jmc: JMC-6223: Visualize the PID from the VM information event Message-ID: <201901091936.x09Jaaqh029295@aojmv0008.oracle.com> Changeset: c8d49eb3a0f6 Author: jmatsuoka Date: 2019-01-09 14:35 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/c8d49eb3a0f6 JMC-6223: Visualize the PID from the VM information event Summary: Visualize the PID from the JVM Information Event Reviewed By: hirt Contributed-by: Ken Dobson ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties From kdobson at redhat.com Wed Jan 9 19:57:16 2019 From: kdobson at redhat.com (Ken Dobson) Date: Wed, 9 Jan 2019 14:57:16 -0500 Subject: JMC-5002: Put JVM Start Time in perspective In-Reply-To: References: <6F97263B-43D3-4A66-ADCB-75E01AFDEAA5@redhat.com> Message-ID: Sorry forgot to add the modified test to the original patch here it is now. Nothing else has changed just need a quick approval on the test update. Thanks, Ken Dobson diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java @@ -57,6 +57,7 @@ import org.openjdk.jmc.common.item.IMemberAccessor; import org.openjdk.jmc.common.item.ItemFilters; import org.openjdk.jmc.common.unit.BinaryPrefix; +import org.openjdk.jmc.common.unit.DecimalPrefix; import org.openjdk.jmc.common.unit.IQuantity; import org.openjdk.jmc.common.unit.UnitLookup; import org.openjdk.jmc.common.util.IPreferenceValueProvider; @@ -134,11 +135,13 @@ EventAvailability ea = RulesToolkit.getEventAvailability(items, JdkTypeIDs.OLD_OBJECT_SAMPLE); // FIXME: Should construct an message using memoryIncrease, not use a hard limit if (score >= 25 && (ea == EventAvailability.DISABLED || ea == EventAvailability.UNKNOWN)) { + IQuantity timeAfterJVMStart = items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); String shortMessage = MessageFormat.format( Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); String longMessage = shortMessage + "

    " //$NON-NLS-1$ - + Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); + + MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), + timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); return new Result(this, score, shortMessage, longMessage, JdkQueries.HEAP_SUMMARY_AFTER_GC); } else if (score < 25) { return new Result(this, score, Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties @@ -374,7 +374,7 @@ IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend # {0} is a number denoted in Mebibytes per second IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems to increase with a speed of about {0} per second during the recording. -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began {0} after the JVM was started. More information can be gathered by using the 'Old Object Sample' event, if available. IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set Trend IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems to increase constantly in the metaspace during the recording. IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may indicate a memory leak in the metaspace, this could be due to the application not unloading classes as needed. diff --git a/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml b/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml --- a/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml +++ b/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml @@ -3888,7 +3888,7 @@ Information 58.89187525739308 The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording. -The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording.<p>This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording.<p>This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began 3.249 s after the JVM was started. More information can be gathered by using the Old Object Sample event, if available. IncreasingMetaSpaceLiveSet On Tue, Jan 8, 2019 at 3:33 AM Marcus Hirt wrote: > Hi Ken, > > I think it's fine. Please go ahead. > > Kind regards, > Marcus > > ?On 2019-01-07, 21:54, "jmc-dev on behalf of Ken Dobson" < > jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> wrote: > > Hi all, > > This is just a small patch that adds how long a flight recording was > started after the JVM was started to the rule text for the > IncreasingLiveSetRule. The wording of the rule text feels a little > choppy > now so if anyone has suggestions they would be appreciated. > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5002 > > Thanks, > > Ken Dobson > > diff --git > > a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java > > b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java > --- > > a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java > +++ > > b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java > @@ -57,6 +57,7 @@ > import org.openjdk.jmc.common.item.IMemberAccessor; > import org.openjdk.jmc.common.item.ItemFilters; > import org.openjdk.jmc.common.unit.BinaryPrefix; > +import org.openjdk.jmc.common.unit.DecimalPrefix; > import org.openjdk.jmc.common.unit.IQuantity; > import org.openjdk.jmc.common.unit.UnitLookup; > import org.openjdk.jmc.common.util.IPreferenceValueProvider; > @@ -134,11 +135,13 @@ > EventAvailability ea = > RulesToolkit.getEventAvailability(items, > JdkTypeIDs.OLD_OBJECT_SAMPLE); > // FIXME: Should construct an message using memoryIncrease, > not > use a hard limit > if (score >= 25 && (ea == EventAvailability.DISABLED || ea == > EventAvailability.UNKNOWN)) { > + IQuantity timeAfterJVMStart = > > items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); > String shortMessage = MessageFormat.format( > > Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), > > liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); > String longMessage = shortMessage + "

    " //$NON-NLS-1$ > - + > > Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); > + + > > MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), > + > timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); > return new Result(this, score, shortMessage, longMessage, > JdkQueries.HEAP_SUMMARY_AFTER_GC); > } else if (score < 25) { > return new Result(this, score, > Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); > diff --git > > a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties > > b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties > --- > > a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties > +++ > > b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties > @@ -368,7 +368,7 @@ > IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend > # {0} is a number denoted in Mebibytes per second > IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems > to > increase with a speed of about {0} per second during the recording. > -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a > memory > leak in the application or it may be an artifact of a short recording. > More > information can be gathered by using the 'Old Object Sample' event, if > available. > +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a > memory > leak in the application or it may be an artifact of a short recording > if > the JVM has recently been started. The recording began {0} after the > JVM > was started. More information can be gathered by using the 'Old Object > Sample' event, if available. > IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set > Trend > IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems > to > increase constantly in the metaspace during the recording. > IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may > indicate a memory leak in the metaspace, this could be due to the > application not unloading classes as needed. > > > > > From jmatsuok at redhat.com Wed Jan 9 20:20:00 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Wed, 09 Jan 2019 20:20:00 +0000 Subject: hg: jmc/jmc: JMC-6260: Fix up documentation Message-ID: <201901092020.x09KK0na016454@aojmv0008.oracle.com> Changeset: b85cad824acf Author: jmatsuoka Date: 2019-01-09 15:19 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/b85cad824acf JMC-6260: Fix up documentation Summary: Update and clean up the documentation Reviewed-by: hirt Contributed-by: Ken Dobson ! application/org.openjdk.jmc.docs/html/GUID-0352E76D-96F5-4EDA-A8DE-88B9E18635B9.htm ! application/org.openjdk.jmc.docs/html/GUID-0BFAAA05-CF48-4351-B5FF-AC8E11BAA9DC.htm ! application/org.openjdk.jmc.docs/html/GUID-343C6885-3367-4DDE-9BE5-1A7421CE00A1.htm ! application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm ! application/org.openjdk.jmc.docs/html/GUID-492BB17D-5964-48C3-9212-D4848514437A.htm ! application/org.openjdk.jmc.docs/html/GUID-4B13023D-6AFA-4563-8532-74871DE29B62.htm ! application/org.openjdk.jmc.docs/html/GUID-4F885E48-A548-4140-B985-74B1685BEDEA.htm ! application/org.openjdk.jmc.docs/html/GUID-63742D06-CF58-47F2-9CF2-08C0DB9F09F1.htm ! application/org.openjdk.jmc.docs/html/GUID-66413CF1-A0E1-43BD-B8DB-9720B112D8F3.htm ! application/org.openjdk.jmc.docs/html/GUID-6A66D658-7FD4-4621-9FE7-662D8B8FFACF.htm ! application/org.openjdk.jmc.docs/html/GUID-6B99EBAD-C94C-4B3D-B7B4-867F408012BF.htm ! application/org.openjdk.jmc.docs/html/GUID-8E04A807-3D2B-4896-AD06-B0DE61ACBBD9.htm ! application/org.openjdk.jmc.docs/html/GUID-8EA35A18-669C-4EC3-BCEF-7EA7F92BA3EE.htm ! application/org.openjdk.jmc.docs/html/GUID-953292B2-45D3-4842-9656-DAE88D239BA6.htm ! application/org.openjdk.jmc.docs/html/GUID-A27CE821-5AD5-438D-9A2F-D0B45B743EF0.htm ! application/org.openjdk.jmc.docs/html/GUID-ABF6E2F7-9FE9-4054-934C-BE05AEA8EDFE.htm ! application/org.openjdk.jmc.docs/html/GUID-BCAF66B8-BC4F-48F3-8453-5AA921067861.htm ! application/org.openjdk.jmc.docs/html/GUID-C12D23CE-E9DE-4BFA-A310-9AD5B6D835FD.htm ! application/org.openjdk.jmc.docs/html/GUID-C661942A-3DCF-40B4-87C3-F5000DE4830E.htm ! application/org.openjdk.jmc.docs/html/GUID-CD7A11BF-27AE-481A-8158-03ECC2DB9697.htm ! application/org.openjdk.jmc.docs/html/GUID-DB152DDE-4694-439D-B8A7-CF1EABFAF795.htm ! application/org.openjdk.jmc.docs/html/GUID-DDE72C8A-0A15-43F9-A109-EB87804FD480.htm ! application/org.openjdk.jmc.docs/html/GUID-F94F7FBB-5B53-40A3-854E-8BE8FC172629.htm ! application/org.openjdk.jmc.docs/html/GUID-FEFBE854-3298-46A6-A149-8B48A62330D2.htm From prem.balakrishnan at oracle.com Thu Jan 10 06:17:57 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Wed, 9 Jan 2019 22:17:57 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> Message-ID: Hi All, Corrected supported JDK versions, Please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.03/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 8:00 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus/Guru/Sharath, I have update patch as per review comments please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.02/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 11:32 AM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, GA hosting location is not yet finalized. Will update the patch once I receive the link and send it out for review. Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Tuesday, January 08, 2019 10:29 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -

  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From sharath.ballal at oracle.com Thu Jan 10 10:05:25 2019 From: sharath.ballal at oracle.com (Sharath Ballal) Date: Thu, 10 Jan 2019 02:05:25 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> Message-ID: <7d532f52-d144-4bcb-ab91-2fff9da6fdf6@default> +1 Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 10, 2019 11:48 AM To: Marcus Hirt; Guru Hb; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Corrected supported JDK versions, Please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.03/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 8:00 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus/Guru/Sharath, I have update patch as per review comments please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.02/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 11:32 AM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, GA hosting location is not yet finalized. Will update the patch once I receive the link and send it out for review. Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Tuesday, January 08, 2019 10:29 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -
  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From marcus.hirt at oracle.com Thu Jan 10 11:15:01 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 10 Jan 2019 12:15:01 +0100 Subject: JMC-5002: Put JVM Start Time in perspective In-Reply-To: References: <6F97263B-43D3-4A66-ADCB-75E01AFDEAA5@redhat.com> Message-ID: Looks good! /M From: Ken Dobson Date: Wednesday, 9 January 2019 at 20:57 To: Marcus Hirt Cc: Subject: Re: JMC-5002: Put JVM Start Time in perspective Sorry forgot to add the modified test to the original patch here it is now. Nothing else has changed just need a quick approval on the test update. Thanks, Ken Dobson diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java @@ -57,6 +57,7 @@ import org.openjdk.jmc.common.item.IMemberAccessor; import org.openjdk.jmc.common.item.ItemFilters; import org.openjdk.jmc.common.unit.BinaryPrefix; +import org.openjdk.jmc.common.unit.DecimalPrefix; import org.openjdk.jmc.common.unit.IQuantity; import org.openjdk.jmc.common.unit.UnitLookup; import org.openjdk.jmc.common.util.IPreferenceValueProvider; @@ -134,11 +135,13 @@ EventAvailability ea = RulesToolkit.getEventAvailability(items, JdkTypeIDs.OLD_OBJECT_SAMPLE); // FIXME: Should construct an message using memoryIncrease, not use a hard limit if (score >= 25 && (ea == EventAvailability.DISABLED || ea == EventAvailability.UNKNOWN)) { + IQuantity timeAfterJVMStart = items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); String shortMessage = MessageFormat.format( Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); String longMessage = shortMessage + "

    " //$NON-NLS-1$ - + Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); + + MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), + timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); return new Result(this, score, shortMessage, longMessage, JdkQueries.HEAP_SUMMARY_AFTER_GC); } else if (score < 25) { return new Result(this, score, Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties @@ -374,7 +374,7 @@ IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend # {0} is a number denoted in Mebibytes per second IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems to increase with a speed of about {0} per second during the recording. -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began {0} after the JVM was started. More information can be gathered by using the 'Old Object Sample' event, if available. IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set Trend IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems to increase constantly in the metaspace during the recording. IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may indicate a memory leak in the metaspace, this could be due to the application not unloading classes as needed. diff --git a/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml b/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml --- a/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml +++ b/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml @@ -3888,7 +3888,7 @@ Information 58.89187525739308 The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording. -The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording.<p>This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +The live set on the heap seems to increase with a speed of about 638 KiB per second during the recording.<p>This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began 3.249 s after the JVM was started. More information can be gathered by using the Old Object Sample event, if available. IncreasingMetaSpaceLiveSet On Tue, Jan 8, 2019 at 3:33 AM Marcus Hirt wrote: Hi Ken, I think it's fine. Please go ahead. Kind regards, Marcus ?On 2019-01-07, 21:54, "jmc-dev on behalf of Ken Dobson" wrote: Hi all, This is just a small patch that adds how long a flight recording was started after the JVM was started to the rule text for the IncreasingLiveSetRule. The wording of the rule text feels a little choppy now so if anyone has suggestions they would be appreciated. https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5002 Thanks, Ken Dobson diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java @@ -57,6 +57,7 @@ import org.openjdk.jmc.common.item.IMemberAccessor; import org.openjdk.jmc.common.item.ItemFilters; import org.openjdk.jmc.common.unit.BinaryPrefix; +import org.openjdk.jmc.common.unit.DecimalPrefix; import org.openjdk.jmc.common.unit.IQuantity; import org.openjdk.jmc.common.unit.UnitLookup; import org.openjdk.jmc.common.util.IPreferenceValueProvider; @@ -134,11 +135,13 @@ EventAvailability ea = RulesToolkit.getEventAvailability(items, JdkTypeIDs.OLD_OBJECT_SAMPLE); // FIXME: Should construct an message using memoryIncrease, not use a hard limit if (score >= 25 && (ea == EventAvailability.DISABLED || ea == EventAvailability.UNKNOWN)) { + IQuantity timeAfterJVMStart = items.getAggregate(JdkAggregators.FIRST_ITEM_START).subtract(items.getAggregate(JdkAggregators.JVM_START_TIME)); String shortMessage = MessageFormat.format( Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO), liveSetIncreasePerSecond.displayUsing(IDisplayable.AUTO)); String longMessage = shortMessage + "

    " //$NON-NLS-1$ - + Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG); + + MessageFormat.format(Messages.getString(Messages.IncreasingLiveSetRuleFactory_TEXT_INFO_LONG), + timeAfterJVMStart.displayUsing(IDisplayable.AUTO)); return new Result(this, score, shortMessage, longMessage, JdkQueries.HEAP_SUMMARY_AFTER_GC); } else if (score < 25) { return new Result(this, score, Messages.getString(Messages.IncreasingLiveSetRule_TEXT_OK)); diff --git a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties --- a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties +++ b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties @@ -368,7 +368,7 @@ IncreasingLiveSetRuleFactory_RULE_NAME=Heap Live Set Trend # {0} is a number denoted in Mebibytes per second IncreasingLiveSetRuleFactory_TEXT_INFO=The live set on the heap seems to increase with a speed of about {0} per second during the recording. -IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording. More information can be gathered by using the 'Old Object Sample' event, if available. +IncreasingLiveSetRuleFactory_TEXT_INFO_LONG=This may be due to a memory leak in the application or it may be an artifact of a short recording if the JVM has recently been started. The recording began {0} after the JVM was started. More information can be gathered by using the 'Old Object Sample' event, if available. IncreasingMetaspaceLiveSetRuleFactory_RULE_NAME=Metaspace Live Set Trend IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO=The class data seems to increase constantly in the metaspace during the recording. IncreasingMetaspaceLiveSetRuleFactory_TEXT_INFO_LONG=This behavior may indicate a memory leak in the metaspace, this could be due to the application not unloading classes as needed. From marcus.hirt at oracle.com Thu Jan 10 14:13:26 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 10 Jan 2019 15:13:26 +0100 Subject: Review request for JMC-6327: Updating version to 7.1.0 Message-ID: Hi all, Please review this fix to update the versions in the mainline repo. Jira: https://bugs.openjdk.java.net/browse/JMC-6327 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6327/webrev.0/ Kind regards, Marcus From almacdon at redhat.com Thu Jan 10 17:51:44 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 10 Jan 2019 12:51:44 -0500 Subject: RFR: JMC-6313: Exit menu item alternates visibility in "File" dropdown menu Message-ID: Hi, The following webrev [0] addresses issue JMC-6313 [1], in which the Exit option in the menubar toggles visibility. The culprit here is the recent files list, which is supplied by the ReopenEditorMenu via Eclipse Platform UI [2]. When added to a menu, the ReopenEditorMenu has an interesting effect where subsequent menu items alternate being included and being missing from the menu when the menu is opened. I cloned the Platform UI repo to try and poke around, and I ran into an issue where the subsequent menu items actually aren't added to the menu every-other click. I recreated this behaviour on a simple RCP application and opened a bug report on the Eclipse bugzilla [3]. For what it's worth, the Recent Files list should be added to it's own submenu. Placing the list into it's own submenu is also a workaround because we won't be adding an Exit action sequentially in the menu after the Recent Files list. The included patch [0] adds a new submenu "recentMenu" and adds a couple of separators to distinguish it from it's neighbouring menu items. Images [4]: I've included a couple of images of before [5] and after [6] this patch, as well as a couple of gifs (before [7] & after [8]) that show the issue and proposed solution. Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6313 [2] http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/ReopenEditorMenu.java [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269 [4] https://imgur.com/a/pJkEoKQ [5] https://imgur.com/gnV5aFw [6] https://imgur.com/8S4L7wi [7] https://imgur.com/GlVZ0Ut [8] https://imgur.com/jh6lDoH From marcus.hirt at oracle.com Thu Jan 10 18:25:29 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 10 Jan 2019 19:25:29 +0100 Subject: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu In-Reply-To: <8E4FA5E3-F4E2-4FB6-83A8-98A3BD65B740@redhat.com> References: <8E4FA5E3-F4E2-4FB6-83A8-98A3BD65B740@redhat.com> Message-ID: <30B7659E-9E2B-4C2E-8806-511B63C17F73@oracle.com> Hi Alex, Looks good. Perhaps inline the recentText and recentId String local variables in ApplicationActionBarAdvisor? Let me know if you need help running the UI tests. Kind regards, Marcus ?On 2019-01-10, 18:52, "jmc-dev on behalf of Alex Macdonald" wrote: Hi, The following webrev [0] addresses issue JMC-6313 [1], in which the Exit option in the menubar toggles visibility. The culprit here is the recent files list, which is supplied by the ReopenEditorMenu via Eclipse Platform UI [2]. When added to a menu, the ReopenEditorMenu has an interesting effect where subsequent menu items alternate being included and being missing from the menu when the menu is opened. I cloned the Platform UI repo to try and poke around, and I ran into an issue where the subsequent menu items actually aren't added to the menu every-other click. I recreated this behaviour on a simple RCP application and opened a bug report on the Eclipse bugzilla [3]. For what it's worth, the Recent Files list should be added to it's own submenu. Placing the list into it's own submenu is also a workaround because we won't be adding an Exit action sequentially in the menu after the Recent Files list. The included patch [0] adds a new submenu "recentMenu" and adds a couple of separators to distinguish it from it's neighbouring menu items. Images [4]: I've included a couple of images of before [5] and after [6] this patch, as well as a couple of gifs (before [7] & after [8]) that show the issue and proposed solution. Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6313 [2] http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/ReopenEditorMenu.java [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269 [4] https://imgur.com/a/pJkEoKQ [5] https://imgur.com/gnV5aFw [6] https://imgur.com/8S4L7wi [7] https://imgur.com/GlVZ0Ut [8] https://imgur.com/jh6lDoH From almacdon at redhat.com Thu Jan 10 19:10:36 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 10 Jan 2019 14:10:36 -0500 Subject: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu In-Reply-To: <30B7659E-9E2B-4C2E-8806-511B63C17F73@oracle.com> References: <8E4FA5E3-F4E2-4FB6-83A8-98A3BD65B740@redhat.com> <30B7659E-9E2B-4C2E-8806-511B63C17F73@oracle.com> Message-ID: Hi Marcus, On Thu, Jan 10, 2019 at 1:25 PM Marcus Hirt wrote: > Hi Alex, > > Looks good. Perhaps inline the recentText and recentId String > local variables in ApplicationActionBarAdvisor? Let me know if > you need help running the UI tests. > Sure that sounds good to me, I've updated it in a newer webrev @ http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.01/. I've run the UI tests with this patch applied and it doesn't interfere with the tests or menu highlighting. Kind regards, > Marcus > > > ?On 2019-01-10, 18:52, "jmc-dev on behalf of Alex Macdonald" < > jmc-dev-bounces at openjdk.java.net on behalf of almacdon at redhat.com> wrote: > > Hi, > > The following webrev [0] addresses issue JMC-6313 [1], in which the > Exit > option in the menubar toggles visibility. > > The culprit here is the recent files list, which is supplied by the > ReopenEditorMenu via Eclipse Platform UI [2]. When added to a menu, the > ReopenEditorMenu has an interesting effect where subsequent menu items > alternate being included and being missing from the menu when the menu > is > opened. I cloned the Platform UI repo to try and poke around, and I ran > into an issue where the subsequent menu items actually aren't added to > the > menu every-other click. I recreated this behaviour on a simple RCP > application and opened a bug report on the Eclipse bugzilla [3]. > > For what it's worth, the Recent Files list should be added to it's own > submenu. Placing the list into it's own submenu is also a workaround > because we won't be adding an Exit action sequentially in the menu > after > the Recent Files list. The included patch [0] adds a new submenu > "recentMenu" and adds a couple of separators to distinguish it from > it's > neighbouring menu items. > > Images [4]: > I've included a couple of images of before [5] and after [6] this > patch, as > well as a couple of gifs (before [7] & after [8]) that show the issue > and > proposed solution. > > Thoughts? > > Cheers, > > Alex > > [0] http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.00/ > [1] https://bugs.openjdk.java.net/browse/JMC-6313 > [2] > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/ReopenEditorMenu.java > [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269 > [4] https://imgur.com/a/pJkEoKQ > [5] https://imgur.com/gnV5aFw > [6] https://imgur.com/8S4L7wi > [7] https://imgur.com/GlVZ0Ut > [8] https://imgur.com/jh6lDoH > > From jkang at redhat.com Thu Jan 10 19:19:23 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 10 Jan 2019 14:19:23 -0500 Subject: Review request for JMC-6327: Updating version to 7.1.0 In-Reply-To: References: Message-ID: On Thu, Jan 10, 2019 at 9:16 AM Marcus Hirt wrote: > > Hi all, > > Please review this fix to update the versions in the mainline repo. Hi Marcus, After applying this patch I see two remaining references to 7.0.0: README.md: 317: application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip releng/third-party/pom.xml: 39: 7.0.0-SNAPSHOT Should these be updated as well? Otherwise it looks okay to me. I was able to build and run JMC. Regards, > > Jira: https://bugs.openjdk.java.net/browse/JMC-6327 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6327/webrev.0/ > > Kind regards, > Marcus > > From guru.hb at oracle.com Thu Jan 10 19:29:48 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 11 Jan 2019 00:59:48 +0530 Subject: Review request for JMC-6327: Updating version to 7.1.0 In-Reply-To: References: Message-ID: Hi Marcus, Looks good to me with additional changes required as suggested by Jie Kang. Tested on Mac. Thanks, Guru > On 11-Jan-2019, at 12:49 AM, Jie Kang wrote: > > On Thu, Jan 10, 2019 at 9:16 AM Marcus Hirt wrote: >> >> Hi all, >> >> Please review this fix to update the versions in the mainline repo. > > Hi Marcus, > > After applying this patch I see two remaining references to 7.0.0: > > README.md: > 317: application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip > > releng/third-party/pom.xml: > 39: 7.0.0-SNAPSHOT > > Should these be updated as well? Otherwise it looks okay to me. I was > able to build and run JMC. > > > Regards, > >> >> Jira: https://bugs.openjdk.java.net/browse/JMC-6327 >> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6327/webrev.0/ >> >> Kind regards, >> Marcus >> >> From marcus at hirt.se Thu Jan 10 20:02:59 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 10 Jan 2019 21:02:59 +0100 Subject: SV: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu In-Reply-To: References: <8E4FA5E3-F4E2-4FB6-83A8-98A3BD65B740@redhat.com> <30B7659E-9E2B-4C2E-8806-511B63C17F73@oracle.com> Message-ID: <02e301d4a91f$7c2c37e0$7484a7a0$@hirt.se> Looks good! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Alex Macdonald Skickat: den 10 januari 2019 20:11 Till: Marcus Hirt Kopia: jmc-dev at openjdk.java.net ?mne: Re: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu Hi Marcus, On Thu, Jan 10, 2019 at 1:25 PM Marcus Hirt wrote: > Hi Alex, > > Looks good. Perhaps inline the recentText and recentId String local > variables in ApplicationActionBarAdvisor? Let me know if you need help > running the UI tests. > Sure that sounds good to me, I've updated it in a newer webrev @ http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.01/. I've run the UI tests with this patch applied and it doesn't interfere with the tests or menu highlighting. Kind regards, > Marcus > > > ?On 2019-01-10, 18:52, "jmc-dev on behalf of Alex Macdonald" < > jmc-dev-bounces at openjdk.java.net on behalf of almacdon at redhat.com> wrote: > > Hi, > > The following webrev [0] addresses issue JMC-6313 [1], in which > the Exit > option in the menubar toggles visibility. > > The culprit here is the recent files list, which is supplied by the > ReopenEditorMenu via Eclipse Platform UI [2]. When added to a menu, the > ReopenEditorMenu has an interesting effect where subsequent menu items > alternate being included and being missing from the menu when the > menu is > opened. I cloned the Platform UI repo to try and poke around, and I ran > into an issue where the subsequent menu items actually aren't > added to the > menu every-other click. I recreated this behaviour on a simple RCP > application and opened a bug report on the Eclipse bugzilla [3]. > > For what it's worth, the Recent Files list should be added to it's own > submenu. Placing the list into it's own submenu is also a workaround > because we won't be adding an Exit action sequentially in the menu > after > the Recent Files list. The included patch [0] adds a new submenu > "recentMenu" and adds a couple of separators to distinguish it > from it's > neighbouring menu items. > > Images [4]: > I've included a couple of images of before [5] and after [6] this > patch, as > well as a couple of gifs (before [7] & after [8]) that show the > issue and > proposed solution. > > Thoughts? > > Cheers, > > Alex > > [0] http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.00/ > [1] https://bugs.openjdk.java.net/browse/JMC-6313 > [2] > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/ReopenEditorMenu.java > [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269 > [4] https://imgur.com/a/pJkEoKQ > [5] https://imgur.com/gnV5aFw > [6] https://imgur.com/8S4L7wi > [7] https://imgur.com/GlVZ0Ut > [8] https://imgur.com/jh6lDoH > > From marcus at hirt.se Thu Jan 10 20:04:05 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 10 Jan 2019 21:04:05 +0100 Subject: SV: Review request for JMC-6327: Updating version to 7.1.0 In-Reply-To: References: Message-ID: <02e501d4a91f$a36543b0$ea2fcb10$@hirt.se> Good catch Jie! Will update and commit. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Jie Kang Skickat: den 10 januari 2019 20:19 Till: Marcus Hirt Kopia: jmc-dev at openjdk.java.net ?mne: Re: Review request for JMC-6327: Updating version to 7.1.0 On Thu, Jan 10, 2019 at 9:16 AM Marcus Hirt wrote: > > Hi all, > > Please review this fix to update the versions in the mainline repo. Hi Marcus, After applying this patch I see two remaining references to 7.0.0: README.md: 317: application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip releng/third-party/pom.xml: 39: 7.0.0-SNAPSHOT Should these be updated as well? Otherwise it looks okay to me. I was able to build and run JMC. Regards, > > Jira: https://bugs.openjdk.java.net/browse/JMC-6327 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6327/webrev.0/ > > Kind regards, > Marcus > > From almacdon at redhat.com Thu Jan 10 20:04:31 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 10 Jan 2019 15:04:31 -0500 Subject: RFC: JMC-6329: UITest fails due to font changes in MBean Browser Message-ID: Hi, This one-liner patch [0] addresses issue JMC-6329 [1], in which a UI test failure occurs when resizing fonts in the MBeanBrowserTabTest [2]. The test in question is "testValueFontSize()" [3], which essentially verifies that a larger font (size 16) can be resized to a smaller one (e.g., default font) for font height consistency. However, the font size constant used in the test is hardcoded at 11 [4] which is a likely value for many machines, but not all. For example, when running the UI tests on my Linux desktop the test passes, because my default font is size 11, but if I run the tests in a virtual display (using something like vncserver), then my default font size is actually 10 and I encounter a test failure that looks like: expected:<1|Monospace|11.0|2|GTK|1|> but was:<1|Monospace|10.0|2|GTK|1> To address this, I've changed the DEFAULT_FONT_HEIGHT [4] to instead use the actual value of the default font height, retrieved by using JFaceResources.getDefaultFont().getFontData()[0].getHeight(). This change allows the tests to pass on my Linux machines, but I'm interested to see if this will fix the issue on other platforms; the example in the bug report shows that the FontData array differed in two places when run in Windows (one difference in the font height, and another in the font style). Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6329/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6329 [2] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java [3] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l372 [4] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l86 From marcus.hirt at oracle.com Thu Jan 10 20:22:57 2019 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Thu, 10 Jan 2019 20:22:57 +0000 Subject: hg: jmc/jmc: JMC-6327: Updating version to 7.1.0 Message-ID: <201901102022.x0AKMvck004172@aojmv0008.oracle.com> Changeset: 819d1869139a Author: hirt Date: 2019-01-10 21:22 +0100 URL: http://hg.openjdk.java.net/jmc/jmc/rev/819d1869139a JMC-6327: Updating version to 7.1.0 Reviewed-by: Jie Kang ,ghb ! README.md ! application/l10n/org.openjdk.jmc.alert.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.ja/pom.xml ! application/l10n/org.openjdk.jmc.alert.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.docs.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.ja/nl/ja/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.ja/pom.xml ! application/l10n/org.openjdk.jmc.docs.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.zh_CN/nl/zh/CN/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.intro.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.zh_CN/pom.xml ! application/l10n/pom.xml ! application/org.openjdk.jmc.alert/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.alert/pom.xml ! application/org.openjdk.jmc.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.attach/pom.xml ! application/org.openjdk.jmc.browser.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.jdp/pom.xml ! application/org.openjdk.jmc.browser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser/pom.xml ! application/org.openjdk.jmc.commands/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.commands/pom.xml ! application/org.openjdk.jmc.console.jconsole/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.jconsole/pom.xml ! application/org.openjdk.jmc.console.pde/pom.xml ! application/org.openjdk.jmc.console.persistence/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.persistence/pom.xml ! application/org.openjdk.jmc.console.twitter/pom.xml ! application/org.openjdk.jmc.console.ui.diagnostic/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.diagnostic/pom.xml ! application/org.openjdk.jmc.console.ui.mbeanbrowser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.mbeanbrowser/pom.xml ! application/org.openjdk.jmc.console.ui.notification/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.notification/pom.xml ! application/org.openjdk.jmc.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/pom.xml ! application/org.openjdk.jmc.docs/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.docs/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/org.openjdk.jmc.docs/pom.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.feature.console/feature.xml ! application/org.openjdk.jmc.feature.console/pom.xml ! application/org.openjdk.jmc.feature.core/feature.xml ! application/org.openjdk.jmc.feature.core/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder/pom.xml ! application/org.openjdk.jmc.feature.ide.launch/feature.xml ! application/org.openjdk.jmc.feature.ide.launch/pom.xml ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.ide/pom.xml ! application/org.openjdk.jmc.feature.jconsole/feature.xml ! application/org.openjdk.jmc.feature.jconsole/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.feature.joverflow/pom.xml ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.license/pom.xml ! application/org.openjdk.jmc.feature.pde/feature.xml ! application/org.openjdk.jmc.feature.pde/pom.xml ! application/org.openjdk.jmc.feature.rcp.update/feature.xml ! application/org.openjdk.jmc.feature.rcp.update/pom.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml ! application/org.openjdk.jmc.feature.rcp/pom.xml ! application/org.openjdk.jmc.feature.twitter/feature.xml ! application/org.openjdk.jmc.feature.twitter/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.flightrecorder.metadata/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.flightrecorder.pde/pom.xml ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ui/pom.xml ! application/org.openjdk.jmc.greychart.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart.ui/pom.xml ! application/org.openjdk.jmc.greychart/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart/pom.xml ! application/org.openjdk.jmc.ide.jdt/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.jdt/pom.xml ! application/org.openjdk.jmc.ide.launch/pom.xml ! application/org.openjdk.jmc.ide.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.ui/pom.xml ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/pom.xml ! application/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.jdp/pom.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml ! application/org.openjdk.jmc.joverflow/pom.xml ! application/org.openjdk.jmc.osgi.extension/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.osgi.extension/pom.xml ! application/org.openjdk.jmc.pde/pom.xml ! application/org.openjdk.jmc.rcp.application/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.application/pom.xml ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties ! application/org.openjdk.jmc.rcp.application/src/main/resources/updatesites.properties ! application/org.openjdk.jmc.rcp.intro/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.intro/pom.xml ! application/org.openjdk.jmc.rcp.product.feature/feature.xml ! application/org.openjdk.jmc.rcp.product.feature/pom.xml ! application/org.openjdk.jmc.rcp.product/feature.xml ! application/org.openjdk.jmc.rcp.product/jmc.product ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ext/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.services.jfr/pom.xml ! application/org.openjdk.jmc.rjmx.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ui/pom.xml ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx/pom.xml ! application/org.openjdk.jmc.ui.common/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui.common/pom.xml ! application/org.openjdk.jmc.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui/pom.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.ide/pom.xml ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/pom.xml ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.greychart.test/pom.xml ! application/tests/org.openjdk.jmc.ide.launch.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ide.launch.test/pom.xml ! application/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.jdp.test/pom.xml ! application/tests/org.openjdk.jmc.joverflow.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.joverflow.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/BasicCommunicationTest.java ! application/tests/org.openjdk.jmc.ui.common.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.common.test/pom.xml ! application/tests/org.openjdk.jmc.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.test/pom.xml ! application/tests/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.jconsole.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/pom.xml ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/src/test/java/org/openjdk/jmc/rcp/application/uitest/UpdateSiteTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/pom.xml ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-oxygen/pom.xml ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml ! releng/pom.xml ! releng/third-party/pom.xml From jmatsuok at redhat.com Thu Jan 10 20:55:41 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Thu, 10 Jan 2019 20:55:41 +0000 Subject: hg: jmc/jmc: JMC-5002: Put the JVM Start Time in perspective Message-ID: <201901102055.x0AKtf4F018342@aojmv0008.oracle.com> Changeset: aa701f60af6d Author: jmatsuoka Date: 2019-01-10 15:55 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/aa701f60af6d JMC-5002: Put the JVM Start Time in perspective Summary: Put JVM Start Time in perspective for IncreasingLiveSetRule Reviewed by: hirt Contributed-by: Ken Dobson ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml From marcus at hirt.se Thu Jan 10 21:41:41 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 10 Jan 2019 22:41:41 +0100 Subject: SV: JMC-6329: UITest fails due to font changes in MBean Browser In-Reply-To: References: Message-ID: <032101d4a92d$4626aff0$d2740fd0$@hirt.se> Hi Alex, The uitests pass with the fix on my Windows system. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Alex Macdonald Skickat: den 10 januari 2019 21:05 Till: jmc-dev at openjdk.java.net ?mne: RFC: JMC-6329: UITest fails due to font changes in MBean Browser Hi, This one-liner patch [0] addresses issue JMC-6329 [1], in which a UI test failure occurs when resizing fonts in the MBeanBrowserTabTest [2]. The test in question is "testValueFontSize()" [3], which essentially verifies that a larger font (size 16) can be resized to a smaller one (e.g., default font) for font height consistency. However, the font size constant used in the test is hardcoded at 11 [4] which is a likely value for many machines, but not all. For example, when running the UI tests on my Linux desktop the test passes, because my default font is size 11, but if I run the tests in a virtual display (using something like vncserver), then my default font size is actually 10 and I encounter a test failure that looks like: expected:<1|Monospace|11.0|2|GTK|1|> but was:<1|Monospace|10.0|2|GTK|1> To address this, I've changed the DEFAULT_FONT_HEIGHT [4] to instead use the actual value of the default font height, retrieved by using JFaceResources.getDefaultFont().getFontData()[0].getHeight(). This change allows the tests to pass on my Linux machines, but I'm interested to see if this will fix the issue on other platforms; the example in the bug report shows that the FontData array differed in two places when run in Windows (one difference in the font height, and another in the font style). Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6329/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6329 [2] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java [3] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l372 [4] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l86 From prem.balakrishnan at oracle.com Fri Jan 11 11:11:06 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Fri, 11 Jan 2019 03:11:06 -0800 (PST) Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's In-Reply-To: <7d532f52-d144-4bcb-ab91-2fff9da6fdf6@default> References: <42aff96a-a89a-4138-b584-7f328e9bb692@default> <37f2d2e3-62ef-4c5d-9425-f262d46aa04f@default> <7d532f52-d144-4bcb-ab91-2fff9da6fdf6@default> Message-ID: Hi Guru, Here is the patch for JMC 7.0.0 . http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.04/ Regards, Prem -----Original Message----- From: Sharath Ballal Sent: Thursday, January 10, 2019 3:35 PM To: Prem Balakrishnan ; Marcus Hirt ; Guru Hb Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's +1 Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 10, 2019 11:48 AM To: Marcus Hirt; Guru Hb; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Corrected supported JDK versions, Please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.03/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 8:00 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus/Guru/Sharath, I have update patch as per review comments please take a look. http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.02/ Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Wednesday, January 09, 2019 11:32 AM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, GA hosting location is not yet finalized. Will update the patch once I receive the link and send it out for review. Regards, Prem -----Original Message----- From: Prem Balakrishnan Sent: Tuesday, January 08, 2019 10:29 PM To: Marcus Hirt ; Guru Hb ; Sharath Ballal Cc: jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Marcus, Guru , Sharath, Please review the updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.01/ @Sharath, item 4 and 5 myself and Guru we have decided to remove this section. Item 6 link will be up soon. 2 and 7 corrected. 3 and 8 GA will be available at http://jdk.java.net/jmc/ -----Original Message----- From: Sharath Ballal Sent: Tuesday, January 08, 2019 5:04 PM To: Prem Balakrishnan ; jmc-dev at openjdk.java.net Subject: RE: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi Prem, My comments below. 1. In all the files, Copyright year should not be replaced to 2019 instead should be changed to: Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. File application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html 2. Not sure about this. I think JMC still works with Eclipse 4.7, can you pls verify? -

  • Requires Eclipse 4.7 or later.
    • +
  • Requires Eclipse 4.8 or later.
    • - JDK Mission Control is a set of plug-ins for Eclipse 4.7 or later.

    + JDK Mission Control is a set of plug-ins for Eclipse 4.8 or later.

    3. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - Release Notes can be found on the     JDK Mission Control home page
    + Release Notes can be found on the JDK Mission Control home page
    4. No need to remove these lines - Download and Install
    - JDK Mission Control is available free of charge for development. - For more information, see the JDK Mission Control home page.

    5. No need to remove these lines. Updatesite will be available in this link going forward. - Bullet - - Download for Offline Installation -
    File application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html 6. The new link doesn't seem to work - http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/

    + https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/ide/

    7. Same as earlier comment, pls check if 4.7 is supported or not. - Before starting, make sure that you have downloaded and installed Eclipse 4.7 or later. + Before starting, make sure that you have downloaded and installed Eclipse 4.8 or later. File application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html 8. No need to change the OTN link to http://jdk.java.net/jmc/ as the final GA bundle will be available in OTN. - + Thanks, Sharath -----Original Message----- From: Prem Balakrishnan Sent: Thursday, January 03, 2019 6:41 PM To: jmc-dev at openjdk.java.net Subject: Review Request: JMC-6308 JMC 7.0.0 update ide and rcp landing page with correct url's Hi All, Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6308"JMC-6308 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6308/webrev.00/ updated "Mission control" to "JDK Mission control" and JMC download location. Regards, Prem From marcus.hirt at oracle.com Fri Jan 11 20:08:59 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Fri, 11 Jan 2019 21:08:59 +0100 Subject: JMC-6329: UITest fails due to font changes in MBean Browser In-Reply-To: <9F323EB0-8266-4969-819B-E00C858E0BBA@hirt.se> References: <9F323EB0-8266-4969-819B-E00C858E0BBA@hirt.se> Message-ID: Hi Alex, The change looks good. Please work with Josh or Mario to push it. Kind regards, Marcus ?On 2019-01-10, 22:42, "jmc-dev on behalf of Marcus Hirt" wrote: Hi Alex, The uitests pass with the fix on my Windows system. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Alex Macdonald Skickat: den 10 januari 2019 21:05 Till: jmc-dev at openjdk.java.net ?mne: RFC: JMC-6329: UITest fails due to font changes in MBean Browser Hi, This one-liner patch [0] addresses issue JMC-6329 [1], in which a UI test failure occurs when resizing fonts in the MBeanBrowserTabTest [2]. The test in question is "testValueFontSize()" [3], which essentially verifies that a larger font (size 16) can be resized to a smaller one (e.g., default font) for font height consistency. However, the font size constant used in the test is hardcoded at 11 [4] which is a likely value for many machines, but not all. For example, when running the UI tests on my Linux desktop the test passes, because my default font is size 11, but if I run the tests in a virtual display (using something like vncserver), then my default font size is actually 10 and I encounter a test failure that looks like: expected:<1|Monospace|11.0|2|GTK|1|> but was:<1|Monospace|10.0|2|GTK|1> To address this, I've changed the DEFAULT_FONT_HEIGHT [4] to instead use the actual value of the default font height, retrieved by using JFaceResources.getDefaultFont().getFontData()[0].getHeight(). This change allows the tests to pass on my Linux machines, but I'm interested to see if this will fix the issue on other platforms; the example in the bug report shows that the FontData array differed in two places when run in Windows (one difference in the font height, and another in the font style). Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6329/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6329 [2] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java [3] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l372 [4] http://hg.openjdk.java.net/jmc/jmc/file/b85cad824acf/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java#l86 From jmatsuok at redhat.com Fri Jan 11 20:54:53 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Fri, 11 Jan 2019 20:54:53 +0000 Subject: hg: jmc/jmc: 2 new changesets Message-ID: <201901112054.x0BKsrKp017697@aojmv0008.oracle.com> Changeset: 6931dbc97c10 Author: aptmac Date: 2019-01-10 15:13 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/6931dbc97c10 JMC-6313: Exit menu item alternates visibility in "File" dropdown menu Reviewed-by: hirt ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationActionBarAdvisor.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/Messages.java ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties Changeset: 042002d27b58 Author: aptmac Date: 2019-01-11 15:13 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/042002d27b58 JMC-6329: UITest fails due to font changes in MBean Browser Reviewed-by: hirt ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java From jmatsuok at redhat.com Fri Jan 11 21:31:26 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Fri, 11 Jan 2019 21:31:26 +0000 Subject: hg: jmc/jmc: JMC-6314: Default JMC binaries for Linux reference odd "-vm ../../bin" Message-ID: <201901112131.x0BLVQrU001972@aojmv0008.oracle.com> Changeset: 77a9bfb4a741 Author: jmatsuoka Date: 2019-01-11 16:31 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/77a9bfb4a741 JMC-6314: Default JMC binaries for Linux reference odd "-vm ../../bin" Summary: Make use of the default java on Linux systems Reviewed-by: ghb, jmatsuok Contributed-by: Salman Siddiqui ! application/org.openjdk.jmc.rcp.product/jmc.product From jmatsuok at redhat.com Fri Jan 11 21:30:18 2019 From: jmatsuok at redhat.com (Joshua Matsuoka) Date: Fri, 11 Jan 2019 16:30:18 -0500 Subject: Review Request: JMC 6314 - Default JMC binaries for Linux reference odd "-vm ../../bin" In-Reply-To: References: Message-ID: Hi Salman, looks good to me. Cheers, - Josh On Tue, Jan 8, 2019 at 10:16 AM Guru wrote: > +1 Looks good to me. > > Note: https://bugs.openjdk.java.net/browse/JMC-6314 is still ?Unassigned? > and its state is in ?Triage?. > > Please request any of your team member who has JBS Account to assign to > them self and sponsor the changes. > > Thanks, > Guru > > On 08-Jan-2019, at 8:35 PM, Salman Siddiqui wrote: > > > > Hi all, > > > > This is a patch to use the default Java on Linux systems instead of > > searching for a JDK in the non-existent "../../bin" directory. > > > > Thanks, > > Salman > > > > > > diff -r 80f49c3226cb application/org.openjdk.jmc.rcp.product/jmc.product > > --- a/application/org.openjdk.jmc.rcp.product/jmc.product Thu Jan > 03 > > 16:54:12 2019 +0530 > > +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Tue Jan > 08 > > 09:59:09 2019 -0500 > > @@ -48,7 +48,7 @@ > > > > --launcher.appendVmargs > > > > - -vm ../../bin/ > > + -vm /usr/bin/java > > > > -ws cocoa -vm ../jdk/Contents/Home/bin/ > > > > From marcus at hirt.se Sun Jan 13 14:19:50 2019 From: marcus at hirt.se (Marcus Hirt) Date: Sun, 13 Jan 2019 15:19:50 +0100 Subject: Review request for JMC-6334: Fixing wrongly spelt method Message-ID: <028a01d4ab4b$0b5f5140$221df3c0$@hirt.se> Jira: https://bugs.openjdk.java.net/browse/JMC-6334 Diff: diff -r 77a9bfb4a741 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightreco rder/internal/parser/Chunk.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre corder/internal/parser/Chunk.java Fri Jan 11 16:31:10 2019 -0500 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre corder/internal/parser/Chunk.java Sun Jan 13 15:16:32 2019 +0100 @@ -87,7 +87,7 @@ * @return the current buffer for the chunk data */ public byte[] fill(long upToPosition) throws IOException, InvalidJfrFileException { - int fillUpTo = getArrayPosistion(upToPosition); + int fillUpTo = getArrayPosition(upToPosition); if (data.length < fillUpTo) { data = Arrays.copyOf(data, (int) (fillUpTo * 1.2)); } @@ -106,7 +106,7 @@ * chunk relative position */ public void skip(long upToPosition) throws IOException, InvalidJfrFileException { - int skipUpTo = getArrayPosistion(upToPosition); + int skipUpTo = getArrayPosition(upToPosition); if (skipUpTo > position) { int skipped = input.skipBytes(skipUpTo - position); position += skipped; @@ -124,7 +124,7 @@ return data; } - private static int getArrayPosistion(long pos) throws InvalidJfrFileException { + private static int getArrayPosition(long pos) throws InvalidJfrFileException { if (pos > Integer.MAX_VALUE) { throw new InvalidJfrFileException(); } else { From guru.hb at oracle.com Sun Jan 13 16:17:45 2019 From: guru.hb at oracle.com (Guru) Date: Sun, 13 Jan 2019 21:47:45 +0530 Subject: Review request for JMC-6334: Fixing wrongly spelt method In-Reply-To: <028a01d4ab4b$0b5f5140$221df3c0$@hirt.se> References: <028a01d4ab4b$0b5f5140$221df3c0$@hirt.se> Message-ID: <13348E73-8A3F-4C80-A5DD-79FFBF393BFF@oracle.com> +1 Looks good to me. > On 13-Jan-2019, at 7:49 PM, Marcus Hirt wrote: > > Jira: https://bugs.openjdk.java.net/browse/JMC-6334 > Diff: > diff -r 77a9bfb4a741 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightreco > rder/internal/parser/Chunk.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre > corder/internal/parser/Chunk.java Fri Jan 11 16:31:10 2019 -0500 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre > corder/internal/parser/Chunk.java Sun Jan 13 15:16:32 2019 +0100 > @@ -87,7 +87,7 @@ > * @return the current buffer for the chunk data > */ > public byte[] fill(long upToPosition) throws IOException, > InvalidJfrFileException { > - int fillUpTo = getArrayPosistion(upToPosition); > + int fillUpTo = getArrayPosition(upToPosition); > if (data.length < fillUpTo) { > data = Arrays.copyOf(data, (int) (fillUpTo * 1.2)); > } > @@ -106,7 +106,7 @@ > * chunk relative position > */ > public void skip(long upToPosition) throws IOException, > InvalidJfrFileException { > - int skipUpTo = getArrayPosistion(upToPosition); > + int skipUpTo = getArrayPosition(upToPosition); > if (skipUpTo > position) { > int skipped = input.skipBytes(skipUpTo - position); > position += skipped; > @@ -124,7 +124,7 @@ > return data; > } > > - private static int getArrayPosistion(long pos) throws > InvalidJfrFileException { > + private static int getArrayPosition(long pos) throws > InvalidJfrFileException { > if (pos > Integer.MAX_VALUE) { > throw new InvalidJfrFileException(); > } else { > > From miro.wengner at gmail.com Sun Jan 13 16:25:27 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Sun, 13 Jan 2019 17:25:27 +0100 Subject: Review request for JMC-6334: Fixing wrongly spelt method In-Reply-To: <13348E73-8A3F-4C80-A5DD-79FFBF393BFF@oracle.com> References: <028a01d4ab4b$0b5f5140$221df3c0$@hirt.se> <13348E73-8A3F-4C80-A5DD-79FFBF393BFF@oracle.com> Message-ID: +1 Looks good to me > On Jan 13, 2019, at 5:17 PM, Guru wrote: > > +1 Looks good to me. > >> On 13-Jan-2019, at 7:49 PM, Marcus Hirt wrote: >> >> Jira: https://bugs.openjdk.java.net/browse/JMC-6334 >> Diff: >> diff -r 77a9bfb4a741 >> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightreco >> rder/internal/parser/Chunk.java >> --- >> a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre >> corder/internal/parser/Chunk.java Fri Jan 11 16:31:10 2019 -0500 >> +++ >> b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre >> corder/internal/parser/Chunk.java Sun Jan 13 15:16:32 2019 +0100 >> @@ -87,7 +87,7 @@ >> * @return the current buffer for the chunk data >> */ >> public byte[] fill(long upToPosition) throws IOException, >> InvalidJfrFileException { >> - int fillUpTo = getArrayPosistion(upToPosition); >> + int fillUpTo = getArrayPosition(upToPosition); >> if (data.length < fillUpTo) { >> data = Arrays.copyOf(data, (int) (fillUpTo * 1.2)); >> } >> @@ -106,7 +106,7 @@ >> * chunk relative position >> */ >> public void skip(long upToPosition) throws IOException, >> InvalidJfrFileException { >> - int skipUpTo = getArrayPosistion(upToPosition); >> + int skipUpTo = getArrayPosition(upToPosition); >> if (skipUpTo > position) { >> int skipped = input.skipBytes(skipUpTo - position); >> position += skipped; >> @@ -124,7 +124,7 @@ >> return data; >> } >> >> - private static int getArrayPosistion(long pos) throws >> InvalidJfrFileException { >> + private static int getArrayPosition(long pos) throws >> InvalidJfrFileException { >> if (pos > Integer.MAX_VALUE) { >> throw new InvalidJfrFileException(); >> } else { >> >> > From marcus.hirt at oracle.com Sun Jan 13 16:50:52 2019 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Sun, 13 Jan 2019 16:50:52 +0000 Subject: hg: jmc/jmc: JMC-6334: Rectifying typo in method name Message-ID: <201901131650.x0DGoqGi029637@aojmv0008.oracle.com> Changeset: 0e7f3f9e078c Author: hirt Date: 2019-01-13 17:50 +0100 URL: http://hg.openjdk.java.net/jmc/jmc/rev/0e7f3f9e078c JMC-6334: Rectifying typo in method name Reviewed-by: ghb, mwengner ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/Chunk.java From guru.hb at oracle.com Mon Jan 14 04:15:55 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Mon, 14 Jan 2019 04:15:55 +0000 Subject: hg: jmc/jmc7: JMC-6308: JMC 7.0.0 update ide and rcp landing page with correct url's Message-ID: <201901140415.x0E4Ftv3026070@aojmv0008.oracle.com> Changeset: b145c11e18c5 Author: ghb Date: 2019-01-14 09:45 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/b145c11e18c5 JMC-6308: JMC 7.0.0 update ide and rcp landing page with correct url's Reviewed-by: sballal, ghb Contributed-by: pkbalakr ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/run-on-jdk-instructions/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html From sasiddiq at redhat.com Mon Jan 14 21:01:54 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Mon, 14 Jan 2019 16:01:54 -0500 Subject: Review Request: JMC-6333 - Default JMC binaries should not hardcode -vm /usr/bin/java Message-ID: Hi all, This is a patch to remove "-vm /usr/bin/java" from jmc.ini so that the default Java on the PATH is used on Linux systems. It is a follow-up of JMC-6314. Thanks, Salman diff -r 0e7f3f9e078c application/org.openjdk.jmc.rcp.product/jmc.product --- a/application/org.openjdk.jmc.rcp.product/jmc.product Sun Jan 13 17:50:38 2019 +0100 +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Mon Jan 14 15:53:39 2019 -0500 @@ -48,8 +48,8 @@ --launcher.appendVmargs - -vm /usr/bin/java - + + -ws cocoa -vm ../jdk/Contents/Home/bin/ -vm ./ From sasiddiq at redhat.com Tue Jan 15 16:56:04 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Tue, 15 Jan 2019 11:56:04 -0500 Subject: Unable to reproduce bug in JMC-6216 Message-ID: Hi Marcus, I'm unable to reproduce this issue. Can you please verify that the issue still exists? I'm on Fedora 29 and running JMC in Eclipse with JDK 11. Thanks, Salman From jkang at redhat.com Tue Jan 15 17:03:28 2019 From: jkang at redhat.com (Jie Kang) Date: Tue, 15 Jan 2019 12:03:28 -0500 Subject: Unable to reproduce bug in JMC-6216 In-Reply-To: References: Message-ID: On Tue, Jan 15, 2019 at 11:56 AM Salman Siddiqui wrote: > > Hi Marcus, > > I'm unable to reproduce this issue. Can you please verify that the issue > still exists? > I'm on Fedora 29 and running JMC in Eclipse with JDK 11. This could be related to the version of Eclipse being used; what version was this found on and what version was used to try to reproduce? The OS used is also useful information. I've included a link to the bug below for quick browsing. https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6216 Regards, > > Thanks, > Salman From sasiddiq at redhat.com Tue Jan 15 18:38:45 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Tue, 15 Jan 2019 13:38:45 -0500 Subject: Clarification on JMC-5835 Message-ID: Hi all, In the description of JMC-5835 [1], Per Kroon described the issue is that an alert dialog doesn't always appear when a trigger occurs. >From what I've noticed, an alert dialog only appears for 2 triggers: 'Application Alert' and 'Dump Flight Recording'. I just wanted to confirm if we want to have alert dialogs for every trigger action. Perhaps I'm missing some discussion on this since there is a comment in the issue's activity that says "This issue relates to JMC-6088" but I can't access JMC-6088 without an OpenJDK account. Thanks, Salman [1] https://bugs.openjdk.java.net/browse/JMC-5385 From marcus.hirt at oracle.com Tue Jan 15 18:52:54 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 15 Jan 2019 19:52:54 +0100 Subject: Clarification on JMC-5835 In-Reply-To: References: Message-ID: <228B52D5-44E3-497A-8907-E777A32A04ED@oracle.com> Hi Salman, The way it is currently supposed to work, the alert dialog only appears for two reasons: either because there is an Application Alert action, or because there is an error evaluating an action (for example an error evaluating the ?Dump Flight Recording? action). If I understand Per correctly, it seems he is reporting that it can take a very long time upon encountering an error, until the Action Dialog is finally shown. Either that, or there is a misunderstanding in how triggers are currently using the Alert Dialog (always on errors or when configured as an action). Kind regards, Marcus > 15 jan. 2019 kl. 19:38 skrev Salman Siddiqui : > > Hi all, > > In the description of JMC-5835 [1], Per Kroon described the issue is that > an alert dialog doesn't always appear when a trigger occurs. > From what I've noticed, an alert dialog only appears for 2 triggers: > 'Application Alert' and 'Dump Flight Recording'. > > I just wanted to confirm if we want to have alert dialogs for every trigger > action. > > Perhaps I'm missing some discussion on this since there is a comment in the > issue's activity that says "This issue relates to JMC-6088" but I can't > access JMC-6088 without an OpenJDK account. > > > Thanks, > Salman > > [1] https://bugs.openjdk.java.net/browse/JMC-5385 From marcus at hirt.se Tue Jan 15 19:26:14 2019 From: marcus at hirt.se (Marcus Hirt) Date: Tue, 15 Jan 2019 20:26:14 +0100 Subject: SV: Unable to reproduce bug in JMC-6216 In-Reply-To: References: Message-ID: <115e01d4ad08$2e431980$8ac94c80$@hirt.se> It was on Mac OS X, and running the plug-in version installed from a locally built update site into either an Eclipse Photon or 2018-09. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Jie Kang Skickat: den 15 januari 2019 18:03 Till: Salman Siddiqui Kopia: jmc-dev at openjdk.java.net ?mne: Re: Unable to reproduce bug in JMC-6216 On Tue, Jan 15, 2019 at 11:56 AM Salman Siddiqui wrote: > > Hi Marcus, > > I'm unable to reproduce this issue. Can you please verify that the > issue still exists? > I'm on Fedora 29 and running JMC in Eclipse with JDK 11. This could be related to the version of Eclipse being used; what version was this found on and what version was used to try to reproduce? The OS used is also useful information. I've included a link to the bug below for quick browsing. https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6216 Regards, > > Thanks, > Salman From guru.hb at oracle.com Wed Jan 16 04:51:32 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Wed, 16 Jan 2019 04:51:32 +0000 Subject: hg: jmc/jmc7: JMC-6330: [Backport]Bring the fix for JMC-6329 to the jmc7 repo Message-ID: <201901160451.x0G4pWjB006859@aojmv0008.oracle.com> Changeset: 7a46d5380634 Author: ghb Date: 2019-01-16 10:21 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/7a46d5380634 JMC-6330: [Backport]Bring the fix for JMC-6329 to the jmc7 repo Reviewed-by: sballal, ghb Contributed-by: pkbalakr ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java From sasiddiq at redhat.com Wed Jan 16 14:54:01 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Wed, 16 Jan 2019 09:54:01 -0500 Subject: Unable to reproduce bug in JMC-6216 In-Reply-To: <115e01d4ad08$2e431980$8ac94c80$@hirt.se> References: <115e01d4ad08$2e431980$8ac94c80$@hirt.se> Message-ID: Hi, On Tue, Jan 15, 2019 at 2:26 PM Marcus Hirt wrote: > It was on Mac OS X, and running the plug-in version installed from > a locally built update site into either an Eclipse Photon or 2018-09. > I suppose I'll leave this for someone else to tackle since I don't have a Mac to test on. > > Kind regards, > Marcus > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Jie Kang > Skickat: den 15 januari 2019 18:03 > Till: Salman Siddiqui > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: Unable to reproduce bug in JMC-6216 > > On Tue, Jan 15, 2019 at 11:56 AM Salman Siddiqui > wrote: > > > > Hi Marcus, > > > > I'm unable to reproduce this issue. Can you please verify that the > > issue still exists? > > I'm on Fedora 29 and running JMC in Eclipse with JDK 11. > > This could be related to the version of Eclipse being used; what version > was this found on and what version was used to try to reproduce? The OS > used is also useful information. > > I've included a link to the bug below for quick browsing. > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6216 > > > Regards, > > > > > Thanks, > > Salman > > From guru.hb at oracle.com Thu Jan 17 17:39:59 2019 From: guru.hb at oracle.com (Guru) Date: Thu, 17 Jan 2019 23:09:59 +0530 Subject: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Message-ID: Hi, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6128 webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/ Solution and RC updated in JBS. Thanks, Guru From marcus at hirt.se Thu Jan 17 19:21:26 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 17 Jan 2019 20:21:26 +0100 Subject: SV: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites In-Reply-To: References: Message-ID: <017901d4ae99$d7317900$85946b00$@hirt.se> Hi Guru, Super! Good work - please go ahead! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Guru Skickat: den 17 januari 2019 18:40 Till: jmc-dev at openjdk.java.net ?mne: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Hi, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6128 webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/ Solution and RC updated in JBS. Thanks, Guru From marcus at hirt.se Thu Jan 17 20:48:28 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 17 Jan 2019 21:48:28 +0100 Subject: SV: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites In-Reply-To: References: Message-ID: <058b01d4aea6$00255dc0$00701940$@hirt.se> You need a line break at the end of org.openjdk.jmc.javafx.osgi/META_INF/MANIFEST.MF, as headers must be terminated by line breaks. /M -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Guru Skickat: den 17 januari 2019 18:40 Till: jmc-dev at openjdk.java.net ?mne: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Hi, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6128 webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/ Solution and RC updated in JBS. Thanks, Guru From guru.hb at oracle.com Fri Jan 18 07:40:47 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 18 Jan 2019 13:10:47 +0530 Subject: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites In-Reply-To: <058b01d4aea6$00255dc0$00701940$@hirt.se> References: <058b01d4aea6$00255dc0$00701940$@hirt.se> Message-ID: <7028B8C8-6764-40DA-ACFF-555DCF352928@oracle.com> Please find Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.1/ 1. Updated oxygen and 2018-19 target files 2. Updated copyright years (Additional comments in JBS) With this fix, Eclipse running with JDK 9 or its below + JMC doesn?t work as OpenJFX modules are compiled with OpenJDK 11 (i.e with Class file version 54.0). For this https://bugs.openjdk.java.net/browse/JMC-6342 will be a follow on bug to address this defect. Thanks, Guru > On 18-Jan-2019, at 2:18 AM, Marcus Hirt wrote: > > You need a line break at the end of > org.openjdk.jmc.javafx.osgi/META_INF/MANIFEST.MF, > as headers must be terminated by line breaks. > > /M > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Guru > Skickat: den 17 januari 2019 18:40 > Till: jmc-dev at openjdk.java.net > ?mne: Review request: JMC-6128: Integrate org.openjfx library as dependency > local local p2 and re-distribute with Update sites > > Hi, > > Please review the fix for : > JBS : https://bugs.openjdk.java.net/browse/JMC-6128 > webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/ > > Solution and RC updated in JBS. > > Thanks, > Guru > > From marcus at hirt.se Fri Jan 18 18:31:07 2019 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 18 Jan 2019 19:31:07 +0100 Subject: SV: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites In-Reply-To: <7028B8C8-6764-40DA-ACFF-555DCF352928@oracle.com> References: <058b01d4aea6$00255dc0$00701940$@hirt.se> <7028B8C8-6764-40DA-ACFF-555DCF352928@oracle.com> Message-ID: <011901d4af5b$fa7a70c0$ef6f5240$@hirt.se> Thank you, Guru! Looks good! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: Guru Skickat: den 18 januari 2019 08:41 Till: Marcus Hirt Kopia: jmc-dev at openjdk.java.net ?mne: Re: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Please find Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.1/ 1. Updated oxygen and 2018-19 target files 2. Updated copyright years (Additional comments in JBS) With this fix, Eclipse running with JDK 9 or its below + JMC doesn?t work as OpenJFX modules are compiled with OpenJDK 11 (i.e with Class file version 54.0). For this https://bugs.openjdk.java.net/browse/JMC-6342 will be a follow on bug to address this defect. Thanks, Guru > On 18-Jan-2019, at 2:18 AM, Marcus Hirt wrote: > > You need a line break at the end of > org.openjdk.jmc.javafx.osgi/META_INF/MANIFEST.MF, > as headers must be terminated by line breaks. > > /M > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Guru > Skickat: den 17 januari 2019 18:40 > Till: jmc-dev at openjdk.java.net > ?mne: Review request: JMC-6128: Integrate org.openjfx library as > dependency local local p2 and re-distribute with Update sites > > Hi, > > Please review the fix for : > JBS : https://bugs.openjdk.java.net/browse/JMC-6128 > webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/ > > Solution and RC updated in JBS. > > Thanks, > Guru > > From guru.hb at oracle.com Fri Jan 18 18:34:50 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Fri, 18 Jan 2019 18:34:50 +0000 Subject: hg: jmc/jmc: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Message-ID: <201901181834.x0IIYo5T028969@aojmv0008.oracle.com> Changeset: 8c017a4ff44a Author: ghb Date: 2019-01-19 00:04 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/8c017a4ff44a JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Reviewed-by: hirt ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.joverflow.ui/META-INF/MANIFEST.MF ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From guru.hb at oracle.com Fri Jan 18 18:47:33 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Fri, 18 Jan 2019 18:47:33 +0000 Subject: hg: jmc/jmc7: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Message-ID: <201901181847.x0IIlX9p004779@aojmv0008.oracle.com> Changeset: 655bb4f25bae Author: ghb Date: 2019-01-19 00:04 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/655bb4f25bae JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites Reviewed-by: hirt ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.joverflow.ui/META-INF/MANIFEST.MF ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From guru.hb at oracle.com Tue Jan 22 10:58:41 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Tue, 22 Jan 2019 10:58:41 +0000 Subject: hg: jmc/jmc7: JMC-5928: Update versions for all oracle plugins - remove snapshot Message-ID: <201901221058.x0MAwgJp011563@aojmv0008.oracle.com> Changeset: 1b58299aa8b7 Author: ghb Date: 2019-01-22 16:28 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/1b58299aa8b7 JMC-5928: Update versions for all oracle plugins - remove snapshot Reviewed-by: ghb, hirt Contributed-by: deepa.avhad at oracle.com ! application/pom.xml ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml ! pom.xml From sasiddiq at redhat.com Tue Jan 22 15:50:32 2019 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Tue, 22 Jan 2019 10:50:32 -0500 Subject: Review Request: JMC-6333 - Default JMC binaries should not hardcode -vm /usr/bin/java In-Reply-To: References: Message-ID: Hi, This patch is still awaiting review. Thanks, Salman On Mon, Jan 14, 2019 at 4:01 PM Salman Siddiqui wrote: > Hi all, > > This is a patch to remove "-vm /usr/bin/java" from jmc.ini so that the > default Java on the PATH is used on Linux systems. It is a follow-up of > JMC-6314. > > Thanks, > Salman > > diff -r 0e7f3f9e078c application/org.openjdk.jmc.rcp.product/jmc.product > --- a/application/org.openjdk.jmc.rcp.product/jmc.product Sun Jan 13 > 17:50:38 2019 +0100 > +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Mon Jan 14 > 15:53:39 2019 -0500 > @@ -48,8 +48,8 @@ > > --launcher.appendVmargs > > - -vm /usr/bin/java > - > + > + > -ws cocoa -vm ../jdk/Contents/Home/bin/ > > -vm ./ > > From marcus.hirt at oracle.com Wed Jan 23 10:06:16 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Wed, 23 Jan 2019 11:06:16 +0100 Subject: JMC 7 release delayed Message-ID: Hi all, As it looks, we will not be able to release JMC 7 on Jan 30. We're handling additional process required to produce a stand-alone, open-sourced, version of JMC. As you may have noticed, we have switched over the mainline branch to 7.1 development, and we are all now mostly working on JMC 7.1. I don't foresee many changes to the jmc7 repo before building the GA. I don?t have a new date, as it?s hard to estimate the time these processes take to complete. If I had to venture a guess, I would say less than a month. Please let me know if you have any questions! Kind regards, Marcus From neugens at redhat.com Wed Jan 23 11:39:58 2019 From: neugens at redhat.com (Mario Torre) Date: Wed, 23 Jan 2019 12:39:58 +0100 Subject: Review Request: JMC-6333 - Default JMC binaries should not hardcode -vm /usr/bin/java In-Reply-To: References: Message-ID: <4f2c10a70607156ba03e8f144c3851f79dac5af5.camel@redhat.com> On Tue, 2019-01-22 at 10:50 -0500, Salman Siddiqui wrote: > Hi, > > This patch is still awaiting review. The patch looks good to me, however I think we need to have Marcus OK on this one, I don't know if it has any impact on the closed JMC that needs to be addressed. Cheers, Mario > Thanks, > Salman > > On Mon, Jan 14, 2019 at 4:01 PM Salman Siddiqui > wrote: > > > Hi all, > > > > This is a patch to remove "-vm /usr/bin/java" from jmc.ini so that > > the > > default Java on the PATH is used on Linux systems. It is a follow- > > up of > > JMC-6314. > > > > Thanks, > > Salman > > > > diff -r 0e7f3f9e078c > > application/org.openjdk.jmc.rcp.product/jmc.product > > --- a/application/org.openjdk.jmc.rcp.product/jmc.product Sun > > Jan 13 > > 17:50:38 2019 +0100 > > +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Mon > > Jan 14 > > 15:53:39 2019 -0500 > > @@ -48,8 +48,8 @@ > > > > --launcher.appendVmargs > > > > - -vm /usr/bin/java > > - > > + > > + > > -ws cocoa -vm ../jdk/Contents/Home/bin/ > > > > -vm ./ > > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From guru.hb at oracle.com Wed Jan 23 13:50:20 2019 From: guru.hb at oracle.com (Guru) Date: Wed, 23 Jan 2019 19:20:20 +0530 Subject: Review Request: JMC-6333 - Default JMC binaries should not hardcode -vm /usr/bin/java In-Reply-To: <4f2c10a70607156ba03e8f144c3851f79dac5af5.camel@redhat.com> References: <4f2c10a70607156ba03e8f144c3851f79dac5af5.camel@redhat.com> Message-ID: <9704904F-A0AD-4BB8-BCFD-FDF657279420@oracle.com> +1, Looks good to me. Thanks, Guru > On 23-Jan-2019, at 5:09 PM, Mario Torre wrote: > > On Tue, 2019-01-22 at 10:50 -0500, Salman Siddiqui wrote: >> Hi, >> >> This patch is still awaiting review. > > The patch looks good to me, however I think we need to have Marcus OK > on this one, I don't know if it has any impact on the closed JMC that > needs to be addressed. > > Cheers, > Mario > >> Thanks, >> Salman >> >> On Mon, Jan 14, 2019 at 4:01 PM Salman Siddiqui >> wrote: >> >>> Hi all, >>> >>> This is a patch to remove "-vm /usr/bin/java" from jmc.ini so that >>> the >>> default Java on the PATH is used on Linux systems. It is a follow- >>> up of >>> JMC-6314. >>> >>> Thanks, >>> Salman >>> >>> diff -r 0e7f3f9e078c >>> application/org.openjdk.jmc.rcp.product/jmc.product >>> --- a/application/org.openjdk.jmc.rcp.product/jmc.product Sun >>> Jan 13 >>> 17:50:38 2019 +0100 >>> +++ b/application/org.openjdk.jmc.rcp.product/jmc.product Mon >>> Jan 14 >>> 15:53:39 2019 -0500 >>> @@ -48,8 +48,8 @@ >>> >>> --launcher.appendVmargs >>> >>> - -vm /usr/bin/java >>> - >>> + >>> + >>> -ws cocoa -vm ../jdk/Contents/Home/bin/ >>> >>> -vm ./ >>> >>> > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From almacdon at redhat.com Wed Jan 23 17:05:57 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Wed, 23 Jan 2019 12:05:57 -0500 Subject: RFR: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs Message-ID: Hi, The following webrev [0] addresses issue JMC-6358 [1], in which builds using SpotBugs fail due to a number of flagged bugs and errors [2]. These errors appear as of a recent resolved bug [3] to use maven central's OpenJFX. We are currently using spotbugs-maven-plugin version 3.1.3, which doesn't have support for JDK 10/11 (introduced in version 3.1.3.1). I've set up a bunch of branches on Travis CI [4] to test the build using versions 3.1.3.1 through to 3.1.10 (current release), and the updated spotbugs plugin does not error. There have been a number of improvements [5] in the spotbugs plugin since 3.1.3, many of which correspond to JDK 11 support. The proposed one-line patch [0] simply updates the version of the spotbugs-maven-plugin to 3.1.10. Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6358/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6358 [2] https://api.travis-ci.org/v3/job/482998757/log.txt [3] https://bugs.openjdk.java.net/browse/JMC-6128 [4] https://imgur.com/p6z15eX [5] https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.3...spotbugs From marcus at hirt.se Wed Jan 23 20:00:08 2019 From: marcus at hirt.se (Marcus Hirt) Date: Wed, 23 Jan 2019 21:00:08 +0100 Subject: SV: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs In-Reply-To: References: Message-ID: <00f001d4b356$3d952190$b8bf64b0$@hirt.se> Hi Alex! Looks good! Feel free to submit to the mainline repo (only, for now). Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Alex Macdonald Skickat: den 23 januari 2019 18:06 Till: jmc-dev at openjdk.java.net ?mne: RFR: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs Hi, The following webrev [0] addresses issue JMC-6358 [1], in which builds using SpotBugs fail due to a number of flagged bugs and errors [2]. These errors appear as of a recent resolved bug [3] to use maven central's OpenJFX. We are currently using spotbugs-maven-plugin version 3.1.3, which doesn't have support for JDK 10/11 (introduced in version 3.1.3.1). I've set up a bunch of branches on Travis CI [4] to test the build using versions 3.1.3.1 through to 3.1.10 (current release), and the updated spotbugs plugin does not error. There have been a number of improvements [5] in the spotbugs plugin since 3.1.3, many of which correspond to JDK 11 support. The proposed one-line patch [0] simply updates the version of the spotbugs-maven-plugin to 3.1.10. Thoughts? Cheers, Alex [0] http://cr.openjdk.java.net/~aptmac/JMC-6358/webrev.00/ [1] https://bugs.openjdk.java.net/browse/JMC-6358 [2] https://api.travis-ci.org/v3/job/482998757/log.txt [3] https://bugs.openjdk.java.net/browse/JMC-6128 [4] https://imgur.com/p6z15eX [5] https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.3...spotbugs From guru.hb at oracle.com Wed Jan 23 20:19:34 2019 From: guru.hb at oracle.com (Guru) Date: Thu, 24 Jan 2019 01:49:34 +0530 Subject: Review request : JMC-6286 : Update L10N translation for JMC 7.1.0 In-Reply-To: References: <1374EAF5-E2CD-4058-972B-2E13F271B2A3@oracle.com> Message-ID: <294E49C0-3B95-4B4A-B435-233E95A4E135@oracle.com> Hi, Please review the updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.1/ Solution : Updated missing string localised strings. Note: As the current Development branch version is 7.1.0, JBS title is updated with 7.1.0. Once this is fixed (fix committed in http://hg.openjdk.java.net/jmc/jmc the same will be back ported to http://hg.openjdk.java.net/jmc/jmc7 which is planned for JMC 7.0.0 release) Thanks, Guru > On 21-Dec-2018, at 2:00 AM, Marcus Hirt wrote: > > Some translations seem to be missing. I pinged Guru, and he's > looking into this. > > /M > > ?On 2018-12-20, 19:14, "jmc-dev on behalf of Guru" wrote: > > Hi, > > Please review the fix for https://bugs.openjdk.java.net/browse/JMC-6286 > Webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.0/ > > Thanks, > Guru > > > > From marcus.hirt at oracle.com Wed Jan 23 21:08:56 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Wed, 23 Jan 2019 22:08:56 +0100 Subject: Review request : JMC-6286 : Update L10N translation for JMC 7.1.0 In-Reply-To: <8C006FEA-3C45-426A-98C3-FFEE25C2DE0F@oracle.com> References: <1374EAF5-E2CD-4058-972B-2E13F271B2A3@oracle.com> <8C006FEA-3C45-426A-98C3-FFEE25C2DE0F@oracle.com> Message-ID: I can?t speak to the contents of the strings, but it looks good! +1 /M From: Guru Date: Wednesday, 23 January 2019 at 21:19 To: Marcus Hirt Cc: Subject: Re: Review request : JMC-6286 : Update L10N translation for JMC 7.1.0 Hi, Please review the updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.1/ Solution : Updated missing string localised strings. Note: As the current Development branch version is 7.1.0, JBS title is updated with 7.1.0. Once this is fixed (fix committed in http://hg.openjdk.java.net/jmc/jmc the same will be back ported to http://hg.openjdk.java.net/jmc/jmc7 which is planned for JMC 7.0.0 release) Thanks, Guru On 21-Dec-2018, at 2:00 AM, Marcus Hirt wrote: Some translations seem to be missing. I pinged Guru, and he's looking into this. /M ?On 2018-12-20, 19:14, "jmc-dev on behalf of Guru" wrote: Hi, Please review the fix for https://bugs.openjdk.java.net/browse/JMC-6286 Webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.0/ Thanks, Guru From christoph.langer at sap.com Thu Jan 24 10:10:03 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Jan 2019 10:10:03 +0000 Subject: Building JMC with OpenJDK Message-ID: <1f81fcf9e38142e2b15dc4a9fba5646f@sap.com> Hi Marcus, I?m currently doing my first steps with JMC development. So, I was following your blog [1] to build it. Thanks for this great piece of information! In general, it worked for me. ?? However, there was one thing where I had to do some guessing. You mention, one needs Java 8. But, as of the build, you?d probably need to be more concrete and mention that one needs an Oracle JDK 8. Because, if you do the build with OpenJDK, you get errors: org.openjdk.jmc.javafx.osgi ........................ FAILURE It seems that there are some dependencies to javafx, that only the Oracle JDK can satisfy: [ERROR] import javafx.application.Platform; [ERROR] ^^^^^^ I also had to use the option -Dspotbugs.skip=true, but I guess this is because of [2]. I?m going to verify this. So, as for the JDK to use: Are there plans to get rid of the dependency to javafx from the JDK? E.g. use OpenJFX? Thanks and best regards, Christoph [1] http://hirt.se/blog/?p=947 [2] https://mail.openjdk.java.net/pipermail/jmc-dev/2019-January/000743.html From marcus.hirt at oracle.com Thu Jan 24 10:32:31 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 24 Jan 2019 11:32:31 +0100 Subject: Building JMC with OpenJDK In-Reply-To: References: Message-ID: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> Hi Christoph, Yes, as you read in the mailinglist spotbugs will be upgraded soon to solve the spotbugs problem, see https://bugs.openjdk.java.net/browse/JMC-6358. Alex Mcdonald has a fix ready: --- old/./pom.xml 2019-01-23 11:49:27.934826522 -0500 +++ new/./pom.xml 2019-01-23 11:49:27.874825738 -0500 @@ -82,7 +82,7 @@ 3.0.0-M1 3.0.2 1.0.0 - 3.1.3 + 3.1.10 ${user.name} scm:hg:http://hg.openjdk.java.net/jmc/jmc JMC should be buildable with OpenJDK 8, and yes, we?ve recently switched to OpenJFX and therefore now require JDK 10 or above for plug-ins requiring JavaFX. Are you pulling the source from the hg repo or the git mirror? If git, know that it lags the mercurial repo. Kind regards, Marcus From: "Langer, Christoph" Date: Thursday, 24 January 2019 at 11:10 To: Marcus Hirt , "jmc-dev at openjdk.java.net" Subject: Building JMC with OpenJDK Hi Marcus, ? I?m currently doing my first steps with JMC development. ? So, I was following your blog [1] to build it. Thanks for this great piece of information! In general, it worked for me. ?? ? However, there was one thing where I had to do some guessing. You mention, one needs Java 8. But, as of the build, you?d probably need to be more concrete and mention that one needs an Oracle JDK 8. Because, if you do the build with OpenJDK, you get errors: ? org.openjdk.jmc.javafx.osgi ........................ FAILURE ? It seems that there are some dependencies to javafx, that only the Oracle JDK can satisfy: ? [ERROR] import javafx.application.Platform; [ERROR] ^^^^^^ ? I also had to use the option -Dspotbugs.skip=true, but I guess this is because of [2]. I?m going to verify this. ? So, as for the JDK to use: Are there plans to get rid of the dependency to javafx from the JDK? E.g. use OpenJFX? ? Thanks and best regards, Christoph ? [1] http://hirt.se/blog/?p=947 [2] https://mail.openjdk.java.net/pipermail/jmc-dev/2019-January/000743.html From christoph.langer at sap.com Thu Jan 24 11:04:25 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Jan 2019 11:04:25 +0000 Subject: Building JMC with OpenJDK In-Reply-To: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> Message-ID: <0d253f133bad4d409d183314f92bcb51@sap.com> Hi Marcus, thanks for the quick reply. The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex Mcdonald works for me. > JMC should be buildable with OpenJDK 8, and yes, we?ve recently switched to > OpenJFX and therefore now require JDK 10 or above for plug-ins requiring JavaFX. This one I can't confirm. For me, it only works with the Oracle JDK 8. With my OpenJDK 8 the build shows these javafx dependency errors. > Are you pulling the source from the hg repo or the git mirror? If git, know > that it lags the mercurial repo. I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ So, should I be able to build with OpenJDK11 (as opposed to the documentation that explicitly says it should be JDK 8)? Thanks Christoph From christoph.langer at sap.com Thu Jan 24 11:06:27 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Jan 2019 11:06:27 +0000 Subject: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs In-Reply-To: <00f001d4b356$3d952190$b8bf64b0$@hirt.se> References: <00f001d4b356$3d952190$b8bf64b0$@hirt.se> Message-ID: <12a495f4c1e54d53af20e485b78ab8ef@sap.com> Hi Alex, I can confirm that this solves an issue that I encountered in my build. Thanks for fixing. Best regards Christoph > -----Original Message----- > From: jmc-dev On Behalf Of Marcus > Hirt > Sent: Mittwoch, 23. Januar 2019 21:00 > To: 'Alex Macdonald' ; jmc-dev at openjdk.java.net > Subject: SV: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs > > Hi Alex! > > Looks good! Feel free to submit to the mainline repo (only, for now). > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Alex Macdonald > Skickat: den 23 januari 2019 18:06 > Till: jmc-dev at openjdk.java.net > ?mne: RFR: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs > > Hi, > > The following webrev [0] addresses issue JMC-6358 [1], in which builds using > SpotBugs fail due to a number of flagged bugs and errors [2]. > > These errors appear as of a recent resolved bug [3] to use maven central's > OpenJFX. We are currently using spotbugs-maven-plugin version 3.1.3, which > doesn't have support for JDK 10/11 (introduced in version 3.1.3.1). I've set up > a bunch of branches on Travis CI [4] to test the build using versions 3.1.3.1 > through to 3.1.10 (current release), and the updated spotbugs plugin does > not error. There have been a number of improvements [5] in the spotbugs > plugin since 3.1.3, many of which correspond to JDK 11 support. The > proposed one-line patch [0] simply updates the version of the spotbugs- > maven-plugin to 3.1.10. > > Thoughts? > > Cheers, > > Alex > > [0] http://cr.openjdk.java.net/~aptmac/JMC-6358/webrev.00/ > [1] https://bugs.openjdk.java.net/browse/JMC-6358 > [2] https://api.travis-ci.org/v3/job/482998757/log.txt > [3] https://bugs.openjdk.java.net/browse/JMC-6128 > [4] https://imgur.com/p6z15eX > [5] > https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs- > maven-plugin-3.1.3...spotbugs From marcus.hirt at oracle.com Thu Jan 24 11:11:42 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 24 Jan 2019 12:11:42 +0100 Subject: Building JMC with OpenJDK In-Reply-To: References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> Message-ID: <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> Hi Christoph, No, OpenJDK 11 will not work yet. We will have to look into OpenJDK 8. Kind regards, Marcus ?On 2019-01-24, 12:04, "Langer, Christoph" wrote: Hi Marcus, thanks for the quick reply. The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex Mcdonald works for me. > JMC should be buildable with OpenJDK 8, and yes, we?ve recently switched to > OpenJFX and therefore now require JDK 10 or above for plug-ins requiring JavaFX. This one I can't confirm. For me, it only works with the Oracle JDK 8. With my OpenJDK 8 the build shows these javafx dependency errors. > Are you pulling the source from the hg repo or the git mirror? If git, know > that it lags the mercurial repo. I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ So, should I be able to build with OpenJDK11 (as opposed to the documentation that explicitly says it should be JDK 8)? Thanks Christoph From christoph.langer at sap.com Thu Jan 24 11:14:04 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Jan 2019 11:14:04 +0000 Subject: Building JMC with OpenJDK In-Reply-To: <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> Message-ID: <855e58371b344c78b0febc216223e3dd@sap.com> Ok, shall I open a ticket for this item then? Can you/would you like to reproduce it on your premises before? > -----Original Message----- > From: Marcus Hirt > Sent: Donnerstag, 24. Januar 2019 12:12 > To: Langer, Christoph ; jmc- > dev at openjdk.java.net > Subject: Re: Building JMC with OpenJDK > > Hi Christoph, > > No, OpenJDK 11 will not work yet. We will have to look into OpenJDK 8. > > Kind regards, > Marcus > > ?On 2019-01-24, 12:04, "Langer, Christoph" > wrote: > > Hi Marcus, > > thanks for the quick reply. > > The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex > Mcdonald works for me. > > > JMC should be buildable with OpenJDK 8, and yes, we?ve recently > switched to > > OpenJFX and therefore now require JDK 10 or above for plug-ins > requiring JavaFX. > > This one I can't confirm. For me, it only works with the Oracle JDK 8. With > my OpenJDK 8 the build shows these javafx dependency errors. > > > Are you pulling the source from the hg repo or the git mirror? If git, know > > that it lags the mercurial repo. > > I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ > > So, should I be able to build with OpenJDK11 (as opposed to the > documentation that explicitly says it should be JDK 8)? > > Thanks > Christoph > > > > From marcus.hirt at oracle.com Thu Jan 24 11:19:14 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 24 Jan 2019 12:19:14 +0100 Subject: Building JMC with OpenJDK In-Reply-To: <6C4A482A-266B-4FD7-8027-89B4002DE761@sap.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> <6C4A482A-266B-4FD7-8027-89B4002DE761@sap.com> Message-ID: <3C9B5A78-229C-4E9B-9D3F-705F7524F5CB@oracle.com> Mario, can you or someone over at Red Hat reproduce this? I assume you're not using an Oracle JDK to build JMC. ;) Kind regards, Marcus ?On 2019-01-24, 12:14, "Langer, Christoph" wrote: Ok, shall I open a ticket for this item then? Can you/would you like to reproduce it on your premises before? > -----Original Message----- > From: Marcus Hirt > Sent: Donnerstag, 24. Januar 2019 12:12 > To: Langer, Christoph ; jmc- > dev at openjdk.java.net > Subject: Re: Building JMC with OpenJDK > > Hi Christoph, > > No, OpenJDK 11 will not work yet. We will have to look into OpenJDK 8. > > Kind regards, > Marcus > > ?On 2019-01-24, 12:04, "Langer, Christoph" > wrote: > > Hi Marcus, > > thanks for the quick reply. > > The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex > Mcdonald works for me. > > > JMC should be buildable with OpenJDK 8, and yes, we?ve recently > switched to > > OpenJFX and therefore now require JDK 10 or above for plug-ins > requiring JavaFX. > > This one I can't confirm. For me, it only works with the Oracle JDK 8. With > my OpenJDK 8 the build shows these javafx dependency errors. > > > Are you pulling the source from the hg repo or the git mirror? If git, know > > that it lags the mercurial repo. > > I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ > > So, should I be able to build with OpenJDK11 (as opposed to the > documentation that explicitly says it should be JDK 8)? > > Thanks > Christoph > > > > From guru.hb at oracle.com Thu Jan 24 14:45:18 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 24 Jan 2019 14:45:18 +0000 Subject: hg: jmc/jmc: JMC-6286: Update L10N translation for JMC 7.1.0 Message-ID: <201901241445.x0OEjIaO022600@aojmv0008.oracle.com> Changeset: 287a2038ce09 Author: ghb Date: 2019-01-24 20:14 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/287a2038ce09 JMC-6286: Update L10N translation for JMC 7.1.0 Reviewed-by: hirt + application/l10n/org.openjdk.jmc.docs.ja/plugin_ja.properties + application/l10n/org.openjdk.jmc.docs.zh_CN/plugin_zh_CN.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.ui.ja/src/main/resources/org/openjdk/jmc/ui/misc/messages_ja.properties ! application/l10n/org.openjdk.jmc.ui.zh_CN/src/main/resources/org/openjdk/jmc/ui/misc/messages_zh_CN.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder.rules/src/main/resources/org/openjdk/jmc/flightrecorder/rules/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder.rules/src/main/resources/org/openjdk/jmc/flightrecorder/rules/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages_zh_CN.properties From jmatsuok at redhat.com Thu Jan 24 15:33:23 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Thu, 24 Jan 2019 15:33:23 +0000 Subject: hg: jmc/jmc: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs Message-ID: <201901241533.x0OFXNGX012567@aojmv0008.oracle.com> Changeset: a88d5b9277ba Author: aptmac Date: 2019-01-23 16:23 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/a88d5b9277ba JMC-6358: Build fails due to bugs and errors flagged by SpotBugs Reviewed-by: hirt ! pom.xml From jkang at redhat.com Thu Jan 24 16:06:16 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 24 Jan 2019 11:06:16 -0500 Subject: Building JMC with OpenJDK In-Reply-To: <3C9B5A78-229C-4E9B-9D3F-705F7524F5CB@oracle.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> <6C4A482A-266B-4FD7-8027-89B4002DE761@sap.com> <3C9B5A78-229C-4E9B-9D3F-705F7524F5CB@oracle.com> Message-ID: Hi Marcus, Christoph, I can confirm that on an F28 system with OpenJDK 8 and without OpenJFX the latest revision a88d5b9277ba fails to build due to missing javafx packages, even though they are contained in the p2 site (releng/third-party/target/plugins) and have a reference in the default platform definition (photon). I believe this is because the pom.xml and/or MANIFEST.MF for the module org.openjdk.jmc.javafx.osgi have not been updated to reference these. E.g. the pom still has: sun.jdk jfxswt 1.8.0 system ${java.home}/lib/jfxswt.jar which would be a reference that doesn't exist in OpenJDK 8 without OpenJFX linked. The MANIFEST.MF also does not specify any import-package or require-bundle for the openjfx jars in the p2 site. I think it would be appropriate to create a bug for this. I would be interested in providing a fix so as to contribute a patch to JMC :) In the mean time, if you would like to build with OpenJDK 8, you can acquire OpenJFX jars and link them into the JDK. If you are on Fedora 28+ with OpenJDK 8 (java-1.8.0-openjdk java-1.8.0-openjdk-devel) you can install the packages: openjfx openjfx-devel java-1.8.0-openjdk-openjfx java-1.8.0-openjdk-openjfx-devel to acquire the OpenJFX jars and have them linked into the system OpenJDK 8. Regards, On Thu, Jan 24, 2019 at 6:19 AM Marcus Hirt wrote: > > Mario, can you or someone over at Red Hat reproduce this? I assume > you're not using an Oracle JDK to build JMC. ;) > > Kind regards, > Marcus > > ?On 2019-01-24, 12:14, "Langer, Christoph" wrote: > > Ok, shall I open a ticket for this item then? Can you/would you like to reproduce it on your premises before? > > > -----Original Message----- > > From: Marcus Hirt > > Sent: Donnerstag, 24. Januar 2019 12:12 > > To: Langer, Christoph ; jmc- > > dev at openjdk.java.net > > Subject: Re: Building JMC with OpenJDK > > > > Hi Christoph, > > > > No, OpenJDK 11 will not work yet. We will have to look into OpenJDK 8. > > > > Kind regards, > > Marcus > > > > ?On 2019-01-24, 12:04, "Langer, Christoph" > > wrote: > > > > Hi Marcus, > > > > thanks for the quick reply. > > > > The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex > > Mcdonald works for me. > > > > > JMC should be buildable with OpenJDK 8, and yes, we?ve recently > > switched to > > > OpenJFX and therefore now require JDK 10 or above for plug-ins > > requiring JavaFX. > > > > This one I can't confirm. For me, it only works with the Oracle JDK 8. With > > my OpenJDK 8 the build shows these javafx dependency errors. > > > > > Are you pulling the source from the hg repo or the git mirror? If git, know > > > that it lags the mercurial repo. > > > > I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ > > > > So, should I be able to build with OpenJDK11 (as opposed to the > > documentation that explicitly says it should be JDK 8)? > > > > Thanks > > Christoph > > > > > > > > > > > > > From marcus.hirt at oracle.com Thu Jan 24 16:55:46 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 24 Jan 2019 17:55:46 +0100 Subject: Building JMC with OpenJDK In-Reply-To: <323F32FD-CB86-439E-A26B-974A93983EE3@redhat.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> <6C4A482A-266B-4FD7-8027-89B4002DE761@sap.com> <3C9B5A78-229C-4E9B-9D3F-705F7524F5CB@oracle.com> <323F32FD-CB86-439E-A26B-974A93983EE3@redhat.com> Message-ID: <8D09A954-4CB7-4621-9767-C3CC58C63974@oracle.com> Excellent Jie! Please work with Mario to get the bug created, and get this in! Kind regards, Marcus ?On 2019-01-24, 17:06, "Jie Kang" wrote: Hi Marcus, Christoph, I can confirm that on an F28 system with OpenJDK 8 and without OpenJFX the latest revision a88d5b9277ba fails to build due to missing javafx packages, even though they are contained in the p2 site (releng/third-party/target/plugins) and have a reference in the default platform definition (photon). I believe this is because the pom.xml and/or MANIFEST.MF for the module org.openjdk.jmc.javafx.osgi have not been updated to reference these. E.g. the pom still has: sun.jdk jfxswt 1.8.0 system ${java.home}/lib/jfxswt.jar which would be a reference that doesn't exist in OpenJDK 8 without OpenJFX linked. The MANIFEST.MF also does not specify any import-package or require-bundle for the openjfx jars in the p2 site. I think it would be appropriate to create a bug for this. I would be interested in providing a fix so as to contribute a patch to JMC :) In the mean time, if you would like to build with OpenJDK 8, you can acquire OpenJFX jars and link them into the JDK. If you are on Fedora 28+ with OpenJDK 8 (java-1.8.0-openjdk java-1.8.0-openjdk-devel) you can install the packages: openjfx openjfx-devel java-1.8.0-openjdk-openjfx java-1.8.0-openjdk-openjfx-devel to acquire the OpenJFX jars and have them linked into the system OpenJDK 8. Regards, On Thu, Jan 24, 2019 at 6:19 AM Marcus Hirt wrote: > > Mario, can you or someone over at Red Hat reproduce this? I assume > you're not using an Oracle JDK to build JMC. ;) > > Kind regards, > Marcus > > ?On 2019-01-24, 12:14, "Langer, Christoph" wrote: > > Ok, shall I open a ticket for this item then? Can you/would you like to reproduce it on your premises before? > > > -----Original Message----- > > From: Marcus Hirt > > Sent: Donnerstag, 24. Januar 2019 12:12 > > To: Langer, Christoph ; jmc- > > dev at openjdk.java.net > > Subject: Re: Building JMC with OpenJDK > > > > Hi Christoph, > > > > No, OpenJDK 11 will not work yet. We will have to look into OpenJDK 8. > > > > Kind regards, > > Marcus > > > > ?On 2019-01-24, 12:04, "Langer, Christoph" > > wrote: > > > > Hi Marcus, > > > > thanks for the quick reply. > > > > The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by Alex > > Mcdonald works for me. > > > > > JMC should be buildable with OpenJDK 8, and yes, we?ve recently > > switched to > > > OpenJFX and therefore now require JDK 10 or above for plug-ins > > requiring JavaFX. > > > > This one I can't confirm. For me, it only works with the Oracle JDK 8. With > > my OpenJDK 8 the build shows these javafx dependency errors. > > > > > Are you pulling the source from the hg repo or the git mirror? If git, know > > > that it lags the mercurial repo. > > > > I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ > > > > So, should I be able to build with OpenJDK11 (as opposed to the > > documentation that explicitly says it should be JDK 8)? > > > > Thanks > > Christoph > > > > > > > > > > > > > From guru.hb at oracle.com Thu Jan 24 18:21:46 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 24 Jan 2019 18:21:46 +0000 Subject: hg: jmc/jmc7: JMC-6286: Update L10N translation for JMC 7.1.0 Message-ID: <201901241821.x0OILk3a020670@aojmv0008.oracle.com> Changeset: 72a1ecea8652 Author: ghb Date: 2019-01-24 23:51 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/72a1ecea8652 JMC-6286: Update L10N translation for JMC 7.1.0 Reviewed-by: hirt + application/l10n/org.openjdk.jmc.docs.ja/plugin_ja.properties + application/l10n/org.openjdk.jmc.docs.zh_CN/plugin_zh_CN.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.ui.ja/src/main/resources/org/openjdk/jmc/ui/misc/messages_ja.properties ! application/l10n/org.openjdk.jmc.ui.zh_CN/src/main/resources/org/openjdk/jmc/ui/misc/messages_zh_CN.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder.rules/src/main/resources/org/openjdk/jmc/flightrecorder/rules/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder.rules/src/main/resources/org/openjdk/jmc/flightrecorder/rules/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages_zh_CN.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages_zh_CN.properties From christoph.langer at sap.com Thu Jan 24 21:39:57 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Jan 2019 21:39:57 +0000 Subject: Building JMC with OpenJDK In-Reply-To: <8D09A954-4CB7-4621-9767-C3CC58C63974@oracle.com> References: <4DB526CA-6E76-4CFF-B8E5-E209AB1A4369@oracle.com> <29DC1993-F328-4CEF-BBFE-9352B59ABA18@oracle.com> <6C4A482A-266B-4FD7-8027-89B4002DE761@sap.com> <3C9B5A78-229C-4E9B-9D3F-705F7524F5CB@oracle.com> <323F32FD-CB86-439E-A26B-974A93983EE3@redhat.com> <8D09A954-4CB7-4621-9767-C3CC58C63974@oracle.com> Message-ID: Hi Jie, thanks for your analysis. I've filed bug https://bugs.openjdk.java.net/browse/JMC-6370 for this and assigned it to Mario. Best regards Christoph > -----Original Message----- > From: jmc-dev On Behalf Of Marcus > Hirt > Sent: Donnerstag, 24. Januar 2019 17:56 > To: Jie Kang > Cc: jmc-dev at openjdk.java.net > Subject: Re: Building JMC with OpenJDK > > Excellent Jie! > > Please work with Mario to get the bug created, and get this in! > > Kind regards, > Marcus > > ?On 2019-01-24, 17:06, "Jie Kang" wrote: > > Hi Marcus, Christoph, > > I can confirm that on an F28 system with OpenJDK 8 and without OpenJFX > the latest revision a88d5b9277ba fails to build due to missing javafx > packages, even though they are contained in the p2 site > (releng/third-party/target/plugins) and have a reference in the > default platform definition (photon). > > I believe this is because the pom.xml and/or MANIFEST.MF for the > module org.openjdk.jmc.javafx.osgi have not been updated to reference > these. E.g. the pom still has: > > > > sun.jdk > jfxswt > 1.8.0 > system > ${java.home}/lib/jfxswt.jar > > > > which would be a reference that doesn't exist in OpenJDK 8 without > OpenJFX linked. The MANIFEST.MF also does not specify any > import-package or require-bundle for the openjfx jars in the p2 site. > > I think it would be appropriate to create a bug for this. I would be > interested in providing a fix so as to contribute a patch to JMC :) > > > In the mean time, if you would like to build with OpenJDK 8, you can > acquire OpenJFX jars and link them into the JDK. If you are on Fedora > 28+ with OpenJDK 8 (java-1.8.0-openjdk java-1.8.0-openjdk-devel) you > can install the packages: > openjfx openjfx-devel java-1.8.0-openjdk-openjfx > java-1.8.0-openjdk-openjfx-devel > > to acquire the OpenJFX jars and have them linked into the system > OpenJDK 8. > > > Regards, > > > > On Thu, Jan 24, 2019 at 6:19 AM Marcus Hirt > wrote: > > > > Mario, can you or someone over at Red Hat reproduce this? I assume > > you're not using an Oracle JDK to build JMC. ;) > > > > Kind regards, > > Marcus > > > > ?On 2019-01-24, 12:14, "Langer, Christoph" > wrote: > > > > Ok, shall I open a ticket for this item then? Can you/would you like to > reproduce it on your premises before? > > > > > -----Original Message----- > > > From: Marcus Hirt > > > Sent: Donnerstag, 24. Januar 2019 12:12 > > > To: Langer, Christoph ; jmc- > > > dev at openjdk.java.net > > > Subject: Re: Building JMC with OpenJDK > > > > > > Hi Christoph, > > > > > > No, OpenJDK 11 will not work yet. We will have to look into OpenJDK > 8. > > > > > > Kind regards, > > > Marcus > > > > > > ?On 2019-01-24, 12:04, "Langer, Christoph" > > > > wrote: > > > > > > Hi Marcus, > > > > > > thanks for the quick reply. > > > > > > The fix for https://bugs.openjdk.java.net/browse/JMC-6358 by > Alex > > > Mcdonald works for me. > > > > > > > JMC should be buildable with OpenJDK 8, and yes, we?ve recently > > > switched to > > > > OpenJFX and therefore now require JDK 10 or above for plug-ins > > > requiring JavaFX. > > > > > > This one I can't confirm. For me, it only works with the Oracle JDK 8. > With > > > my OpenJDK 8 the build shows these javafx dependency errors. > > > > > > > Are you pulling the source from the hg repo or the git mirror? If > git, know > > > > that it lags the mercurial repo. > > > > > > I'm using this mercurial repo: http://hg.openjdk.java.net/jmc/jmc/ > > > > > > So, should I be able to build with OpenJDK11 (as opposed to the > > > documentation that explicitly says it should be JDK 8)? > > > > > > Thanks > > > Christoph > > > > > > > > > > > > > > > > > > > > > > > > > From jkang at redhat.com Fri Jan 25 16:27:31 2019 From: jkang at redhat.com (Jie Kang) Date: Fri, 25 Jan 2019 11:27:31 -0500 Subject: RFR: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi Message-ID: Hi, The following patch allows JMC to build with OpenJDK 8. * removes org.openjdk.jmc.javafx.osgi plugin from base feature org.openjdk.jmc.feature.flightrecorder where it is unused * removes org.openjdk.jmc.javafx.osgi dependency from org.openjdk.jmc.flightrecorder.ui where it is unused * updates MANIFEST.MF of org.openjdk.jmc.javafx.osgi to include the correct imports for javafx packages * removes unnecessary extra classpath elements as OpenJFX jars now come from the p2 site and the MANIFEST.MF has the correct imports Note: the JOverflow plugin requires OpenJFX which has JavaSE-10 I have tested this on Fedora 28 building on OpenJDK 8 and running the result using OpenJDK 8 and 11. The JOverflow plugin continues to work on OpenJDK 11. On OpenJDK 8, the plugin fails to load but the rest of JMC still functions. Let me know how it looks! diff --git a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml @@ -94,13 +94,6 @@ unpack="false"/> - - org.openjdk.jmc.javafx.osgi eclipse-plugin - - - - org.eclipse.tycho - tycho-compiler-plugin - ${tycho.version} - - - **/Empty.java - - - - sun.jdk - jfxswt - 1.8.0 - system - ${java.home}/lib/jfxswt.jar - - - - - - Regards, From jmatsuok at redhat.com Fri Jan 25 16:46:21 2019 From: jmatsuok at redhat.com (Joshua Matsuoka) Date: Fri, 25 Jan 2019 11:46:21 -0500 Subject: RFR: JMC-6324: Values in Method Profiling rule result text not correct when filtering Message-ID: Hi, The following patch adds some extra clarity to the Method Profiling rule. Currently the percentage reported by the Method Profiling rule is the percentage of all possible samples in a given period, rather than the actual number of samples. This can lead to some rather misleading results when for example a method takes up 99% of the actual samples in a window, but only constitutes 25% of the theoretical maximum number of samples. This patch keeps track of both the relation to the maximum, as well as the actual percentage of samples and reports both with the rule results (e.g. Method x had y% of possible samples and z% of actual samples) http://cr.openjdk.java.net/~jmatsuoka/JMC-6324/webrev.00/ Thoughts? Cheers, - Josh From christoph.langer at sap.com Mon Jan 28 07:52:08 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 28 Jan 2019 07:52:08 +0000 Subject: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi In-Reply-To: References: Message-ID: Hi Jie, thanks for posting the fix. I can confirm that the build using OpenJDK works for me with these changes. Other people need to assess whether the changes are functionally correct, though ?? Best regards Christoph > -----Original Message----- > From: jmc-dev On Behalf Of Jie Kang > Sent: Freitag, 25. Januar 2019 17:28 > To: jmc-dev at openjdk.java.net > Subject: RFR: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx > packages in org.openjdk.jmc.javafx.osgi > > Hi, > > The following patch allows JMC to build with OpenJDK 8. > > * removes org.openjdk.jmc.javafx.osgi plugin from base feature > org.openjdk.jmc.feature.flightrecorder where it is unused > * removes org.openjdk.jmc.javafx.osgi dependency from > org.openjdk.jmc.flightrecorder.ui where it is unused > * updates MANIFEST.MF of org.openjdk.jmc.javafx.osgi to include the > correct imports for javafx packages > * removes unnecessary extra classpath elements as OpenJFX jars now > come from the p2 site and the MANIFEST.MF has the correct imports > > Note: the JOverflow plugin requires OpenJFX which has > JavaSE-10 RequiredExecutionEnvironment> > > I have tested this on Fedora 28 building on OpenJDK 8 and running the > result using OpenJDK 8 and 11. The JOverflow plugin continues to work > on OpenJDK 11. On OpenJDK 8, the plugin fails to load but the rest of > JMC still functions. > > Let me know how it looks! > > diff --git a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > @@ -94,13 +94,6 @@ > unpack="false"/> > > - id="org.openjdk.jmc.javafx.osgi" > - download-size="0" > - install-size="0" > - version="0.0.0" > - unpack="false"/> > - > - id="org.openjdk.jmc.flightrecorder.rules.extensionprovider" > download-size="0" > install-size="0" > diff --git a/application/org.openjdk.jmc.flightrecorder.ui/META- > INF/MANIFEST.MF > b/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF > --- a/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF > +++ b/application/org.openjdk.jmc.flightrecorder.ui/META- > INF/MANIFEST.MF > @@ -9,7 +9,6 @@ > Require-Bundle: org.openjdk.jmc.rjmx, > org.openjdk.jmc.flightrecorder;visibility:=reexport, > org.openjdk.jmc.ui;visibility:=reexport, > - org.openjdk.jmc.javafx.osgi, > org.openjdk.jmc.flightrecorder.rules, > org.openjdk.jmc.flightrecorder.rules.jdk, > org.openjdk.jmc.flightrecorder.configuration, > diff --git a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > --- a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > +++ b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > @@ -7,6 +7,9 @@ > Bundle-RequiredExecutionEnvironment: JavaSE-1.8 > Bundle-ClassPath: . > Eclipse-BuddyPolicy: app > +Import-Package: javafx.application, javafx.embed.swt, > + javafx.fxml, javafx.scene, javafx.scene.control, > + javafx.scene.image > Export-Package: org.openjdk.jmc.javafx.osgi > Require-Bundle: org.eclipse.swt;resolution:=optional, > org.eclipse.jface > diff --git a/application/org.openjdk.jmc.javafx.osgi/pom.xml > b/application/org.openjdk.jmc.javafx.osgi/pom.xml > --- a/application/org.openjdk.jmc.javafx.osgi/pom.xml > +++ b/application/org.openjdk.jmc.javafx.osgi/pom.xml > @@ -40,27 +40,4 @@ > > org.openjdk.jmc.javafx.osgi > eclipse-plugin > - > - > - > - org.eclipse.tycho > - tycho-compiler-plugin > - ${tycho.version} > - > - > - **/Empty.java > - > - > - > - sun.jdk > - jfxswt > - 1.8.0 > - system > - ${java.home}/lib/jfxswt.jar > - > - > - > - > - > - > > > > Regards, From christoph.langer at sap.com Mon Jan 28 10:56:47 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 28 Jan 2019 10:56:47 +0000 Subject: Questions/comments about setting up JMC development workspace in Eclipse Message-ID: <39f2388782b1450f9904ed999d5f1905@sap.com> Hi Marcus, After my build works, my next task is setting up the development infrastructure ?? So, of course, I followed your blog [1] about that closely. I eventually managed to set up my Eclipse workspace that it now shows no errors and JMC launches. But I have some feedback: - JDKs: I think the part with JDK 10 is a bit outdated, right? Now it's all about JDK11 (and, JDK 8, of course). The cited bug JMC-5895 [2] has already been fixed quite some time ago. Is that correct? - Setting up user library JMC_JDK: I've set up the library as described in the blog. However, it seemed to me that the maven import has deleted reference to JMC_JDK from the projects. (It also made quite a few modifications to .classpath files which I'm unhappy with as it spills hg status by the way). So I had to add reference back in projects org.openjdk.jmc.browser.attach and org.openjdk.jmc.console.jconsole. Also, now after the javafx dependencies were set up correctly as external dependency and not from the JDK, I think jfxswt.jar and jfxrt.jar can be removed. The reference to JMC_JDK can be dropped from the .classpath files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. - Importing the projects: If I import the projects from the main jmc directory, it does not show the projects inside subfolder core, as the main pom.xml does not define "core" as a module. So I had to manually import the core subdirectory. Best regards Christoph [1] http://hirt.se/blog/?p=989 [2] https://bugs.openjdk.java.net/browse/JMC-5895 From marcus.hirt at oracle.com Mon Jan 28 13:13:57 2019 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 28 Jan 2019 14:13:57 +0100 Subject: Questions/comments about setting up JMC development workspace in Eclipse In-Reply-To: <99D4E614-E640-4E7F-9496-E556C3E81E52@sap.com> References: <99D4E614-E640-4E7F-9496-E556C3E81E52@sap.com> Message-ID: <24E260A3-9DA1-4B32-A6C7-D520A5DA05E5@oracle.com> Hi Christoph, 1. Yep, JDK 8 and JDK 11. I updated the blog - thanks! 2. Yes, now it should be okay to remove the jfx and update the classpath files as described. Will update the blog once the fixes are in. Let me know if you want to contribute these! 3. Yep, that is correct, as we decided we wanted to be able to build core without Tycho and separately (also be able to push the core artifacts to Maven Central at some point in the future). I updated the blog (except for the images) - thanks! Kind regards, Marcus ?On 2019-01-28, 11:56, "Langer, Christoph" wrote: Hi Marcus, After my build works, my next task is setting up the development infrastructure ?? So, of course, I followed your blog [1] about that closely. I eventually managed to set up my Eclipse workspace that it now shows no errors and JMC launches. But I have some feedback: - JDKs: I think the part with JDK 10 is a bit outdated, right? Now it's all about JDK11 (and, JDK 8, of course). The cited bug JMC-5895 [2] has already been fixed quite some time ago. Is that correct? - Setting up user library JMC_JDK: I've set up the library as described in the blog. However, it seemed to me that the maven import has deleted reference to JMC_JDK from the projects. (It also made quite a few modifications to .classpath files which I'm unhappy with as it spills hg status by the way). So I had to add reference back in projects org.openjdk.jmc.browser.attach and org.openjdk.jmc.console.jconsole. Also, now after the javafx dependencies were set up correctly as external dependency and not from the JDK, I think jfxswt.jar and jfxrt.jar can be removed. The reference to JMC_JDK can be dropped from the .classpath files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. - Importing the projects: If I import the projects from the main jmc directory, it does not show the projects inside subfolder core, as the main pom.xml does not define "core" as a module. So I had to manually import the core subdirectory. Best regards Christoph [1] http://hirt.se/blog/?p=989 [2] https://bugs.openjdk.java.net/browse/JMC-5895 From christoph.langer at sap.com Mon Jan 28 13:29:52 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 28 Jan 2019 13:29:52 +0000 Subject: Questions/comments about setting up JMC development workspace in Eclipse In-Reply-To: <24E260A3-9DA1-4B32-A6C7-D520A5DA05E5@oracle.com> References: <99D4E614-E640-4E7F-9496-E556C3E81E52@sap.com> <24E260A3-9DA1-4B32-A6C7-D520A5DA05E5@oracle.com> Message-ID: <4eaafdd8e5a948678762a6dfc4b0fea1@sap.com> Hi Marcus, sure, I can contribute the changes to remove the references to JMC_JDK from the .classpath files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. Or maybe those could also be a part of Jie's fix for JMC-6370? Do you know why maven changed so many of the .classpath files that are checked in in the JMC repository when I import the projects into Eclipse and whether this can be avoided? Worst is the removal of the JMC_JDK dependency... Best regards Christoph > -----Original Message----- > From: Marcus Hirt > Sent: Montag, 28. Januar 2019 14:14 > To: Langer, Christoph > Cc: jmc-dev at openjdk.java.net > Subject: Re: Questions/comments about setting up JMC development > workspace in Eclipse > > Hi Christoph, > > 1. Yep, JDK 8 and JDK 11. I updated the blog - thanks! > 2. Yes, now it should be okay to remove the jfx and update the classpath files > as described. Will update the blog once the fixes are in. Let me know if you > want to contribute these! > 3. Yep, that is correct, as we decided we wanted to be able to build core > without Tycho and separately (also be able to push the core artifacts to > Maven Central at some point in the future). I updated the blog (except for > the images) - thanks! > > Kind regards, > Marcus > > ?On 2019-01-28, 11:56, "Langer, Christoph" > wrote: > > Hi Marcus, > > After my build works, my next task is setting up the development > infrastructure ?? > > So, of course, I followed your blog [1] about that closely. I eventually > managed to set up my Eclipse workspace that it now shows no errors and > JMC launches. But I have some feedback: > > - JDKs: I think the part with JDK 10 is a bit outdated, right? Now it's all about > JDK11 (and, JDK 8, of course). The cited bug JMC-5895 [2] has already been > fixed quite some time ago. Is that correct? > - Setting up user library JMC_JDK: I've set up the library as described in the > blog. However, it seemed to me that the maven import has deleted > reference to JMC_JDK from the projects. (It also made quite a few > modifications to .classpath files which I'm unhappy with as it spills hg status > by the way). So I had to add reference back in projects > org.openjdk.jmc.browser.attach and org.openjdk.jmc.console.jconsole. > Also, now after the javafx dependencies were set up correctly as external > dependency and not from the JDK, I think jfxswt.jar and jfxrt.jar can be > removed. The reference to JMC_JDK can be dropped from the .classpath > files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. > - Importing the projects: If I import the projects from the main jmc > directory, it does not show the projects inside subfolder core, as the main > pom.xml does not define "core" as a module. So I had to manually import the > core subdirectory. > > Best regards > Christoph > > [1] http://hirt.se/blog/?p=989 > [2] https://bugs.openjdk.java.net/browse/JMC-5895 > > > From marcus at hirt.se Mon Jan 28 13:40:27 2019 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 28 Jan 2019 14:40:27 +0100 Subject: SV: JMC-6324: Values in Method Profiling rule result text not correct when filtering In-Reply-To: References: Message-ID: <019c01d4b70f$077445c0$165cd140$@hirt.se> Hi Josh, Looks good! Perhaps the percentage shown for the most interesting candidate should be updated to show the percentage of the actual samples taken? This is since the normalization bars we show as backdrop in some columns is in regards to actual events. I think we only need to drop the relation to the theoretical maximum amount of samples in the user's head once, and only to motivate a lower score than expected. For example: The following methods are the most interesting candidates for code optimization: ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) (24,1 %) 2018-11-09 14:40:39 ? 14:41:09 -> The following methods are the most interesting candidates for code optimization: ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) (98,2 %) 2018-11-09 14:40:39 ? 14:41:09 or possible more verbosely: The following methods are the most interesting candidates for code optimization: ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) (98,2 % of the samples) 2018-11-09 14:40:39 ? 14:41:09 Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Joshua Matsuoka Skickat: den 25 januari 2019 17:46 Till: jmc-dev at openjdk.java.net ?mne: RFR: JMC-6324: Values in Method Profiling rule result text not correct when filtering Hi, The following patch adds some extra clarity to the Method Profiling rule. Currently the percentage reported by the Method Profiling rule is the percentage of all possible samples in a given period, rather than the actual number of samples. This can lead to some rather misleading results when for example a method takes up 99% of the actual samples in a window, but only constitutes 25% of the theoretical maximum number of samples. This patch keeps track of both the relation to the maximum, as well as the actual percentage of samples and reports both with the rule results (e.g. Method x had y% of possible samples and z% of actual samples) http://cr.openjdk.java.net/~jmatsuoka/JMC-6324/webrev.00/ Thoughts? Cheers, - Josh From guru.hb at oracle.com Mon Jan 28 13:48:08 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 28 Jan 2019 19:18:08 +0530 Subject: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi In-Reply-To: References: Message-ID: <8A115C25-5303-43C1-8475-74532F7BC9AB@oracle.com> Hi Jie, OpenJFX is required for Update sites. Let me check the dependency and test this patch and update you with comments. Thanks, Guru > On 28-Jan-2019, at 1:22 PM, Langer, Christoph wrote: > > Hi Jie, > > thanks for posting the fix. I can confirm that the build using OpenJDK works for me with these changes. Other people need to assess whether the changes are functionally correct, though ?? > > Best regards > Christoph > >> -----Original Message----- >> From: jmc-dev On Behalf Of Jie Kang >> Sent: Freitag, 25. Januar 2019 17:28 >> To: jmc-dev at openjdk.java.net >> Subject: RFR: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx >> packages in org.openjdk.jmc.javafx.osgi >> >> Hi, >> >> The following patch allows JMC to build with OpenJDK 8. >> >> * removes org.openjdk.jmc.javafx.osgi plugin from base feature >> org.openjdk.jmc.feature.flightrecorder where it is unused >> * removes org.openjdk.jmc.javafx.osgi dependency from >> org.openjdk.jmc.flightrecorder.ui where it is unused >> * updates MANIFEST.MF of org.openjdk.jmc.javafx.osgi to include the >> correct imports for javafx packages >> * removes unnecessary extra classpath elements as OpenJFX jars now >> come from the p2 site and the MANIFEST.MF has the correct imports >> >> Note: the JOverflow plugin requires OpenJFX which has >> JavaSE-10> RequiredExecutionEnvironment> >> >> I have tested this on Fedora 28 building on OpenJDK 8 and running the >> result using OpenJDK 8 and 11. The JOverflow plugin continues to work >> on OpenJDK 11. On OpenJDK 8, the plugin fails to load but the rest of >> JMC still functions. >> >> Let me know how it looks! >> >> diff --git a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >> b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >> --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >> +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >> @@ -94,13 +94,6 @@ >> unpack="false"/> >> >> > - id="org.openjdk.jmc.javafx.osgi" >> - download-size="0" >> - install-size="0" >> - version="0.0.0" >> - unpack="false"/> >> - >> - > id="org.openjdk.jmc.flightrecorder.rules.extensionprovider" >> download-size="0" >> install-size="0" >> diff --git a/application/org.openjdk.jmc.flightrecorder.ui/META- >> INF/MANIFEST.MF >> b/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF >> --- a/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF >> +++ b/application/org.openjdk.jmc.flightrecorder.ui/META- >> INF/MANIFEST.MF >> @@ -9,7 +9,6 @@ >> Require-Bundle: org.openjdk.jmc.rjmx, >> org.openjdk.jmc.flightrecorder;visibility:=reexport, >> org.openjdk.jmc.ui;visibility:=reexport, >> - org.openjdk.jmc.javafx.osgi, >> org.openjdk.jmc.flightrecorder.rules, >> org.openjdk.jmc.flightrecorder.rules.jdk, >> org.openjdk.jmc.flightrecorder.configuration, >> diff --git a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >> b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >> --- a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >> +++ b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >> @@ -7,6 +7,9 @@ >> Bundle-RequiredExecutionEnvironment: JavaSE-1.8 >> Bundle-ClassPath: . >> Eclipse-BuddyPolicy: app >> +Import-Package: javafx.application, javafx.embed.swt, >> + javafx.fxml, javafx.scene, javafx.scene.control, >> + javafx.scene.image >> Export-Package: org.openjdk.jmc.javafx.osgi >> Require-Bundle: org.eclipse.swt;resolution:=optional, >> org.eclipse.jface >> diff --git a/application/org.openjdk.jmc.javafx.osgi/pom.xml >> b/application/org.openjdk.jmc.javafx.osgi/pom.xml >> --- a/application/org.openjdk.jmc.javafx.osgi/pom.xml >> +++ b/application/org.openjdk.jmc.javafx.osgi/pom.xml >> @@ -40,27 +40,4 @@ >> >> org.openjdk.jmc.javafx.osgi >> eclipse-plugin >> - >> - >> - >> - org.eclipse.tycho >> - tycho-compiler-plugin >> - ${tycho.version} >> - >> - >> - **/Empty.java >> - >> - >> - >> - sun.jdk >> - jfxswt >> - 1.8.0 >> - system >> - ${java.home}/lib/jfxswt.jar >> - >> - >> - >> - >> - >> - >> >> >> >> Regards, From marcus at hirt.se Mon Jan 28 13:53:34 2019 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 28 Jan 2019 14:53:34 +0100 Subject: SV: Questions/comments about setting up JMC development workspace in Eclipse In-Reply-To: <4eaafdd8e5a948678762a6dfc4b0fea1@sap.com> References: <99D4E614-E640-4E7F-9496-E556C3E81E52@sap.com> <24E260A3-9DA1-4B32-A6C7-D520A5DA05E5@oracle.com> <4eaafdd8e5a948678762a6dfc4b0fea1@sap.com> Message-ID: <01aa01d4b710$dc810630$95831290$@hirt.se> Hi Cristoph, SAP has signed the OCA, so feel free to contribute. The more the merrier! :) Regarding the .classpath files and Maven: no, I haven't had time to look into it. IIRC, earlier, when there were no JavaFX bundles on Maven Central, we had to do funny things to make it possible to run the plug-ins from within Eclipse on both Oracle JDK and later JDKs. Perhaps we're closer now to a situation where we can clean up the last of the special cases, and make Maven the authority in all things class path. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Langer, Christoph Skickat: den 28 januari 2019 14:30 Till: Marcus Hirt ; Jie Kang Kopia: jmc-dev at openjdk.java.net ?mne: RE: Questions/comments about setting up JMC development workspace in Eclipse Hi Marcus, sure, I can contribute the changes to remove the references to JMC_JDK from the .classpath files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. Or maybe those could also be a part of Jie's fix for JMC-6370? Do you know why maven changed so many of the .classpath files that are checked in in the JMC repository when I import the projects into Eclipse and whether this can be avoided? Worst is the removal of the JMC_JDK dependency... Best regards Christoph > -----Original Message----- > From: Marcus Hirt > Sent: Montag, 28. Januar 2019 14:14 > To: Langer, Christoph > Cc: jmc-dev at openjdk.java.net > Subject: Re: Questions/comments about setting up JMC development > workspace in Eclipse > > Hi Christoph, > > 1. Yep, JDK 8 and JDK 11. I updated the blog - thanks! > 2. Yes, now it should be okay to remove the jfx and update the > classpath files as described. Will update the blog once the fixes are > in. Let me know if you want to contribute these! > 3. Yep, that is correct, as we decided we wanted to be able to build > core without Tycho and separately (also be able to push the core > artifacts to Maven Central at some point in the future). I updated the > blog (except for the images) - thanks! > > Kind regards, > Marcus > > ?On 2019-01-28, 11:56, "Langer, Christoph" > wrote: > > Hi Marcus, > > After my build works, my next task is setting up the development > infrastructure ?? > > So, of course, I followed your blog [1] about that closely. I > eventually managed to set up my Eclipse workspace that it now shows no > errors and JMC launches. But I have some feedback: > > - JDKs: I think the part with JDK 10 is a bit outdated, right? Now > it's all about > JDK11 (and, JDK 8, of course). The cited bug JMC-5895 [2] has already > been fixed quite some time ago. Is that correct? > - Setting up user library JMC_JDK: I've set up the library as > described in the blog. However, it seemed to me that the maven import > has deleted reference to JMC_JDK from the projects. (It also made > quite a few modifications to .classpath files which I'm unhappy with > as it spills hg status by the way). So I had to add reference back in > projects org.openjdk.jmc.browser.attach and org.openjdk.jmc.console.jconsole. > Also, now after the javafx dependencies were set up correctly as > external dependency and not from the JDK, I think jfxswt.jar and > jfxrt.jar can be removed. The reference to JMC_JDK can be dropped from > the .classpath files of org.openjdk.jmc.flightrecorder.ui and org.openjdk.jmc.javafx.osgi. > - Importing the projects: If I import the projects from the main > jmc directory, it does not show the projects inside subfolder core, as > the main pom.xml does not define "core" as a module. So I had to > manually import the core subdirectory. > > Best regards > Christoph > > [1] http://hirt.se/blog/?p=989 > [2] https://bugs.openjdk.java.net/browse/JMC-5895 > > > From guru.hb at oracle.com Mon Jan 28 17:07:57 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 28 Jan 2019 22:37:57 +0530 Subject: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi In-Reply-To: <8A115C25-5303-43C1-8475-74532F7BC9AB@oracle.com> References: <8A115C25-5303-43C1-8475-74532F7BC9AB@oracle.com> Message-ID: Hi Jie, +1, Changes looks good to me, With Nit Please maintain format in "org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF? for Import-Package (i.e one package per line starting with space). If you have not executed Ui test , Please do run Ui test with ?mvn verify -P uitests? before requesting to commit the code. Test : Compiled and verified installing (RCP) update sites on Mac OS X. Thanks, Guru > On 28-Jan-2019, at 7:18 PM, Guru wrote: > > Hi Jie, > > OpenJFX is required for Update sites. Let me check the dependency and test this patch and update you with comments. > > Thanks, > Guru >> On 28-Jan-2019, at 1:22 PM, Langer, Christoph wrote: >> >> Hi Jie, >> >> thanks for posting the fix. I can confirm that the build using OpenJDK works for me with these changes. Other people need to assess whether the changes are functionally correct, though ?? >> >> Best regards >> Christoph >> >>> -----Original Message----- >>> From: jmc-dev On Behalf Of Jie Kang >>> Sent: Freitag, 25. Januar 2019 17:28 >>> To: jmc-dev at openjdk.java.net >>> Subject: RFR: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx >>> packages in org.openjdk.jmc.javafx.osgi >>> >>> Hi, >>> >>> The following patch allows JMC to build with OpenJDK 8. >>> >>> * removes org.openjdk.jmc.javafx.osgi plugin from base feature >>> org.openjdk.jmc.feature.flightrecorder where it is unused >>> * removes org.openjdk.jmc.javafx.osgi dependency from >>> org.openjdk.jmc.flightrecorder.ui where it is unused >>> * updates MANIFEST.MF of org.openjdk.jmc.javafx.osgi to include the >>> correct imports for javafx packages >>> * removes unnecessary extra classpath elements as OpenJFX jars now >>> come from the p2 site and the MANIFEST.MF has the correct imports >>> >>> Note: the JOverflow plugin requires OpenJFX which has >>> JavaSE-10>> RequiredExecutionEnvironment> >>> >>> I have tested this on Fedora 28 building on OpenJDK 8 and running the >>> result using OpenJDK 8 and 11. The JOverflow plugin continues to work >>> on OpenJDK 11. On OpenJDK 8, the plugin fails to load but the rest of >>> JMC still functions. >>> >>> Let me know how it looks! >>> >>> diff --git a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >>> b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >>> --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >>> +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml >>> @@ -94,13 +94,6 @@ >>> unpack="false"/> >>> >>> >> - id="org.openjdk.jmc.javafx.osgi" >>> - download-size="0" >>> - install-size="0" >>> - version="0.0.0" >>> - unpack="false"/> >>> - >>> - >> id="org.openjdk.jmc.flightrecorder.rules.extensionprovider" >>> download-size="0" >>> install-size="0" >>> diff --git a/application/org.openjdk.jmc.flightrecorder.ui/META- >>> INF/MANIFEST.MF >>> b/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF >>> --- a/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF >>> +++ b/application/org.openjdk.jmc.flightrecorder.ui/META- >>> INF/MANIFEST.MF >>> @@ -9,7 +9,6 @@ >>> Require-Bundle: org.openjdk.jmc.rjmx, >>> org.openjdk.jmc.flightrecorder;visibility:=reexport, >>> org.openjdk.jmc.ui;visibility:=reexport, >>> - org.openjdk.jmc.javafx.osgi, >>> org.openjdk.jmc.flightrecorder.rules, >>> org.openjdk.jmc.flightrecorder.rules.jdk, >>> org.openjdk.jmc.flightrecorder.configuration, >>> diff --git a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >>> b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >>> --- a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >>> +++ b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF >>> @@ -7,6 +7,9 @@ >>> Bundle-RequiredExecutionEnvironment: JavaSE-1.8 >>> Bundle-ClassPath: . >>> Eclipse-BuddyPolicy: app >>> +Import-Package: javafx.application, javafx.embed.swt, >>> + javafx.fxml, javafx.scene, javafx.scene.control, >>> + javafx.scene.image >>> Export-Package: org.openjdk.jmc.javafx.osgi >>> Require-Bundle: org.eclipse.swt;resolution:=optional, >>> org.eclipse.jface >>> diff --git a/application/org.openjdk.jmc.javafx.osgi/pom.xml >>> b/application/org.openjdk.jmc.javafx.osgi/pom.xml >>> --- a/application/org.openjdk.jmc.javafx.osgi/pom.xml >>> +++ b/application/org.openjdk.jmc.javafx.osgi/pom.xml >>> @@ -40,27 +40,4 @@ >>> >>> org.openjdk.jmc.javafx.osgi >>> eclipse-plugin >>> - >>> - >>> - >>> - org.eclipse.tycho >>> - tycho-compiler-plugin >>> - ${tycho.version} >>> - >>> - >>> - **/Empty.java >>> - >>> - >>> - >>> - sun.jdk >>> - jfxswt >>> - 1.8.0 >>> - system >>> - ${java.home}/lib/jfxswt.jar >>> - >>> - >>> - >>> - >>> - >>> - >>> >>> >>> >>> Regards, > From jkang at redhat.com Mon Jan 28 20:56:13 2019 From: jkang at redhat.com (Jie Kang) Date: Mon, 28 Jan 2019 15:56:13 -0500 Subject: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi In-Reply-To: References: <8A115C25-5303-43C1-8475-74532F7BC9AB@oracle.com> Message-ID: Hi Guru, Thanks for reviewing this I will address the format changes and ask Joshua to commit for me. I have run the ui-tests as well. Regards, On Mon, Jan 28, 2019 at 12:10 PM Guru wrote: > Hi Jie, > > +1, Changes looks good to me, With Nit > Please maintain format in > "org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF? for Import-Package (i.e > one package per line starting with space). > > If you have not executed Ui test , Please do run Ui test with ?mvn verify > -P uitests? before requesting to commit the code. > > Test : Compiled and verified installing (RCP) update sites on Mac OS X. > > Thanks, > Guru > > On 28-Jan-2019, at 7:18 PM, Guru wrote: > > > > Hi Jie, > > > > OpenJFX is required for Update sites. Let me check the dependency and > test this patch and update you with comments. > > > > Thanks, > > Guru > >> On 28-Jan-2019, at 1:22 PM, Langer, Christoph > wrote: > >> > >> Hi Jie, > >> > >> thanks for posting the fix. I can confirm that the build using OpenJDK > works for me with these changes. Other people need to assess whether the > changes are functionally correct, though ?? > >> > >> Best regards > >> Christoph > >> > >>> -----Original Message----- > >>> From: jmc-dev On Behalf Of Jie Kang > >>> Sent: Freitag, 25. Januar 2019 17:28 > >>> To: jmc-dev at openjdk.java.net > >>> Subject: RFR: JMC-6370: JMC build fails with OpenJDK 8 due to missing > javafx > >>> packages in org.openjdk.jmc.javafx.osgi > >>> > >>> Hi, > >>> > >>> The following patch allows JMC to build with OpenJDK 8. > >>> > >>> * removes org.openjdk.jmc.javafx.osgi plugin from base feature > >>> org.openjdk.jmc.feature.flightrecorder where it is unused > >>> * removes org.openjdk.jmc.javafx.osgi dependency from > >>> org.openjdk.jmc.flightrecorder.ui where it is unused > >>> * updates MANIFEST.MF of org.openjdk.jmc.javafx.osgi to include the > >>> correct imports for javafx packages > >>> * removes unnecessary extra classpath elements as OpenJFX jars now > >>> come from the p2 site and the MANIFEST.MF has the correct imports > >>> > >>> Note: the JOverflow plugin requires OpenJFX which has > >>> JavaSE-10 >>> RequiredExecutionEnvironment> > >>> > >>> I have tested this on Fedora 28 building on OpenJDK 8 and running the > >>> result using OpenJDK 8 and 11. The JOverflow plugin continues to work > >>> on OpenJDK 11. On OpenJDK 8, the plugin fails to load but the rest of > >>> JMC still functions. > >>> > >>> Let me know how it looks! > >>> > >>> diff --git > a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > >>> b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > >>> --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > >>> +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.xml > >>> @@ -94,13 +94,6 @@ > >>> unpack="false"/> > >>> > >>> >>> - id="org.openjdk.jmc.javafx.osgi" > >>> - download-size="0" > >>> - install-size="0" > >>> - version="0.0.0" > >>> - unpack="false"/> > >>> - > >>> - >>> id="org.openjdk.jmc.flightrecorder.rules.extensionprovider" > >>> download-size="0" > >>> install-size="0" > >>> diff --git a/application/org.openjdk.jmc.flightrecorder.ui/META- > >>> INF/MANIFEST.MF > >>> b/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF > >>> --- > a/application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF > >>> +++ b/application/org.openjdk.jmc.flightrecorder.ui/META- > >>> INF/MANIFEST.MF > >>> @@ -9,7 +9,6 @@ > >>> Require-Bundle: org.openjdk.jmc.rjmx, > >>> org.openjdk.jmc.flightrecorder;visibility:=reexport, > >>> org.openjdk.jmc.ui;visibility:=reexport, > >>> - org.openjdk.jmc.javafx.osgi, > >>> org.openjdk.jmc.flightrecorder.rules, > >>> org.openjdk.jmc.flightrecorder.rules.jdk, > >>> org.openjdk.jmc.flightrecorder.configuration, > >>> diff --git > a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > >>> b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > >>> --- a/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > >>> +++ b/application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF > >>> @@ -7,6 +7,9 @@ > >>> Bundle-RequiredExecutionEnvironment: JavaSE-1.8 > >>> Bundle-ClassPath: . > >>> Eclipse-BuddyPolicy: app > >>> +Import-Package: javafx.application, javafx.embed.swt, > >>> + javafx.fxml, javafx.scene, javafx.scene.control, > >>> + javafx.scene.image > >>> Export-Package: org.openjdk.jmc.javafx.osgi > >>> Require-Bundle: org.eclipse.swt;resolution:=optional, > >>> org.eclipse.jface > >>> diff --git a/application/org.openjdk.jmc.javafx.osgi/pom.xml > >>> b/application/org.openjdk.jmc.javafx.osgi/pom.xml > >>> --- a/application/org.openjdk.jmc.javafx.osgi/pom.xml > >>> +++ b/application/org.openjdk.jmc.javafx.osgi/pom.xml > >>> @@ -40,27 +40,4 @@ > >>> > >>> org.openjdk.jmc.javafx.osgi > >>> eclipse-plugin > >>> - > >>> - > >>> - > >>> - org.eclipse.tycho > >>> - tycho-compiler-plugin > >>> - ${tycho.version} > >>> - > >>> - > >>> - **/Empty.java > >>> - > >>> - > >>> - > >>> - sun.jdk > >>> - jfxswt > >>> - 1.8.0 > >>> - system > >>> - ${java.home}/lib/jfxswt.jar > >>> - > >>> - > >>> - > >>> - > >>> - > >>> - > >>> > >>> > >>> > >>> Regards, > > > > From jmatsuok at redhat.com Mon Jan 28 21:06:15 2019 From: jmatsuok at redhat.com (Joshua Matsuoka) Date: Mon, 28 Jan 2019 16:06:15 -0500 Subject: JMC-6324: Values in Method Profiling rule result text not correct when filtering In-Reply-To: <019c01d4b70f$077445c0$165cd140$@hirt.se> References: <019c01d4b70f$077445c0$165cd140$@hirt.se> Message-ID: Hi Marcus, Here's an updated patch: http://cr.openjdk.java.net/~jmatsuoka/JMC-6324/webrev.01/ Cheers, - Josh On Mon, Jan 28, 2019 at 8:40 AM Marcus Hirt wrote: > Hi Josh, > > Looks good! Perhaps the percentage shown for the most interesting > candidate should be updated to show the percentage of the actual > samples taken? This is since the normalization bars we show as > backdrop in some columns is in regards to actual events. I think we > only need to drop the relation to the theoretical maximum amount of > samples in the user's head once, and only to motivate a lower score > than expected. > > For example: > The following methods are the most interesting candidates for code > optimization: > ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) > (24,1 %) 2018-11-09 14:40:39 ? 14:41:09 > -> > The following methods are the most interesting candidates for code > optimization: > ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) > (98,2 %) 2018-11-09 14:40:39 ? 14:41:09 > > or possible more verbosely: > The following methods are the most interesting candidates for code > optimization: > ?se.hirt.jmc.tutorial.hotmethods.HolderOfUniqueValues.countIntersection(HolderOfUniqueValues) > (98,2 % of the samples) 2018-11-09 14:40:39 ? 14:41:09 > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Joshua Matsuoka > Skickat: den 25 januari 2019 17:46 > Till: jmc-dev at openjdk.java.net > ?mne: RFR: JMC-6324: Values in Method Profiling rule result text not > correct when filtering > > Hi, > > The following patch adds some extra clarity to the Method Profiling rule. > > Currently the percentage reported by the Method Profiling rule is the > percentage of all possible samples in a given period, rather than the > actual number of samples. This can lead to some rather misleading results > when for example a method takes up 99% of the actual samples in a window, > but only constitutes 25% of the theoretical maximum number of samples. > > This patch keeps track of both the relation to the maximum, as well as the > actual percentage of samples and reports both with the rule results (e.g. > Method x had y% of possible samples and z% of actual samples) > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6324/webrev.00/ > > Thoughts? > > Cheers, > > - Josh > > From jmatsuok at redhat.com Mon Jan 28 21:45:47 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Mon, 28 Jan 2019 21:45:47 +0000 Subject: hg: jmc/jmc: JMC-6333: Default JMC binaries should not hardcode -vm /usr/bin/java Message-ID: <201901282145.x0SLjlGU020126@aojmv0008.oracle.com> Changeset: 2b0376cc5830 Author: jmatsuoka Date: 2019-01-28 16:45 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/2b0376cc5830 JMC-6333: Default JMC binaries should not hardcode -vm /usr/bin/java Summary: use default Java from PATH on Linux Reviewed-by: neugens, ghb Contributed-by: Salman Siddiqui ! application/org.openjdk.jmc.rcp.product/jmc.product From jmatsuok at redhat.com Tue Jan 29 17:04:35 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Tue, 29 Jan 2019 17:04:35 +0000 Subject: hg: jmc/jmc: JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi Message-ID: <201901291704.x0TH4ZnY019596@aojmv0008.oracle.com> Changeset: 1a1a3bc8115b Author: jmatsuoka Date: 2019-01-29 12:04 -0500 URL: http://hg.openjdk.java.net/jmc/jmc/rev/1a1a3bc8115b JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi Summary: Updates dependency on OpenJFX to build on OpenJDK 8 Contributed-by: Jie Kang Reviewed-by: ghb, Christoph Langer ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/pom.xml From ebaron at redhat.com Tue Jan 29 23:07:21 2019 From: ebaron at redhat.com (Elliott Baron) Date: Tue, 29 Jan 2019 18:07:21 -0500 Subject: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences Message-ID: <28a559c2-7858-896b-449c-4f1fe281f536@redhat.com> Hi, This patch fixes the JMX Console->Communication preference page to properly restore the username and password fields to their (blank) defaults when the user selects "Restore Defaults". I added a UI test to ensure Restore Defaults works as expected for the Communication page as a whole. I created a new test class since there didn't seem to be an existing one that was a good fit. I had to add a getText method to MCDialog to get the text entered into the fields in the preference page. There are new x-friends directives for org.openjdk.jmc.rjmx.preferences and org.openjdk.jmc.console.ui.messages.internal to expose some constants used by the test. The copyright header for the new test class may need some adjusting. Are we updating copyright year for source files, and should we name the author/author's employer in the copyright header for new source files originating outside of Oracle? How does the patch look? Thanks, Elliott -------------- next part -------------- A non-text attachment was scrubbed... Name: jmc-6211.patch Type: text/x-patch Size: 15311 bytes Desc: not available URL: From marcus.hirt at oracle.com Thu Jan 31 19:40:08 2019 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Thu, 31 Jan 2019 19:40:08 +0000 Subject: hg: jmc/jmc7: JMC-6358: Need a more recent version of spotbugs to facilitate third-party process Message-ID: <201901311940.x0VJe9NX004367@aojmv0008.oracle.com> Changeset: ef09b4bf82a1 Author: hirt Date: 2019-01-31 20:06 +0100 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/ef09b4bf82a1 JMC-6358: Need a more recent version of spotbugs to facilitate third-party process Reviewed-by: hirt Contributed-by: aptmac ! pom.xml From clement at unportant.info Thu Jan 24 22:23:58 2019 From: clement at unportant.info (=?ISO-8859-1?Q?Cl=E9ment?= MATHIEU) Date: Thu, 24 Jan 2019 22:23:58 -0000 Subject: [PATCH] fix-info-plist-maven-plugin now available on Maven Central Message-ID: <0f6fb2693a5074089c4e898703066df1234e9726.camel@unportant.info> Hi, fix-info-plist-maven-plugin was published on a custom maven repo, http://buchen.github.io/maven-repo, requiring to configure a proxy in corporate environments (local Maven proxy likely doesn't track this repo). Plugin author just published latest rev on Maven central, see https://github.com/buchen/fix-info-plist-maven-plugin/issues/3. I gave it a shot and it seems to work. This should make building jmc a bit easier. What do you think? Regards, Cl?ment MATHIEU -------------- next part -------------- A non-text attachment was scrubbed... Name: fix-info-plist-maven-plugin-maven-central.patch Type: text/x-patch Size: 788 bytes Desc: not available URL: