Review Request: Fix 2018-09 Platform Definition

[Prem Balakrishnan]

Hi Jie,

Thank you for bringing this to our attention.

We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch.

Request you to create a bug for the same and update the review thread. 


Regards,
Prem

-----Original Message-----
From: Jie Kang <jkang at redhat.com> 
Sent: Thursday, January 03, 2019 8:07 PM
To: jmc-dev at openjdk.java.net
Subject: Review Request: Fix 2018-09 Platform Definition

Hi,

The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the
2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts?

diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
--- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
+++ b/releng/platform-definitions/platform-definition-2018-09/platform-d
+++ efinition-2018-09.target
@@ -34,9 +34,11 @@
 <?pde version="3.8"?><target name="jmc-target-2018-09" sequenceNumber="47">
     <locations>
         <location includeAllPlatforms="false"
includeConfigurePhase="true" includeMode="planner"
includeSource="true" type="InstallableUnit">
-            <unit id="com.sun.mail.jakarta.mail" version="1.6.3"/>
-            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
+            <unit id="javax.mail.api" version="1.4.0"/>
             <unit id="javax.mail.dsn" version="1.4.0"/>
+            <unit id="javax.mail.imap" version="1.4.0"/>
+            <unit id="javax.mail.pop3" version="1.4.0"/>
+            <unit id="javax.mail.smtp" version="1.4.0"/>
             <unit id="org.owasp.encoder" version="1.2.1"/>
             <unit id="org.twitter4j.core" version="4.0.6"/>
             <repository location="http://localhost:8080/site"/>


Regards,