JMC-6223- Visualize the PID from JVM Information Event

[Ken Dobson]

Hi all,

Here's a patch adding the PID to the JVM Internals page because I saw that
https://bugs.openjdk.java.net/browse/JDK-8213617 had been completed so this
ticket was no longer blocked. I've just posted it verbatim below as I'm
still waiting on my OpenJDK registration email.

Thanks,

Ken Dobson

diff -r abb4b7f54009
application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java
---
a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java
Thu Dec 06 19:12:44 2018 +0100
+++
b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java
Thu Jan 03 11:57:09 2019 -0500
@@ -162,6 +162,7 @@
                        infoViewer = new ItemAggregateViewer(jvmInfSection,
toolkit);

infoViewer.addAggregate(JdkAggregators.JVM_START_TIME);
                        infoViewer.addAggregate(JdkAggregators.JVM_NAME);
+                       infoViewer.addAggregate(JdkAggregators.JVM_PID);
                        infoViewer.addAggregate(JdkAggregators.JVM_VERSION);

infoViewer.addAggregate(JdkAggregators.JVM_ARGUMENTS);

infoViewer.addAggregate(JdkAggregators.JAVA_ARGUMENTS);
diff -r abb4b7f54009
core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java
---
a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java
Thu Dec 06 19:12:44 2018 +0100
+++
b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java
Thu Jan 03 11:57:09 2019 -0500
@@ -113,6 +113,8 @@

        // VM Info
        public static final IAggregator<String, ?> JVM_NAME =
distinctAsString(VM_INFO, JdkAttributes.JVM_NAME);
+       public static final IAggregator<IQuantity, ?> JVM_PID =
min(JdkAttributes.JVM_PID.getName(), null,
+                       VM_INFO, JdkAttributes.JVM_PID);
        public static final IAggregator<IQuantity, ?> JVM_START_TIME =
min(JdkAttributes.JVM_START_TIME.getName(), null,
                        VM_INFO, JdkAttributes.JVM_START_TIME);
        public static final IAggregator<String, ?> JVM_VERSION =
distinctAsString(VM_INFO, JdkAttributes.JVM_VERSION);
diff -r abb4b7f54009
core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java
---
a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java
Thu Dec 06 19:12:44 2018 +0100
+++
b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java
Thu Jan 03 11:57:09 2019 -0500
@@ -441,6 +441,8 @@
                        Messages.getString(Messages.ATTR_JVM_START_TIME),
TIMESTAMP);
        public static final IAttribute<String> JVM_NAME = attr("jvmName",
Messages.getString(Messages.ATTR_JVM_NAME), //$NON-NLS-1$
                        PLAIN_TEXT);
+       public static final IAttribute<IQuantity> JVM_PID = attr("pid",
Messages.getString(Messages.ATTR_JVM_PID), //$NON-NLS-1$
+                       NUMBER);
        public static final IAttribute<String> JVM_VERSION =
attr("jvmVersion", //$NON-NLS-1$
                        Messages.getString(Messages.ATTR_JVM_VERSION),
PLAIN_TEXT);
        public static final IAttribute<String> JVM_ARGUMENTS =
attr("jvmArguments", //$NON-NLS-1$
diff -r abb4b7f54009
core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java
---
a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java
Thu Dec 06 19:12:44 2018 +0100
+++
b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java
Thu Jan 03 11:57:09 2019 -0500
@@ -314,6 +314,7 @@
        public static final String ATTR_JAVA_ARGUMENTS =
"ATTR_JAVA_ARGUMENTS"; //$NON-NLS-1$
        public static final String ATTR_JVM_ARGUMENTS =
"ATTR_JVM_ARGUMENTS"; //$NON-NLS-1$
        public static final String ATTR_JVM_NAME = "ATTR_JVM_NAME";
//$NON-NLS-1$
+       public static final String ATTR_JVM_PID = "ATTR_JVM_PID";
//$NON-NLS-1$
        public static final String ATTR_JVM_START_TIME =
"ATTR_JVM_START_TIME"; //$NON-NLS-1$
        public static final String ATTR_JVM_SYSTEM = "ATTR_JVM_SYSTEM";
//$NON-NLS-1$
        public static final String ATTR_JVM_SYSTEM_DESC =
"ATTR_JVM_SYSTEM_DESC"; //$NON-NLS-1$
diff -r abb4b7f54009
core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties
---
a/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties
Thu Dec 06 19:12:44 2018 +0100
+++
b/core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties
Thu Jan 03 11:57:09 2019 -0500
@@ -53,6 +53,7 @@
 ATTR_REC_SETTING_VALUE=Setting Value
 ATTR_JVM_START_TIME=JVM Start Time
 ATTR_JVM_NAME=JVM Name
+ATTR_JVM_PID = JVM PID
 ATTR_JVM_VERSION=JVM Version
 ATTR_JVM_ARGUMENTS=JVM Arguments
 ATTR_JAVA_ARGUMENTS=JVM Application Arguments