Review request for JMC-6327: Updating version to 7.1.0
Guru
guru.hb at oracle.com
Thu Jan 10 19:29:48 UTC 2019
Hi Marcus,
Looks good to me with additional changes required as suggested by Jie Kang.
Tested on Mac.
Thanks,
Guru
> On 11-Jan-2019, at 12:49 AM, Jie Kang <jkang at redhat.com> wrote:
>
> On Thu, Jan 10, 2019 at 9:16 AM Marcus Hirt <marcus.hirt at oracle.com> wrote:
>>
>> Hi all,
>>
>> Please review this fix to update the versions in the mainline repo.
>
> Hi Marcus,
>
> After applying this patch I see two remaining references to 7.0.0:
>
> README.md:
> 317: application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip
>
> releng/third-party/pom.xml:
> 39: <version>7.0.0-SNAPSHOT</version>
>
> Should these be updated as well? Otherwise it looks okay to me. I was
> able to build and run JMC.
>
>
> Regards,
>
>>
>> Jira: https://bugs.openjdk.java.net/browse/JMC-6327
>> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6327/webrev.0/
>>
>> Kind regards,
>> Marcus
>>
>>
More information about the jmc-dev
mailing list