Review Request: JMC 6314 - Default JMC binaries for Linux reference odd "-vm ../../bin"

Joshua Matsuoka jmatsuok at redhat.com
Fri Jan 11 21:30:18 UTC 2019


Hi Salman,

looks good to me.

Cheers,

- Josh

On Tue, Jan 8, 2019 at 10:16 AM Guru <guru.hb at oracle.com> wrote:

> +1 Looks good to me.
>
> Note: https://bugs.openjdk.java.net/browse/JMC-6314 is still “Unassigned”
> and its state is in “Triage”.
>
> Please request any of your team member who has JBS Account to assign to
> them self and sponsor the changes.
>
> Thanks,
> Guru
> > On 08-Jan-2019, at 8:35 PM, Salman Siddiqui <sasiddiq at redhat.com> wrote:
> >
> > Hi all,
> >
> > This is a patch to use the default Java on Linux systems instead of
> > searching for a JDK in the non-existent "../../bin" directory.
> >
> > Thanks,
> > Salman
> >
> >
> > diff -r 80f49c3226cb application/org.openjdk.jmc.rcp.product/jmc.product
> > --- a/application/org.openjdk.jmc.rcp.product/jmc.product       Thu Jan
> 03
> > 16:54:12 2019 +0530
> > +++ b/application/org.openjdk.jmc.rcp.product/jmc.product       Tue Jan
> 08
> > 09:59:09 2019 -0500
> > @@ -48,7 +48,7 @@
> >    <launcherArgs>
> >       <programArgs>--launcher.appendVmargs
> >       </programArgs>
> > -      <programArgsLin>-vm ../../bin/
> > +      <programArgsLin>-vm /usr/bin/java
> >       </programArgsLin>
> >       <programArgsMac>-ws cocoa -vm ../jdk/Contents/Home/bin/
> >       </programArgsMac>
>
>


More information about the jmc-dev mailing list