Review request for JMC-6334: Fixing wrongly spelt method
Miro Wengner
miro.wengner at gmail.com
Sun Jan 13 16:25:27 UTC 2019
+1 Looks good to me
> On Jan 13, 2019, at 5:17 PM, Guru <guru.hb at oracle.com> wrote:
>
> +1 Looks good to me.
>
>> On 13-Jan-2019, at 7:49 PM, Marcus Hirt <marcus at hirt.se> wrote:
>>
>> Jira: https://bugs.openjdk.java.net/browse/JMC-6334
>> Diff:
>> diff -r 77a9bfb4a741
>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightreco
>> rder/internal/parser/Chunk.java
>> ---
>> a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre
>> corder/internal/parser/Chunk.java Fri Jan 11 16:31:10 2019 -0500
>> +++
>> b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightre
>> corder/internal/parser/Chunk.java Sun Jan 13 15:16:32 2019 +0100
>> @@ -87,7 +87,7 @@
>> * @return the current buffer for the chunk data
>> */
>> public byte[] fill(long upToPosition) throws IOException,
>> InvalidJfrFileException {
>> - int fillUpTo = getArrayPosistion(upToPosition);
>> + int fillUpTo = getArrayPosition(upToPosition);
>> if (data.length < fillUpTo) {
>> data = Arrays.copyOf(data, (int) (fillUpTo * 1.2));
>> }
>> @@ -106,7 +106,7 @@
>> * chunk relative position
>> */
>> public void skip(long upToPosition) throws IOException,
>> InvalidJfrFileException {
>> - int skipUpTo = getArrayPosistion(upToPosition);
>> + int skipUpTo = getArrayPosition(upToPosition);
>> if (skipUpTo > position) {
>> int skipped = input.skipBytes(skipUpTo - position);
>> position += skipped;
>> @@ -124,7 +124,7 @@
>> return data;
>> }
>>
>> - private static int getArrayPosistion(long pos) throws
>> InvalidJfrFileException {
>> + private static int getArrayPosition(long pos) throws
>> InvalidJfrFileException {
>> if (pos > Integer.MAX_VALUE) {
>> throw new InvalidJfrFileException();
>> } else {
>>
>>
>
More information about the jmc-dev
mailing list