SV: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites

[Marcus Hirt]

Thank you, Guru! Looks good!

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: Guru <guru.hb at oracle.com> 
Skickat: den 18 januari 2019 08:41
Till: Marcus Hirt <marcus at hirt.se>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: Review request: JMC-6128: Integrate org.openjfx library as dependency local local p2 and re-distribute with Update sites

Please find Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.1/
1. Updated oxygen and 2018-19 target files 2. Updated copyright years (Additional comments in JBS)

With this fix, Eclipse running with JDK 9 or its below + JMC doesn’t work as OpenJFX modules are compiled with OpenJDK 11 (i.e with Class file version 54.0). For this https://bugs.openjdk.java.net/browse/JMC-6342 will be a follow on bug to address this defect.

Thanks,
Guru
> On 18-Jan-2019, at 2:18 AM, Marcus Hirt <marcus at hirt.se> wrote:
> 
> You need a line break at the end of
> org.openjdk.jmc.javafx.osgi/META_INF/MANIFEST.MF,
> as headers must be terminated by line breaks.
> 
> /M
> 
> -----Ursprungligt meddelande-----
> Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Guru
> Skickat: den 17 januari 2019 18:40
> Till: jmc-dev at openjdk.java.net
> Ämne: Review request: JMC-6128: Integrate org.openjfx library as 
> dependency local local p2 and re-distribute with Update sites
> 
> Hi,
> 
> Please review the fix for : 
> JBS : https://bugs.openjdk.java.net/browse/JMC-6128
> webrev : http://cr.openjdk.java.net/~ghb/JMC-6128/webrev.0/
> 
> Solution and RC updated in JBS.
> 
> Thanks,
> Guru
> 
>