Review Request: JMC-6333 - Default JMC binaries should not hardcode -vm /usr/bin/java

[Guru]

+1, Looks good to me. 

Thanks,
Guru
> On 23-Jan-2019, at 5:09 PM, Mario Torre <neugens at redhat.com> wrote:
> 
> On Tue, 2019-01-22 at 10:50 -0500, Salman Siddiqui wrote:
>> Hi,
>> 
>> This patch is still awaiting review.
> 
> The patch looks good to me, however I think we need to have Marcus OK
> on this one, I don't know if it has any impact on the closed JMC that
> needs to be addressed.
> 
> Cheers,
> Mario
> 
>> Thanks,
>> Salman
>> 
>> On Mon, Jan 14, 2019 at 4:01 PM Salman Siddiqui <sasiddiq at redhat.com>
>> wrote:
>> 
>>> Hi all,
>>> 
>>> This is a patch to remove "-vm /usr/bin/java" from jmc.ini so that
>>> the
>>> default Java on the PATH is used on Linux systems. It is a follow-
>>> up of
>>> JMC-6314.
>>> 
>>> Thanks,
>>> Salman
>>> 
>>> diff -r 0e7f3f9e078c
>>> application/org.openjdk.jmc.rcp.product/jmc.product
>>> --- a/application/org.openjdk.jmc.rcp.product/jmc.product       Sun
>>> Jan 13
>>> 17:50:38 2019 +0100
>>> +++ b/application/org.openjdk.jmc.rcp.product/jmc.product       Mon
>>> Jan 14
>>> 15:53:39 2019 -0500
>>> @@ -48,8 +48,8 @@
>>>    <launcherArgs>
>>>       <programArgs>--launcher.appendVmargs
>>>       </programArgs>
>>> -      <programArgsLin>-vm /usr/bin/java
>>> -      </programArgsLin>
>>> +      <!-- use default Java from PATH on Linux -->
>>> +      <programArgsLin></programArgsLin>
>>>       <programArgsMac>-ws cocoa -vm ../jdk/Contents/Home/bin/
>>>       </programArgsMac>
>>>       <programArgsWin>-vm ./
>>> 
>>> 
> -- 
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com <https://www.redhat.com/>>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898