SV: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs

[Marcus Hirt]

Hi Alex!

Looks good! Feel free to submit to the mainline repo (only, for now).

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Alex Macdonald
Skickat: den 23 januari 2019 18:06
Till: jmc-dev at openjdk.java.net
Ämne: RFR: JMC-6358: Build fails due to bugs and errors flagged by SpotBugs

Hi,

The following webrev [0] addresses issue JMC-6358 [1], in which builds using SpotBugs fail due to a number of flagged bugs and errors [2].

These errors appear as of a recent resolved bug [3] to use maven central's OpenJFX. We are currently using spotbugs-maven-plugin version 3.1.3, which doesn't have support for JDK 10/11 (introduced in version 3.1.3.1). I've set up a bunch of branches on Travis CI [4] to test the build using versions 3.1.3.1 through to 3.1.10 (current release), and the updated spotbugs plugin does not error. There have been a number of improvements [5] in the spotbugs plugin since 3.1.3, many of which correspond to JDK 11 support. The proposed one-line patch [0] simply updates the version of the spotbugs-maven-plugin to 3.1.10.

Thoughts?

Cheers,

Alex

[0] http://cr.openjdk.java.net/~aptmac/JMC-6358/webrev.00/
[1] https://bugs.openjdk.java.net/browse/JMC-6358
[2] https://api.travis-ci.org/v3/job/482998757/log.txt
[3] https://bugs.openjdk.java.net/browse/JMC-6128
[4] https://imgur.com/p6z15eX
[5]
https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.3...spotbugs