Review request : JMC-6286 : Update L10N translation for JMC 7.1.0

[Marcus Hirt]

I can’t speak to the contents of the strings, but it looks good!

 

+1

 

/M

 

From: Guru <guru.hb at oracle.com>
Date: Wednesday, 23 January 2019 at 21:19
To: Marcus Hirt <marcus.hirt at oracle.com>
Cc: <jmc-dev at openjdk.java.net>
Subject: Re: Review request : JMC-6286 : Update L10N translation for JMC 7.1.0

 

Hi,

 

Please review the updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.1/ 

Solution : Updated missing string localised strings. 

 

Note: As the current Development branch version is 7.1.0, JBS title is updated with 7.1.0. Once this is fixed (fix committed in http://hg.openjdk.java.net/jmc/jmc the same will be back ported to http://hg.openjdk.java.net/jmc/jmc7 which is planned for JMC 7.0.0 release) 

 

Thanks,

Guru

On 21-Dec-2018, at 2:00 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:

 

Some translations seem to be missing. I pinged Guru, and he's 
looking into this.

/M

On 2018-12-20, 19:14, "jmc-dev on behalf of Guru" <jmc-dev-bounces at openjdk.java.net on behalf of guru.hb at oracle.com> wrote:

   Hi,

   Please review the fix for https://bugs.openjdk.java.net/browse/JMC-6286 
   Webrev : http://cr.openjdk.java.net/~ghb/JMC-6286/webrev.0/ 

   Thanks,
   Guru