RFR: JMC-6324: Values in Method Profiling rule result text not correct when filtering

Joshua Matsuoka jmatsuok at redhat.com
Fri Jan 25 16:46:21 UTC 2019


Hi,

The following patch adds some extra clarity to the Method Profiling rule.

Currently the percentage reported by the Method Profiling rule is the
percentage of all possible samples in a given period, rather than the
actual number of samples. This can lead to some rather misleading results
when for example a method takes up 99% of the actual samples in a window,
but only constitutes 25% of the theoretical maximum number of samples.

This patch keeps track of both the relation to the maximum, as well as the
actual percentage of samples and reports both with the rule results (e.g.
Method x had y% of possible samples and z% of actual samples)

http://cr.openjdk.java.net/~jmatsuoka/JMC-6324/webrev.00/

Thoughts?

Cheers,

- Josh


More information about the jmc-dev mailing list