RFC: JMC-6524: Rename Launcher files and exclude spaces

[Alex Macdonald]

On Mon, Jul 22, 2019 at 12:48 PM Jie Kang <jkang at redhat.com> wrote:

> On Mon, Jul 22, 2019 at 12:15 PM Alex Macdonald <almacdon at redhat.com>
> wrote:
> >
> > Hi Jie,
> >
> > On Mon, Jul 8, 2019 at 4:08 PM Jie Kang <jkang at redhat.com> wrote:
> >>
> >> Hi,
> >>
> >> Please review the attached patch targeting JMC-6524 [1]. I tried to
> >> create a webrev but of course, the webrev system did not enjoy the
> >> files with spaces in them.
> >>
> >> It renames the launcher files, replacing ' ' (spaces) with '-' and
> >> removed usages of brackets '(' and ')'. If there are any stronger
> >> opinions on how the files should be renamed, please do let me know! I
> >> would be glad to accommodate.
> >>
> >> I have tried using these configurations with Eclipse 2019-03 on Fedora
> >> 30 (X11). Testing on other system setups would be appreciated!
> >
> >
> > The configurations worked for me on both my Linux & Windows machines (on
> Eclipse 2018-09 & 2019-03).
> >
> > There were updates to the JMC plug-in launchers as part of the flame
> graph commit [0], so this patch no longer applies cleanly and will require
> a rebase for those affected files.
>
> Hi Alex,
>
> Thanks for the review. I've attached an updated patch. If a second
> reviewer could take a look, I'd appreciate it.
>

Great, I can sponsor this patch for you.


>
>
> Regards,
>
> >
> >>
> >>
> >>
> >> Regards,
> >>
> >> [1] https://bugs.openjdk.java.net/browse/JMC-6524
> >
> >
> > Cheers,
> >
> > Alex
> >
> > [0] http://hg.openjdk.java.net/jmc/jmc/rev/1488ed0683c8
>