Review Request for JMC-6537: Autoboxing rule is slow

[Marcus Hirt]

Looks good!

Kind regards,
Marcus

On Mon, Jul 22, 2019 at 8:58 PM Henrik Dafgård <hdafgard at gmail.com> wrote:
>
> Updated webrev here: http://cr.openjdk.java.net/~hdafgard/JMC-6537/webrev.2/index.html
>
>
> On Mon, 22 Jul 2019 at 16:58, Henrik Dafgård <hdafgard at gmail.com> wrote:
>>
>> Yeah, that would be a good change.
>>
>>
>> Cheers,
>> Henrik Dafgård
>>
>>
>> On Mon, 22 Jul 2019 at 15:37, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>>>
>>> Hi Henrik,
>>>
>>> Since it is always the valueOf method you're checking for, wouldn't it
>>> be nicer (and also avoiding some allocations), to simply first check
>>> the method name and then the class name (and not fuse the class and
>>> method name together in the Predicate)? Also, don't forget to
>>> update/add the copyright year.
>>>
>>> Kind regards,
>>> Marcus
>>>
>>> On Mon, Jul 22, 2019 at 3:26 PM Henrik Dafgård <hdafgard at gmail.com> wrote:
>>> >
>>> > Hi all again,
>>> >
>>> > Sorry about that, I put up a webrev instead.
>>> > Webrev: http://cr.openjdk.java.net/~hdafgard/JMC-6537/webrev.0/index.html
>>> > JIRA: https://bugs.openjdk.java.net/browse/JMC-6537
>>> >
>>> >
>>> > Cheers,
>>> > Henrik Dafgård
>>> >
>>> >
>>> > On Mon, 22 Jul 2019 at 14:19, Andrew Azores <aazores at redhat.com> wrote:
>>> >
>>> > > Hi Henrik,
>>> > >
>>> > > On Mon, 2019-07-22 at 13:17 +0200, Henrik Dafgård wrote:
>>> > > > Hi all,
>>> > > >
>>> > > > The attached patch is a proposal to fix the somewhat inefficient
>>> > > > Autoboxing
>>> > > > rule. This should provide a ~4x performance increase without changing
>>> > > > the
>>> > > > output of the rule.
>>> > > >
>>> > > >
>>> > > > Cheers,
>>> > > > Henrik Dafgård
>>> > >
>>> > > I think your attachment got missed or scrubbed.
>>> > >
>>> > > --
>>> > > Andrew Azores
>>> > > Software Engineer, OpenJDK Team
>>> > > Red Hat
>>> > >
>>> > >