Cannot build JMC

[Mario Torre]

On Mon, Jun 3, 2019 at 7:14 PM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> That depends. The plan is to resolve where to host update sites etc
> for 7.1.0, so perhaps this not being back-ported to 7.0.0 is
> acceptable. Oracle will be fine either way. You guys (Red Hat) exclude
> it anyways. It would be if Azul needs this backport. Anyone from Azul
> having a strong opinion on this?

I'm fine with not backporting it, but we need to think about upstream
first not what Red Hat or Oracle does in their builds. JavaFX at
runtime is not a given so we need to be sure things only get compiled
when it's present, when the plugin is specifically requested (or it
wouldn't be optional) and in this case if the maven build can access
the OpenJFX distribution via maven central and this can be used at
runtime when building from sources directly from upstream.

Cheers,
Mario

> Kind regards,
> Marcus
>
> On Mon, Jun 3, 2019 at 6:52 PM Jie Kang <jkang at redhat.com> wrote:
> >
> > Hi Marcus,
> >
> > I recall contribution of JMC-6370 [1] to allow building with OpenJDK 8
> > without OpenJFX. My search shows that this was not backported to
> > jmc/jmc7. I'm sorry to have missed this; in Fedora/RHEL, we currently
> > remove all usages of OpenJFX, even the JOverflow plugin itself, when
> > building.
> >
> > * I will setup a system to verify the situation with jmc/jmc7 repo and
> > OpenJDK 8 and see if a backport would fix the issue. In the event that
> > this does, would you like to see a backport request of JMC-6370 from
> > me to jmc/jmc7?
> > * I will also test building JOverflow with OpenJDK 8 not including
> > JavaFX to verify the p2 work that was done in jmc/jmc.
> >
> > [1]
> > https://bugs.openjdk.java.net/browse/JMC-6370
> > http://hg.openjdk.java.net/jmc/jmc/rev/1a1a3bc8115b
> >
> >
> > Apologies,
> >
> > On Mon, Jun 3, 2019 at 9:30 AM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> > >
> > > The idea is that it should still be possible to build JOverflow with a
> > > JDK 8 not including JavaFX. The javafx packages should be downloaded
> > > from Maven Central by default and exposed through the local p2
> > > repositiory. JOverflow is a pretty useful tool. Unless the patch Jie
> > > has actually builds JOverflow, I think a closer look is warranted.
> > >
> > > Kind regards,
> > > Marcus
> > >
> > > On Mon, Jun 3, 2019 at 3:21 PM Mario Torre <neugens at redhat.com> wrote:
> > > >
> > > > To be fair, I also thought this was the case already, I remember Jie
> > > > proposing a patch, but I may confuse with what we have in our
> > > > downstream RPM (or maybe we just pushed the patch to 7.x and not to
> > > > the 7.0 branch).
> > > >
> > > > Can you please assign this bug to Jie I think he may be able to
> > > > backport the RPM patch into upstream.
> > > >
> > > > Cheers,
> > > > Mario
> > > >
> > > > On Mon, Jun 3, 2019 at 2:11 PM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> > > > >
> > > > > The JavaFX bits are used by optional plug-ins, and they should be
> > > > > downloaded from maven central when required. It should be possible to
> > > > > build JMC without having JavaFX linked into the JDK. I actually
> > > > > thought this was already the case. I will open an Issue.
> > > > >
> > > > > Kind regards,
> > > > > Marcus
> > > > >
> > > > > On Mon, Jun 3, 2019 at 11:43 AM Mario Torre <neugens at redhat.com> wrote:
> > > > > >
> > > > > > What system are you on?
> > > > > >
> > > > > > On RHEL 8 (and 7) for example there's no bundled JFX, while there is
> > > > > > on Fedora. So if you are using a system where no JFX is present (any
> > > > > > build of OpenJDK and any Oracle JDK since 11) then you either need to
> > > > > > install it or patch the JFX bits out.
> > > > > >
> > > > > > I think the JFX bits should be optional on JMC but we're not there yet.
> > > > > >
> > > > > > Cheers,
> > > > > > Mario
> > > > > >
> > > > > > On Mon, Jun 3, 2019 at 11:34 AM Simone Bordet <simone.bordet at gmail.com> wrote:
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > JMC 7.0.0-ga.
> > > > > > >
> > > > > > > I'm following what's in the README and the build fails for me at the
> > > > > > > "mvn package" command from the JMC root directory:
> > > > > > >
> > > > > > > [ERROR] Failed to execute goal
> > > > > > > org.eclipse.tycho:tycho-compiler-plugin:1.4.0:compile
> > > > > > > (default-compile) on project org.openjdk.jmc.javafx.osgi: Compilation
> > > > > > > failure: Compilation failure:
> > > > > > > [ERROR] /home/simon/opensource/openjdk/jmc7/application/org.openjdk.jmc.javafx.osgi/src/main/java/org/openjdk/jmc/javafx/osgi/FXToolkit.java:[42]
> > > > > > > [ERROR] import javafx.application.Platform;
> > > > > > > [ERROR]        ^^^^^^
> > > > > > >
> > > > > > > There are other 20 errors similar to this one.
> > > > > > >
> > > > > > > Ideas?
> > > > > > >
> > > > > > > Thanks!
> > > > > > >
> > > > > > > --
> > > > > > > Simone Bordet
> > > > > > > ---
> > > > > > > Finally, no matter how good the architecture and design are,
> > > > > > > to deliver bug-free software with optimal performance and reliability,
> > > > > > > the implementation technique must be flawless.   Victoria Livschitz
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Mario Torre
> > > > > > Associate Manager, Software Engineering
> > > > > > Red Hat GmbH <https://www.redhat.com>
> > > > > > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> > > >
> > > >
> > > >
> > > > --
> > > > Mario Torre
> > > > Associate Manager, Software Engineering
> > > > Red Hat GmbH <https://www.redhat.com>
> > > > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898