[PATCH] JMC-6485 *.jfc" file extension set as default on Open File

[Alex Macdonald]

Hi Jessye,

On Thu, May 23, 2019 at 1:58 PM Jessye Coleman Shapiro <jescolem at redhat.com>
wrote:

> On Thu, May 23, 2019 at 12:10 PM Jessye Coleman Shapiro <
> jescolem at redhat.com>
> wrote:
>
> > Hello,
> >
> > This patch fixes the JMC-6485 bug where file extensions in the Open File
> > pop-up were being set to ".jfc" instead of "*"  by default [0].  This was
> > an eclipse FileDialog bug and was fixed in the Eclipse 4.10 release in
> > December 2018 [1].  This patch reverts the JMC-6151 workaround [2] that
> was
> > created for this FileDialog bug and was mentioned in JMC-6171 [3].
> >
>

This looks good to me.


> > See the attached patch bellow.
>

It's not a concern at the moment (and doesn't require a new patch IMO), but
when you go to export the patch make sure to change the header title from
JMC-6151 to JMC-6171.


> >
> > Thank you!
> >
> > [0] https://bugs.openjdk.java.net/browse/JMC-6485
> > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=540164
> > [2] https://bugs.openjdk.java.net/browse/JMC-6151
> > [3] https://bugs.openjdk.java.net/browse/JMC-6171
> >
> >
> >
> To clarify, this patch addresses JMC-6171 with comment to revert JMC-6151
> and it does not fix JMC-6485, though it is related.
>
> Sorry if there was any confusion.
>
> Jessye
>

Cheers,

Alex