JMC-5368: Clear Stacktrace View when editor is closed

Henrik Dafgård hdafgard at gmail.com
Wed Jun 5 14:54:27 UTC 2019


Looks good to me as well, the only note I'd give is that if we're strictly
following the formatting style the "else if" statement should not be on a
new line.


Cheers,
Henrik Dafgård


On Wed, 5 Jun 2019 at 13:32, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:

> LGTM! :)
>
> Kind regards,
> Marcus
>
> On Tue, Jun 4, 2019 at 10:44 PM Ken Dobson <kdobson at redhat.com> wrote:
>
> > Here's a small patch that clears the stacktrace view when all JfrEditors
> > are closed rather than persisting the most recent stacktrace.
> >
> > Bug ID: https://bugs.openjdk.java.net/browse/JMC-5368
> > Webrev: http://cr.openjdk.java.net/~kdobson/JMC-5368/webrev/
> >
> > Thanks,
> >
> > Ken Dobson
> >
>


More information about the jmc-dev mailing list