[PATCH] JMC-5499 Add XFlagChanged events to JVM Information or subpage

[Jessye Coleman Shapiro]

Hi Alex,

I will make those changes and send an updated patch.

Thank you!

Jessye

On Wed, Jun 19, 2019 at 3:45 PM Alex Macdonald <almacdon at redhat.com> wrote:

> Hi Jessye,
>
> On Fri, Jun 7, 2019 at 2:48 PM Jessye Coleman Shapiro <jescolem at redhat.com>
> wrote:
>
>> Hi,
>>
>> This patch addresses JMC-5499: Add XFlagChanged events to JVM Information
>> or subpage [0].  I have added a JVM Flags Log table to the JVM Internals
>> Page that displays XFlagChanged events.
>>
>> Please see the attached patch and let me know what you think.
>>
>
> The content of this patch look good to me.
>
> However, there are test failures:
>
> > TestRulesWithJfr.verifyAllResults:132->verifyRuleResults:159
>
> because the generated JfrRuleBaseline.xml doesn't match the hardcopy one
> used to verify the test. This will need to be updated.
>
> There's also some empty spaces that can be cleaned up.
>
> JavaBlockingRule.java
> - empty space @ lines 134, 138, 151
> - trailing empty space @ line 142
>
>
>>
>> Thank you!
>>
>> Jessye Coleman-Shapiro
>>
>>  [0] https://bugs.openjdk.java.net/browse/JMC-5499
>
>
> Cheers,
>
> Alex
>