Review request for JMC-6492: Add unit support for jdk.jfr.Frequency

[Jie Kang]

On Wed, Jun 5, 2019 at 9:52 AM Alex Macdonald <almacdon at redhat.com> wrote:
>
> Hi Jie,
>
> On Wed, May 29, 2019 at 9:36 AM Jie Kang <jkang at redhat.com> wrote:
>>
>> Hi,
>>
>> The attached patch adds a case for contentType "hertz",  annotation
>> "jdk.jfr.Frequency" used in JFR events like CPUTimeStampCounter, to
>> use the Hertz unit introduced in JMC-5768.
>>
>> The following is a before and after image for the event browser for
>> CPUTimeStampCounter
>> https://imgur.com/a/cSVlmOM
>>
>> How does it look?
>
>
> This looks good to me.
>
> Just a note from playing around with the patch, CPUTimeStampCounter was updated in changeset 2cf5bec8d8ba [0] to use hertz instead of frequency per second. As a result, older recordings will still show their numerical value as per their jfr file, but newer recordings will now correctly use the hz unit.

Thanks. Any chance this could get another review? It's a tiny patch.


Regards,

>
>>
>>
>>
>> Regards,
>
>
> Cheers,
>
> Alex
>
> [0] http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/2cf5bec8d8ba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jmc-6492.patch
Type: text/x-patch
Size: 1377 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/jmc-dev/attachments/20190625/a9b6eb55/jmc-6492.patch>