From yasuenag at gmail.com Fri Mar 1 02:47:10 2019 From: yasuenag at gmail.com (Yasumasa Suenaga) Date: Fri, 1 Mar 2019 11:47:10 +0900 Subject: Question about JMC 7 release Message-ID: Hi. I have two question about JMC 7 release. 1. When is JMC 7 GA released? 2. When can I get JMC 7 EA from jdk.java.net? If you have updates about them, please share me. Thanks, Yasumasa From prem.balakrishnan at oracle.com Fri Mar 1 05:39:19 2019 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Thu, 28 Feb 2019 21:39:19 -0800 (PST) Subject: Review Request[7] JMC-6283 Update Javamail api and its dependencies Message-ID: <51daa632-99e6-42c9-8c94-58f769368d09@default> Hi All, Please review the patch for JMC7.0 Bug: https://bugs.openjdk.java.net/browse/JMC-6283 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6283/webrev.00/ Earlier we had reverted the fix for bug https://bugs.openjdk.java.net/browse/JMC-6217 "Update mail.api and its dependencies". Now we have all the necessary third-party approvals, re-submitting the patch for review. Regards, Prem From guru.hb at oracle.com Fri Mar 1 06:55:45 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 1 Mar 2019 12:25:45 +0530 Subject: Review Request[7] JMC-6283 Update Javamail api and its dependencies In-Reply-To: <51daa632-99e6-42c9-8c94-58f769368d09@default> References: <51daa632-99e6-42c9-8c94-58f769368d09@default> Message-ID: <0B8F3E3D-FA43-44DD-B0A3-5AFCB2927B61@oracle.com> +1 I have verified your fix applying to "http://hg.openjdk.java.net/jmc/jmc? rather than "http://hg.openjdk.java.net/jmc/jmc7? as you have created webrev based on jmc7 repo. Please commit the changes to "http://hg.openjdk.java.net/jmc/jmc? repo and I will do the auto backport using hg merge. Merging changes from jmc7 to jmc is bit clumsy , where as the other way is cleaner and simpler. Thanks, Guru > On 01-Mar-2019, at 11:09 AM, Prem Balakrishnan wrote: > > Hi All, > > > > Please review the patch for JMC7.0 > > Bug: https://bugs.openjdk.java.net/browse/JMC-6283 > > Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6283/webrev.00/ > > > > Earlier we had reverted the fix for bug https://bugs.openjdk.java.net/browse/JMC-6217 "Update mail.api and its dependencies". > > Now we have all the necessary third-party approvals, re-submitting the patch for review. > > > > Regards, > > Prem From marcus at hirt.se Fri Mar 1 08:36:10 2019 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 1 Mar 2019 09:36:10 +0100 Subject: SV: Review Request[7] JMC-6283 Update Javamail api and its dependencies In-Reply-To: <51daa632-99e6-42c9-8c94-58f769368d09@default> References: <51daa632-99e6-42c9-8c94-58f769368d09@default> Message-ID: <004b01d4d009$d2bf9140$783eb3c0$@hirt.se> Looks good Prem! /M -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Prem Balakrishnan Skickat: den 1 mars 2019 06:39 Till: jmc-dev at openjdk.java.net ?mne: Review Request[7] JMC-6283 Update Javamail api and its dependencies Hi All, Please review the patch for JMC7.0 Bug: https://bugs.openjdk.java.net/browse/JMC-6283 Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6283/webrev.00/ Earlier we had reverted the fix for bug https://bugs.openjdk.java.net/browse/JMC-6217 "Update mail.api and its dependencies". Now we have all the necessary third-party approvals, re-submitting the patch for review. Regards, Prem From marcus at hirt.se Fri Mar 1 09:15:02 2019 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 1 Mar 2019 10:15:02 +0100 Subject: JMC related slack Message-ID: <009301d4d00f$40784e20$c168ea60$@hirt.se> Hi all, Given recent experiences with trying to shoot off messages asynchronously to various people over IRC, I've decided to set up a JMC related slack. Anyone interested in JMC is welcome to join! Here is an invite link (valid for a week): https://join.slack.com/t/jdkmissioncontrol/shared_invite/enQtNTYzODIyMTU3MDg5L WMzMWQwODAyZWQxZWU1NzQ0ZTNkZWUxZDI3ZmY1YWMzOWQ1OGIwNDRhZjcyNTNjMGI1Zjc0NGM3NTc zZmJjNTg If you miss the window, simply ask me for an invite! Kind regards, Marcus From neugens at redhat.com Fri Mar 1 11:59:51 2019 From: neugens at redhat.com (Mario Torre) Date: Fri, 01 Mar 2019 12:59:51 +0100 Subject: JMC related slack In-Reply-To: <009301d4d00f$40784e20$c168ea60$@hirt.se> References: <009301d4d00f$40784e20$c168ea60$@hirt.se> Message-ID: <6fca2e70f43b2a8963155f1c4d804741c7a56a19.camel@redhat.com> On Fri, 2019-03-01 at 10:15 +0100, Marcus Hirt wrote: > Hi all, > > Given recent experiences with trying to shoot off messages > asynchronously > to various people over IRC, I've decided to set up a JMC related > slack. > > Anyone interested in JMC is welcome to join! > > Here is an invite link (valid for a week): > https://join.slack.com/t/jdkmissioncontrol/shared_invite/enQtNTYzODIyMTU3MDg5L > WMzMWQwODAyZWQxZWU1NzQ0ZTNkZWUxZDI3ZmY1YWMzOWQ1OGIwNDRhZjcyNTNjMGI1Zj > c0NGM3NTc > zZmJjNTg > > If you miss the window, simply ask me for an invite! > > Kind regards, > Marcus Are we moving away from IRC? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus at hirt.se Fri Mar 1 16:57:36 2019 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 1 Mar 2019 17:57:36 +0100 Subject: SV: JMC related slack In-Reply-To: <6fca2e70f43b2a8963155f1c4d804741c7a56a19.camel@redhat.com> References: <009301d4d00f$40784e20$c168ea60$@hirt.se> <6fca2e70f43b2a8963155f1c4d804741c7a56a19.camel@redhat.com> Message-ID: <005801d4d04f$df6ea070$9e4be150$@hirt.se> Hi Mario, IRC will remain as one of several communication channels. This is just another alternative for those who wish to use it. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: Mario Torre Skickat: den 1 mars 2019 13:00 Till: Marcus Hirt ; jmc-dev at openjdk.java.net ?mne: Re: JMC related slack On Fri, 2019-03-01 at 10:15 +0100, Marcus Hirt wrote: > Hi all, > > Given recent experiences with trying to shoot off messages > asynchronously to various people over IRC, I've decided to set up a > JMC related slack. > > Anyone interested in JMC is welcome to join! > > Here is an invite link (valid for a week): > https://join.slack.com/t/jdkmissioncontrol/shared_invite/enQtNTYzODIyMTU3MDg5L > WMzMWQwODAyZWQxZWU1NzQ0ZTNkZWUxZDI3ZmY1YWMzOWQ1OGIwNDRhZjcyNTNjMGI1Zj > c0NGM3NTc > zZmJjNTg > > If you miss the window, simply ask me for an invite! > > Kind regards, > Marcus Are we moving away from IRC? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From neugens at redhat.com Fri Mar 1 17:02:24 2019 From: neugens at redhat.com (Mario Torre) Date: Fri, 1 Mar 2019 18:02:24 +0100 Subject: JMC related slack In-Reply-To: <005801d4d04f$df6ea070$9e4be150$@hirt.se> References: <009301d4d00f$40784e20$c168ea60$@hirt.se> <6fca2e70f43b2a8963155f1c4d804741c7a56a19.camel@redhat.com> <005801d4d04f$df6ea070$9e4be150$@hirt.se> Message-ID: On Fri, Mar 1, 2019 at 5:57 PM Marcus Hirt wrote: > > Hi Mario, > > IRC will remain as one of several communication channels. > This is just another alternative for those who wish to use it. Hi Marcus, But alternative means that messages there will be lost if you only use IRC, I think we should either have a relay (between both channels) or pick a side? Otherwise we risk fragmenting the communication channels and this isn't good I think. Cheers, Mario > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: Mario Torre > Skickat: den 1 mars 2019 13:00 > Till: Marcus Hirt ; jmc-dev at openjdk.java.net > ?mne: Re: JMC related slack > > On Fri, 2019-03-01 at 10:15 +0100, Marcus Hirt wrote: > > Hi all, > > > > Given recent experiences with trying to shoot off messages > > asynchronously to various people over IRC, I've decided to set up a > > JMC related slack. > > > > Anyone interested in JMC is welcome to join! > > > > Here is an invite link (valid for a week): > > > https://join.slack.com/t/jdkmissioncontrol/shared_invite/enQtNTYzODIyMTU3MDg5L > > WMzMWQwODAyZWQxZWU1NzQ0ZTNkZWUxZDI3ZmY1YWMzOWQ1OGIwNDRhZjcyNTNjMGI1Zj > > c0NGM3NTc > > zZmJjNTg > > > > If you miss the window, simply ask me for an invite! > > > > Kind regards, > > Marcus > > Are we moving away from IRC? > > Cheers, > Mario > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus at hirt.se Sat Mar 2 12:32:17 2019 From: marcus at hirt.se (Marcus Hirt) Date: Sat, 2 Mar 2019 13:32:17 +0100 Subject: SV: JMC related slack In-Reply-To: References: <009301d4d00f$40784e20$c168ea60$@hirt.se> <6fca2e70f43b2a8963155f1c4d804741c7a56a19.camel@redhat.com> <005801d4d04f$df6ea070$9e4be150$@hirt.se> Message-ID: <01d601d4d0f3$f92949d0$eb7bdd70$@hirt.se> Hi Mario, Messages are lost all the time with IRC, as you only see messages if you're logged in, unless you use Matrix/Riot or some custom agent solution. I agree there is a risk for communication fragmentation, but the high priority communication should be happening on the mailing list anyways. I think Slack brings benefits: 1. Easy to join. 2. Easy to thread conversations. 3. Easy to share content. 4. Easy to add additional channels and group up as needed. 5. Some persistence, giving people a chance to catch up even after being off-line. We could probably gain similar benefits using e.g. Gitter or other solutions, but many people probably have some Slack workspaces in their life already. It would be great to have an IRC/Slack channel relay set up for the Slack though. I see that there are several solutions, for example: https://github.com/ekmartin/slack-irc If someone feel like setting one up, it would be great! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: Mario Torre Skickat: den 1 mars 2019 18:02 Till: Marcus Hirt Kopia: jmc-dev at openjdk.java.net ?mne: Re: JMC related slack On Fri, Mar 1, 2019 at 5:57 PM Marcus Hirt wrote: > > Hi Mario, > > IRC will remain as one of several communication channels. > This is just another alternative for those who wish to use it. Hi Marcus, But alternative means that messages there will be lost if you only use IRC, I think we should either have a relay (between both channels) or pick a side? Otherwise we risk fragmenting the communication channels and this isn't good I think. Cheers, Mario > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: Mario Torre > Skickat: den 1 mars 2019 13:00 > Till: Marcus Hirt ; jmc-dev at openjdk.java.net > ?mne: Re: JMC related slack > > On Fri, 2019-03-01 at 10:15 +0100, Marcus Hirt wrote: > > Hi all, > > > > Given recent experiences with trying to shoot off messages > > asynchronously to various people over IRC, I've decided to set up a > > JMC related slack. > > > > Anyone interested in JMC is welcome to join! > > > > Here is an invite link (valid for a week): > > > https://join.slack.com/t/jdkmissioncontrol/shared_invite/enQtNTYzODIyM > TU3MDg5L > > WMzMWQwODAyZWQxZWU1NzQ0ZTNkZWUxZDI3ZmY1YWMzOWQ1OGIwNDRhZjcyNTNjMGI1Z > > j > > c0NGM3NTc > > zZmJjNTg > > > > If you miss the window, simply ask me for an invite! > > > > Kind regards, > > Marcus > > Are we moving away from IRC? > > Cheers, > Mario > > -- > Mario Torre > Associate Manager, Software Engineering Red Hat GmbH > > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From guru.hb at oracle.com Mon Mar 4 04:45:04 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 4 Mar 2019 10:15:04 +0530 Subject: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 Message-ID: Hi, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6422 webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ Thanks, Guru From guru.hb at oracle.com Mon Mar 4 06:22:17 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Mon, 04 Mar 2019 06:22:17 +0000 Subject: hg: jmc/jmc: JMC-6283: Update Javamail api and its dependencies Message-ID: <201903040622.x246MHZg023190@aojmv0008.oracle.com> Changeset: 8115549a88aa Author: ghb Date: 2019-03-04 11:52 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/8115549a88aa JMC-6283: Update Javamail api and its dependencies Reviewed-by: hirt, ghb ! application/org.openjdk.jmc.feature.core/feature.xml ! releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From guru.hb at oracle.com Mon Mar 4 06:26:09 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Mon, 04 Mar 2019 06:26:09 +0000 Subject: hg: jmc/jmc7: JMC-6283: Update Javamail api and its dependencies Message-ID: <201903040626.x246Q9JX024453@aojmv0008.oracle.com> Changeset: 89d6cf9d3a7e Author: ghb Date: 2019-03-04 11:52 +0530 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/89d6cf9d3a7e JMC-6283: Update Javamail api and its dependencies Reviewed-by: hirt, ghb ! application/org.openjdk.jmc.feature.core/feature.xml ! releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From guru.hb at oracle.com Mon Mar 4 06:33:01 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 4 Mar 2019 12:03:01 +0530 Subject: Contributed-by: missed for commit message to JMC-6283 Message-ID: <0737CA26-1929-441E-8C66-6E14F50F6F8E@oracle.com> Hi Marcus & Prem, While committing the changes to JMC-6283, I have missed ?Contributed-by? field in the commit message. This will impact Prem?s fix count. Will be cautious for future commits and Please keep note of this Fixed (Contributed-by) by Prem For future ref. Thanks, Guru From praveen.s.srivastava at oracle.com Mon Mar 4 14:25:41 2019 From: praveen.s.srivastava at oracle.com (Praveen Srivastava) Date: Mon, 4 Mar 2019 06:25:41 -0800 (PST) Subject: Question about JMC 7 release In-Reply-To: References: Message-ID: <33159de6-7ff8-4733-a8f5-61ec23026392@default> Hi Yasumasa, We at Oracle, are working to get the EA back online in the next few weeks. Once that is done we expect to have a proposed GA date Regards Praveen -----Original Message----- From: Yasumasa Suenaga Sent: Friday, March 01, 2019 8:17 AM To: jmc-dev at openjdk.java.net Cc: ?? ?? Subject: Question about JMC 7 release Hi. I have two question about JMC 7 release. 1. When is JMC 7 GA released? 2. When can I get JMC 7 EA from jdk.java.net? If you have updates about them, please share me. Thanks, Yasumasa From kdobson at redhat.com Mon Mar 4 17:20:55 2019 From: kdobson at redhat.com (Ken Dobson) Date: Mon, 4 Mar 2019 12:20:55 -0500 Subject: JMC-4645: Size Distribution charts for I/O pages Message-ID: Hi all, I have a patch that adds charts to the File and Socket I/O pages that provide the distribution of I/O events by size for https://bugs.openjdk.java.net/projects/JMC/issues/JMC-4645 . It currently has one issue with adding to the selection store. Currently I can only store either *_BYTES_WRITTEN or *_BYTES_READ but not both, it seems as if we would ideally need some sort of JfrAttributes.SIZE to address this but I'm not sure how to go about that or whether that's possible. This issue can be found at SocketIOPage.java:286 and FileIOPage.java:389. If anybody has any suggestions regarding how to deal with it that would be great. The patch can be found here: http://cr.openjdk.java.net/~kdobson/JMC-4645/webrev/ Thanks, Ken Dobson From ebaron at redhat.com Tue Mar 5 00:29:51 2019 From: ebaron at redhat.com (Elliott Baron) Date: Mon, 4 Mar 2019 19:29:51 -0500 Subject: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences In-Reply-To: <3d5b453f-07f8-97b9-0816-b60e73561305@redhat.com> References: <28a559c2-7858-896b-449c-4f1fe281f536@redhat.com> <3d5b453f-07f8-97b9-0816-b60e73561305@redhat.com> Message-ID: Hi, On 2019-02-27 5:56 p.m., Elliott Baron wrote: > Hi, > > On 2019-01-29 6:07 p.m., Elliott Baron wrote: >> Hi, >> >> This patch fixes the JMX Console->Communication preference page to >> properly restore the username and password fields to their (blank) >> defaults when the user selects "Restore Defaults". >> >> I added a UI test to ensure Restore Defaults works as expected for the >> Communication page as a whole. I created a new test class since there >> didn't seem to be an existing one that was a good fit. I had to add a >> getText method to MCDialog to get the text entered into the fields in >> the preference page. There are new x-friends directives for >> org.openjdk.jmc.rjmx.preferences and >> org.openjdk.jmc.console.ui.messages.internal to expose some constants >> used by the test. >> >> The copyright header for the new test class may need some adjusting. >> Are we updating copyright year for source files, and should we name >> the author/author's employer in the copyright header for new source >> files originating outside of Oracle? >> > > Has there been any decision on the format of such copyright headers? For > example, here is what I am using for both this patch and one for JMC-5768: >> --- /dev/null??? 2018-12-23 13:34:55.064999798 -0500 >> +++ >> new/application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java >> 2019-02-26 10:14:30.249352786 -0500 >> @@ -0,0 +1,98 @@ >> +/* >> + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 2019, Red Hat Inc. All rights reserved. > Marcus has informed me off-list that the above copyright header format is acceptable going forward. I do still need a review for the content of this fix. Would someone be able to take a look? Thanks, Elliott -------------- next part -------------- A non-text attachment was scrubbed... Name: jmc-6211-v2.patch Type: text/x-patch Size: 15311 bytes Desc: not available URL: From neugens at redhat.com Tue Mar 5 14:16:05 2019 From: neugens at redhat.com (Mario Torre) Date: Tue, 05 Mar 2019 15:16:05 +0100 Subject: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences In-Reply-To: References: <28a559c2-7858-896b-449c-4f1fe281f536@redhat.com> <3d5b453f-07f8-97b9-0816-b60e73561305@redhat.com> Message-ID: On Mon, 2019-03-04 at 19:29 -0500, Elliott Baron wrote: > > Marcus has informed me off-list that the above copyright header > format > is acceptable going forward. > > I do still need a review for the content of this fix. Would someone > be > able to take a look? Hi Elliott, The patch looks good to me, I would like to have the opinion of an official reviewer however before you push it. A question on the Manifest. --- a/application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF +++ b/application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF Are those changes in the Manifest really necessary? I take a yes because the ui tests are in a different package that need internal visibility? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From ebaron at redhat.com Tue Mar 5 15:22:47 2019 From: ebaron at redhat.com (Elliott Baron) Date: Tue, 5 Mar 2019 10:22:47 -0500 Subject: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences In-Reply-To: References: <28a559c2-7858-896b-449c-4f1fe281f536@redhat.com> <3d5b453f-07f8-97b9-0816-b60e73561305@redhat.com> Message-ID: Hi Mario, On 2019-03-05 9:16 a.m., Mario Torre wrote: > On Mon, 2019-03-04 at 19:29 -0500, Elliott Baron wrote: >> >> Marcus has informed me off-list that the above copyright header >> format >> is acceptable going forward. >> >> I do still need a review for the content of this fix. Would someone >> be >> able to take a look? > > Hi Elliott, > > The patch looks good to me, I would like to have the opinion of an > official reviewer however before you push it. > > A question on the Manifest. > > --- a/application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF > +++ b/application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF > > Are those changes in the Manifest really necessary? I take a yes > because the ui tests are in a different package that need internal > visibility? > That's correct, the UI tests reside in a different plugin/bundle. Exporting these packages with the x-friends directive means that the UI tests will have access to the package, but any other code will be warned by Eclipse if they try to import the package. These new imports make some String constants available to the test. We could duplicate the constants in the test, but then if they are changed in the main code, the test copies would also need to be changed or the test will break. There's also one localized String imported by the test, which would be harder to work around. Thanks, Elliott From guru.hb at oracle.com Wed Mar 6 01:53:31 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Wed, 06 Mar 2019 01:53:31 +0000 Subject: hg: jmc/jmc7: JMC-6412: Updating about box to support more flexible versioning Message-ID: <201903060153.x261rVHn014718@aojmv0008.oracle.com> Changeset: 92dcb74cb29b Author: hirt Date: 2019-02-28 22:09 +0100 URL: http://hg.openjdk.java.net/jmc/jmc7/rev/92dcb74cb29b JMC-6412: Updating about box to support more flexible versioning Reviewed-by: ghb ! application/l10n/org.openjdk.jmc.rcp.application.ja/plugin_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/plugin_zh_CN.properties ! application/org.openjdk.jmc.rcp.application/plugin.properties ! application/org.openjdk.jmc.rcp.application/src/main/resources/about.mappings ! pom.xml From marcus at hirt.se Thu Mar 14 01:09:03 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 14 Mar 2019 02:09:03 +0100 Subject: SV: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences In-Reply-To: References: <28a559c2-7858-896b-449c-4f1fe281f536@redhat.com> <3d5b453f-07f8-97b9-0816-b60e73561305@redhat.com> Message-ID: <14ef501d4da02$83a8e220$8afaa660$@hirt.se> Looks good Elliott! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Elliott Baron Skickat: den 5 mars 2019 01:30 Till: jmc-dev at openjdk.java.net ?mne: Re: RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences Hi, On 2019-02-27 5:56 p.m., Elliott Baron wrote: > Hi, > > On 2019-01-29 6:07 p.m., Elliott Baron wrote: >> Hi, >> >> This patch fixes the JMX Console->Communication preference page to >> properly restore the username and password fields to their (blank) >> defaults when the user selects "Restore Defaults". >> >> I added a UI test to ensure Restore Defaults works as expected for >> the Communication page as a whole. I created a new test class since >> there didn't seem to be an existing one that was a good fit. I had to >> add a getText method to MCDialog to get the text entered into the >> fields in the preference page. There are new x-friends directives for >> org.openjdk.jmc.rjmx.preferences and >> org.openjdk.jmc.console.ui.messages.internal to expose some constants >> used by the test. >> >> The copyright header for the new test class may need some adjusting. >> Are we updating copyright year for source files, and should we name >> the author/author's employer in the copyright header for new source >> files originating outside of Oracle? >> > > Has there been any decision on the format of such copyright headers? > For example, here is what I am using for both this patch and one for JMC-5768: >> --- /dev/null 2018-12-23 13:34:55.064999798 -0500 >> +++ >> new/application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java >> 2019-02-26 10:14:30.249352786 -0500 >> @@ -0,0 +1,98 @@ >> +/* >> + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All >> +rights >> reserved. >> + * Copyright (c) 2019, Red Hat Inc. All rights reserved. > Marcus has informed me off-list that the above copyright header format is acceptable going forward. I do still need a review for the content of this fix. Would someone be able to take a look? Thanks, Elliott From jmatsuok at redhat.com Mon Mar 18 19:11:13 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Mon, 18 Mar 2019 19:11:13 +0000 Subject: hg: jmc/jmc: JMC-5768: Add frequency (Hz) support in UnitLookup Message-ID: <201903181911.x2IJBDM6019544@aojmv0008.oracle.com> Changeset: e290828d0636 Author: jmatsuoka Date: 2019-03-18 15:10 -0400 URL: http://hg.openjdk.java.net/jmc/jmc/rev/e290828d0636 JMC-5768: Add frequency (Hz) support in UnitLookup Summary: Create Frequency KindOfQuantity and Hertz Unit in UnitLookup, and change JfxPulseDurationRule to use Hertz for its target frame rate. Reviewed-by: hdafgard Contributed-by: Elliott Baron ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages.properties ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages_ja.properties ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages_zh_CN.properties + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/.classpath + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/.project + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/META-INF/MANIFEST.MF + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/build.properties + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/pom.xml + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/resources/jfr/pulseduration.jfr ! application/tests/pom.xml ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/UnitLookup.java ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_zh_CN.properties ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/DeriveUnitTest.java From guru.hb at oracle.com Wed Mar 20 17:03:23 2019 From: guru.hb at oracle.com (Guru) Date: Wed, 20 Mar 2019 22:33:23 +0530 Subject: Review request: JMC-6434: common.test fails with error Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter Message-ID: <26ECF271-8D9B-4DC1-A7F0-DBCD2D712CE5@oracle.com> Hi All, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6434 webrev : http://cr.openjdk.java.net/~ghb/JMC-6434/webrev.0/ Solution and RC updated in JBS. Note: This only happens in Ubuntu 16.04 in our Hudson build environment. Thanks, Guru From marcus at hirt.se Wed Mar 20 18:01:45 2019 From: marcus at hirt.se (Marcus Hirt) Date: Wed, 20 Mar 2019 19:01:45 +0100 Subject: SV: Review request: JMC-6434: common.test fails with error Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter In-Reply-To: <26ECF271-8D9B-4DC1-A7F0-DBCD2D712CE5@oracle.com> References: <26ECF271-8D9B-4DC1-A7F0-DBCD2D712CE5@oracle.com> Message-ID: <9a4001d4df46$fb20e9d0$f162bd70$@hirt.se> Looks fine! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Guru Skickat: den 20 mars 2019 18:03 Till: jmc-dev at openjdk.java.net Kopia: Marcus Hirt ?mne: Review request: JMC-6434: common.test fails with error Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter Hi All, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JMC-6434 webrev : http://cr.openjdk.java.net/~ghb/JMC-6434/webrev.0/ Solution and RC updated in JBS. Note: This only happens in Ubuntu 16.04 in our Hudson build environment. Thanks, Guru From guru.hb at oracle.com Wed Mar 20 18:23:18 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Wed, 20 Mar 2019 18:23:18 +0000 Subject: hg: jmc/jmc: JMC-6434: common.test fails with error Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter Message-ID: <201903201823.x2KINIJL022144@aojmv0008.oracle.com> Changeset: 6854d079320a Author: ghb Date: 2019-03-20 23:53 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/6854d079320a JMC-6434: common.test fails with error Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter Reviewed-by: hirt ! core/tests/pom.xml From jmatsuok at redhat.com Thu Mar 21 15:53:27 2019 From: jmatsuok at redhat.com (Joshua Matsuoka) Date: Thu, 21 Mar 2019 11:53:27 -0400 Subject: JMC-4645: Size Distribution charts for I/O pages In-Reply-To: References: Message-ID: Hi Ken, Other than the selection issue which needs to be addressed, the patch looks good to me. Nice work. > It currently has one issue with adding to the selection store. Currently I > can only store either *_BYTES_WRITTEN or *_BYTES_READ but not both, it > seems as if we would ideally need some sort of JfrAttributes.SIZE to > address this but I'm not sure how to go about that or whether that's > possible Such an attribute would belong in JdkAttributes, I'd start by taking a look there if you're looking to add a new SIZE attribute. Cheers, - Josh On Mon, Mar 4, 2019 at 12:21 PM Ken Dobson wrote: > Hi all, > > I have a patch that adds charts to the File and Socket I/O pages that > provide the distribution of I/O events by size for > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-4645 . > > It currently has one issue with adding to the selection store. Currently I > can only store either *_BYTES_WRITTEN or *_BYTES_READ but not both, it > seems as if we would ideally need some sort of JfrAttributes.SIZE to > address this but I'm not sure how to go about that or whether that's > possible. This issue can be found at SocketIOPage.java:286 and > FileIOPage.java:389. If anybody has any suggestions regarding how to deal > with it that would be great. > > The patch can be found here: > http://cr.openjdk.java.net/~kdobson/JMC-4645/webrev/ > > Thanks, > > Ken Dobson > From jkang at redhat.com Thu Mar 21 17:02:54 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 21 Mar 2019 13:02:54 -0400 Subject: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 In-Reply-To: References: Message-ID: Hi, This looks okay to me. I'd like to see it in jmc and jmc7 repos :D Regards, On Sun, Mar 3, 2019 at 11:45 PM Guru wrote: > > Hi, > > Please review the fix for : > JBS : https://bugs.openjdk.java.net/browse/JMC-6422 > webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ > > Thanks, > Guru From guru.hb at oracle.com Thu Mar 21 19:21:13 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 22 Mar 2019 00:51:13 +0530 Subject: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 In-Reply-To: References: Message-ID: Thanks Jie, Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.1/ I had missed updating the ?Copyright text? for both Jaf and Javamail, which I have incorporated the changes in the webrev.1. Please review the fix and update your comments. Thanks, Guru > On 21-Mar-2019, at 10:32 PM, Jie Kang wrote: > > Hi, > > This looks okay to me. I'd like to see it in jmc and jmc7 repos :D > > > Regards, > > On Sun, Mar 3, 2019 at 11:45 PM Guru wrote: >> >> Hi, >> >> Please review the fix for : >> JBS : https://bugs.openjdk.java.net/browse/JMC-6422 >> webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ >> >> Thanks, >> Guru From marcus at hirt.se Thu Mar 21 19:29:09 2019 From: marcus at hirt.se (Marcus Hirt) Date: Thu, 21 Mar 2019 20:29:09 +0100 Subject: SV: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 In-Reply-To: References: Message-ID: <46ee01d4e01c$5b7a12e0$126e38a0$@hirt.se> Looks fine Guru! Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Guru Skickat: den 21 mars 2019 20:21 Till: Jie Kang Kopia: jmc-dev at openjdk.java.net ?mne: Re: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 Thanks Jie, Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.1/ I had missed updating the ?Copyright text? for both Jaf and Javamail, which I have incorporated the changes in the webrev.1. Please review the fix and update your comments. Thanks, Guru > On 21-Mar-2019, at 10:32 PM, Jie Kang wrote: > > Hi, > > This looks okay to me. I'd like to see it in jmc and jmc7 repos :D > > > Regards, > > On Sun, Mar 3, 2019 at 11:45 PM Guru wrote: >> >> Hi, >> >> Please review the fix for : >> JBS : https://bugs.openjdk.java.net/browse/JMC-6422 >> webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ >> >> Thanks, >> Guru From jkang at redhat.com Thu Mar 21 19:43:19 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 21 Mar 2019 15:43:19 -0400 Subject: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 In-Reply-To: <46ee01d4e01c$5b7a12e0$126e38a0$@hirt.se> References: <46ee01d4e01c$5b7a12e0$126e38a0$@hirt.se> Message-ID: Hi, Nice, thanks! From my eye it now matches the license and notices at: https://github.com/eclipse-ee4j/javamail/blob/master/LICENSE.md https://github.com/eclipse-ee4j/javamail/blob/master/NOTICE.md https://github.com/eclipse-ee4j/jaf/blob/master/LICENSE.md https://github.com/eclipse-ee4j/jaf/blob/master/NOTICE.md Regards, On Thu, Mar 21, 2019 at 3:37 PM Marcus Hirt wrote: > > Looks fine Guru! > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Guru > Skickat: den 21 mars 2019 20:21 > Till: Jie Kang > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3 > > Thanks Jie, > > Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.1/ > > I had missed updating the ?Copyright text? for both Jaf and Javamail, which I have incorporated the changes in the webrev.1. > > Please review the fix and update your comments. > > Thanks, > Guru > > On 21-Mar-2019, at 10:32 PM, Jie Kang wrote: > > > > Hi, > > > > This looks okay to me. I'd like to see it in jmc and jmc7 repos :D > > > > > > Regards, > > > > On Sun, Mar 3, 2019 at 11:45 PM Guru wrote: > >> > >> Hi, > >> > >> Please review the fix for : > >> JBS : https://bugs.openjdk.java.net/browse/JMC-6422 > >> webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ > >> > >> Thanks, > >> Guru > > From guru.hb at oracle.com Thu Mar 21 20:41:06 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Thu, 21 Mar 2019 20:41:06 +0000 Subject: hg: jmc/jmc: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 Message-ID: <201903212041.x2LKf61D003901@aojmv0008.oracle.com> Changeset: add86f36862f Author: ghb Date: 2019-03-22 02:10 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/add86f36862f JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 Reviewed-by: hirt , Jie Kang ! license/THIRDPARTYREADME.txt From carusso at redhat.com Tue Mar 26 13:01:53 2019 From: carusso at redhat.com (Carmine Vincenzo Russo) Date: Tue, 26 Mar 2019 14:01:53 +0100 Subject: JMC 5657 - Code Coverage Message-ID: Hello everyone, I'm currently investigating the possibility of using Jcov as Code Coverage Tool for JMC [0]. First of all I wanted to give a try to use JCov and see how it works and interacts with the existing project, but I'm having some difficulties on integrating Jcov in Maven tests. Second, I also wanted to understand how the code coverage has been done until now, and what are the reasons to proceed to Jcov. In the issue there is a reference about JaCoCo but seems like there is no code coverage any more. Therefore if anyone has ever used Jcov or integrated it in JMC I would much appreciate any tip. Also If you can give me some background on how the code coverage was done and about the whole transition from JaCoCo to Jcov, it would be really helpful. Have a nice day, Cheers! Carmine [0] https://bugs.openjdk.java.net/browse/JMC-5657 -- Carmine Vincenzo Russo From klara at kth.se Tue Mar 26 14:50:50 2019 From: klara at kth.se (Klara Ward) Date: Tue, 26 Mar 2019 15:50:50 +0100 Subject: JMC 5657 - Code Coverage In-Reply-To: References: Message-ID: <9ce532b9-d918-53b4-129e-ee9ad4894d0b@kth.se> Hi Carmine, The potential move from jacoco to jcov was suggested when JMC was not open source, and depending more on inhouse Oracle infrastructure. When we moved from the old build infrastructure to open source and Maven, we never added jacoco, so I would suggest changing the jira issue to add jacoco now instead. Regards, Klara, former JMC engineer On 2019-03-26 14:01, Carmine Vincenzo Russo wrote: > Hello everyone, > > I'm currently investigating the possibility of using Jcov as Code Coverage > Tool for JMC [0]. > First of all I wanted to give a try to use JCov and see how it works and > interacts with the existing project, but I'm having some difficulties on > integrating Jcov in Maven tests. > Second, I also wanted to understand how the code coverage has been done > until now, and what are the reasons to proceed to Jcov. > In the issue there is a reference about JaCoCo but seems like there is no > code coverage any more. > > Therefore if anyone has ever used Jcov or integrated it in JMC I would much > appreciate any tip. > Also If you can give me some background on how the code coverage was done > and about the whole transition from JaCoCo to Jcov, it would be really > helpful. > > Have a nice day, > Cheers! > > Carmine > > [0] https://bugs.openjdk.java.net/browse/JMC-5657 > From jmatsuok at redhat.com Tue Mar 26 18:12:04 2019 From: jmatsuok at redhat.com (jmatsuok at redhat.com) Date: Tue, 26 Mar 2019 18:12:04 +0000 Subject: hg: jmc/jmc: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences Message-ID: <201903261812.x2QIC4VE022076@aojmv0008.oracle.com> Changeset: 5b9d72265772 Author: jmatsuoka Date: 2019-03-26 14:11 -0400 URL: http://hg.openjdk.java.net/jmc/jmc/rev/5b9d72265772 JMC-6211: Restore Defaults button doesn't revert username and password in Preferences Summary: Reset mail server user credentials to blank values when reverting to defaults Reviewed-by: hirt Contributed-by: Elliott Baron ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/preferences/CommunicationPage.java ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.console.uitest/META-INF/MANIFEST.MF + application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsolePreferencesTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCDialog.java From kdobson at redhat.com Fri Mar 29 20:06:27 2019 From: kdobson at redhat.com (Ken Dobson) Date: Fri, 29 Mar 2019 16:06:27 -0400 Subject: Review request for JMC-4645: Add size distribution chart to IO Pages Message-ID: Hi all, Please review this patch I've made that adds a size distribution chart to the IO Pages. Bug: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-4645 Webrev: http://cr.openjdk.java.net/~kdobson/sizedistributionchart/webrev/ Thanks, Ken Dobson