JMC-4645: Size Distribution charts for I/O pages

[Joshua Matsuoka]

Hi Ken,

Other than the selection issue which needs to be addressed, the patch looks
good to me. Nice work.

> It currently has one issue with adding to the selection store. Currently I
> can only store either *_BYTES_WRITTEN or *_BYTES_READ but not both, it
> seems as if we would ideally need some sort of JfrAttributes.SIZE to
> address this but I'm not sure how to go about that or whether that's
> possible

Such an attribute would belong in JdkAttributes, I'd start by taking a look
there if you're looking to add a new SIZE attribute.

Cheers,

- Josh

On Mon, Mar 4, 2019 at 12:21 PM Ken Dobson <kdobson at redhat.com> wrote:

> Hi all,
>
> I have a patch that adds charts to the File and Socket I/O pages that
> provide the distribution of I/O events by size for
> https://bugs.openjdk.java.net/projects/JMC/issues/JMC-4645 .
>
> It currently has one issue with adding to the selection store. Currently I
> can only store either *_BYTES_WRITTEN or *_BYTES_READ but not both, it
> seems as if we would ideally need some sort of JfrAttributes.SIZE to
> address this but I'm not sure how to go about that or whether that's
> possible. This issue can be found at SocketIOPage.java:286 and
> FileIOPage.java:389. If anybody has any suggestions regarding how to deal
> with it that would be great.
>
> The patch can be found here:
> http://cr.openjdk.java.net/~kdobson/JMC-4645/webrev/
>
> Thanks,
>
> Ken Dobson
>