Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3

Jie Kang jkang at redhat.com
Thu Mar 21 19:43:19 UTC 2019


Hi,

Nice, thanks! From my eye it now matches the license and notices at:

https://github.com/eclipse-ee4j/javamail/blob/master/LICENSE.md
https://github.com/eclipse-ee4j/javamail/blob/master/NOTICE.md
https://github.com/eclipse-ee4j/jaf/blob/master/LICENSE.md
https://github.com/eclipse-ee4j/jaf/blob/master/NOTICE.md


Regards,

On Thu, Mar 21, 2019 at 3:37 PM Marcus Hirt <marcus at hirt.se> wrote:
>
> Looks fine Guru!
>
> Kind regards,
> Marcus
>
> -----Ursprungligt meddelande-----
> Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Guru
> Skickat: den 21 mars 2019 20:21
> Till: Jie Kang <jkang at redhat.com>
> Kopia: jmc-dev at openjdk.java.net
> Ämne: Re: Review request: JMC-6422: Update JMC7.0 THIRDPARTYREADME with latest javamail 1.6.3 version and JavaBeans Activation Framework 1.2.1 1.6.3
>
> Thanks Jie,
>
> Updated webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.1/ <http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.1/>
>
> I had missed updating the “Copyright text” for both Jaf and Javamail, which I have incorporated the changes in the webrev.1.
>
> Please review the fix and update your comments.
>
> Thanks,
> Guru
> > On 21-Mar-2019, at 10:32 PM, Jie Kang <jkang at redhat.com> wrote:
> >
> > Hi,
> >
> > This looks okay to me. I'd like to see it in jmc and jmc7 repos :D
> >
> >
> > Regards,
> >
> > On Sun, Mar 3, 2019 at 11:45 PM Guru <guru.hb at oracle.com> wrote:
> >>
> >> Hi,
> >>
> >> Please review the fix for :
> >> JBS : https://bugs.openjdk.java.net/browse/JMC-6422 <https://bugs.openjdk.java.net/browse/JMC-6422>
> >> webrev : http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/ <http://cr.openjdk.java.net/~ghb/JMC-6422/webrev.0/>
> >>
> >> Thanks,
> >> Guru
>
>


More information about the jmc-dev mailing list