hg: jmc/jmc: JMC-6274: Add Eclipse 2018-12 and 2019-03 target platforms

[Alex Macdonald]

Hi,

This commit appears to have introduced a source of failure when running
uitests. To verify I had Travis run UI tests on the changeset before [0]
and after [1] the application of this patch.

The error occurs when the PluginTest [2] tries to retrieve the tab folders
for the Installation Dialog - which occurs in MCInstallation [3]. A commit
to Platform UI [4] changed the type of tabbed folders from TabFolder to
CTabFolder, which causes a NPE because Jemmy tries to lookup the TabFolder
[3]. I've put together a quick patch (
http://cr.openjdk.java.net/~aptmac/JMC-6274/webrev.00/) [5] that updates
MCInstallation to look for CTabFolder. To confirm, I've applied the patch
to a branch and had Travis run uitests on it [6].

On Mon, Apr 29, 2019 at 4:36 PM <marcus at hirt.se> wrote:

> Changeset: 0339c57d510c
> Author:    hirt <marcus.hirt at oracle.com>
> Date:      2019-04-29 22:36 +0200
> URL:       http://hg.openjdk.java.net/jmc/jmc/rev/0339c57d510c
>
> JMC-6274: Add Eclipse 2018-12 and 2019-03 target platforms
> Reviewed-by: ghb, Jie Kang <jkang at redhat.com>
>
> !
> application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.pde.prefs
> ! application/org.openjdk.jmc.feature.rcp/feature.xml
> ! application/org.openjdk.jmc.osgi.extension/.project
> ! application/org.openjdk.jmc.rcp.application/META-INF/MANIFEST.MF
> ! application/org.openjdk.jmc.rcp.product/jmc.product
> ! pom.xml
> + releng/platform-definitions/platform-definition-2018-12/.project
> +
> releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target
> + releng/platform-definitions/platform-definition-2018-12/pom.xml
> + releng/platform-definitions/platform-definition-2019-03/.project
> +
> releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target
> + releng/platform-definitions/platform-definition-2019-03/pom.xml
> - releng/platform-definitions/platform-definition-oxygen/.project
> -
> releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target
> - releng/platform-definitions/platform-definition-oxygen/pom.xml
> ! releng/platform-definitions/platform-definition-photon/.project
> ! releng/platform-definitions/pom.xml
>

Thoughts?

Cheers,

Alex

[0] https://travis-ci.org/aptmac/jmc-qa/builds/527043208
[1] https://travis-ci.org/aptmac/jmc-qa/builds/527043396
[2]
http://hg.openjdk.java.net/jmc/jmc/file/a16fe51679ca/application/uitests/org.openjdk.jmc.rcp.application.uitest/src/test/java/org/openjdk/jmc/rcp/application/uitest/PluginTest.java#l67
[3]
http://hg.openjdk.java.net/jmc/jmc/file/a16fe51679ca/application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCInstallation.java#l216
[4]
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=43433b7ddf3d8d43e86a28cbd122178e8beca2ff
[5] http://cr.openjdk.java.net/~aptmac/JMC-6274/webrev.00/
[6] https://travis-ci.org/aptmac/jmc-qa/builds/527066207