Sv: Review request for JMC-6480: Fixing the GC Locker rule.

[Marcus Hirt]

Thanks Jie!

Here is an updated version:
cr.openjdk.java.net/~hirt/JMC-6480/webrev.1/

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: Jie Kang <jkang at redhat.com> 
Skickat: den 22 maj 2019 15:01
Till: Marcus Hirt <marcus at hirt.se>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: Review request for JMC-6480: Fixing the GC Locker rule.

Hi Marcus,

Looks mostly good to me though I think the tests will need to be adjusted for the new text:
[ERROR]   TestRulesWithJfr.verifyAllResults:132->verifyRuleResults:159

As well, I would like to suggest rephrasing of a portion of GcLockerRuleFactory_TEXT_INFO_LONG

s/will need for the object/will need the object/


Regards,


On Tue, May 21, 2019 at 5:09 PM Marcus Hirt <marcus at hirt.se> wrote:
>
> Hi all,
>
> Please review this fix for the GC Locker rule.
>
> Jira:   https://bugs.openjdk.java.net/browse/JMC-6480
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6480/webrev.0/
>
> Kind regards,
> Marcus
>