Review request for JMC-3338: Visualization of loaded libraries.

Henrik Dafgård hdafgard at gmail.com
Mon May 27 09:54:33 UTC 2019


Hi Marcus,

I think the proposed change looks good, even though there are a few
formatting/whitespace changes in there as well. The JdkFilters file also
seems to be included without any changes somehow?


Regards,
Henrik Dafgård


On Sat, 25 May 2019 at 01:38, Marcus Hirt <marcus at hirt.se> wrote:

> Hi all,
>
> Please review this fix to add simple visualization of loaded native
> libraries.
>
> Also fixes some other annoyances:
> . Environment variables should be sorted on key by default.
> . System properties should be sorted on key by default.
> . It should be okay to have a query with both attributes and aggregators to
> fuel
>   the DistinctItemsPage.
> . Some unused imports.
>
> Jira:   https://bugs.openjdk.java.net/browse/JMC-3338
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-3338/webrev.0/
>
> Kind regards,
> Marcus
>
>
>


More information about the jmc-dev mailing list