Sv: Review request for JMC-3338: Visualization of loaded libraries.

[Marcus Hirt]

Hi Jie,

UI testing for individual JFR pages is a bit lacking. 
Some of the more complex ones do have UI-tests, and
some of the more central views, such as the stack trace
view and controlling recordings. The UI tests also walk 
through the pages repeatedly to see if there is
any memory leak.

I've updated the JfrUi class so that it will at least 
load and show the page as part of the memory leak hunt. 

http://cr.openjdk.java.net/~hirt/JMC-3338/webrev.2/

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: Jie Kang <jkang at redhat.com> 
Skickat: den 28 maj 2019 20:29
Till: Marcus Hirt <marcus at hirt.se>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: Review request for JMC-3338: Visualization of loaded libraries.

Hi Marcus,

The changes look okay to me and also worked for me on Fedora. Though the code is very straightforward, I was wondering what the standard is for testing functionality like this? Do any of the UI tests cover this page or the other pages?


Regards,

On Tue, May 28, 2019 at 9:42 AM Marcus Hirt <marcus at hirt.se> wrote:
>
> Hi Henrik,
>
> Reverted the accidental whitespace-change to JdkFilters:
> http://cr.openjdk.java.net/~hirt/JMC-3338/webrev.1/
>
> Kind regards,
>
> Marcus
>
>
>
> Från: Henrik Dafgård <hdafgard at gmail.com>
> Skickat: den 27 maj 2019 11:55
> Till: Marcus Hirt <marcus at hirt.se>
> Kopia: jmc-dev at openjdk.java.net
> Ämne: Re: Review request for JMC-3338: Visualization of loaded libraries.
>
>
>
> Hi Marcus,
>
>
>
> I think the proposed change looks good, even though there are a few formatting/whitespace changes in there as well. The JdkFilters file also seems to be included without any changes somehow?
>
>
>
>
>
>
> Regards,
>
> Henrik Dafgård
>
>
>
>
>
> On Sat, 25 May 2019 at 01:38, Marcus Hirt <marcus at hirt.se <mailto:marcus at hirt.se> > wrote:
>
> Hi all,
>
> Please review this fix to add simple visualization of loaded native libraries.
>
> Also fixes some other annoyances:
> . Environment variables should be sorted on key by default.
> . System properties should be sorted on key by default.
> . It should be okay to have a query with both attributes and 
> aggregators to fuel
>   the DistinctItemsPage.
> . Some unused imports.
>
> Jira:   https://bugs.openjdk.java.net/browse/JMC-3338
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-3338/webrev.0/
>
> Kind regards,
> Marcus
>
>
>