From jkang at redhat.com Fri Nov 1 14:17:24 2019 From: jkang at redhat.com (Jie Kang) Date: Fri, 1 Nov 2019 10:17:24 -0400 Subject: [RFC] Threads Page Improvements In-Reply-To: References: Message-ID: Hey Alex, Wow this is an extensive re-work of the page. It looks pretty neat. I've put my comments below in a bullet-point sort of format. I understand this is a WIP, hopefully not too many of the comments are known and going to be addressed already :p * The thread table can have text cutoff depending on the space given. It would be good to add tooltips for the text content being shown. Tooltips should also be added to the buttons that inform users of the purpose (in case the icons aren't obvious) * The orange bar at the bottom overlaps with larger system font sizes. * Opinion: The zoom in and out selector buttons should just function as zoom in/out. The pointer selector seems like it could be scrapped then while the pop-out map enable/disable button can remain. For example, having to click zoom in and then click on the view, when there isn't any other view to click zoom in on doesn't make sense. When user testing there were many times even after I realized the functionality where I tried to zoom in or out by pressing the button repeatedly. * I believe the standard is not to add Red Hat copyright to existing files, only to completely new ones * The filter button to set the view's duration need not exist, it should just update the view either when the user enters valid input or after the user hits enter, after entering valid input * For duration entry, it could be smarter and allow somewhat invalid entries that could be augmented to be valid: e.g. 3:25 -> 03:25:00:00 * Opinion: Thread state selection should modify current Thread Activity Lane profile rather than creating a new "Quick Filter". * The view does not horizontally scroll or fit to window size like the other pages so if the user has a small window, they cannot see a large portion of the threads page. Either fit to window size like the other pages, or allow for appropriate scrolling. * I feel like you should be able to zoom out from the "100%" view, mainly to see more threads on the screen at once. Is this even useful? No idea... * The zoom slider being visible but not usable is very strange. I'd make it functional or drop it from the design + List subdivision = row.getNestedRows(); // height 1450, has all 32 rows * Can you elaborate on the comment added above. ``` resetButton.addListener(SWT.Selection, e -> on.accept(false)); + resetButton.addListener(SWT.Selection, new Listener() { + @Override + public void handleEvent(Event event) { + on.accept(false); + } + }); ``` * This added listener seems to be doing the same thing as the listener added just before it. Am I misreading it this? ``` + public Set getEnabledLanes() { + List laneFilters = laneDefs.stream() + .filter((Predicate) LaneDefinition::isEnabledAndNotRestLane).map(ld -> ld.getFilter()) + .collect(Collectors.toList()); + return ((Types) ItemFilters.or(laneFilters.toArray(new IItemFilter[laneFilters.size()]))).getTypes(); + } ``` This cast makes me wonder if there's a better way to get the information needed. If necessary, maybe the underlying classes can be augmented to provide it? Regards, Jie Kang On Tue, Oct 22, 2019 at 9:31 AM Alex Macdonald wrote: > > Hi, > > Demo video: https://www.youtube.com/watch?v=H_szS2gfXlo > > GIFs: https://imgur.com/a/KhmQThl#RWmGCbW > > Repo (on top of JMC GitHub mirror): https://github.com/aptmac/jmc > > Webrev (on top of current Mercurial repo): > http://cr.openjdk.java.net/~aptmac/jfr-threads-page/webrev.00/ > > The following work has been in-development to improve upon the usability of > the JFR Threads Page. > > While taking a look into the JIRA ticket for improving the Threads Page > [0], Mario and I discussed some of the pain-points and use-cases of the > Threads page with one of our UX teams. The end result of these discussions > were some mock-ups that would leverage the existing components and codebase > to make the chart and table more interactable. At a high-level, the idea > was to relocate the existing table to regain screen real-estate, add a > secondary canvas (Text Canvas) for rendering the Thread names, and add > toolbars (x2) to help filter through the information and affect how it is > displayed on the screen. In an attempt to not create a wall of text here > describing the specific changes I?ll include some bullet-point notes > towards the end of this e-mail that will go more into the changes and > additions. Additionally, I have included a demo video at the top of this > e-mail that goes over the changes, and an imgur album that contains GIFs of > the features shown in the video. This work has been a combined effort from > myself and Jessye, so if you have any specific questions about the > implementation just let us know. > > Currently this update runs correctly on Fedora (Linux), but there seem to > be a couple issues (with regards to painting) in Windows that I?ll be > investigating shortly. We also don?t have easy access to Mac machines at > the moment, so I?d be curious to see what it looks like and if it needs > further modifications there too. > > For the most part the development of the functional elements is wrapped-up > and we?re working on cleanup and testing. It?d be nice to have some > feedback prior to writing a bunch of uitests just in case things have to be > modified. > > These updates to the Threads Page also happen to coincide with (and > address) a number of outstanding issues on the JIRA, such as: > > [0] JMC-6364: Improvements to the Thread Graph (Tracking bug) > > [1] JMC-4475: Zoom out to full range in chart is not obvious > > - > > SWT Scale in the display bar indicates current zoom power > > [2] JMC-5001: Difficult to unselect in graph > > - > > The ESC key now un-highlights all lanes > > [3] JMC-5301: Shorter events hidden if drawn in same pixels as a long one > > - > > Not completely addressed, but can toggle activity visibility to find > hidden events > > [4] JMC-6165: Missing thread names in graph view (Thread view) > > - > > There?s now a fixed amount of vertical space for each lane; the names > are always visible > > [5] JMC-6366: [JFR] Event graph, make label area resizable > > - > > Text and Chart canvases connected by SashForm; no more distinct SWT > table & AWT chart > > [6] JMC-6368: Foldable threads table in the Threads page > > - > > Table converted to a popup table to save on screen real-estate > > > Summary of changes: > > - New: Chart Filter Bar (Top) > > - - Controls: time filters, reset button, dropdown thread activity filter > > - New: Dropdown Thread Activity Filter > > - - Dropdown combobox that allows for toggling of visible lane activity > > - New: Time Filter > > - - Displays for the start and end time of the visible range > > - - Can input specific start & end times to update the visible range > > > > - New: Chart Display Bar (Right) > > - - Controls: selection, zoom-in, zoom level indicator, zoom-out, zoom-pan, > and scale-to-fit > > - New: Zoom-In Mode > > - - Zoom in chart incrementally on chart click > > - - Zoom in chart continuously on long press of button > > - - Zoom to selection automatically by highlighting area on chart > > - New: Zoom Level Indicator > > - - Vertical SWT Scale + Label to show the current level of zoom > > - New: Zoom-Out Mode > > - - Zoom out chart incrementally on chart click > > - - Zoom out chart continuously on long press of button > > - New: Zoom-Pan Functionality > > - - Moving the display moves the location of the chart view > > - Changed: Timeline Display > > - - Rendered timeline display previously located below the chart has been > relocated to its own component > > - - The orange range indicator can be moved horizontally to pan the chart > view > > - Changed: Chart Canvas > > - - Chart moved into a scrolled composite that allows for vertical > scrolling from the chart canvas, horizontal scrolling from the timeline > canvas > > - Changed: Text Canvas > > - - ESC key can be pressed to remove lane highlighting > > - Changed: Zoom & Pan Mechanics > > Let us know what you think! > > Cheers, > > Alex > > [0] https://bugs.openjdk.java.net/browse/JMC-6364 > > [1] https://bugs.openjdk.java.net/browse/JMC-4475 > > [2] https://bugs.openjdk.java.net/browse/JMC-5001 > > [3] https://bugs.openjdk.java.net/browse/JMC-5301 > > [4] https://bugs.openjdk.java.net/browse/JMC-6165 > > [5] https://bugs.openjdk.java.net/browse/JMC-6366 > > [6] https://bugs.openjdk.java.net/browse/JMC-6368 From almacdon at redhat.com Fri Nov 1 16:22:49 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Fri, 1 Nov 2019 12:22:49 -0400 Subject: [RFC] Threads Page Improvements In-Reply-To: References: Message-ID: Hi Jie, On Fri, Nov 1, 2019 at 10:17 AM Jie Kang wrote: > Hey Alex, > > Wow this is an extensive re-work of the page. It looks pretty neat. > I've put my comments below in a bullet-point sort of format. I > understand this is a WIP, hopefully not too many of the comments are > known and going to be addressed already :p > Thanks for taking a look! > > * The thread table can have text cutoff depending on the space given. > The name portion to the left of the chart? It's in a sashform so it should be able to resize horizontally. > It would be good to add tooltips for the text content being shown. > Tooltips should also be added to the buttons that inform users of the > purpose (in case the icons aren't obvious) > Tooltips are a nice idea, I've recently addressed this on the GitHub repo, and can make another webrev with a more up-to-date version if required. > > * The orange bar at the bottom overlaps with larger system font sizes. > Nice catch. > > * Opinion: The zoom in and out selector buttons should just function > as zoom in/out. The pointer selector seems like it could be scrapped > then while the pop-out map enable/disable button can remain. For > example, having to click zoom in and then click on the view, when > there isn't any other view to click zoom in on doesn't make sense. > When user testing there were many times even after I realized the > functionality where I tried to zoom in or out by pressing the button > repeatedly. > Great feedback, and perhaps we could use an info blurb on how to use these tools better. I believe the intended reasoning behind the cursor changes is that it might make it easier to search for specific activities or change in activities. For example, if I'm looking for some specific, short-lived activity, with the zoom cursor active my workflow would involve clicking on the chart and using the zoom-pan functionality to search for whatever I'm looking for; my mouse cursor never has to leave the chart area. In this case if the button was a click-to-zoom, then I'd have to move the mouse back and forth between the zoom button every time I wanted to get a better look at something, which could be potentially tedious. There is also functionality to just hold the button and it'll continuously zoom, I think I added that to the summary notes but I know it was a wall of text and tough to digest in a short time frame. There's a tooltip coming for these zoom buttons which will specify what action happens on a short click vs. a long click. > > * I believe the standard is not to add Red Hat copyright to existing > files, only to completely new ones > Right, I'll take note and run through the license headers again. > > * The filter button to set the view's duration need not exist, it > should just update the view either when the user enters valid input I think this could work well if the full time format is required as an input. From an error handling perspective I don't think this would play too nicely with your later idea of a smarter input, because of potential ambiguity of time (e.g., is 3:25 H:MM or M:SS?), and how error dialogs are currently displayed. At the moment, when the Filter button is clicked the time filters are evaluated and a specific error message is displayed in a dialog explaining why the new time is invalid. If the button disappears, either we need to rethink how we display the error message, or the dialog needs to appear only when it's certain that the format is invalid. > or > after the user hits enter, after entering valid input > Making the user hit enter to trigger the filter would be the same flow as having the button IMO, and in which case would probably be better to keep the button so there is no mistaking that an action has to be performed to edit the visible range. > > * For duration entry, it could be smarter and allow somewhat invalid > entries that could be augmented to be valid: e.g. 3:25 -> 03:25:00:00 > That could work, and I'm guessing because we're so used to colon separation for hours & minutes that it would be okay that way.. but depending on context it could be end up being inferred as m:ss too? > > * Opinion: Thread state selection should modify current Thread > Activity Lane profile rather than creating a new "Quick Filter". > The reasoning behind this one is that the page by default has two filters with pre-set lanes: Java Latencies (enabled) and JVM Compiler (disabled). IMO it feels more intuitive to make a copy of the enabled lanes and add/remove from a new active filter than to add/remove from a list of predetermined ones. An example use case being if I wanted to go in and see where my threads are sleeping, I could use the dropdown to hide everything except the Thread Sleep lanes, and by making a new "quick filter" I preserve the original "Java Latencies" filter so I can toggle it back on to pick up where I was before. > * The view does not horizontally scroll or fit to window size like the > other pages so if the user has a small window, they cannot see a large > portion of the threads page. Either fit to window size like the other > pages, or allow for appropriate scrolling. > Good call, I'll add this to the list of tasks to re-visit. > > * I feel like you should be able to zoom out from the "100%" view, > mainly to see more threads on the screen at once. Is this even useful? > No idea... > That could be interesting, as in decreasing the lane heights to fit more threads on the screen? And in which case, I wonder if it would be better to have separate controls for this. > > * The zoom slider being visible but not usable is very strange. I'd > make it functional or drop it from the design > There was a slider included in the original design to show zoom level, but the SWT slider being functional didn't pan out as expected. I can take a look back into it, IIRC the problem was the listener not always getting fired on every drag event when dragging up and down during a single mouse down click - so the slider could end up in a state where the thumb is at a location where the event hasn't fired, and cause a disconnect between it's supposed zoom amount and what the chart is actually showing. > > + List subdivision = row.getNestedRows(); > // height 1450, has all 32 rows > * Can you elaborate on the comment added above. > Whoops, that was a comment I added early on when I was trying to figure out the vertical sizing of the chart. > > ``` > resetButton.addListener(SWT.Selection, e -> > on.accept(false)); > + resetButton.addListener(SWT.Selection, new > Listener() { > + @Override > + public void handleEvent(Event event) { > + on.accept(false); > + } > + }); > ``` > > * This added listener seems to be doing the same thing as the listener > added just before it. Am I misreading it this? > Ah yes, thanks for catching that. > > ``` > + public Set getEnabledLanes() { > + List laneFilters = laneDefs.stream() > + .filter((Predicate LaneDefinition>) LaneDefinition::isEnabledAndNotRestLane).map(ld -> > ld.getFilter()) > + .collect(Collectors.toList()); > + return ((Types) ItemFilters.or(laneFilters.toArray(new > IItemFilter[laneFilters.size()]))).getTypes(); > + } > ``` > > This cast makes me wonder if there's a better way to get the > information needed. If necessary, maybe the underlying classes can be > augmented to provide it? > > > Regards, > Jie Kang > > > On Tue, Oct 22, 2019 at 9:31 AM Alex Macdonald > wrote: > > > > Hi, > > > > Demo video: https://www.youtube.com/watch?v=H_szS2gfXlo > > > > GIFs: https://imgur.com/a/KhmQThl#RWmGCbW > > > > Repo (on top of JMC GitHub mirror): https://github.com/aptmac/jmc > > > > Webrev (on top of current Mercurial repo): > > http://cr.openjdk.java.net/~aptmac/jfr-threads-page/webrev.00/ > > > > The following work has been in-development to improve upon the usability > of > > the JFR Threads Page. > > > > While taking a look into the JIRA ticket for improving the Threads Page > > [0], Mario and I discussed some of the pain-points and use-cases of the > > Threads page with one of our UX teams. The end result of these > discussions > > were some mock-ups that would leverage the existing components and > codebase > > to make the chart and table more interactable. At a high-level, the idea > > was to relocate the existing table to regain screen real-estate, add a > > secondary canvas (Text Canvas) for rendering the Thread names, and add > > toolbars (x2) to help filter through the information and affect how it is > > displayed on the screen. In an attempt to not create a wall of text here > > describing the specific changes I?ll include some bullet-point notes > > towards the end of this e-mail that will go more into the changes and > > additions. Additionally, I have included a demo video at the top of this > > e-mail that goes over the changes, and an imgur album that contains GIFs > of > > the features shown in the video. This work has been a combined effort > from > > myself and Jessye, so if you have any specific questions about the > > implementation just let us know. > > > > Currently this update runs correctly on Fedora (Linux), but there seem to > > be a couple issues (with regards to painting) in Windows that I?ll be > > investigating shortly. We also don?t have easy access to Mac machines at > > the moment, so I?d be curious to see what it looks like and if it needs > > further modifications there too. > > > > For the most part the development of the functional elements is > wrapped-up > > and we?re working on cleanup and testing. It?d be nice to have some > > feedback prior to writing a bunch of uitests just in case things have to > be > > modified. > > > > These updates to the Threads Page also happen to coincide with (and > > address) a number of outstanding issues on the JIRA, such as: > > > > [0] JMC-6364: Improvements to the Thread Graph (Tracking bug) > > > > [1] JMC-4475: Zoom out to full range in chart is not obvious > > > > - > > > > SWT Scale in the display bar indicates current zoom power > > > > [2] JMC-5001: Difficult to unselect in graph > > > > - > > > > The ESC key now un-highlights all lanes > > > > [3] JMC-5301: Shorter events hidden if drawn in same pixels as a long one > > > > - > > > > Not completely addressed, but can toggle activity visibility to find > > hidden events > > > > [4] JMC-6165: Missing thread names in graph view (Thread view) > > > > - > > > > There?s now a fixed amount of vertical space for each lane; the names > > are always visible > > > > [5] JMC-6366: [JFR] Event graph, make label area resizable > > > > - > > > > Text and Chart canvases connected by SashForm; no more distinct SWT > > table & AWT chart > > > > [6] JMC-6368: Foldable threads table in the Threads page > > > > - > > > > Table converted to a popup table to save on screen real-estate > > > > > > Summary of changes: > > > > - New: Chart Filter Bar (Top) > > > > - - Controls: time filters, reset button, dropdown thread activity filter > > > > - New: Dropdown Thread Activity Filter > > > > - - Dropdown combobox that allows for toggling of visible lane activity > > > > - New: Time Filter > > > > - - Displays for the start and end time of the visible range > > > > - - Can input specific start & end times to update the visible range > > > > > > > > - New: Chart Display Bar (Right) > > > > - - Controls: selection, zoom-in, zoom level indicator, zoom-out, > zoom-pan, > > and scale-to-fit > > > > - New: Zoom-In Mode > > > > - - Zoom in chart incrementally on chart click > > > > - - Zoom in chart continuously on long press of button > > > > - - Zoom to selection automatically by highlighting area on chart > > > > - New: Zoom Level Indicator > > > > - - Vertical SWT Scale + Label to show the current level of zoom > > > > - New: Zoom-Out Mode > > > > - - Zoom out chart incrementally on chart click > > > > - - Zoom out chart continuously on long press of button > > > > - New: Zoom-Pan Functionality > > > > - - Moving the display moves the location of the chart view > > > > - Changed: Timeline Display > > > > - - Rendered timeline display previously located below the chart has been > > relocated to its own component > > > > - - The orange range indicator can be moved horizontally to pan the chart > > view > > > > - Changed: Chart Canvas > > > > - - Chart moved into a scrolled composite that allows for vertical > > scrolling from the chart canvas, horizontal scrolling from the timeline > > canvas > > > > - Changed: Text Canvas > > > > - - ESC key can be pressed to remove lane highlighting > > > > - Changed: Zoom & Pan Mechanics > > > > Let us know what you think! > > > > Cheers, > > > > Alex > > > > [0] https://bugs.openjdk.java.net/browse/JMC-6364 > > > > [1] https://bugs.openjdk.java.net/browse/JMC-4475 > > > > [2] https://bugs.openjdk.java.net/browse/JMC-5001 > > > > [3] https://bugs.openjdk.java.net/browse/JMC-5301 > > > > [4] https://bugs.openjdk.java.net/browse/JMC-6165 > > > > [5] https://bugs.openjdk.java.net/browse/JMC-6366 > > > > [6] https://bugs.openjdk.java.net/browse/JMC-6368 > From marcus.hirt at datadoghq.com Wed Nov 6 00:29:37 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 6 Nov 2019 01:29:37 +0100 Subject: Review request for JMC-6622: Correcting landing page information Message-ID: Hi all, Please review this fix to correct some information in the update site landing pages. Jira: https://bugs.openjdk.java.net/browse/JMC-6622 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6622/webrev.0/ Kind regards, Marcus From jkang at redhat.com Wed Nov 6 16:25:37 2019 From: jkang at redhat.com (Jie Kang) Date: Wed, 6 Nov 2019 11:25:37 -0500 Subject: Review request for JMC-6622: Correcting landing page information In-Reply-To: References: Message-ID: On Tue, Nov 5, 2019 at 7:32 PM Marcus Hirt wrote: > > Hi all, > > Please review this fix to correct some information in the update site > landing pages. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6622 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6622/webrev.0/ This looks okay to me. Cheers, Jie Kang > > Kind regards, > Marcus From marcus at hirt.se Wed Nov 6 20:30:14 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Wed, 06 Nov 2019 20:30:14 +0000 Subject: hg: jmc/jmc: JMC-6622: Correcting landing page information Message-ID: <201911062030.xA6KUEud023432@aojmv0008.oracle.com> Changeset: 9def51fa742e Author: hirt Date: 2019-11-06 21:29 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/9def51fa742e JMC-6622: Correcting landing page information Reviewed-by: jkang, hdafgard ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html From jkang at redhat.com Thu Nov 7 19:40:16 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 7 Nov 2019 14:40:16 -0500 Subject: [RFC] Threads Page Improvements In-Reply-To: References: Message-ID: On Fri, Nov 1, 2019 at 12:23 PM Alex Macdonald wrote: > > Hi Jie, > > On Fri, Nov 1, 2019 at 10:17 AM Jie Kang wrote: >> >> Hey Alex, >> >> Wow this is an extensive re-work of the page. It looks pretty neat. >> I've put my comments below in a bullet-point sort of format. I >> understand this is a WIP, hopefully not too many of the comments are >> known and going to be addressed already :p > > > Thanks for taking a look! > >> >> >> * The thread table can have text cutoff depending on the space given. > > > The name portion to the left of the chart? It's in a sashform so it should be able to resize horizontally. Maybe it has to do with the font sizes? On my setup, the horizontal scroll doesn't have much movement to it so text is cutoff and a bit of it can never be seen. > >> >> It would be good to add tooltips for the text content being shown. >> Tooltips should also be added to the buttons that inform users of the >> purpose (in case the icons aren't obvious) > > > Tooltips are a nice idea, I've recently addressed this on the GitHub repo, and can make another webrev with a more up-to-date version if required. > >> >> >> * The orange bar at the bottom overlaps with larger system font sizes. > > > Nice catch. > >> >> >> * Opinion: The zoom in and out selector buttons should just function >> as zoom in/out. The pointer selector seems like it could be scrapped >> then while the pop-out map enable/disable button can remain. For >> example, having to click zoom in and then click on the view, when >> there isn't any other view to click zoom in on doesn't make sense. >> When user testing there were many times even after I realized the >> functionality where I tried to zoom in or out by pressing the button >> repeatedly. > > > Great feedback, and perhaps we could use an info blurb on how to use these tools better. > > I believe the intended reasoning behind the cursor changes is that it might make it easier to search for specific activities or change in activities. For example, if I'm looking for some specific, short-lived activity, with the zoom cursor active my workflow would involve clicking on the chart and using the zoom-pan functionality to search for whatever I'm looking for; my mouse cursor never has to leave the chart area. In this case if the button was a click-to-zoom, then I'd have to move the mouse back and forth between the zoom button every time I wanted to get a better look at something, which could be potentially tedious. > > There is also functionality to just hold the button and it'll continuously zoom, I think I added that to the summary notes but I know it was a wall of text and tough to digest in a short time frame. There's a tooltip coming for these zoom buttons which will specify what action happens on a short click vs. a long click. Okay, that sounds fine to me. > >> >> >> * I believe the standard is not to add Red Hat copyright to existing >> files, only to completely new ones > > > Right, I'll take note and run through the license headers again. > >> >> >> * The filter button to set the view's duration need not exist, it >> should just update the view either when the user enters valid input > > > I think this could work well if the full time format is required as an input. From an error handling perspective I don't think this would play too nicely with your later idea of a smarter input, because of potential ambiguity of time (e.g., is 3:25 H:MM or M:SS?), and how error dialogs are currently displayed. At the moment, when the Filter button is clicked the time filters are evaluated and a specific error message is displayed in a dialog explaining why the new time is invalid. If the button disappears, either we need to rethink how we display the error message, or the dialog needs to appear only when it's certain that the format is invalid. > >> >> or >> after the user hits enter, after entering valid input > > > Making the user hit enter to trigger the filter would be the same flow as having the button IMO, and in which case would probably be better to keep the button so there is no mistaking that an action has to be performed to edit the visible range. It should be possible to evaluate and notify as necessary after user input without having to wait for them to hit the button or the enter key. In fact, neither are really necessary, once valid input is received, it can immediately update the relevant UI. At the least, I'd expect the enter key to function the same as the button. > >> >> >> * For duration entry, it could be smarter and allow somewhat invalid >> entries that could be augmented to be valid: e.g. 3:25 -> 03:25:00:00 > > > That could work, and I'm guessing because we're so used to colon separation for hours & minutes that it would be okay that way.. but depending on context it could be end up being inferred as m:ss too? I think if we pick one way and stay consistent, it's still better than having neither. On another related note, it seems this filter needs adjustment to better work with events with time in PM, AM and different days. For example. how about a recording that has 1 hour of events but between 23:59 day one and 00:59 day two? Or (maybe unlikely) a set of events across 3 days of time. > >> >> >> * Opinion: Thread state selection should modify current Thread >> Activity Lane profile rather than creating a new "Quick Filter". > > > The reasoning behind this one is that the page by default has two filters with pre-set lanes: Java Latencies (enabled) and JVM Compiler (disabled). IMO it feels more intuitive to make a copy of the enabled lanes and add/remove from a new active filter than to add/remove from a list of predetermined ones. An example use case being if I wanted to go in and see where my threads are sleeping, I could use the dropdown to hide everything except the Thread Sleep lanes, and by making a new "quick filter" I preserve the original "Java Latencies" filter so I can toggle it back on to pick up where I was before. > I guess this is subjective but I don't agree that it is intuitive. If I understand that I have profiles for thread activity lane selections that I can create and modify, I'd expect this selection UI to manipulate the profile that I have currently selected. There isn't any sign to me that it will create a new 'temporary' profile that I can't update the actual profile setup I have to match. I agree with the idea of having a state from which I can revert back from, but I don't think it makes sense unless it is touching the profile I have set-up where I can choose to update to my new settings, or revert to my old settings. E.g. writing text to a file, in vim I can choose to save and exit or exit discarding changes. >> >> * The view does not horizontally scroll or fit to window size like the >> other pages so if the user has a small window, they cannot see a large >> portion of the threads page. Either fit to window size like the other >> pages, or allow for appropriate scrolling. > > > Good call, I'll add this to the list of tasks to re-visit. > >> >> >> * I feel like you should be able to zoom out from the "100%" view, >> mainly to see more threads on the screen at once. Is this even useful? >> No idea... > > > That could be interesting, as in decreasing the lane heights to fit more threads on the screen? And in which case, I wonder if it would be better to have separate controls for this. Yeah, but definitely something for another issue, if it's even deemed appropriate. I'm actually not too sure on this idea. > >> >> >> * The zoom slider being visible but not usable is very strange. I'd >> make it functional or drop it from the design > > > There was a slider included in the original design to show zoom level, but the SWT slider being functional didn't pan out as expected. I can take a look back into it, IIRC the problem was the listener not always getting fired on every drag event when dragging up and down during a single mouse down click - so the slider could end up in a state where the thumb is at a location where the event hasn't fired, and cause a disconnect between it's supposed zoom amount and what the chart is actually showing. Okay. Well if it can't be made usable, I think the percentage indicator is good enough. > >> >> >> + List subdivision = row.getNestedRows(); >> // height 1450, has all 32 rows >> * Can you elaborate on the comment added above. > > > Whoops, that was a comment I added early on when I was trying to figure out the vertical sizing of the chart. > >> >> >> ``` >> resetButton.addListener(SWT.Selection, e -> >> on.accept(false)); >> + resetButton.addListener(SWT.Selection, new Listener() { >> + @Override >> + public void handleEvent(Event event) { >> + on.accept(false); >> + } >> + }); >> ``` >> >> * This added listener seems to be doing the same thing as the listener >> added just before it. Am I misreading it this? > > > Ah yes, thanks for catching that. > >> >> >> ``` >> + public Set getEnabledLanes() { >> + List laneFilters = laneDefs.stream() >> + .filter((Predicate> LaneDefinition>) LaneDefinition::isEnabledAndNotRestLane).map(ld -> >> ld.getFilter()) >> + .collect(Collectors.toList()); >> + return ((Types) ItemFilters.or(laneFilters.toArray(new >> IItemFilter[laneFilters.size()]))).getTypes(); >> + } >> ``` >> >> This cast makes me wonder if there's a better way to get the >> information needed. If necessary, maybe the underlying classes can be >> augmented to provide it? >> >> >> Regards, >> Jie Kang >> >> >> On Tue, Oct 22, 2019 at 9:31 AM Alex Macdonald wrote: >> > >> > Hi, >> > >> > Demo video: https://www.youtube.com/watch?v=H_szS2gfXlo >> > >> > GIFs: https://imgur.com/a/KhmQThl#RWmGCbW >> > >> > Repo (on top of JMC GitHub mirror): https://github.com/aptmac/jmc >> > >> > Webrev (on top of current Mercurial repo): >> > http://cr.openjdk.java.net/~aptmac/jfr-threads-page/webrev.00/ >> > >> > The following work has been in-development to improve upon the usability of >> > the JFR Threads Page. >> > >> > While taking a look into the JIRA ticket for improving the Threads Page >> > [0], Mario and I discussed some of the pain-points and use-cases of the >> > Threads page with one of our UX teams. The end result of these discussions >> > were some mock-ups that would leverage the existing components and codebase >> > to make the chart and table more interactable. At a high-level, the idea >> > was to relocate the existing table to regain screen real-estate, add a >> > secondary canvas (Text Canvas) for rendering the Thread names, and add >> > toolbars (x2) to help filter through the information and affect how it is >> > displayed on the screen. In an attempt to not create a wall of text here >> > describing the specific changes I?ll include some bullet-point notes >> > towards the end of this e-mail that will go more into the changes and >> > additions. Additionally, I have included a demo video at the top of this >> > e-mail that goes over the changes, and an imgur album that contains GIFs of >> > the features shown in the video. This work has been a combined effort from >> > myself and Jessye, so if you have any specific questions about the >> > implementation just let us know. >> > >> > Currently this update runs correctly on Fedora (Linux), but there seem to >> > be a couple issues (with regards to painting) in Windows that I?ll be >> > investigating shortly. We also don?t have easy access to Mac machines at >> > the moment, so I?d be curious to see what it looks like and if it needs >> > further modifications there too. >> > >> > For the most part the development of the functional elements is wrapped-up >> > and we?re working on cleanup and testing. It?d be nice to have some >> > feedback prior to writing a bunch of uitests just in case things have to be >> > modified. >> > >> > These updates to the Threads Page also happen to coincide with (and >> > address) a number of outstanding issues on the JIRA, such as: >> > >> > [0] JMC-6364: Improvements to the Thread Graph (Tracking bug) >> > >> > [1] JMC-4475: Zoom out to full range in chart is not obvious >> > >> > - >> > >> > SWT Scale in the display bar indicates current zoom power >> > >> > [2] JMC-5001: Difficult to unselect in graph >> > >> > - >> > >> > The ESC key now un-highlights all lanes >> > >> > [3] JMC-5301: Shorter events hidden if drawn in same pixels as a long one >> > >> > - >> > >> > Not completely addressed, but can toggle activity visibility to find >> > hidden events >> > >> > [4] JMC-6165: Missing thread names in graph view (Thread view) >> > >> > - >> > >> > There?s now a fixed amount of vertical space for each lane; the names >> > are always visible >> > >> > [5] JMC-6366: [JFR] Event graph, make label area resizable >> > >> > - >> > >> > Text and Chart canvases connected by SashForm; no more distinct SWT >> > table & AWT chart >> > >> > [6] JMC-6368: Foldable threads table in the Threads page >> > >> > - >> > >> > Table converted to a popup table to save on screen real-estate >> > >> > >> > Summary of changes: >> > >> > - New: Chart Filter Bar (Top) >> > >> > - - Controls: time filters, reset button, dropdown thread activity filter >> > >> > - New: Dropdown Thread Activity Filter >> > >> > - - Dropdown combobox that allows for toggling of visible lane activity >> > >> > - New: Time Filter >> > >> > - - Displays for the start and end time of the visible range >> > >> > - - Can input specific start & end times to update the visible range >> > >> > >> > >> > - New: Chart Display Bar (Right) >> > >> > - - Controls: selection, zoom-in, zoom level indicator, zoom-out, zoom-pan, >> > and scale-to-fit >> > >> > - New: Zoom-In Mode >> > >> > - - Zoom in chart incrementally on chart click >> > >> > - - Zoom in chart continuously on long press of button >> > >> > - - Zoom to selection automatically by highlighting area on chart >> > >> > - New: Zoom Level Indicator >> > >> > - - Vertical SWT Scale + Label to show the current level of zoom >> > >> > - New: Zoom-Out Mode >> > >> > - - Zoom out chart incrementally on chart click >> > >> > - - Zoom out chart continuously on long press of button >> > >> > - New: Zoom-Pan Functionality >> > >> > - - Moving the display moves the location of the chart view >> > >> > - Changed: Timeline Display >> > >> > - - Rendered timeline display previously located below the chart has been >> > relocated to its own component >> > >> > - - The orange range indicator can be moved horizontally to pan the chart >> > view >> > >> > - Changed: Chart Canvas >> > >> > - - Chart moved into a scrolled composite that allows for vertical >> > scrolling from the chart canvas, horizontal scrolling from the timeline >> > canvas >> > >> > - Changed: Text Canvas >> > >> > - - ESC key can be pressed to remove lane highlighting >> > >> > - Changed: Zoom & Pan Mechanics >> > >> > Let us know what you think! >> > >> > Cheers, >> > >> > Alex >> > >> > [0] https://bugs.openjdk.java.net/browse/JMC-6364 >> > >> > [1] https://bugs.openjdk.java.net/browse/JMC-4475 >> > >> > [2] https://bugs.openjdk.java.net/browse/JMC-5001 >> > >> > [3] https://bugs.openjdk.java.net/browse/JMC-5301 >> > >> > [4] https://bugs.openjdk.java.net/browse/JMC-6165 >> > >> > [5] https://bugs.openjdk.java.net/browse/JMC-6366 >> > >> > [6] https://bugs.openjdk.java.net/browse/JMC-6368 From marcus at hirt.se Sat Nov 9 10:24:12 2019 From: marcus at hirt.se (Marcus Hirt) Date: Sat, 9 Nov 2019 11:24:12 +0100 Subject: Starting the JMC 8 project at GitHub Message-ID: <039e01d596e7$d4dca760$7e95f620$@hirt.se> Hi all, We're almost done with JMC 7.1.0 at this point. There are a few small tasks left, but we're now feature complete. By the end of next week, we'll switch over to using the repository at GitHub [0] for our development. Please make sure that you have associated your GitHub account with your OpenJDK username[1]. Please let me know if there are any questions! Kind regards, Marcus [0]: https://github.com/openjdk/jmc [1]: https://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001456.html From guru.hb at oracle.com Sat Nov 9 17:00:43 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Sat, 09 Nov 2019 17:00:43 +0000 Subject: hg: jmc/jmc7: 91 new changesets Message-ID: <201911091700.xA9H0hrv008199@aojmv0008.oracle.com> Changeset: 4a66fe85d333 Author: hirt Date: 2018-12-20 22:20 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/4a66fe85d333 JMC-6250: Updated splash for JMC 7.1 EA Reviewed-by: ghb ! application/org.openjdk.jmc.rcp.application/splash.bmp Changeset: 9e506d468c22 Author: hirt Date: 2019-01-08 09:00 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/9e506d468c22 JMC-6277: Supporting new JavaFX 12 events (also fixing various warnings and mounting optional pages in better places) Reviewed-by: ghb ! application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java ! application/org.openjdk.jmc.flightrecorder.ext.g1/pages.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pages.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxConstants.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java + application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxVersionUtil.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/Messages.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages.properties ! application/org.openjdk.jmc.flightrecorder.metadata/pages.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/DataPageDescriptor.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ClassLoadingPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/HotSpot24DiagnosticCommandService.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/AwtCanvas.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Changeset: ead823d5707d Author: jmatsuoka Date: 2019-01-09 14:35 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/ead823d5707d JMC-6223: Visualize the PID from the VM information event Summary: Visualize the PID from the JVM Information Event Reviewed By: hirt Contributed-by: Ken Dobson ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Changeset: 68f76f29e8b8 Author: jmatsuoka Date: 2019-01-09 15:19 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/68f76f29e8b8 JMC-6260: Fix up documentation Summary: Update and clean up the documentation Reviewed-by: hirt Contributed-by: Ken Dobson ! application/org.openjdk.jmc.docs/html/GUID-0352E76D-96F5-4EDA-A8DE-88B9E18635B9.htm ! application/org.openjdk.jmc.docs/html/GUID-0BFAAA05-CF48-4351-B5FF-AC8E11BAA9DC.htm ! application/org.openjdk.jmc.docs/html/GUID-343C6885-3367-4DDE-9BE5-1A7421CE00A1.htm ! application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm ! application/org.openjdk.jmc.docs/html/GUID-492BB17D-5964-48C3-9212-D4848514437A.htm ! application/org.openjdk.jmc.docs/html/GUID-4B13023D-6AFA-4563-8532-74871DE29B62.htm ! application/org.openjdk.jmc.docs/html/GUID-4F885E48-A548-4140-B985-74B1685BEDEA.htm ! application/org.openjdk.jmc.docs/html/GUID-63742D06-CF58-47F2-9CF2-08C0DB9F09F1.htm ! application/org.openjdk.jmc.docs/html/GUID-66413CF1-A0E1-43BD-B8DB-9720B112D8F3.htm ! application/org.openjdk.jmc.docs/html/GUID-6A66D658-7FD4-4621-9FE7-662D8B8FFACF.htm ! application/org.openjdk.jmc.docs/html/GUID-6B99EBAD-C94C-4B3D-B7B4-867F408012BF.htm ! application/org.openjdk.jmc.docs/html/GUID-8E04A807-3D2B-4896-AD06-B0DE61ACBBD9.htm ! application/org.openjdk.jmc.docs/html/GUID-8EA35A18-669C-4EC3-BCEF-7EA7F92BA3EE.htm ! application/org.openjdk.jmc.docs/html/GUID-953292B2-45D3-4842-9656-DAE88D239BA6.htm ! application/org.openjdk.jmc.docs/html/GUID-A27CE821-5AD5-438D-9A2F-D0B45B743EF0.htm ! application/org.openjdk.jmc.docs/html/GUID-ABF6E2F7-9FE9-4054-934C-BE05AEA8EDFE.htm ! application/org.openjdk.jmc.docs/html/GUID-BCAF66B8-BC4F-48F3-8453-5AA921067861.htm ! application/org.openjdk.jmc.docs/html/GUID-C12D23CE-E9DE-4BFA-A310-9AD5B6D835FD.htm ! application/org.openjdk.jmc.docs/html/GUID-C661942A-3DCF-40B4-87C3-F5000DE4830E.htm ! application/org.openjdk.jmc.docs/html/GUID-CD7A11BF-27AE-481A-8158-03ECC2DB9697.htm ! application/org.openjdk.jmc.docs/html/GUID-DB152DDE-4694-439D-B8A7-CF1EABFAF795.htm ! application/org.openjdk.jmc.docs/html/GUID-DDE72C8A-0A15-43F9-A109-EB87804FD480.htm ! application/org.openjdk.jmc.docs/html/GUID-F94F7FBB-5B53-40A3-854E-8BE8FC172629.htm ! application/org.openjdk.jmc.docs/html/GUID-FEFBE854-3298-46A6-A149-8B48A62330D2.htm Changeset: c6268ad8d01a Author: hirt Date: 2019-01-10 21:22 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/c6268ad8d01a JMC-6327: Updating version to 7.1.0 Reviewed-by: Jie Kang ,ghb ! README.md ! application/l10n/org.openjdk.jmc.alert.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.ja/pom.xml ! application/l10n/org.openjdk.jmc.alert.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.docs.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.ja/nl/ja/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.ja/pom.xml ! application/l10n/org.openjdk.jmc.docs.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.zh_CN/nl/zh/CN/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.intro.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.zh_CN/pom.xml ! application/l10n/pom.xml ! application/org.openjdk.jmc.alert/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.alert/pom.xml ! application/org.openjdk.jmc.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.attach/pom.xml ! application/org.openjdk.jmc.browser.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.jdp/pom.xml ! application/org.openjdk.jmc.browser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser/pom.xml ! application/org.openjdk.jmc.commands/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.commands/pom.xml ! application/org.openjdk.jmc.console.jconsole/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.jconsole/pom.xml ! application/org.openjdk.jmc.console.pde/pom.xml ! application/org.openjdk.jmc.console.persistence/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.persistence/pom.xml ! application/org.openjdk.jmc.console.twitter/pom.xml ! application/org.openjdk.jmc.console.ui.diagnostic/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.diagnostic/pom.xml ! application/org.openjdk.jmc.console.ui.mbeanbrowser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.mbeanbrowser/pom.xml ! application/org.openjdk.jmc.console.ui.notification/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.notification/pom.xml ! application/org.openjdk.jmc.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/pom.xml ! application/org.openjdk.jmc.docs/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.docs/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/org.openjdk.jmc.docs/pom.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.feature.console/feature.xml ! application/org.openjdk.jmc.feature.console/pom.xml ! application/org.openjdk.jmc.feature.core/feature.xml ! application/org.openjdk.jmc.feature.core/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder/pom.xml ! application/org.openjdk.jmc.feature.ide.launch/feature.xml ! application/org.openjdk.jmc.feature.ide.launch/pom.xml ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.ide/pom.xml ! application/org.openjdk.jmc.feature.jconsole/feature.xml ! application/org.openjdk.jmc.feature.jconsole/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.feature.joverflow/pom.xml ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.license/pom.xml ! application/org.openjdk.jmc.feature.pde/feature.xml ! application/org.openjdk.jmc.feature.pde/pom.xml ! application/org.openjdk.jmc.feature.rcp.update/feature.xml ! application/org.openjdk.jmc.feature.rcp.update/pom.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml ! application/org.openjdk.jmc.feature.rcp/pom.xml ! application/org.openjdk.jmc.feature.twitter/feature.xml ! application/org.openjdk.jmc.feature.twitter/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.flightrecorder.metadata/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.flightrecorder.pde/pom.xml ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ui/pom.xml ! application/org.openjdk.jmc.greychart.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart.ui/pom.xml ! application/org.openjdk.jmc.greychart/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart/pom.xml ! application/org.openjdk.jmc.ide.jdt/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.jdt/pom.xml ! application/org.openjdk.jmc.ide.launch/pom.xml ! application/org.openjdk.jmc.ide.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.ui/pom.xml ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/pom.xml ! application/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.jdp/pom.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml ! application/org.openjdk.jmc.joverflow/pom.xml ! application/org.openjdk.jmc.osgi.extension/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.osgi.extension/pom.xml ! application/org.openjdk.jmc.pde/pom.xml ! application/org.openjdk.jmc.rcp.application/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.application/pom.xml ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties ! application/org.openjdk.jmc.rcp.application/src/main/resources/updatesites.properties ! application/org.openjdk.jmc.rcp.intro/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.intro/pom.xml ! application/org.openjdk.jmc.rcp.product.feature/feature.xml ! application/org.openjdk.jmc.rcp.product.feature/pom.xml ! application/org.openjdk.jmc.rcp.product/feature.xml ! application/org.openjdk.jmc.rcp.product/jmc.product ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ext/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.services.jfr/pom.xml ! application/org.openjdk.jmc.rjmx.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ui/pom.xml ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx/pom.xml ! application/org.openjdk.jmc.ui.common/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui.common/pom.xml ! application/org.openjdk.jmc.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui/pom.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.ide/pom.xml ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/pom.xml ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.greychart.test/pom.xml ! application/tests/org.openjdk.jmc.ide.launch.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ide.launch.test/pom.xml ! application/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.jdp.test/pom.xml ! application/tests/org.openjdk.jmc.joverflow.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.joverflow.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/BasicCommunicationTest.java ! application/tests/org.openjdk.jmc.ui.common.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.common.test/pom.xml ! application/tests/org.openjdk.jmc.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.test/pom.xml ! application/tests/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.jconsole.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/pom.xml ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/src/test/java/org/openjdk/jmc/rcp/application/uitest/UpdateSiteTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/pom.xml ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/pom.xml + releng/platform-definitions/platform-definition-oxygen/pom.xml ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml ! releng/pom.xml ! releng/third-party/pom.xml Changeset: 947da61a318d Author: jmatsuoka Date: 2019-01-10 15:55 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/947da61a318d JMC-5002: Put the JVM Start Time in perspective Summary: Put JVM Start Time in perspective for IncreasingLiveSetRule Reviewed by: hirt Contributed-by: Ken Dobson ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: eeff6fb88595 Author: aptmac Date: 2019-01-10 15:13 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/eeff6fb88595 JMC-6313: Exit menu item alternates visibility in "File" dropdown menu Reviewed-by: hirt ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationActionBarAdvisor.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/Messages.java ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties Changeset: de13e570b3c8 Author: jmatsuoka Date: 2019-01-11 16:31 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/de13e570b3c8 JMC-6314: Default JMC binaries for Linux reference odd "-vm ../../bin" Summary: Make use of the default java on Linux systems Reviewed-by: ghb, jmatsuok Contributed-by: Salman Siddiqui ! application/org.openjdk.jmc.rcp.product/jmc.product Changeset: c8dab420bbf3 Author: hirt Date: 2019-01-13 17:50 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/c8dab420bbf3 JMC-6334: Rectifying typo in method name Reviewed-by: ghb, mwengner ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/Chunk.java Changeset: 815745150d95 Author: aptmac Date: 2019-01-23 16:23 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/815745150d95 JMC-6358: Build fails due to bugs and errors flagged by SpotBugs Reviewed-by: hirt ! pom.xml Changeset: 4fb1ac71baa5 Author: jmatsuoka Date: 2019-01-28 16:45 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/4fb1ac71baa5 JMC-6333: Default JMC binaries should not hardcode -vm /usr/bin/java Summary: use default Java from PATH on Linux Reviewed-by: neugens, ghb Contributed-by: Salman Siddiqui ! application/org.openjdk.jmc.rcp.product/jmc.product Changeset: 263d415e4379 Author: jmatsuoka Date: 2019-01-29 12:04 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/263d415e4379 JMC-6370: JMC build fails with OpenJDK 8 due to missing javafx packages in org.openjdk.jmc.javafx.osgi Summary: Updates dependency on OpenJFX to build on OpenJDK 8 Contributed-by: Jie Kang Reviewed-by: ghb, Christoph Langer ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.javafx.osgi/pom.xml Changeset: 747eb2bbafd1 Author: hirt Date: 2019-02-06 21:07 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/747eb2bbafd1 JMC-6377: Cleaning up warnings Reviewed-by: ghb ! application/org.openjdk.jmc.browser/build.properties ! application/org.openjdk.jmc.osgi.extension/src/org/openjdk/jmc/osgi/extension/ExtClassLoaderHook.java ! application/org.openjdk.jmc.rcp.application/.project ! application/org.openjdk.jmc.ui.common/pom.xml ! core/org.openjdk.jmc.agent/.classpath ! core/org.openjdk.jmc.agent/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.common/.classpath ! core/org.openjdk.jmc.common/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.flightrecorder.rules.jdk/.classpath ! core/org.openjdk.jmc.flightrecorder.rules.jdk/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules/.classpath ! core/org.openjdk.jmc.flightrecorder.rules/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.flightrecorder/.classpath ! core/org.openjdk.jmc.flightrecorder/.settings/org.eclipse.jdt.core.prefs ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/MetadataEventLocationUpdateTest.java Changeset: 5f4d0a95bf6a Author: hirt Date: 2019-02-07 10:04 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/5f4d0a95bf6a JMC-6397: InMemoryCredentials should not implement Serializable Reviewed-by: ghb ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/InMemoryCredentials.java Changeset: 7e1c0550751c Author: hirt Date: 2019-02-13 09:04 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/7e1c0550751c JMC-6376: Upgrading Maven build tools Reviewed-by: ghb ! pom.xml ! releng/third-party/pom.xml Changeset: d8319ae0ddd1 Author: hirt Date: 2019-02-13 15:14 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/d8319ae0ddd1 JMC-6408: Cleaning up some around the MBean Operation wrapping Reviewed-by: ghb + application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/MBeanOperationWrapper.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/RJMXConnection.java - application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/MBeanOperationsWrapper.java Changeset: 0b561c9aebac Author: hirt Date: 2019-02-13 15:28 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/0b561c9aebac JMC-6408: Fixing argument order of the factory method to match that of the constructor Reviewed-by: Christoph Langer ! application/org.openjdk.jmc.attach/.classpath ! application/org.openjdk.jmc.flightrecorder.ui/.classpath ! application/org.openjdk.jmc.javafx.osgi/.classpath ! application/org.openjdk.jmc.joverflow.ui/.classpath ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/MBeanOperationWrapper.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/RJMXConnection.java Changeset: 46cbddabd471 Author: hirt Date: 2019-02-13 15:39 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/46cbddabd471 JMC-6408: Backing out changes part of JMC-6409 ! application/org.openjdk.jmc.attach/.classpath ! application/org.openjdk.jmc.flightrecorder.ui/.classpath ! application/org.openjdk.jmc.javafx.osgi/.classpath ! application/org.openjdk.jmc.joverflow.ui/.classpath Changeset: 2089d5503b85 Author: hirt Date: 2019-02-13 15:45 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/2089d5503b85 JMC-6409: Cleaning out unnecessary dependencies Reviewed-by: hirt Contributed-by: Christoph Langer ! application/org.openjdk.jmc.attach/.classpath ! application/org.openjdk.jmc.flightrecorder.ui/.classpath ! application/org.openjdk.jmc.javafx.osgi/.classpath ! application/org.openjdk.jmc.joverflow.ui/.classpath Changeset: ec6b5a044948 Author: aptmac Date: 2019-02-19 11:27 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/ec6b5a044948 JMC-6367: Improve Thread graph tooltip Summary: Add the thread name and lane name to the tooltip when hovering a thread lane Reviewed-by: hirt, Christoph Langer ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/IChartInfoVisitor.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/QuantitySpanRenderer.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/SpanRenderer.java Changeset: cb62786d8d53 Author: jmatsuoka Date: 2019-02-19 15:49 -0500 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/cb62786d8d53 JMC-6324: Values in Method Profiling rule result text not correct when filtering Summary: Add additional clarity to the method profiling rule, showing the percentage of actual samples in the rule results Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties Changeset: 5d0b3f85c9ed Author: hirt Date: 2019-02-22 17:11 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/5d0b3f85c9ed JMC-6418: Possible null dereference in LocalJVMToolkit Reviewed-by: Jie Kang ! application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java Changeset: 59ac7e40f263 Author: neugens Date: 2019-02-27 13:52 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/59ac7e40f263 JMC-6421: Small correction to README to make it simpler to copy past for building JMC Summary: Reword instructions so that they can be copy/pasted in terminal directly Reviewed-by: hirt ! README.md Changeset: 6ee2531eadae Author: hirt Date: 2019-02-28 12:49 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/6ee2531eadae JMC-6267: Removing the need for NON-NLS tags from dedicated test bundles Reviewed-by: ghb, Christoph Langer ! application/org.openjdk.jmc.browser/build.properties ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java + application/tests/org.openjdk.jmc.flightrecorder.ui.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/ui/scripts/TokenizerTest.java + application/tests/org.openjdk.jmc.greychart.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/GreyChartPanelTester.java ! application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/PieChartTester.java ! application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/RenderingOutOfOrderTester.java ! application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/RenderingPerformanceTester.java ! application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java + application/tests/org.openjdk.jmc.rjmx.services.jfr.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrControlTest.java ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrPackageExampleTest.java ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrTestCase.java ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/RecordingOptionsTest.java + application/tests/org.openjdk.jmc.rjmx.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/BasicCommunicationTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/DefaultServicesTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/PackageExampleTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/RjmxTestCase.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/RJMXConnectionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/RJMXProxyOperationsTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/TabularDataBeanTestMBean.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/services/CommercialFeaturesServiceTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/services/ServicesPackageExampleTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeDescriptorTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeSubscriptionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeValueTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/CompositeDataSubscriptionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JRockitPerfCounterMBeanTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JmxOperatingSystemTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JmxThreadTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MRIMetadataServiceTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MRIMetadataToolkitTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MultipleAttributeSubscriptionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/NotificationAttributeSubscriptionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/ConsoleAttributeInfoManagerTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/DummyConnectionHandle.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/UpdatePolicyTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/PropertyTestAttribute.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/SyntheticAttributesTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/SyntheticNotificationTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/TestAttribute.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/testutil/JVMKeepAlive.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/testutil/TestToolkit.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationActionCallback.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationModelTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationTriggerAndRuleTest.java + application/tests/org.openjdk.jmc.ui.common.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.ui.common.test/src/test/java/org/openjdk/jmc/ui/common/jvm/JVMCommandLineToolkitTest.java ! application/tests/org.openjdk.jmc.ui.common.test/src/test/java/org/openjdk/jmc/ui/common/security/SecureStoreTest.java + application/tests/org.openjdk.jmc.ui.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/fields/FilterMatcherTest.java ! application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/util/ProgressCircleTester.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/TestRunner.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/Testable.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/TestHelper.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestJFRTransformer.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestToolkit.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestVisitor.java + core/tests/org.openjdk.jmc.common.test/.settings/org.eclipse.jdt.core.prefs ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/BinaryPrefixTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/MCTestCase.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/mock/item/MockAttributes.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/mock/item/MockCollections.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/string/StringToolkitTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/ContentTypeTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/util/BoundedListTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/version/JavaVMVersionToolkitTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/version/JavaVersionTest.java + core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/.settings/org.eclipse.jdt.core.prefs + core/tests/org.openjdk.jmc.flightrecorder.rules.test/.settings/org.eclipse.jdt.core.prefs + core/tests/org.openjdk.jmc.flightrecorder.test/.settings/org.eclipse.jdt.core.prefs ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/JfrAttributesTest.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/MetadataEventLocationUpdateTest.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/StacktraceBaselineGenerator.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/StacktraceTestToolkit.java Changeset: 4dbb52686dac Author: jmatsuoka Date: 2019-03-18 15:10 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/4dbb52686dac JMC-5768: Add frequency (Hz) support in UnitLookup Summary: Create Frequency KindOfQuantity and Hertz Unit in UnitLookup, and change JfxPulseDurationRule to use Hertz for its target frame rate. Reviewed-by: hdafgard Contributed-by: Elliott Baron ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages.properties ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages_ja.properties ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/resources/org/openjdk/jmc/flightrecorder/ext/jfx/messages_zh_CN.properties + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/.classpath + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/.project + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/META-INF/MANIFEST.MF + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/build.properties + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/pom.xml + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java + application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/resources/jfr/pulseduration.jfr ! application/tests/pom.xml ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/UnitLookup.java ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_ja.properties ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages_zh_CN.properties ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/DeriveUnitTest.java Changeset: 4d7d8c685a5b Author: jmatsuoka Date: 2019-03-26 14:11 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/4d7d8c685a5b JMC-6211: Restore Defaults button doesn't revert username and password in Preferences Summary: Reset mail server user credentials to blank values when reverting to defaults Reviewed-by: hirt Contributed-by: Elliott Baron ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/preferences/CommunicationPage.java ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.console.uitest/META-INF/MANIFEST.MF + application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsolePreferencesTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCDialog.java Changeset: 85cd81df8bed Author: hirt Date: 2019-04-09 20:07 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/85cd81df8bed JMC-6442: Transform sampledThread attribute to eventThread attribute for NativeMethodSample events Reviewed-by: hirt Contributed-by: klward ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java Changeset: e831d13af019 Author: hirt Date: 2019-04-15 13:14 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/e831d13af019 JMC-6455: Building source jars when building core Reviewed-by: hirt Contributed-by: Stefan Ferstl ! core/pom.xml Changeset: 00229df30bf5 Author: aptmac Date: 2019-04-12 14:59 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/00229df30bf5 JMC-4613: Thread name striked out Reviewed-by: hirt ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYChart.java Changeset: f3f0eba01db1 Author: jmatsuoka Date: 2019-04-15 10:48 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f3f0eba01db1 JMC-6456: Fix name of JDK Flight Recorder feature Summary: Fix name of JDK Flight Recorder feature Contributed-by: Jie Kang Reviewed-by: ghb, hirt ! application/org.openjdk.jmc.feature.flightrecorder/feature.properties Changeset: 313d5b90e7bb Author: hirt Date: 2019-04-19 12:55 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/313d5b90e7bb JMC-6444: Upgrading to fix-info-plist 1.5 Reviewed-by: ghb ! application/org.openjdk.jmc.rcp.product/pom.xml Changeset: 45819349275d Author: hirt Date: 2019-04-19 21:51 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/45819349275d JMC-6454: Upgrade to Tycho 1.4.0 Reviewed-by: ghb ! pom.xml Changeset: ea29d81117c8 Author: hirt Date: 2019-04-29 22:36 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/ea29d81117c8 JMC-6274: Add Eclipse 2018-12 and 2019-03 target platforms Reviewed-by: ghb, Jie Kang ! application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.pde.prefs ! application/org.openjdk.jmc.osgi.extension/.project ! application/org.openjdk.jmc.rcp.product/jmc.product ! pom.xml + releng/platform-definitions/platform-definition-2018-12/.project ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2018-12/pom.xml + releng/platform-definitions/platform-definition-2019-03/.project ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-03/pom.xml - releng/platform-definitions/platform-definition-oxygen/pom.xml Changeset: 18db58119bae Author: hirt Date: 2019-04-30 09:34 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/18db58119bae JMC-6429: Upgrade to ASM 7.1 Reviewed-by: ghb ! core/org.openjdk.jmc.agent/pom.xml Changeset: 73a62a8106bc Author: hirt Date: 2019-05-01 21:45 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/73a62a8106bc JMC-6460: Provide simple mechanism for building JMC under Docker Reviewed-by: klward,hirt,Jie Kang Contributed-by: Will Thames ! .gitignore ! .hgignore ! README.md + docker/Dockerfile-jmc + docker/Dockerfile-p2 + docker/docker-compose.yml Changeset: f0b2afefc8b2 Author: kdobson Date: 2019-05-02 11:06 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f0b2afefc8b2 JMC-4645:Size distribution chart for File/Socket I/O pages Summary:Adds a chart that shows the distribution of I/O events by size Reviewed By: hirt, almac ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/FileIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/SocketIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java Changeset: 15b69c633d6c Author: kdobson Date: 2019-05-02 11:03 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/15b69c633d6c JMC-4469:Adding a page from properties view Summary:Create a page from selected events by right clicking the properties view Reviewed By: Hirt, almac ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrPropertySheet.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/EventBrowserPage.java Changeset: 26ddbb287466 Author: hirt Date: 2019-05-08 20:30 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/26ddbb287466 JMC-6461: Cleaner versioning information when not embedding a JDK Reviewed-by: ghb ! application/l10n/org.openjdk.jmc.rcp.application.ja/plugin_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/plugin_zh_CN.properties ! application/org.openjdk.jmc.rcp.application/plugin.properties ! pom.xml Changeset: f9cf221cac52 Author: aptmac Date: 2019-05-09 11:48 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f9cf221cac52 JMC-4466: Hide thread directly from Thread graph context menu Summary: Add functionality to the context menu to hide threads from the JFR Threads page graph, and reset the graph to display the current selection of Threads Reviewed-by: ghb, neugens ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/IChartInfoVisitor.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/Messages.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/QuantitySpanRenderer.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/RendererToolkit.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java ! application/org.openjdk.jmc.ui/src/main/resources/org/openjdk/jmc/ui/charts/messages.properties + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrThreadsPageTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/base/wrappers/MCJemmyBase.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrUi.java + application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCChartCanvas.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTable.java Changeset: 2dbad2a2f1bd Author: hirt Date: 2019-05-16 12:33 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/2dbad2a2f1bd JMC-6468: Rule for detecting unsupported JDK version Reviewed-by: ghb ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersionSupport.java + core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/UnsupportedJdkVersionRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/META-INF/services/org.openjdk.jmc.flightrecorder.rules.IRule ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties - core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/baseline/Generated_JfrRuleBaseline.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: f2439cf4fe3d Author: hirt Date: 2019-05-24 13:05 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f2439cf4fe3d JMC-6480: Fixing the GC Locker rule Reviewed-by: hdafgard, Jie Kang ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/GarbageCollectionsInfo.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: 4cdad7109d53 Author: hirt Date: 2019-05-31 23:26 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/4cdad7109d53 JMC-3338: Adds simple visualization of loaded native libraries Summary: Also fixes some other annoyances, like environment variables should be sorted on key by default, system properties should be sorted on key by default, it should be okay to have a quary with both attributes and aggregators to fuel the DistinctItemsPage and removal of some unused imports Reviewed-by: hdafgard, Jie Kang ! application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml + application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries.png + application/org.openjdk.jmc.flightrecorder.ui/icons/pages/nativelibraries at 2x.png ! application/org.openjdk.jmc.flightrecorder.ui/plugin.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrPropertySheet.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ImageConstants.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/EventBrowserPage.java + application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/NativeLibraryPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrUi.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java ! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/JfrRuleTopics.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties Changeset: 85076b7a4651 Author: jmatsuoka Date: 2019-06-03 16:50 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/85076b7a4651 JMC-6252: Method Profiling rule appears to be taking forever to evaluate Summary: Resolved a race condition where rules were added to the queue without being consumed. Corrected JavaScript command execution order so UI is correctly updated. Reviewed-by: hdafgard Contributed-by: Kangcheng Xu ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java Changeset: cc848bd6e679 Author: jmatsuoka Date: 2019-06-05 10:18 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/cc848bd6e679 JMC-6171: (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected Summary: Revert workaround for the file dialog bug on Mac OS X, which is now fixed in the Eclipse 4.10 release Reviewed-by: aptmac, jmatsuoka Contributed-by: Jessye Coleman-Shapiro ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java Changeset: c5c4fcd97f7c Author: kdobson Date: 2019-06-05 10:24 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/c5c4fcd97f7c 5368: Clear stacktrace view when editor is closed Summary: Stacktrace clears on close Reviewed by: hirt ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java Changeset: 6999dd6f9331 Author: aptmac Date: 2019-06-07 11:07 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/6999dd6f9331 JMC-4466: Fix the hide thread functionality in Windows and JfrThreadsPageTest uitest failures Summary: The hide thread functionality on the JFR Threads page was not working as intended in Windows. Additionally, the uitests would sometimes not focus the table when trying to make a selection, causing the tests to fail. Reviewed-by: hirt ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCChartCanvas.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTable.java Changeset: 3156d32ea42f Author: neugens Date: 2019-06-13 11:41 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/3156d32ea42f JMC-6505: Cannot run JMC on JDK 8 by default Summary: Add +IgnoreUnrecognizedVMOptions to the jmc.ini so that JVM with no modules or support for JFR can still run JMC Reviewed-by: hirt ! application/org.openjdk.jmc.rcp.product/jmc.product Changeset: 8a3db82fa123 Author: hirt Date: 2019-06-25 12:32 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/8a3db82fa123 JMC-6514: Upgrading to Eclipse 2019-06 Reviewed-by: hirt, ghb Contributed-by: clanger ! pom.xml + releng/platform-definitions/platform-definition-2019-06/.project + releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target + releng/platform-definitions/platform-definition-2019-06/pom.xml ! releng/platform-definitions/pom.xml Changeset: 8958e3463ce3 Author: aptmac Date: 2019-06-27 14:41 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/8958e3463ce3 JMC-6484: "Recent Files" sub-menu not populated on startup Summary: Marked MCPathEditorInput(File) constructor deprecated. Updated all callers to use the alternative constructor. Contributed-by: Kangcheng Xu ! application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/action/TriggerActionStartTimeBoundRecording.java ! application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/action/WriteAndOpenRecordingJob.java ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/jobs/DumpRecordingJob.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java ! application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchDelegateHelper.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/MissionControlEditorDropAdapter.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/OpenDocumentEventProcessor.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/commands/OpenFile.java ! application/org.openjdk.jmc.rcp.intro/src/main/java/org/openjdk/jmc/rcp/intro/FlightRecordingExampleAction.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/MCPathEditorInput.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/TestHelper.java Changeset: 658c0e1104e5 Author: hirt Date: 2019-07-01 11:37 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/658c0e1104e5 JMC-6513: Explicitly setting compiler level to JDK 8 Reviewed-by: hirt Contributed-by: clanger + application/org.openjdk.jmc.alert/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.attach/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.browser.jdp/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.browser/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.commands/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.jconsole/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.console.pde/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.persistence/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.console.twitter/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.ui.diagnostic/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.ui.mbeanbrowser/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.ui.notification/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.ui.subscriptions/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.console.ui/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.docs/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.configuration/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.controlpanel.ui/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.ext.g1/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.ext.jfx/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.metadata/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.pde/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.ui/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.greychart.ui/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.greychart/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.ide.jdt/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.ide.launch/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.ide.ui/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.javafx.osgi/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.jdp/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.joverflow.ui/.settings/org.eclipse.jdt.core.prefs ! application/org.openjdk.jmc.joverflow/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.pde/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rcp.application/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rcp.intro/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rjmx.ext/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rjmx.services.jfr/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rjmx.ui/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.rjmx/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.ui.common/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.ui/.settings/org.eclipse.jdt.core.prefs + application/tests/org.openjdk.jmc.flightrecorder.configuration.test/.settings/org.eclipse.jdt.core.prefs + application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/.settings/org.eclipse.jdt.core.prefs + application/tests/org.openjdk.jmc.ide.launch.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.joverflow.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.rjmx.test/.settings/org.eclipse.jdt.core.prefs ! application/tests/org.openjdk.jmc.ui.common.test/.settings/org.eclipse.jdt.core.prefs ! application/uitests/org.openjdk.jmc.console.persistence.uitest/.settings/org.eclipse.jdt.core.prefs ! application/uitests/org.openjdk.jmc.console.uitest/.settings/org.eclipse.jdt.core.prefs ! application/uitests/org.openjdk.jmc.rcp.application.uitest/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.common/.settings/org.eclipse.jdt.core.prefs ! core/tests/org.openjdk.jmc.common.test/.settings/org.eclipse.jdt.core.prefs Changeset: 420b03a2faa7 Author: hirt Date: 2019-07-02 00:47 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/420b03a2faa7 JMC-6518: Fix formatting of some notes in the Start Flight Recording wizard Reviewed-by: hirt Contributed-by: clanger ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages_zh_CN.properties ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages.properties Changeset: 7d46393c3bed Author: ebaron Date: 2019-07-03 11:55 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/7d46393c3bed JMC-5327: Using HdrHistograms to visualize latencies Summary: Add HdrHistogram-backed table to show IO latency percentile distribution Reviewed-by: hirt, aptmac ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml + application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java + application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ItemHistogram.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/FileIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/SocketIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/column/ColumnManager.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/META-INF/MANIFEST.MF + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/IOPageTestBase.java + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/resources/jfr/io_test.jfr ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml Changeset: 842000eb6bf7 Author: aptmac Date: 2019-07-03 15:07 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/842000eb6bf7 JMC-5657: Start using JaCoCo for code coverage Summary: Added code coverage with JaCoCo for all the modules in both jmc/core/ and jmc/application Reviewed-by: ghb, aptmac Contributed-by: Carmine Vincenzo Russo ! .gitignore ! .hgignore + application/coverage/pom.xml ! application/pom.xml ! application/tests/pom.xml ! application/uitests/pom.xml + core/coverage/pom.xml ! core/pom.xml ! core/tests/pom.xml Changeset: e17627ddb9c0 Author: jmatsuoka Date: 2019-07-05 10:59 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/e17627ddb9c0 JMC-5706: JavaBlocking rule should report total block times Summary: Added total block time to information displayed about most blocked thread or class Reviewed-by: aptmac, jmatsuoka Contributed-by: Jessye Coleman-Shapiro ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/JavaBlockingRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: 8ea70b7b04c4 Author: hirt Date: 2019-07-05 17:36 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/8ea70b7b04c4 JMC-6520: Removing the old JDK version rule Reviewed-by: ghb,neugens - core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/UnsupportedJdkVersionRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/META-INF/services/org.openjdk.jmc.flightrecorder.rules.IRule ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: d33ac305d7be Author: hirt Date: 2019-07-11 17:23 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/d33ac305d7be JMC-6512: Competing CPU load rule should take overall load into account Reviewed-by: jkang, hirt Contributed-by: Florian David ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/cpu/CompareCpuRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: b3f19d17c4f7 Author: hdafgard Date: 2019-07-11 17:52 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/b3f19d17c4f7 JMC-5701: GC stall rule never reports OK result Summary: Require GC events to be both unavailable and disabled to return a N/A result Reviewed-by: hdafgard Contributed-by: Florian David ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/GcStallRule.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: f8e85b2ad8dd Author: hirt Date: 2019-07-13 15:33 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f8e85b2ad8dd JMC-4057: Flame graph view delivered as experimental plug-in Reviewed-by: Jie Kang , hdafgard Contributed-by: hirt, mwengner, Nenad Bogojevic + application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/.project + application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/build.properties + application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.properties + application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.xml + application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/pom.xml + application/org.openjdk.jmc.flightrecorder.ext.flameview/.classpath + application/org.openjdk.jmc.flightrecorder.ext.flameview/.project + application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.m2e.core.prefs + application/org.openjdk.jmc.flightrecorder.ext.flameview/META-INF/MANIFEST.MF + application/org.openjdk.jmc.flightrecorder.ext.flameview/build.properties + application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame.png + application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame at 2x.png + application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.properties + application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.xml + application/org.openjdk.jmc.flightrecorder.ext.flameview/pom.xml + application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceNode.java + application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceTreeUtils.java + application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/FlameGraphView.java + application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/page.html ! application/org.openjdk.jmc.updatesite.ide/category.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/category.xml ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsolePreferencesTest.java ! configuration/ide/eclipse/launchers/JMC Eclipse plug-ins (JDK 8).launch ! configuration/ide/eclipse/launchers/JMC Eclipse plug-ins.launch ! configuration/ide/eclipse/launchers/JMC RCP plug-ins (JDK 8).launch ! configuration/ide/eclipse/launchers/JMC RCP plug-ins.launch ! core/org.openjdk.jmc.flightrecorder.rules.jdk/.settings/org.eclipse.jdt.core.prefs ! core/org.openjdk.jmc.flightrecorder.rules/.settings/org.eclipse.jdt.core.prefs Changeset: 3ebb70a155d1 Author: aptmac Date: 2019-07-16 11:42 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/3ebb70a155d1 JMC-6492: Add unit support for jdk.jfr.Frequency Reviewed-by: aptmac, neugens Contributed-by: Jie Kang ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkMetadata.java Changeset: dee2cfe0edc0 Author: aptmac Date: 2019-07-16 14:05 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/dee2cfe0edc0 JMC-5499: Add XFlagChanged events to JVM Internals Page Summary: Created JVM Flags Log table on JVM Internals Page to display XFlagChanged events. Reviewed-by: aptmac, neugens Contributed-by: Jessye Coleman-Shapiro ! application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/JVMInformationPageTest.java + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/resources/jfr/flags_changed.jfr ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java Changeset: 5c48822d0147 Author: aptmac Date: 2019-07-17 12:53 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/5c48822d0147 JMC-6082: JOverflow does not handle large heap dumps well Summary: Corrected CachedReadBufferFactory from closing dump files prematurely Reviewed-by: hirt Contributed-by: Kangcheng Xu ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/parser/ReadBuffer.java Changeset: 9a74cf778b23 Author: aptmac Date: 2019-07-22 14:41 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/9a74cf778b23 JMC-6524: Rename Launcher files and exclude spaces Reviewed-by: hirt, aptmac Contributed-by: Jie Kang - configuration/ide/eclipse/launchers/JMC Eclipse (JDK 8).launch - configuration/ide/eclipse/launchers/JMC Eclipse plug-ins (JDK 8).launch - configuration/ide/eclipse/launchers/JMC Eclipse plug-ins.launch - configuration/ide/eclipse/launchers/JMC Eclipse.launch - configuration/ide/eclipse/launchers/JMC RCP (JDK 8).launch - configuration/ide/eclipse/launchers/JMC RCP plug-ins (JDK 8).launch - configuration/ide/eclipse/launchers/JMC RCP plug-ins.launch - configuration/ide/eclipse/launchers/JMC RCP.launch + configuration/ide/eclipse/launchers/JMC-Eclipse-JDK-8.launch + configuration/ide/eclipse/launchers/JMC-Eclipse-plug-ins-JDK-8.launch + configuration/ide/eclipse/launchers/JMC-Eclipse-plug-ins.launch + configuration/ide/eclipse/launchers/JMC-Eclipse.launch + configuration/ide/eclipse/launchers/JMC-RCP-JDK-8.launch + configuration/ide/eclipse/launchers/JMC-RCP-plug-ins-JDK-8.launch + configuration/ide/eclipse/launchers/JMC-RCP-plug-ins.launch + configuration/ide/eclipse/launchers/JMC-RCP.launch - configuration/ide/eclipse/launchers/Remote RCP Debugging.launch + configuration/ide/eclipse/launchers/Remote-RCP-Debugging.launch Changeset: 7d10e844548e Author: hdafgard Date: 2019-07-22 15:14 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/7d10e844548e JMC-6537: Autoboxing rule is slow Summary: Rewrote autoboxing rule to use StacktraceModel instead of Aggregators with String-based IItemFilters to improve performance Reviewed-by: mhirt ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AutoBoxingRule.java Changeset: 6f1cf187885b Author: hirt Date: 2019-07-29 14:14 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/6f1cf187885b JMC-6541: Switching to more compact data format for the flame graph json, also updating to new version of the flame graph library (JMC-6530) Reviewed-by: hdafgard ! application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/FlameGraphView.java ! application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/page.html Changeset: bf6609b40d80 Author: hdafgard Date: 2019-08-08 19:01 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/bf6609b40d80 JMC-6544: Allow FlightRecordingSupportRule to run even with an unknown Java version Summary: Fix bugs where FlightRecordingSupportRule and CodeCachePage cause NPEs when run on recordings made with certain unknown JVMs Reviewed-by: hdafgard Contributed-by: Florian David ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/CodeCachePage.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/FlightRecordingSupportRule.java Changeset: 69f6cde0eb0c Author: kdobson Date: 2019-08-08 16:47 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/69f6cde0eb0c JMC-5640: Heap Usage after GC Chart Summary: Adds a chart to the Garbage Collections Page displaying Heap Usage Post GC Reviewed By: hdafgard, neugens ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties Changeset: 5b716ee5bbeb Author: hdafgard Date: 2019-08-12 16:29 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/5b716ee5bbeb JMC-6548: Allow multiple java agents in jvm argument rule check Summary: Duplicate flags rule now checks for duplicated java agents properly so multiple agents will not trigger a warning result Reviewed-by: hdafgard Contributed-by: Florian David ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/JvmInternalsDataProvider.java + core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/java/org/openjdk/jmc/flightrecorder/test/rules/dataproviders/TestJvmInternalsDataProvider.java Changeset: fbefd07aa4b6 Author: jkang Date: 2019-08-19 11:57 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/fbefd07aa4b6 JMC-6115: Use Jemmy builds from Maven Central Summary: Jemmy now comes from the local p2 repository and uses the updated Jemmy version 2.0.0 Reviewed-by: aptmac, hirt ! README.md ! application/uitests/org.openjdk.jmc.test.jemmy/.classpath ! application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.test.jemmy/build.properties ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/base/wrappers/MCJemmyBase.java ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml Changeset: f8c62bc5783d Author: hdafgard Date: 2019-08-27 00:23 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f8c62bc5783d JMC-6556: Remove static modifier for struct map in TypeManager Summary: Removes static modifier to fix memory leak and maybe prevent other bugs Reviewed-by: egahlin ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java Changeset: eab31bec00c6 Author: aptmac Date: 2019-08-27 10:51 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/eab31bec00c6 JMC-6553: Update error message when JFR is not available Summary: Edit error message for unavailable JFR and rename some message variables Reviewed-by: hirt, ghb Contributed-by: Salman Siddiqui ! application/l10n/org.openjdk.jmc.rjmx.ja/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages_zh_CN.properties ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/JVMSupportToolkit.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/messages/internal/Messages.java ! application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/messages/internal/messages.properties ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/JVMSupportToolkitTest.java ! application/uitests/org.openjdk.jmc.browser.uitest/src/test/java/org/openjdk/jmc/browser/uitest/jvmcompat/ConnectionMessageTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JvmBrowser.java Changeset: 859c3fb83aeb Author: hirt Date: 2019-09-05 21:18 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/859c3fb83aeb JMC-6564: Add distribution management section for release versions Reviewed-by: hirt Contributed-by: reinhapa ! pom.xml Changeset: 55e40ac38237 Author: jmatsuoka Date: 2019-09-10 13:07 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/55e40ac38237 JMC-6559: Fix typos in Spotbugs exclude Summary: Correct typos and exclude false positives Reviewed-by: jkang, neugens, jmatsuoka Contributed-by: Kangcheng Xu ! configuration/spotbugs/spotbugs-exclude.xml Changeset: cf7c184dbed4 Author: hirt Date: 2019-09-11 10:42 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/cf7c184dbed4 JMC-6546: Fixing the update sites in JMC 7.1.0 Reviewed-by: ebaron, klward ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml Changeset: 2ca097091ebb Author: hdafgard Date: 2019-09-18 18:47 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/2ca097091ebb JMC-6582: ItemTreeBuilder is slow and not interruptible Summary: Improve performance by using proper accessors and add implementable interface to allow interruption Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/ItemTreeBuilder.java ! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TreeNode.java Changeset: 7e694af88f7d Author: hirt Date: 2019-09-23 12:43 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/7e694af88f7d JMC-6584: Include Flame View by default Reviewed-by: hdafgard - application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/.project - application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/build.properties - application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.properties - application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/feature.xml - application/org.openjdk.jmc.feature.flightrecorder.ext.flameview/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml - application/org.openjdk.jmc.flightrecorder.ext.flameview/.classpath - application/org.openjdk.jmc.flightrecorder.ext.flameview/.project - application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.jdt.core.prefs - application/org.openjdk.jmc.flightrecorder.ext.flameview/.settings/org.eclipse.m2e.core.prefs - application/org.openjdk.jmc.flightrecorder.ext.flameview/META-INF/MANIFEST.MF - application/org.openjdk.jmc.flightrecorder.ext.flameview/build.properties - application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame.png - application/org.openjdk.jmc.flightrecorder.ext.flameview/icons/flame at 2x.png - application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.properties - application/org.openjdk.jmc.flightrecorder.ext.flameview/plugin.xml - application/org.openjdk.jmc.flightrecorder.ext.flameview/pom.xml - application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceNode.java - application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/tree/TraceTreeUtils.java - application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/FlameGraphView.java - application/org.openjdk.jmc.flightrecorder.ext.flameview/src/main/java/org/openjdk/jmc/flightrecorder/ext/flameview/views/page.html + application/org.openjdk.jmc.flightrecorder.flameview/.classpath + application/org.openjdk.jmc.flightrecorder.flameview/.project + application/org.openjdk.jmc.flightrecorder.flameview/.settings/org.eclipse.jdt.core.prefs + application/org.openjdk.jmc.flightrecorder.flameview/.settings/org.eclipse.m2e.core.prefs + application/org.openjdk.jmc.flightrecorder.flameview/META-INF/MANIFEST.MF + application/org.openjdk.jmc.flightrecorder.flameview/build.properties + application/org.openjdk.jmc.flightrecorder.flameview/icons/flame.png + application/org.openjdk.jmc.flightrecorder.flameview/icons/flame at 2x.png + application/org.openjdk.jmc.flightrecorder.flameview/plugin.properties + application/org.openjdk.jmc.flightrecorder.flameview/plugin.xml + application/org.openjdk.jmc.flightrecorder.flameview/pom.xml + application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java + application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java + application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java + application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/page.html + application/org.openjdk.jmc.rcp.product/.settings/org.eclipse.core.resources.prefs ! application/org.openjdk.jmc.updatesite.ide/category.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/category.xml ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/pom.xml ! configuration/ide/eclipse/launchers/JMC-Eclipse-plug-ins-JDK-8.launch ! configuration/ide/eclipse/launchers/JMC-Eclipse-plug-ins.launch ! configuration/ide/eclipse/launchers/JMC-RCP-plug-ins-JDK-8.launch ! configuration/ide/eclipse/launchers/JMC-RCP-plug-ins.launch Changeset: 87389ca6755a Author: Jie Kang Date: 2019-09-26 11:16 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/87389ca6755a JMC-5473: Quick search for Automated Analysis Result Table Reviewed-by: aptmac, hdafgard Contributed-by: Jie Kang , Carmine Vincenzo Russo ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultTableUi.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrRecordingTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/OldRecordingsVerificationTest.java + application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/ResultOverviewTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrUi.java Changeset: 5eff6ced81be Author: hirt Date: 2019-10-11 22:43 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/5eff6ced81be JMC-6519: Set a correct default destination file for flight recordings in IDE mode Reviewed-by: hirt Contributed-by: clanger ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java ! application/org.openjdk.jmc.ide.ui/src/main/java/org/openjdk/jmc/ide/ui/idesupport/EclipseIDESupport.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/RCPApplicationIDESupport.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IDESupportToolkit.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IIDESupport.java Changeset: 52d0c2777f2c Author: hirt Date: 2019-10-18 10:37 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/52d0c2777f2c JMC-6594: Fix Eclipse project names Reviewed-by: hirt Contributed-by: clanger ! application/uitests/org.openjdk.jmc.console.uitest/.classpath ! core/org.openjdk.jmc.common/.project ! core/org.openjdk.jmc.flightrecorder.rules.jdk/.project ! core/org.openjdk.jmc.flightrecorder.rules/.project ! core/org.openjdk.jmc.flightrecorder/.project ! core/tests/org.openjdk.jmc.common.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.test/.project Changeset: 618fc035cce7 Author: hirt Date: 2019-10-18 14:46 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/618fc035cce7 JMC-6595: Add Eclipse 2019-09 target definition Reviewed-by: hirt Contributed-by: clanger ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/.project ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-2018-12/.project ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2018-12/pom.xml ! releng/platform-definitions/platform-definition-2019-03/.project ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-03/pom.xml ! releng/platform-definitions/platform-definition-2019-06/.project ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-2019-06/pom.xml + releng/platform-definitions/platform-definition-2019-09/.project + releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target + releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-photon/.project ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml Changeset: bee9d0ed0d4e Author: hirt Date: 2019-10-20 12:22 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/bee9d0ed0d4e JMC-6596: Remove extra text in platform-definition-photon Reviewed-by: aptmac, hirt Contributed-by: jkang ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target Changeset: 0c55ab1594b6 Author: Klara Ward Date: 2019-10-16 16:37 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/0c55ab1594b6 JMC-6557: Thread lanes on Threads page are not persisted Summary: Save the lane state. Reviewed-by: hdafgard ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java Changeset: e5e3088a5a46 Author: hirt Date: 2019-10-24 20:05 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/e5e3088a5a46 JMC-6558: Bringing back agent changes from hirt's GitHub fork Reviewed-by: hirt Contributed-by: Jessye Coleman-Shapiro, jmatsuoka, hirt ! core/org.openjdk.jmc.agent/README.md + core/org.openjdk.jmc.agent/launchers/InstrumentMe.launch + core/org.openjdk.jmc.agent/launchers/InstrumentMeConverter.launch ! core/org.openjdk.jmc.agent/pom.xml ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Agent.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Parameter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/TransformDescriptor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Transformer.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/DefaultStringConverter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/DoubleConverter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/package-info.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/JFRTransformDescriptor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFRClassVisitor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFRMethodAdvisor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextClassVisitor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextEventClassGenerator.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextMethodAdvisor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMBean.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/util/TypeUtils.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterDouble.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterFloat.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterInt.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterLong.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterString.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/InstrumentMeConverter.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/TestConverterTransforms.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/AllTests.java - core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/GurkConverterString.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/InstrumentMe.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestJFRTransformer.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestSetTransforms.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestToolkit.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestVisitor.java + core/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml ! core/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_template.xml Changeset: c8699aa5d2f4 Author: hirt Date: 2019-10-24 20:55 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/c8699aa5d2f4 JMC-6593: Flame graphs should be rendered starting with the thread roots first by default Reviewed-by: jkang, hdafgard ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java Changeset: 41facaf39202 Author: aptmac Date: 2019-10-24 21:43 -0400 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/41facaf39202 JMC-6555: Convert JOverflow plugin to SWT Summary: JOverflow plugin now uses SWT/JFace. Extra dependencies on jfx are dropped. Reviewed-by: hirt, jkang Contributed-by: Kangcheng Xu ! application/coverage/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml - application/org.openjdk.jmc.javafx.osgi/.classpath - application/org.openjdk.jmc.javafx.osgi/.project - application/org.openjdk.jmc.javafx.osgi/.settings/org.eclipse.jdt.core.prefs - application/org.openjdk.jmc.javafx.osgi/.settings/org.eclipse.pde.prefs - application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF - application/org.openjdk.jmc.javafx.osgi/build.properties - application/org.openjdk.jmc.javafx.osgi/pom.xml - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/binding/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/charts/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/scene/control/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/scene/control/skin/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/tk/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/tk/quantum/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/animation/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/application/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/binding/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/property/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/property/adapter/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/value/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/collections/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/collections/transformation/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/concurrent/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/css/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/embed/swing/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/embed/swt/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/event/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/fxml/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/geometry/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/print/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/canvas/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/chart/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/control/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/control/cell/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/effect/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/image/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/input/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/layout/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/media/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/paint/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/shape/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/text/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/transform/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/web/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/stage/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/util/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/util/converter/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/main/java/org/openjdk/jmc/javafx/osgi/FXToolkit.java ! application/org.openjdk.jmc.joverflow.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.joverflow.ui/plugin.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/FxMain.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/InstancesPageBookView.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowFxUi.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowPlugin.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowUi.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/LoadingUi.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractFxEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractFxPage.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractStaticFxEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/FxmlHelper.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ClusterType.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/JavaThingItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/MemoryStatisticsItem.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelLoader.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ObjectCluster.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferenceChain.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItemBuilder.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/TreeItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/ArcItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/ColumnLayout.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/FilterList.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/PieChart.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/tabletree/TreeItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/tabletree/TreeTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/ArcAttributeChangedEvent.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/BaseArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/ColorIndexedArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/FilterChangedListener.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/IArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/IArcAttributeProviderListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/AncestorViewer.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/BaseViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/CellFactories.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ClusterGroupViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ItemPieChart.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingTree.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingTreeViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTableViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/OverheadTypeViewer.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/PieChartViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerItemBuilder.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTreeViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/JOverflowFxUi.fxml - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/grey.css - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/grey_round_tables.css - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/viewers/ItemPieChart.fxml ! application/pom.xml ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml Changeset: 64e04b73fb17 Author: hdafgard Date: 2019-10-25 15:48 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/64e04b73fb17 JMC-6587: IncreasingLiveSetRule triggers too often Summary: The heuristic for detecting live set increases should not warn without old collections occurring and should not trigger without at least a few young collections. Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml Changeset: eae73d812969 Author: hirt Date: 2019-10-28 12:25 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/eae73d812969 JMC-6600: Making JOverflow part of the core distribution Reviewed-by: hdafgard ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml + application/org.openjdk.jmc.joverflow.ui/icons/joverflow.png + application/org.openjdk.jmc.joverflow.ui/icons/joverflow at 2x.png - application/org.openjdk.jmc.joverflow.ui/icons/joverflow_16.png ! application/org.openjdk.jmc.joverflow.ui/plugin.xml ! application/org.openjdk.jmc.updatesite.ide/category.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/category.xml ! application/org.openjdk.jmc.updatesite.rcp/feature.xml Changeset: 3c5c22189d12 Author: hirt Date: 2019-10-30 00:36 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/3c5c22189d12 JMC-6589: Bundle the d3 library for flame charts with JMC Reviewed-by: hirt, jkang Contributed-by: mwengner ! application/org.openjdk.jmc.flightrecorder.flameview/.classpath ! application/org.openjdk.jmc.flightrecorder.flameview/build.properties ! application/org.openjdk.jmc.flightrecorder.flameview/pom.xml ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java - application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/page.html + application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template Changeset: 6f897228487c Author: hirt Date: 2019-10-31 12:07 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/6f897228487c JMC-6619: Updating the thirdpary license to include notices for the js libraries Reviewed-by: jkang, neugens ! license/THIRDPARTYREADME.txt Changeset: 20f28322c4a6 Author: hdafgard Date: 2019-10-31 16:26 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/20f28322c4a6 JMC-6621: Infinite loop in parser when file has event size 0 Summary: Add check for events with event size 0 in jfr v1 chunk parser Reviewed-by: egahlin, hirt ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java Changeset: 671b62f6ada3 Author: hdafgard Date: 2019-10-31 16:45 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/671b62f6ada3 JMC-6621: Removed line from parser Summary: Re-add accidentally deleted line from parser Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java Changeset: 435e75ef789c Author: hirt Date: 2019-11-06 21:29 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/435e75ef789c JMC-6622: Correcting landing page information Reviewed-by: jkang, hdafgard ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html From marcus at hirt.se Sun Nov 10 15:32:25 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Sun, 10 Nov 2019 15:32:25 +0000 Subject: hg: jmc/jmc7: JMC-6602: Release splash Message-ID: <201911101532.xAAFWPQH011215@aojmv0008.oracle.com> Changeset: c10c324bdd5a Author: hirt Date: 2019-11-10 16:32 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/c10c324bdd5a JMC-6602: Release splash ! application/org.openjdk.jmc.rcp.application/splash.bmp From marcus at hirt.se Sun Nov 10 21:42:15 2019 From: marcus at hirt.se (Marcus Hirt) Date: Sun, 10 Nov 2019 22:42:15 +0100 Subject: Review request for JMC-6603: Changing core over to the release version Message-ID: <004f01d5980f$b7bbb080$27331180$@hirt.se> Hi all, Please review this fix to switch core over to the release version. Jira: https://bugs.openjdk.java.net/browse/JMC-6603 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6603/webrev.0/ Kind regards, Marcus From guru.hb at oracle.com Mon Nov 11 08:51:54 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 11 Nov 2019 14:21:54 +0530 Subject: Review request for JMC-6603: Changing core over to the release version In-Reply-To: <004f01d5980f$b7bbb080$27331180$@hirt.se> References: <004f01d5980f$b7bbb080$27331180$@hirt.se> Message-ID: <0F273830-2D0E-4AD9-AC57-8D66E0481E6A@oracle.com> +1, Looks Good to me Thanks, Guru > On 11-Nov-2019, at 3:12 AM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to switch core over to the release version. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6603 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6603/webrev.0/ > > Kind regards, > Marcus > From marcus at hirt.se Mon Nov 11 11:47:33 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Mon, 11 Nov 2019 11:47:33 +0000 Subject: hg: jmc/jmc7: JMC-6603: Changing core over to the release version Message-ID: <201911111147.xABBlXfY016705@aojmv0008.oracle.com> Changeset: 3b3210cd4bab Author: hirt Date: 2019-11-11 12:47 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/3b3210cd4bab JMC-6603: Changing core over to the release version Reviewed-by: ghb ! application/pom.xml ! core/coverage/pom.xml ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml From marcus.hirt at datadoghq.com Mon Nov 11 15:27:27 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 11 Nov 2019 16:27:27 +0100 Subject: Update on the GitHub switch Message-ID: Hi all, Quick update on the GitHub switch: the GitHub repo [0] will be made writable around 8:30 a.m. CET on Thursday (the 21st of November, 2019). Kind regards, Marcus [0]: https://github.com/openjdk/jmc From guru.hb at oracle.com Mon Nov 11 17:31:44 2019 From: guru.hb at oracle.com (Guru) Date: Mon, 11 Nov 2019 23:01:44 +0530 Subject: RFR: JMC-6629: jmc.product merge failure during jmc 7.1.0 branching Message-ID: Hi All, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JMC-6629 Web rev : http://cr.openjdk.java.net/~ghb/JMC-6629/webrev.0/ Solution : jmc.product wasn?t merged correctly during jmc to jmc7 (mercurial merge while resolving JMC-6601). Thanks, Guru From marcus.hirt at datadoghq.com Mon Nov 11 17:32:58 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 11 Nov 2019 18:32:58 +0100 Subject: RFR: JMC-6629: jmc.product merge failure during jmc 7.1.0 branching In-Reply-To: References: Message-ID: LGTM! /M On Mon, Nov 11, 2019 at 6:32 PM Guru wrote: > > Hi All, > > Please review the fix for > JBS : https://bugs.openjdk.java.net/browse/JMC-6629 > Web rev : http://cr.openjdk.java.net/~ghb/JMC-6629/webrev.0/ > Solution : jmc.product wasn?t merged correctly during jmc to jmc7 (mercurial merge while resolving JMC-6601). > > Thanks, > Guru From guru.hb at oracle.com Mon Nov 11 17:34:08 2019 From: guru.hb at oracle.com (guru.hb at oracle.com) Date: Mon, 11 Nov 2019 17:34:08 +0000 Subject: hg: jmc/jmc7: JMC-6629: jmc.product merge failure during jmc 7.1.0 branching Message-ID: <201911111734.xABHY95T029474@aojmv0008.oracle.com> Changeset: 21e25b096933 Author: ghb Date: 2019-11-11 23:03 +0530 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/21e25b096933 JMC-6629: jmc.product merge failure during jmc 7.1.0 branching Reviewed-by: hirt ! application/org.openjdk.jmc.rcp.product/jmc.product From marcus.hirt at datadoghq.com Tue Nov 12 14:04:38 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 12 Nov 2019 15:04:38 +0100 Subject: Review request for JMC-6630: Adding jcheck configuration Message-ID: Hi all, Please review this patch to add a jcheck configuration file in preparation for the move to GitHub. Jira: https://bugs.openjdk.java.net/browse/JMC-6630 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6630/webrev.0/ Kind regards, Marcus From erik.helin at oracle.com Tue Nov 12 14:40:38 2019 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 12 Nov 2019 15:40:38 +0100 Subject: Review request for JMC-6630: Adding jcheck configuration In-Reply-To: References: Message-ID: <63e795b4-fe7c-f025-e46f-5e1961ffc736@oracle.com> On 11/12/19 3:04 PM, Marcus Hirt wrote: > Hi all, > > Please review this patch to add a jcheck configuration file in > preparation for the move to GitHub. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6630 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6630/webrev.0/ I'm not used to the UPL copyright header, so I can't comment on that, but line 36 - 56 (the actual configuration) looks good. Thanks, Erik > Kind regards, > Marcus > From marcus.hirt at datadoghq.com Tue Nov 12 14:57:50 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 12 Nov 2019 15:57:50 +0100 Subject: Review request for JMC-6630: Adding jcheck configuration In-Reply-To: <63e795b4-fe7c-f025-e46f-5e1961ffc736@oracle.com> References: <63e795b4-fe7c-f025-e46f-5e1961ffc736@oracle.com> Message-ID: Thank you Erik! Kind regards, Marcus On Tue, Nov 12, 2019 at 3:40 PM Erik Helin wrote: > > On 11/12/19 3:04 PM, Marcus Hirt wrote: > > Hi all, > > > > Please review this patch to add a jcheck configuration file in > > preparation for the move to GitHub. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6630 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6630/webrev.0/ > > I'm not used to the UPL copyright header, so I can't comment on that, > but line 36 - 56 (the actual configuration) looks good. > > Thanks, > Erik > > > Kind regards, > > Marcus > > From marcus at hirt.se Tue Nov 12 15:03:05 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Tue, 12 Nov 2019 15:03:05 +0000 Subject: hg: jmc/jmc7: Added tag 7.1.0-gac for changeset 21e25b096933 Message-ID: <201911121503.xACF35CH023956@aojmv0008.oracle.com> Changeset: 51dd51da8175 Author: hirt Date: 2019-11-12 16:02 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/51dd51da8175 Added tag 7.1.0-gac for changeset 21e25b096933 ! .hgtags From guru.hb at oracle.com Tue Nov 12 15:06:27 2019 From: guru.hb at oracle.com (Guru) Date: Tue, 12 Nov 2019 20:36:27 +0530 Subject: Review request for JMC-6630: Adding jcheck configuration In-Reply-To: References: Message-ID: +1, Looks good to me. Thanks, Guru > On 12-Nov-2019, at 7:34 PM, Marcus Hirt wrote: > > Hi all, > > Please review this patch to add a jcheck configuration file in > preparation for the move to GitHub. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6630 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6630/webrev.0/ > > Kind regards, > Marcus From marcus.hirt at datadoghq.com Tue Nov 12 15:11:31 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 12 Nov 2019 16:11:31 +0100 Subject: The GA candidate of 7.1.0 has been tagged in the jmc7 repo Message-ID: Hi all, See http://hg.openjdk.java.net/jmc/jmc7/rev/51dd51da8175. Any help in testing the release candidate is most welcome! Please ping the mailing-list with any issues found in the 7.1.0-gac, even if they are reported in Jira. Kind regards, Marcus From marcus.hirt at datadoghq.com Tue Nov 12 15:16:55 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 12 Nov 2019 16:16:55 +0100 Subject: Review request for JMC-6630: Adding jcheck configuration In-Reply-To: References: Message-ID: Thanks Guru! Kind regards, Marcus On Tue, Nov 12, 2019 at 4:06 PM Guru wrote: > > +1, Looks good to me. > > Thanks, > Guru > > On 12-Nov-2019, at 7:34 PM, Marcus Hirt wrote: > > > > Hi all, > > > > Please review this patch to add a jcheck configuration file in > > preparation for the move to GitHub. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6630 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6630/webrev.0/ > > > > Kind regards, > > Marcus > From marcus at hirt.se Tue Nov 12 15:26:15 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Tue, 12 Nov 2019 15:26:15 +0000 Subject: hg: jmc/jmc: JMC-6630: Adding initial jcheck configuration Message-ID: <201911121526.xACFQFxJ008461@aojmv0008.oracle.com> Changeset: 37a493c3f60b Author: hirt Date: 2019-11-12 16:25 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/37a493c3f60b JMC-6630: Adding initial jcheck configuration Reviewed-by: ehelin,ghb + .jcheck/conf From erik.helin at oracle.com Thu Nov 14 08:12:47 2019 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 14 Nov 2019 09:12:47 +0100 Subject: Update on the GitHub switch In-Reply-To: References: Message-ID: On 11/11/19 4:27 PM, Marcus Hirt wrote: > Hi all, > > Quick update on the GitHub switch: the GitHub repo [0] will be made > writable around 8:30 a.m. CET on Thursday (the 21st of November, > 2019). The transition has been done and the JMC GitHub repository [0] is now open for business. The jmc-graphics repository has also been transitioned [1]. The corresponding Mercurial repositories have been marked as read-only [2]. There is no need to use any particular client-side tooling to contribute, but for those of you that are interested we have developed a number of utilities meant to aid OpenJDK contributors in project Skara [3]. If you have not yet associated your GitHub account with your OpenJDK username, then now is really the time (otherwise the OpenJDK bots won't recognize you when you contribute). For information on how to associate your GitHub account with your OpenJDK username, please see the Skara wiki page [4]. If you run into any issues, have questions and/or feedback, then please let the Skara team know by sending an email to the skara-dev mailing list [5]. We are constantly tweaking and improving the workflow based on your feedback. Thanks, Erik [0]: https://github.com/openjdk/jmc [1]: https://github.com/openjdk/jmc-graphics [2]: https://hg.openjdk.java.net/jmc/ [3]: https://github.com/openjdk/skara [4]: https://wiki.openjdk.java.net/display/skara#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername [5]: https://mail.openjdk.java.net/mailman/listinfo/skara-dev > Kind regards, > Marcus > > [0]: https://github.com/openjdk/jmc > From hirt at openjdk.org Thu Nov 14 13:54:24 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 13:54:24 GMT Subject: RFR: 6631: Updating version to 8.0.0 Message-ID: This patch updates the version to 8.0.0. ---------------- Commits: - ffd61fd7: Updating to 8.0.0 - 837906dc: Updating to 8.0.0 Changes: https://git.openjdk.java.net/jmc/pull/1/files Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6631 Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod Patch: https://git.openjdk.java.net/jmc/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 PR: https://git.openjdk.java.net/jmc/pull/1 From github.com+513271+Gunde at openjdk.org Thu Nov 14 16:16:18 2019 From: github.com+513271+Gunde at openjdk.org (Henrik Dafg=?UTF-8?B?w6U=?=rd) Date: Thu, 14 Nov 2019 16:16:18 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: > This patch updates the version to 8.0.0. > > ---------------- > > Commits: > - ffd61fd7: Updating to 8.0.0 > - 837906dc: Updating to 8.0.0 > > Changes: https://git.openjdk.java.net/jmc/pull/1/files > Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6631 > Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod > Patch: https://git.openjdk.java.net/jmc/pull/1.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 Approved by Gunde at github.com (no OpenJDK username). PR: https://git.openjdk.java.net/jmc/pull/1 From aptmac at openjdk.org Thu Nov 14 19:14:27 2019 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 14 Nov 2019 19:14:27 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: > This patch updates the version to 8.0.0. > > ---------------- > > Commits: > - ffd61fd7: Updating to 8.0.0 > - 837906dc: Updating to 8.0.0 > > Changes: https://git.openjdk.java.net/jmc/pull/1/files > Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6631 > Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod > Patch: https://git.openjdk.java.net/jmc/pull/1.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: > 78:

Fill in the following URL in the Work with: text field:

> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

> 80:

Press the return key.

My terminal is showing new empty spaces on this line .. ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. ---------------- Changes requested by aptmac (Committer). PR: https://git.openjdk.java.net/jmc/pull/1 From kcr at openjdk.org Thu Nov 14 19:20:15 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 14 Nov 2019 19:20:15 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: <-ybdfKec9flq0gPPSNKc87fW39gUfOzwWvQi1HbySpg=.ed2fcbc8-aa6b-4a3f-bafd-9f03287a2e97@github.com> On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald wrote: > On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: > >> This patch updates the version to 8.0.0. >> >> ---------------- >> >> Commits: >> - ffd61fd7: Updating to 8.0.0 >> - 837906dc: Updating to 8.0.0 >> >> Changes: https://git.openjdk.java.net/jmc/pull/1/files >> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6631 >> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod >> Patch: https://git.openjdk.java.net/jmc/pull/1.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 > > Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? > > application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: > >> 78:

Fill in the following URL in the Work with: text field:

>> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

>> 80:

Press the return key.

> > My terminal is showing new empty spaces on this line .. > ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) > > It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. > > ---------------- > > Changes requested by aptmac (Committer). > Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? The latter. The Skara bot will rebase and squash the commits before merging them. PR: https://git.openjdk.java.net/jmc/pull/1 From hirt at openjdk.org Thu Nov 14 19:23:29 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 19:23:29 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald wrote: > On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: > >> This patch updates the version to 8.0.0. >> >> ---------------- >> >> Commits: >> - ffd61fd7: Updating to 8.0.0 >> - 837906dc: Updating to 8.0.0 >> >> Changes: https://git.openjdk.java.net/jmc/pull/1/files >> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6631 >> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod >> Patch: https://git.openjdk.java.net/jmc/pull/1.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 > > Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? > > application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: > >> 78:

Fill in the following URL in the Work with: text field:

>> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

>> 80:

Press the return key.

> > My terminal is showing new empty spaces on this line .. > ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) > > It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. > > ---------------- > > Changes requested by aptmac (Committer). > Or will they be squashed when merged? They should be automatically squashed. PR: https://git.openjdk.java.net/jmc/pull/1 From hirt at openjdk.org Thu Nov 14 19:33:02 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 19:33:02 GMT Subject: [Rev 01] RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 4c2cd5bf: Fixing whitespace Changes: - all: https://git.openjdk.java.net/jmc/pull/1/files - new: https://git.openjdk.java.net/jmc/pull/1/files/ffd61fd7..4c2cd5bf Webrevs: - full: https://webrevs.openjdk.java.net/jmc/1/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/1/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6631 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 PR: https://git.openjdk.java.net/jmc/pull/1 From hirt at openjdk.org Thu Nov 14 19:35:04 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 19:35:04 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald wrote: > On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: > >> This patch updates the version to 8.0.0. >> >> ---------------- >> >> Commits: >> - ffd61fd7: Updating to 8.0.0 >> - 837906dc: Updating to 8.0.0 >> >> Changes: https://git.openjdk.java.net/jmc/pull/1/files >> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6631 >> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod >> Patch: https://git.openjdk.java.net/jmc/pull/1.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 > > Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? > > application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: > >> 78:

Fill in the following URL in the Work with: text field:

>> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

>> 80:

Press the return key.

> > My terminal is showing new empty spaces on this line .. > ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) > > It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. > > ---------------- > > Changes requested by aptmac (Committer). Funny, the following line also had a tab. Given the standard indentation of the project, they should all be tabs, but they got to be spaced for now. We should add spotless... PR: https://git.openjdk.java.net/jmc/pull/1 From aptmac at openjdk.org Thu Nov 14 19:35:36 2019 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 14 Nov 2019 19:35:36 GMT Subject: [Rev 01] RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 19:33:02 GMT, Marcus Hirt wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 4c2cd5bf: Fixing whitespace > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/1/files > - new: https://git.openjdk.java.net/jmc/pull/1/files/ffd61fd7..4c2cd5bf > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/1/webrev.01 > - incr: https://webrevs.openjdk.java.net/jmc/1/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6631 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jmc/pull/1.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 lgtm! ---------------- Approved by aptmac (Committer). PR: https://git.openjdk.java.net/jmc/pull/1 From hirt at openjdk.org Thu Nov 14 19:43:03 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 19:43:03 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: On Thu, 14 Nov 2019 19:35:04 GMT, Marcus Hirt wrote: > On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald wrote: > >> On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: >> >>> This patch updates the version to 8.0.0. >>> >>> ---------------- >>> >>> Commits: >>> - ffd61fd7: Updating to 8.0.0 >>> - 837906dc: Updating to 8.0.0 >>> >>> Changes: https://git.openjdk.java.net/jmc/pull/1/files >>> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JMC-6631 >>> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod >>> Patch: https://git.openjdk.java.net/jmc/pull/1.diff >>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 >> >> Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? >> >> application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: >> >>> 78:

Fill in the following URL in the Work with: text field:

>>> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

>>> 80:

Press the return key.

>> >> My terminal is showing new empty spaces on this line .. >> ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) >> >> It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. >> >> ---------------- >> >> Changes requested by aptmac (Committer). > > Funny, the following line also had a tab. Given the standard indentation of the project, they should all be tabs, but they got to be spaced for now. > > We should add spotless... @Gunde - okay if I integrate this, even though there will be a review missing on record (since you're not properly hooked up yet)? PR: https://git.openjdk.java.net/jmc/pull/1 From github.com+513271+Gunde at openjdk.org Thu Nov 14 19:46:24 2019 From: github.com+513271+Gunde at openjdk.org (Henrik Dafg=?UTF-8?B?w6U=?=rd) Date: Thu, 14 Nov 2019 19:46:24 GMT Subject: RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: <7u3kYagN-2CaMW3yRIkKlHhRJL-VNX72LHPHeMkaLXI=.75c7b02f-bd63-477d-ba05-1663a48e640c@github.com> On Thu, 14 Nov 2019 19:43:03 GMT, Marcus Hirt wrote: > On Thu, 14 Nov 2019 19:35:04 GMT, Marcus Hirt wrote: > >> On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald wrote: >> >>> On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt wrote: >>> >>>> This patch updates the version to 8.0.0. >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - ffd61fd7: Updating to 8.0.0 >>>> - 837906dc: Updating to 8.0.0 >>>> >>>> Changes: https://git.openjdk.java.net/jmc/pull/1/files >>>> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00 >>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6631 >>>> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod >>>> Patch: https://git.openjdk.java.net/jmc/pull/1.diff >>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1 >>> >>> Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged? >>> >>> application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79: >>> >>>> 78:

Fill in the following URL in the Work with: text field:

>>>> 79:

https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/

>>>> 80:

Press the return key.

>>> >>> My terminal is showing new empty spaces on this line .. >>> ![2019-11-14-140606_1315x375_scrot](https://user-images.githubusercontent.com/10425301/68888327-bcec3f00-06e8-11ea-9ffb-d00cebba2b5f.png) >>> >>> It seems to be because there's a tab just before the `

`, but up until that point it's single spaces. >>> >>> ---------------- >>> >>> Changes requested by aptmac (Committer). >> >> Funny, the following line also had a tab. Given the standard indentation of the project, they should all be tabs, but they got to be spaced for now. >> >> We should add spotless... > > @Gunde - okay if I integrate this, even though there will be a review missing on record (since you're not properly hooked up yet)? > @Gunde - okay if I integrate this, even though there will be a review missing on record (since you're not properly hooked up yet)? Go ahead! PR: https://git.openjdk.java.net/jmc/pull/1 From hirt at openjdk.org Thu Nov 14 19:48:17 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 19:48:17 GMT Subject: [Integrated] RFR: 6631: Updating version to 8.0.0 In-Reply-To: References: Message-ID: Changeset: 481f15b0 Author: Marcus Hirt Date: 2019-11-14 19:47:33 +0000 URL: https://git.openjdk.java.net/jmc/commit/481f15b0 6631: Updating version to 8.0.0 Reviewed-by: aptmac ! README.md ! application/coverage/pom.xml ! application/l10n/org.openjdk.jmc.alert.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.ja/pom.xml ! application/l10n/org.openjdk.jmc.alert.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.docs.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.ja/pom.xml ! application/l10n/org.openjdk.jmc.docs.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.intro.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.zh_CN/pom.xml ! application/l10n/pom.xml ! application/org.openjdk.jmc.alert/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.alert/pom.xml ! application/org.openjdk.jmc.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.attach/pom.xml ! application/org.openjdk.jmc.browser.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.jdp/pom.xml ! application/org.openjdk.jmc.browser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser/pom.xml ! application/org.openjdk.jmc.commands/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.commands/pom.xml ! application/org.openjdk.jmc.console.jconsole/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.jconsole/pom.xml ! application/org.openjdk.jmc.console.pde/pom.xml ! application/org.openjdk.jmc.console.persistence/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.persistence/pom.xml ! application/org.openjdk.jmc.console.twitter/pom.xml ! application/org.openjdk.jmc.console.ui.diagnostic/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.diagnostic/pom.xml ! application/org.openjdk.jmc.console.ui.mbeanbrowser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.mbeanbrowser/pom.xml ! application/org.openjdk.jmc.console.ui.notification/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.notification/pom.xml ! application/org.openjdk.jmc.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/pom.xml ! application/org.openjdk.jmc.docs/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.docs/pom.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.feature.console/feature.xml ! application/org.openjdk.jmc.feature.console/pom.xml ! application/org.openjdk.jmc.feature.core/feature.xml ! application/org.openjdk.jmc.feature.core/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder/pom.xml ! application/org.openjdk.jmc.feature.ide.launch/feature.xml ! application/org.openjdk.jmc.feature.ide.launch/pom.xml ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.ide/pom.xml ! application/org.openjdk.jmc.feature.jconsole/feature.xml ! application/org.openjdk.jmc.feature.jconsole/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.feature.joverflow/pom.xml ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.license/pom.xml ! application/org.openjdk.jmc.feature.pde/feature.xml ! application/org.openjdk.jmc.feature.pde/pom.xml ! application/org.openjdk.jmc.feature.rcp.update/feature.xml ! application/org.openjdk.jmc.feature.rcp.update/pom.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml ! application/org.openjdk.jmc.feature.rcp/pom.xml ! application/org.openjdk.jmc.feature.twitter/feature.xml ! application/org.openjdk.jmc.feature.twitter/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.flightrecorder.flameview/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.flameview/pom.xml ! application/org.openjdk.jmc.flightrecorder.metadata/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.flightrecorder.pde/pom.xml ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ui/pom.xml ! application/org.openjdk.jmc.greychart.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart.ui/pom.xml ! application/org.openjdk.jmc.greychart/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart/pom.xml ! application/org.openjdk.jmc.ide.jdt/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.jdt/pom.xml ! application/org.openjdk.jmc.ide.launch/pom.xml ! application/org.openjdk.jmc.ide.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.ui/pom.xml ! application/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.jdp/pom.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml ! application/org.openjdk.jmc.joverflow/pom.xml ! application/org.openjdk.jmc.osgi.extension/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.osgi.extension/pom.xml ! application/org.openjdk.jmc.pde/pom.xml ! application/org.openjdk.jmc.rcp.application/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.application/pom.xml ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties ! application/org.openjdk.jmc.rcp.application/src/main/resources/updatesites.properties ! application/org.openjdk.jmc.rcp.intro/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.intro/pom.xml ! application/org.openjdk.jmc.rcp.product.feature/feature.xml ! application/org.openjdk.jmc.rcp.product.feature/pom.xml ! application/org.openjdk.jmc.rcp.product/feature.xml ! application/org.openjdk.jmc.rcp.product/jmc.product ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ext/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.services.jfr/pom.xml ! application/org.openjdk.jmc.rjmx.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ui/pom.xml ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx/pom.xml ! application/org.openjdk.jmc.ui.common/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui.common/pom.xml ! application/org.openjdk.jmc.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui/pom.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.ide/pom.xml ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/pom.xml ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.greychart.test/pom.xml ! application/tests/org.openjdk.jmc.ide.launch.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ide.launch.test/pom.xml ! application/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.jdp.test/pom.xml ! application/tests/org.openjdk.jmc.joverflow.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.joverflow.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.test/pom.xml ! application/tests/org.openjdk.jmc.ui.common.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.common.test/pom.xml ! application/tests/org.openjdk.jmc.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.test/pom.xml ! application/tests/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.jconsole.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/pom.xml ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/src/test/java/org/openjdk/jmc/rcp/application/uitest/UpdateSiteTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/pom.xml ! core/coverage/pom.xml ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-2018-12/pom.xml ! releng/platform-definitions/platform-definition-2019-03/pom.xml ! releng/platform-definitions/platform-definition-2019-06/pom.xml ! releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml ! releng/pom.xml ! releng/third-party/pom.xml From hirt at openjdk.org Thu Nov 14 20:34:57 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Nov 2019 20:34:57 GMT Subject: RFR: 6604: Adding EA splash for JMC 8 Message-ID: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> Also fixing progress bar. ---------------- Commits: - 62332ba1: Adding EA splash for JMC 8 Changes: https://git.openjdk.java.net/jmc/pull/2/files Webrev: https://webrevs.openjdk.java.net/jmc/2/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6604 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/2/head:pull/2 PR: https://git.openjdk.java.net/jmc/pull/2 From github.com+513271+Gunde at openjdk.org Fri Nov 15 02:14:18 2019 From: github.com+513271+Gunde at openjdk.org (Henrik Dafg=?UTF-8?B?w6U=?=rd) Date: Fri, 15 Nov 2019 02:14:18 GMT Subject: RFR: 6604: Adding EA splash for JMC 8 In-Reply-To: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> References: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> Message-ID: On Thu, 14 Nov 2019 20:34:57 GMT, Marcus Hirt wrote: > Also fixing progress bar. > > ---------------- > > Commits: > - 62332ba1: Adding EA splash for JMC 8 > > Changes: https://git.openjdk.java.net/jmc/pull/2/files > Webrev: https://webrevs.openjdk.java.net/jmc/2/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6604 > Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jmc/pull/2.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/2/head:pull/2 Approved by Gunde at github.com (no OpenJDK username). PR: https://git.openjdk.java.net/jmc/pull/2 From ehelin at openjdk.org Fri Nov 15 08:57:57 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 15 Nov 2019 08:57:57 GMT Subject: RFR: 6604: Adding EA splash for JMC 8 In-Reply-To: References: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> Message-ID: <_a_IG02Egzg4UiEnNRw7qxcju2HX6u4zb8rgF7VUCGI=.87fbbc33-d319-4366-9f17-fea88e2a7572@github.com> On Fri, 15 Nov 2019 02:14:18 GMT, Henrik Dafg?rd wrote: > On Thu, 14 Nov 2019 20:34:57 GMT, Marcus Hirt wrote: > >> Also fixing progress bar. >> >> ---------------- >> >> Commits: >> - 62332ba1: Adding EA splash for JMC 8 >> >> Changes: https://git.openjdk.java.net/jmc/pull/2/files >> Webrev: https://webrevs.openjdk.java.net/jmc/2/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6604 >> Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod >> Patch: https://git.openjdk.java.net/jmc/pull/2.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/2/head:pull/2 > > Approved by Gunde at github.com (no OpenJDK username). Adding a comment just force the bots to re-evaluate this PR and discover that @Gunde is now associated with the OpenJDK user [hdafgard](http://openjdk.java.net/census#hdafgard) and that this PR therefore has a proper review from the JMC [project](http://openjdk.java.net/census#jmc). PR: https://git.openjdk.java.net/jmc/pull/2 From hirt at openjdk.org Fri Nov 15 09:00:18 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2019 09:00:18 GMT Subject: [Integrated] RFR: 6604: Adding EA splash for JMC 8 In-Reply-To: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> References: <-YQzIjxkcc53Pg3zpqxur2vFv5g2Neakuqw8W4iQFCA=.3bdf8294-086b-498e-aea6-269bc325b649@github.com> Message-ID: <2dce78e5-6f7b-4f12-88f2-7eea79b6e3c1@openjdk.org> Changeset: 046390e6 Author: Marcus Hirt Date: 2019-11-15 08:59:12 +0000 URL: https://git.openjdk.java.net/jmc/commit/046390e6 6604: Adding EA splash for JMC 8 Reviewed-by: hdafgard ! application/org.openjdk.jmc.rcp.application/plugin.xml ! application/org.openjdk.jmc.rcp.application/splash.bmp From marcus at hirt.se Fri Nov 15 13:56:52 2019 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 15 Nov 2019 14:56:52 +0100 Subject: Review request for JMC-6633: Adding jcheck configuration Message-ID: <022001d59bbc$8897bbe0$99c733a0$@hirt.se> Hi all, Please review this fix to make the jmc-graphics repo work with Skara. Jira: https://bugs.openjdk.java.net/browse/JMC-6633 Diff: Directly place an exact copy of .jcheck/conf from the jmc repo into the jmc-graphics repo. Kind regards, Marcus From kxu at redhat.com Fri Nov 15 15:43:59 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Fri, 15 Nov 2019 10:43:59 -0500 Subject: New patch submission process for non-contributors? Message-ID: Hello all, After switched JMC development to GitHub, what is the new process is for a participant, who is not a contributor, to submit simple patches, and make other small contributions? Do we still post a patch file to the mail list and wait for a committer to push to the repository? Or, do we directly submit pull requests on GitHub? Personally speaking, the former one sounds more ideal as GitHub PRs provide an easier and more manageable way to review and update patches. Thank you! Kind Regards, Kangcheng From jkang at redhat.com Fri Nov 15 16:14:24 2019 From: jkang at redhat.com (Jie Kang) Date: Fri, 15 Nov 2019 11:14:24 -0500 Subject: New patch submission process for non-contributors? In-Reply-To: References: Message-ID: Hi Arvin, I believe both workflows are supported. More information on workflows can be found here: https://wiki.openjdk.java.net/display/skara#Skara-Workflows Regards, Jie Kang On Fri, Nov 15, 2019 at 10:46 AM Arvin Kangcheng Xu wrote: > > Hello all, > > After switched JMC development to GitHub, what is the new process is > for a participant, who is not a contributor, to submit simple patches, > and make other small contributions? > > Do we still post a patch file to the mail list and wait for a > committer to push to the repository? Or, do we directly submit pull > requests on GitHub? Personally speaking, the former one sounds more > ideal as GitHub PRs provide an easier and more manageable way to > review and update patches. Thank you! > > Kind Regards, > Kangcheng > From marcus.hirt at datadoghq.com Fri Nov 15 16:17:42 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 15 Nov 2019 17:17:42 +0100 Subject: New patch submission process for non-contributors? In-Reply-To: References: Message-ID: Hi Arvin, PRs on GitHub. If the contributor hasn't been flagged to be covered by an OCA yet, the bot will write a message in the PR about what is required to be able to contribute. Kind regards, Marcus On Fri, Nov 15, 2019 at 4:46 PM Arvin Kangcheng Xu wrote: > > Hello all, > > After switched JMC development to GitHub, what is the new process is > for a participant, who is not a contributor, to submit simple patches, > and make other small contributions? > > Do we still post a patch file to the mail list and wait for a > committer to push to the repository? Or, do we directly submit pull > requests on GitHub? Personally speaking, the former one sounds more > ideal as GitHub PRs provide an easier and more manageable way to > review and update patches. Thank you! > > Kind Regards, > Kangcheng > From marcus.hirt at datadoghq.com Fri Nov 15 16:18:50 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 15 Nov 2019 17:18:50 +0100 Subject: New patch submission process for non-contributors? In-Reply-To: References: Message-ID: I'd prefer if we try to endorse just doing a PR on GitHub. Kind regards, Marcus On Fri, Nov 15, 2019 at 5:17 PM Jie Kang wrote: > > Hi Arvin, > > I believe both workflows are supported. More information on workflows > can be found here: > https://wiki.openjdk.java.net/display/skara#Skara-Workflows > > > Regards, > Jie Kang > > On Fri, Nov 15, 2019 at 10:46 AM Arvin Kangcheng Xu wrote: > > > > Hello all, > > > > After switched JMC development to GitHub, what is the new process is > > for a participant, who is not a contributor, to submit simple patches, > > and make other small contributions? > > > > Do we still post a patch file to the mail list and wait for a > > committer to push to the repository? Or, do we directly submit pull > > requests on GitHub? Personally speaking, the former one sounds more > > ideal as GitHub PRs provide an easier and more manageable way to > > review and update patches. Thank you! > > > > Kind Regards, > > Kangcheng > > > From kxu at redhat.com Fri Nov 15 16:38:16 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Fri, 15 Nov 2019 11:38:16 -0500 Subject: New patch submission process for non-contributors? In-Reply-To: References: Message-ID: Thanks for the information Marcus and Jie! From now I'll submit changes directly as PRs instead of posting to the mailing list. And for clarification, when I said "former" in the original post, I was actually meant to say "latter". :-) Regards, On Fri, 15 Nov 2019 at 11:19, Marcus Hirt wrote: > > I'd prefer if we try to endorse just doing a PR on GitHub. > > Kind regards, > Marcus > > On Fri, Nov 15, 2019 at 5:17 PM Jie Kang wrote: > > > > Hi Arvin, > > > > I believe both workflows are supported. More information on workflows > > can be found here: > > https://wiki.openjdk.java.net/display/skara#Skara-Workflows > > > > > > Regards, > > Jie Kang > > > > On Fri, Nov 15, 2019 at 10:46 AM Arvin Kangcheng Xu wrote: > > > > > > Hello all, > > > > > > After switched JMC development to GitHub, what is the new process is > > > for a participant, who is not a contributor, to submit simple patches, > > > and make other small contributions? > > > > > > Do we still post a patch file to the mail list and wait for a > > > committer to push to the repository? Or, do we directly submit pull > > > requests on GitHub? Personally speaking, the former one sounds more > > > ideal as GitHub PRs provide an easier and more manageable way to > > > review and update patches. Thank you! > > > > > > Kind Regards, > > > Kangcheng > > > > > > From marcus.hirt at datadoghq.com Fri Nov 15 17:15:45 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 15 Nov 2019 18:15:45 +0100 Subject: New patch submission process for non-contributors? In-Reply-To: References: Message-ID: Excellent! Thanks Arvin! Kind regards, Marcus On Fri, Nov 15, 2019 at 5:38 PM Arvin Kangcheng Xu wrote: > > Thanks for the information Marcus and Jie! From now I'll submit > changes directly as PRs instead of posting to the mailing list. > > And for clarification, when I said "former" in the original post, I > was actually meant to say "latter". :-) > > Regards, > > On Fri, 15 Nov 2019 at 11:19, Marcus Hirt wrote: > > > > I'd prefer if we try to endorse just doing a PR on GitHub. > > > > Kind regards, > > Marcus > > > > On Fri, Nov 15, 2019 at 5:17 PM Jie Kang wrote: > > > > > > Hi Arvin, > > > > > > I believe both workflows are supported. More information on workflows > > > can be found here: > > > https://wiki.openjdk.java.net/display/skara#Skara-Workflows > > > > > > > > > Regards, > > > Jie Kang > > > > > > On Fri, Nov 15, 2019 at 10:46 AM Arvin Kangcheng Xu wrote: > > > > > > > > Hello all, > > > > > > > > After switched JMC development to GitHub, what is the new process is > > > > for a participant, who is not a contributor, to submit simple patches, > > > > and make other small contributions? > > > > > > > > Do we still post a patch file to the mail list and wait for a > > > > committer to push to the repository? Or, do we directly submit pull > > > > requests on GitHub? Personally speaking, the former one sounds more > > > > ideal as GitHub PRs provide an easier and more manageable way to > > > > review and update patches. Thank you! > > > > > > > > Kind Regards, > > > > Kangcheng > > > > > > > > > > From clanger at openjdk.org Fri Nov 15 21:51:58 2019 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 15 Nov 2019 21:51:58 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration Message-ID: This is my first PR with skara :) I think it would be nice if jcheck would also check for unnecessary whitespace. ---------------- Commits: - e201163f: 6635: Add whitespace rule to JMC jcheck configuration Changes: https://git.openjdk.java.net/jmc/pull/4/files Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6635 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 PR: https://git.openjdk.java.net/jmc/pull/4 From hirt at openjdk.org Fri Nov 15 22:19:25 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2019 22:19:25 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration In-Reply-To: References: Message-ID: On Fri, 15 Nov 2019 21:51:58 GMT, Christoph Langer wrote: > This is my first PR with skara :) > > I think it would be nice if jcheck would also check for unnecessary whitespace. > > ---------------- > > Commits: > - e201163f: 6635: Add whitespace rule to JMC jcheck configuration > > Changes: https://git.openjdk.java.net/jmc/pull/4/files > Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6635 > Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jmc/pull/4.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. PR: https://git.openjdk.java.net/jmc/pull/4 From hirt at openjdk.org Fri Nov 15 23:15:55 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2019 23:15:55 GMT Subject: RFR: 6636: Adding spotless for core Message-ID: This is a test for adding spotless. After this change you can run mvn spotless:check in core, to see that everything is formatted ok. If it fails, you can run mvn spotless:apply, which will format your source automatically for you. If everyone is happy with spotless, I will make spotless available for all code in JMC, and make spotless checks part of the integration checks. If there are any changes we'd like to do to the formatting template, now would be the time to make them. ;) ---------------- Commits: - 933b0d7f: Adding spotless for core Changes: https://git.openjdk.java.net/jmc/pull/5/files Webrev: https://webrevs.openjdk.java.net/jmc/5/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6636 Stats: 331 lines in 48 files changed: 99 ins; 45 del; 187 mod Patch: https://git.openjdk.java.net/jmc/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/5/head:pull/5 PR: https://git.openjdk.java.net/jmc/pull/5 From hirt at openjdk.org Fri Nov 15 23:16:27 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2019 23:16:27 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration In-Reply-To: References: Message-ID: On Fri, 15 Nov 2019 22:19:25 GMT, Marcus Hirt wrote: > On Fri, 15 Nov 2019 21:51:58 GMT, Christoph Langer wrote: > >> This is my first PR with skara :) >> >> I think it would be nice if jcheck would also check for unnecessary whitespace. >> >> ---------------- >> >> Commits: >> - e201163f: 6635: Add whitespace rule to JMC jcheck configuration >> >> Changes: https://git.openjdk.java.net/jmc/pull/4/files >> Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6635 >> Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/jmc/pull/4.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 > > When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. I added a PR for a first trial run with spotless here: #5, let me know what you think! PR: https://git.openjdk.java.net/jmc/pull/4 From hirt at openjdk.org Fri Nov 15 23:33:04 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2019 23:33:04 GMT Subject: [Rev 01] RFR: 6636: Adding spotless for core In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 33c95aff: Small cleanup Changes: - all: https://git.openjdk.java.net/jmc/pull/5/files - new: https://git.openjdk.java.net/jmc/pull/5/files/933b0d7f..33c95aff Webrevs: - full: https://webrevs.openjdk.java.net/jmc/5/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/5/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6636 Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/5/head:pull/5 PR: https://git.openjdk.java.net/jmc/pull/5 From clanger at openjdk.org Mon Nov 18 08:25:14 2019 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 18 Nov 2019 08:25:14 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration In-Reply-To: References: Message-ID: On Fri, 15 Nov 2019 23:16:27 GMT, Marcus Hirt wrote: > On Fri, 15 Nov 2019 22:19:25 GMT, Marcus Hirt wrote: > >> On Fri, 15 Nov 2019 21:51:58 GMT, Christoph Langer wrote: >> >>> This is my first PR with skara :) >>> >>> I think it would be nice if jcheck would also check for unnecessary whitespace. >>> >>> ---------------- >>> >>> Commits: >>> - e201163f: 6635: Add whitespace rule to JMC jcheck configuration >>> >>> Changes: https://git.openjdk.java.net/jmc/pull/4/files >>> Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JMC-6635 >>> Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod >>> Patch: https://git.openjdk.java.net/jmc/pull/4.diff >>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 >> >> When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. > > I added a PR for a first trial run with spotless here: #5, let me know what you think! > When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. What could be the problems? I think we would not want to have tabs in java code, would we? PR: https://git.openjdk.java.net/jmc/pull/4 From clanger at openjdk.org Mon Nov 18 08:26:11 2019 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 18 Nov 2019 08:26:11 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration In-Reply-To: References: Message-ID: On Mon, 18 Nov 2019 08:25:14 GMT, Christoph Langer wrote: > On Fri, 15 Nov 2019 23:16:27 GMT, Marcus Hirt wrote: > >> On Fri, 15 Nov 2019 22:19:25 GMT, Marcus Hirt wrote: >> >>> On Fri, 15 Nov 2019 21:51:58 GMT, Christoph Langer wrote: >>> >>>> This is my first PR with skara :) >>>> >>>> I think it would be nice if jcheck would also check for unnecessary whitespace. >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - e201163f: 6635: Add whitespace rule to JMC jcheck configuration >>>> >>>> Changes: https://git.openjdk.java.net/jmc/pull/4/files >>>> Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 >>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6635 >>>> Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod >>>> Patch: https://git.openjdk.java.net/jmc/pull/4.diff >>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 >>> >>> When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. >> >> I added a PR for a first trial run with spotless here: #5, let me know what you think! > >> When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. > > What could be the problems? I think we would not want to have tabs in java code, would we? > I added a PR for a first trial run with spotless here: #5, let me know what you think! Cool. I'll look into it. PR: https://git.openjdk.java.net/jmc/pull/4 From hirt at openjdk.org Mon Nov 18 13:02:45 2019 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 18 Nov 2019 13:02:45 GMT Subject: RFR: 6635: Add whitespace rule to JMC jcheck configuration In-Reply-To: References: Message-ID: On Mon, 18 Nov 2019 08:26:11 GMT, Christoph Langer wrote: > On Mon, 18 Nov 2019 08:25:14 GMT, Christoph Langer wrote: > >> On Fri, 15 Nov 2019 23:16:27 GMT, Marcus Hirt wrote: >> >>> On Fri, 15 Nov 2019 22:19:25 GMT, Marcus Hirt wrote: >>> >>>> On Fri, 15 Nov 2019 21:51:58 GMT, Christoph Langer wrote: >>>> >>>>> This is my first PR with skara :) >>>>> >>>>> I think it would be nice if jcheck would also check for unnecessary whitespace. >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - e201163f: 6635: Add whitespace rule to JMC jcheck configuration >>>>> >>>>> Changes: https://git.openjdk.java.net/jmc/pull/4/files >>>>> Webrev: https://webrevs.openjdk.java.net/jmc/4/webrev.00 >>>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6635 >>>>> Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod >>>>> Patch: https://git.openjdk.java.net/jmc/pull/4.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/4/head:pull/4 >>>> >>>> When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. >>> >>> I added a PR for a first trial run with spotless here: #5, let me know what you think! >> >>> When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. >> >> What could be the problems? I think we would not want to have tabs in java code, would we? > >> I added a PR for a first trial run with spotless here: #5, let me know what you think! > > Cool. I'll look into it. > > When I discussed this with Erik (Helin), he told me there could be a problem with us using tabs instead of spaces. I think we should instead try to make spotless part of the process. > > What could be the problems? I think we would not want to have tabs in java code, would we? JMC is formatting code with tabs. One indentation level is one tab. So, if you want to read your code with 2 spaces for one indentation step: https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCMethod.java?ts=2 And if you want to read your code with 6 spaces for one indentation step: https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCMethod.java?ts=6 So, basically set your IDE to however you like the tabs visualized. One size doesn't fit all, and does not have to. :) PR: https://git.openjdk.java.net/jmc/pull/4 From hdafgard at openjdk.java.net Wed Nov 20 15:44:14 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 20 Nov 2019 15:44:14 GMT Subject: [Approved] RFR: 6636: Adding spotless for core In-Reply-To: References: Message-ID: On Fri, 15 Nov 2019 23:33:04 GMT, Marcus Hirt wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 33c95aff: Small cleanup > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/5/files > - new: https://git.openjdk.java.net/jmc/pull/5/files/933b0d7f..33c95aff > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/5/webrev.01 > - incr: https://webrevs.openjdk.java.net/jmc/5/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6636 > Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod > Patch: https://git.openjdk.java.net/jmc/pull/5.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/5/head:pull/5 Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/5 From jkang at redhat.com Wed Nov 20 18:16:50 2019 From: jkang at redhat.com (Jie Kang) Date: Wed, 20 Nov 2019 13:16:50 -0500 Subject: JMC with Static Portable JRE 11 Message-ID: Hey Alex, Mario, I just wanted to give a quick status update to clarify that I am going to get to the bottom of this. I tried to run JMC with the static JRE 11 build on Linux and got the same issue with being unable to see JVMs on the system. JMC on launch warns: WARNING: Unknown module: jdk.management.agent specified to --add-exports WARNING: Unknown module: jdk.attach specified to --add-exports WARNING: Unknown module: jdk.internal.jvmstat specified to --add-exports WARNING: Unknown module: jdk.attach specified to --add-opens I am assuming these are needed for the JVM discovery mechanism. I will see how the static builds are made in openjdk. Maybe there's an alternative API that the JRE 11+ provides that JMC can use instead? Otherwise we can conclude that JMC will not have discovery capability with JRE 11, similar to before modules were introduced. In this situation it can still be used with JRE to open and analyze JFR files on disk. Regards, Jie Kang From neugens at redhat.com Wed Nov 20 18:44:30 2019 From: neugens at redhat.com (Mario Torre) Date: Wed, 20 Nov 2019 19:44:30 +0100 Subject: JMC with Static Portable JRE 11 In-Reply-To: References: Message-ID: The API for jdk.management is new, and also all the others were before accessible through the tools.jar if I recall correctly, since by default the jre has been replaced with the modular jdk it's possible our scripts omit some libraries? If I remember correctly Jiri said that the jre is created "manually", perhaps some of the API that's supposed to be included isn't and it's only found in the full jvm. You should be able to check this by grepping for "jdk.management" in the binary tree and see the difference between the two builds. Cheers, Mario On Wed, Nov 20, 2019 at 7:17 PM Jie Kang wrote: > > Hey Alex, Mario, > > I just wanted to give a quick status update to clarify that I am going > to get to the bottom of this. > > I tried to run JMC with the static JRE 11 build on Linux and got the > same issue with being unable to see JVMs on the system. JMC on launch > warns: > > WARNING: Unknown module: jdk.management.agent specified to --add-exports > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.internal.jvmstat specified to --add-exports > WARNING: Unknown module: jdk.attach specified to --add-opens > > I am assuming these are needed for the JVM discovery mechanism. I will > see how the static builds are made in openjdk. Maybe there's an > alternative API that the JRE 11+ provides that JMC can use instead? > Otherwise we can conclude that JMC will not have discovery capability > with JRE 11, similar to before modules were introduced. In this > situation it can still be used with JRE to open and analyze JFR files > on disk. > > > Regards, > Jie Kang > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From erik.gahlin at oracle.com Wed Nov 20 18:51:02 2019 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 20 Nov 2019 19:51:02 +0100 Subject: JMC with Static Portable JRE 11 In-Reply-To: References: Message-ID: <90674925-9972-2025-403c-5b71b8e28d6c@oracle.com> The jdk.attach module is needed if you want to discover another Java process. Erik On 2019-11-20 19:44, Mario Torre wrote: > The API for jdk.management is new, and also all the others were before > accessible through the tools.jar if I recall correctly, since by > default the jre has been replaced with the modular jdk it's possible > our scripts omit some libraries? If I remember correctly Jiri said > that the jre is created "manually", perhaps some of the API that's > supposed to be included isn't and it's only found in the full jvm. > > You should be able to check this by grepping for "jdk.management" in > the binary tree and see the difference between the two builds. > > Cheers, > Mario > > > On Wed, Nov 20, 2019 at 7:17 PM Jie Kang wrote: >> Hey Alex, Mario, >> >> I just wanted to give a quick status update to clarify that I am going >> to get to the bottom of this. >> >> I tried to run JMC with the static JRE 11 build on Linux and got the >> same issue with being unable to see JVMs on the system. JMC on launch >> warns: >> >> WARNING: Unknown module: jdk.management.agent specified to --add-exports >> WARNING: Unknown module: jdk.attach specified to --add-exports >> WARNING: Unknown module: jdk.internal.jvmstat specified to --add-exports >> WARNING: Unknown module: jdk.attach specified to --add-opens >> >> I am assuming these are needed for the JVM discovery mechanism. I will >> see how the static builds are made in openjdk. Maybe there's an >> alternative API that the JRE 11+ provides that JMC can use instead? >> Otherwise we can conclude that JMC will not have discovery capability >> with JRE 11, similar to before modules were introduced. In this >> situation it can still be used with JRE to open and analyze JFR files >> on disk. >> >> >> Regards, >> Jie Kang >> > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > From neugens at redhat.com Wed Nov 20 18:57:34 2019 From: neugens at redhat.com (Mario Torre) Date: Wed, 20 Nov 2019 19:57:34 +0100 Subject: JMC with Static Portable JRE 11 In-Reply-To: <90674925-9972-2025-403c-5b71b8e28d6c@oracle.com> References: <90674925-9972-2025-403c-5b71b8e28d6c@oracle.com> Message-ID: Hi Erik, Yes, the question is why this API isn't it there in those static builds. I assume Jie meant the OpenJDK JRE build that we ship in Fedora - I'm not entirely sure but I think we still have the possibility to install a minimal jre there and Jie was debugging why JMC isn't working on those. In fact, I think he didn't mean to send this to jmc-dev since this is a packaging question ;) Cheers, Mario On Wed, Nov 20, 2019 at 7:51 PM Erik Gahlin wrote: > > The jdk.attach module is needed if you want to discover another Java > process. > > Erik > > > On 2019-11-20 19:44, Mario Torre wrote: > > The API for jdk.management is new, and also all the others were before > > accessible through the tools.jar if I recall correctly, since by > > default the jre has been replaced with the modular jdk it's possible > > our scripts omit some libraries? If I remember correctly Jiri said > > that the jre is created "manually", perhaps some of the API that's > > supposed to be included isn't and it's only found in the full jvm. > > > > You should be able to check this by grepping for "jdk.management" in > > the binary tree and see the difference between the two builds. > > > > Cheers, > > Mario > > > > > > On Wed, Nov 20, 2019 at 7:17 PM Jie Kang wrote: > >> Hey Alex, Mario, > >> > >> I just wanted to give a quick status update to clarify that I am going > >> to get to the bottom of this. > >> > >> I tried to run JMC with the static JRE 11 build on Linux and got the > >> same issue with being unable to see JVMs on the system. JMC on launch > >> warns: > >> > >> WARNING: Unknown module: jdk.management.agent specified to --add-exports > >> WARNING: Unknown module: jdk.attach specified to --add-exports > >> WARNING: Unknown module: jdk.internal.jvmstat specified to --add-exports > >> WARNING: Unknown module: jdk.attach specified to --add-opens > >> > >> I am assuming these are needed for the JVM discovery mechanism. I will > >> see how the static builds are made in openjdk. Maybe there's an > >> alternative API that the JRE 11+ provides that JMC can use instead? > >> Otherwise we can conclude that JMC will not have discovery capability > >> with JRE 11, similar to before modules were introduced. In this > >> situation it can still be used with JRE to open and analyze JFR files > >> on disk. > >> > >> > >> Regards, > >> Jie Kang > >> > > > > -- > > Mario Torre > > Associate Manager, Software Engineering > > Red Hat GmbH > > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From github.com+16651846+dbenamydd at openjdk.java.net Thu Nov 21 13:02:37 2019 From: github.com+16651846+dbenamydd at openjdk.java.net (Dan Benamy) Date: Thu, 21 Nov 2019 13:02:37 GMT Subject: RFR: 6632: Tighten up english rule messages Message-ID: 6632: Tighten up english rule messages ---------------- Commits: - 36815004: Re-add spaces between values and units - c0bd90f2: Tighten up english rule messages Changes: https://git.openjdk.java.net/jmc/pull/3/files Webrev: https://webrevs.openjdk.java.net/jmc/3/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6632 Stats: 43 lines in 1 file changed: 0 ins; 1 del; 42 mod Patch: https://git.openjdk.java.net/jmc/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 PR: https://git.openjdk.java.net/jmc/pull/3 From hirt at openjdk.java.net Thu Nov 21 13:02:39 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 21 Nov 2019 13:02:39 GMT Subject: RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 13:02:37 GMT, Dan Benamy wrote: > 6632: Tighten up english rule messages > > ---------------- > > Commits: > - 36815004: Re-add spaces between values and units > - c0bd90f2: Tighten up english rule messages > > Changes: https://git.openjdk.java.net/jmc/pull/3/files > Webrev: https://webrevs.openjdk.java.net/jmc/3/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6632 > Stats: 43 lines in 1 file changed: 0 ins; 1 del; 42 mod > Patch: https://git.openjdk.java.net/jmc/pull/3.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 Issue number to refer to is 6632. Aside from the project preference to use ISO 31-0 style space between the number and the percent sign, it all looks good to me. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 58: > 57: ApplicationHaltsRule_RULE_TEXT_OK=Application efficiency was not highly affected by halts. > 58: > 59: AutoboxingRule_RULE_NAME=Primitive To Object Conversion We try to keep a space between value and unit. See https://physics.nist.gov/cuu/Units/checklist.html. See also ISO 31-0. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 127: > 126: CodeCacheRuleFactory_WARN_LONG_DESCRIPTION=This causes the code cache to be swept more frequently, with even higher occupancy causing more frequent sweeps. > 127: CodeCacheRuleFactory_WARN_SEGMENTED_HEAP_SHORT_DESCRIPTION=The {0} code heap reached more than 50% occupancy during the recording. > 128: CodeCacheRuleFactory_WARN_SEGMENTED_HEAPS_SHORT_DESCRIPTION=The {0} code heaps reached more than 50% occupancy during the recording. ISO 31-0. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 283: > 282: # {0} is a memory amount, {1} is a timespan, {2} is a timestamp, {3} is a number, {4} is a memory amount > 283: GcFreedRatioRule_RESULT_LONG_DESCRIPTION={0} per second was freed by garbage collections for {1} at {2}. This is {3} times the average liveset which was {4}. > 284: GcFreedRatioRule_RESULT_MORE_INFO=If the garbage collector can free a lot of memory, it may be because the application allocates a lot of short lived objects. Investigate the allocation stack traces to see which code paths cause the most allocations, and see if they can be reduced. ISO 31-0. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 332: > 331: # {0} is a time period, {1} is a time stamp, {2} is a percentage > 332: HighGcRuleFactory_TEXT_INFO=The JVM was paused for {2} of the {0} at {1}. > 333: HighGcRuleFactory_TEXT_INFO_LONG=The time spent performing garbage collection may be reduced by increasing the heap size or by trying to reduce allocation. ISO 31-0. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 615: > 614: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO=The recording was performed on a JVM that had Experimental VM Options enabled. > 615: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO_LONG=Experimental VM options may be unreliable and should not be used in a production environment. Unless you have to use an experimental option, you should avoid the '-XX:+UnlockExperimentalVMOptions' command line option. > 616: VMOperations_RULE_NAME=VMOperation Peak Duration ISO 31-0. ---------------- Changes requested by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/3 From neugens at redhat.com Fri Nov 22 13:09:58 2019 From: neugens at redhat.com (Mario Torre) Date: Fri, 22 Nov 2019 14:09:58 +0100 Subject: RFR: 6636: Adding spotless for core In-Reply-To: References: Message-ID: On Fri, 2019-11-15 at 23:15 +0000, Marcus Hirt wrote: > If there are any changes we'd like to do to the formatting template, > now would be the time to make them. ;) Does it means that we can hate spaces instead of tabs now? ;) Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Fri Nov 22 14:42:30 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 22 Nov 2019 09:42:30 -0500 Subject: RFR: 6636: Adding spotless for core In-Reply-To: References: Message-ID: We will stick with tabs, like before. That said, there are plenty of discussions we could have apart from the tabs-vs-spaces war, like where to do line breaks etc. Spotless uses our Eclipse formatting settings, so you can see our current formatting settings by importing them into Eclipse. Kind regards, Marcus On Fri, Nov 22, 2019 at 8:10 AM Mario Torre wrote: > > On Fri, 2019-11-15 at 23:15 +0000, Marcus Hirt wrote: > > If there are any changes we'd like to do to the formatting template, > > now would be the time to make them. ;) > > Does it means that we can hate spaces instead of tabs now? ;) > > Cheers, > Mario > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > From hirt at openjdk.java.net Fri Nov 22 20:23:28 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 22 Nov 2019 20:23:28 GMT Subject: [Approved] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 13:02:37 GMT, Dan Benamy wrote: > 6632: Tighten up english rule messages > > ---------------- > > Commits: > - 36815004: Re-add spaces between values and units > - c0bd90f2: Tighten up english rule messages > > Changes: https://git.openjdk.java.net/jmc/pull/3/files > Webrev: https://webrevs.openjdk.java.net/jmc/3/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6632 > Stats: 43 lines in 1 file changed: 0 ins; 1 del; 42 mod > Patch: https://git.openjdk.java.net/jmc/pull/3.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 Approved by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/3 From hirt at openjdk.java.net Fri Nov 22 20:33:49 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 22 Nov 2019 20:33:49 GMT Subject: RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 13:02:39 GMT, Marcus Hirt wrote: > On Thu, 21 Nov 2019 13:02:37 GMT, Dan Benamy wrote: > >> 6632: Tighten up english rule messages >> >> ---------------- >> >> Commits: >> - 36815004: Re-add spaces between values and units >> - c0bd90f2: Tighten up english rule messages >> >> Changes: https://git.openjdk.java.net/jmc/pull/3/files >> Webrev: https://webrevs.openjdk.java.net/jmc/3/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6632 >> Stats: 43 lines in 1 file changed: 0 ins; 1 del; 42 mod >> Patch: https://git.openjdk.java.net/jmc/pull/3.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 > > Issue number to refer to is 6632. > > Aside from the project preference to use ISO 31-0 style space between the number and the percent sign, it all looks good to me. > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 58: > >> 57: ApplicationHaltsRule_RULE_TEXT_OK=Application efficiency was not highly affected by halts. >> 58: >> 59: AutoboxingRule_RULE_NAME=Primitive To Object Conversion > > We try to keep a space between value and unit. See https://physics.nist.gov/cuu/Units/checklist.html. See also ISO 31-0. > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 127: > >> 126: CodeCacheRuleFactory_WARN_LONG_DESCRIPTION=This causes the code cache to be swept more frequently, with even higher occupancy causing more frequent sweeps. >> 127: CodeCacheRuleFactory_WARN_SEGMENTED_HEAP_SHORT_DESCRIPTION=The {0} code heap reached more than 50% occupancy during the recording. >> 128: CodeCacheRuleFactory_WARN_SEGMENTED_HEAPS_SHORT_DESCRIPTION=The {0} code heaps reached more than 50% occupancy during the recording. > > ISO 31-0. > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 283: > >> 282: # {0} is a memory amount, {1} is a timespan, {2} is a timestamp, {3} is a number, {4} is a memory amount >> 283: GcFreedRatioRule_RESULT_LONG_DESCRIPTION={0} per second was freed by garbage collections for {1} at {2}. This is {3} times the average liveset which was {4}. >> 284: GcFreedRatioRule_RESULT_MORE_INFO=If the garbage collector can free a lot of memory, it may be because the application allocates a lot of short lived objects. Investigate the allocation stack traces to see which code paths cause the most allocations, and see if they can be reduced. > > ISO 31-0. > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 332: > >> 331: # {0} is a time period, {1} is a time stamp, {2} is a percentage >> 332: HighGcRuleFactory_TEXT_INFO=The JVM was paused for {2} of the {0} at {1}. >> 333: HighGcRuleFactory_TEXT_INFO_LONG=The time spent performing garbage collection may be reduced by increasing the heap size or by trying to reduce allocation. > > ISO 31-0. > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 615: > >> 614: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO=The recording was performed on a JVM that had Experimental VM Options enabled. >> 615: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO_LONG=Experimental VM options may be unreliable and should not be used in a production environment. Unless you have to use an experimental option, you should avoid the '-XX:+UnlockExperimentalVMOptions' command line option. >> 616: VMOperations_RULE_NAME=VMOperation Peak Duration > > ISO 31-0. > > ---------------- > > Changes requested by hirt (Lead). Need to update the tests too! :) PR: https://git.openjdk.java.net/jmc/pull/3 From github.com+16651846+dbenamydd at openjdk.java.net Fri Nov 22 20:40:49 2019 From: github.com+16651846+dbenamydd at openjdk.java.net (Dan Benamy) Date: Fri, 22 Nov 2019 20:40:49 GMT Subject: [Rev 01] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: <1GqXVKdANfxBaJ1w6Eo86VOuIYvByvUMDUb6aoczS6E=.2a5a9c56-8218-4ad3-a0cf-fade8609c3b8@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 5348b73f: Fix typos Changes: - all: https://git.openjdk.java.net/jmc/pull/3/files - new: https://git.openjdk.java.net/jmc/pull/3/files/36815004..5348b73f Webrevs: - full: https://webrevs.openjdk.java.net/jmc/3/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6632 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 PR: https://git.openjdk.java.net/jmc/pull/3 From hdafgard at openjdk.java.net Fri Nov 22 20:40:52 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 22 Nov 2019 20:40:52 GMT Subject: [Rev 01] RFR: 6632: Tighten up english rule messages In-Reply-To: <1GqXVKdANfxBaJ1w6Eo86VOuIYvByvUMDUb6aoczS6E=.2a5a9c56-8218-4ad3-a0cf-fade8609c3b8@github.com> References: <1GqXVKdANfxBaJ1w6Eo86VOuIYvByvUMDUb6aoczS6E=.2a5a9c56-8218-4ad3-a0cf-fade8609c3b8@github.com> Message-ID: On Fri, 22 Nov 2019 20:40:49 GMT, Dan Benamy wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 5348b73f: Fix typos > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/3/files > - new: https://git.openjdk.java.net/jmc/pull/3/files/36815004..5348b73f > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/3/webrev.01 > - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6632 > Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod > Patch: https://git.openjdk.java.net/jmc/pull/3.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 404: > 403: # {0} is a size in bytes, {1} is a size in bytes > 404: LongGcPauseRuleFactory_TEXT_INFO_MX=The application ran with a live set of {0} and a heap size of {1}. Decreasing the heap size may decrease the garbage collection pause times. > 405: LongGcPauseRuleFactory_TEXT_INFO_REFERENCES=Processing reference objects was a considerable part of the garbage collector pauses. You may be able to decrease this by reducing the amount of references or by enabling parallel reference processing with '-XX:+ParallelRefProcEnabled'. blocking core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 614: > 613: TlabAllocationRatioRuleFactory_TEXT_OK_NO_OUTSIDE=No object allocations outside of TLABs detected. > 614: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO=The recording was performed on a JVM that had Experimental VM Options enabled. > 615: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO_LONG=Experimental VM options may be unreliable and should not be used in a production environment. Unless you have to use an experimental option, you should avoid the '-XX:+UnlockExperimentalVMOptions' command line option. > ...and isn't usually needed. This part feels a little awkward to me. PR: https://git.openjdk.java.net/jmc/pull/3 From github.com+16651846+dbenamydd at openjdk.java.net Fri Nov 22 20:45:45 2019 From: github.com+16651846+dbenamydd at openjdk.java.net (Dan Benamy) Date: Fri, 22 Nov 2019 20:45:45 GMT Subject: [Rev 02] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 9e487227: Tweak rule text based on feedback Changes: - all: https://git.openjdk.java.net/jmc/pull/3/files - new: https://git.openjdk.java.net/jmc/pull/3/files/5348b73f..9e487227 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/3/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.01-02 Issue: https://bugs.openjdk.java.net/browse/JMC-6632 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 PR: https://git.openjdk.java.net/jmc/pull/3 From hdafgard at openjdk.java.net Fri Nov 22 20:46:11 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 22 Nov 2019 20:46:11 GMT Subject: [Approved] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: On Fri, 22 Nov 2019 20:45:45 GMT, Dan Benamy wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 9e487227: Tweak rule text based on feedback > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/3/files > - new: https://git.openjdk.java.net/jmc/pull/3/files/5348b73f..9e487227 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/3/webrev.02 > - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.01-02 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6632 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jmc/pull/3.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/3 From github.com+16651846+dbenamydd at openjdk.java.net Fri Nov 22 20:57:59 2019 From: github.com+16651846+dbenamydd at openjdk.java.net (Dan Benamy) Date: Fri, 22 Nov 2019 20:57:59 GMT Subject: [Rev 03] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - facfd30c: Update tests for message changes Changes: - all: https://git.openjdk.java.net/jmc/pull/3/files - new: https://git.openjdk.java.net/jmc/pull/3/files/9e487227..facfd30c Webrevs: - full: https://webrevs.openjdk.java.net/jmc/3/webrev.03 - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.02-03 Issue: https://bugs.openjdk.java.net/browse/JMC-6632 Stats: 101 lines in 1 file changed: 0 ins; 0 del; 101 mod Patch: https://git.openjdk.java.net/jmc/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 PR: https://git.openjdk.java.net/jmc/pull/3 From hdafgard at openjdk.java.net Fri Nov 22 21:08:41 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 22 Nov 2019 21:08:41 GMT Subject: [Approved] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: On Fri, 22 Nov 2019 20:57:59 GMT, Dan Benamy wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - facfd30c: Update tests for message changes > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/3/files > - new: https://git.openjdk.java.net/jmc/pull/3/files/9e487227..facfd30c > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/3/webrev.03 > - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.02-03 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6632 > Stats: 101 lines in 1 file changed: 0 ins; 0 del; 101 mod > Patch: https://git.openjdk.java.net/jmc/pull/3.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3 Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/3 From hdafgard at openjdk.java.net Fri Nov 22 21:18:39 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 22 Nov 2019 21:18:39 GMT Subject: [Integrated] RFR: 6632: Tighten up english rule messages In-Reply-To: References: Message-ID: <73a21242-7223-41f4-8c25-ce5834f6b852@openjdk.org> Changeset: cf825cae Author: Dan Benamy Committer: Henrik Dafg?rd Date: 2019-11-22 21:18:27 +0000 URL: https://git.openjdk.java.net/jmc/commit/cf825cae 6632: Tighten up english rule messages Reviewed-by: hirt, hdafgard ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml From hirt at openjdk.java.net Fri Nov 22 21:35:38 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 22 Nov 2019 21:35:38 GMT Subject: [Integrated] RFR: 6636: Adding spotless for core In-Reply-To: References: Message-ID: <3bbf8e27-4412-42fa-83ae-3ad166627d99@openjdk.org> Changeset: bab98914 Author: Marcus Hirt Date: 2019-11-22 21:35:21 +0000 URL: https://git.openjdk.java.net/jmc/commit/bab98914 6636: Adding spotless for core Reviewed-by: hdafgard ! core/coverage/pom.xml ! core/org.openjdk.jmc.agent/pom.xml ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/UnitLookup.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/TypeHandling.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersionSupport.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/cpu/CompareCpuRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/JvmInternalsDataProvider.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/FatalErrorRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/FlightRecordingSupportRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/JavaBlockingRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AutoBoxingRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/FullGcRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/GarbageCollectionsInfo.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/GcStallRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HighGcRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/ItemTreeBuilder.java ! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TreeNode.java ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/JfrAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkFilters.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/memleak/ReferenceTreeModel.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/memleak/ReferenceTreeObject.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SettingsTransformer.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/util/ChunkReader.java ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/MCTestCase.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/TestToolkit.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/DeriveUnitTest.java ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/version/JavaVersionTest.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/java/org/openjdk/jmc/flightrecorder/test/rules/dataproviders/TestJvmInternalsDataProvider.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/java/org/openjdk/jmc/flightrecorder/test/rules/jdk/TestRulesWithJfr.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/JfrAttributesTest.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/RecordingToolkit.java ! core/tests/pom.xml From marcus.hirt at datadoghq.com Fri Nov 22 22:01:07 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 22 Nov 2019 17:01:07 -0500 Subject: GitHub Actions for running tests and formatting checks Message-ID: Hi all, I?d like to build GitHub actions for running our tests and formatting checks automatically. This will however need for Docker and the maven image on Docker Hub to be used as new project third-party dependencies. Does anyone have any opinions around this? Note: This is only for triggering these tests etc to be run as part of the GitHub process. Kind regards, Marcus From almacdon at redhat.com Fri Nov 22 22:27:57 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Fri, 22 Nov 2019 17:27:57 -0500 Subject: GitHub Actions for running tests and formatting checks In-Reply-To: References: Message-ID: Hi Marcus, On Fri, Nov 22, 2019 at 5:02 PM Marcus Hirt wrote: > Hi all, > > I?d like to build GitHub actions for running our tests and formatting > checks automatically. This will however need for Docker and the maven > image on Docker Hub to be used as new project third-party > dependencies. Does anyone have any opinions around this? > > Note: This is only for triggering these tests etc to be run as part of > the GitHub process. > FWIW, as far as running tests are concerned, I've been using Travis CI [0] to automate the running of unit tests (and previously uitests until they timed out on my free account). Now that JMC is on GitHub it shouldn't be hard to edit the files to make it work with the main repo. The process just involves enabling Travis for the repo, and supplying a yaml file explaining what happens when Travis starts. These builds can also be attached to PRs, pushes, cron jobs, etc.. For example, I have a repo [1] with some scripts that cloned and built JMC. On a free account IIRC the builds time out after an hour, which is unfortunately not enough time to complete the uitests. I used to have a pro account as a part of my GitHub student pack (and the uitests would run to completion using a virtual display) but this is no longer the case. In any case, I still keep it around to make sure the builds and unit tests run fine for Linux (Ubuntu) [2], Mac [3], and Windows [4]. > > Kind regards, > Marcus > > Cheers, Alex [0] https://travis-ci.org/ [1] https://github.com/aptmac/jmc-qa/tree/master/scripts [2] https://github.com/aptmac/jmc-qa/blob/master/.travis.yml [3] https://github.com/aptmac/jmc-qa/blob/osx/.travis.yml [4] https://github.com/aptmac/jmc-qa/blob/windows/.travis.yml From hirt at openjdk.java.net Sat Nov 23 01:20:04 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 23 Nov 2019 01:20:04 GMT Subject: RFR: 6642: Ignoring dependency reduced poms and js-libraries Message-ID: <7uEMZZJRLZWSt4w7XQ2C3Jo7epNlJgvAljUR79aCtPw=.a2511f9f-298f-44ef-9bae-34d314edb59b@github.com> 6642: Ignoring dependency reduced poms and js-libraries ---------------- Commits: - 07b633b9: 6642: Ignoring dependency reduced poms and js-libraries Changes: https://git.openjdk.java.net/jmc/pull/7/files Webrev: https://webrevs.openjdk.java.net/jmc/7/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6642 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/7/head:pull/7 PR: https://git.openjdk.java.net/jmc/pull/7 From hdafgard at openjdk.java.net Sat Nov 23 20:35:47 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sat, 23 Nov 2019 20:35:47 GMT Subject: [Approved] RFR: 6642: Ignoring dependency reduced poms and js-libraries In-Reply-To: <7uEMZZJRLZWSt4w7XQ2C3Jo7epNlJgvAljUR79aCtPw=.a2511f9f-298f-44ef-9bae-34d314edb59b@github.com> References: <7uEMZZJRLZWSt4w7XQ2C3Jo7epNlJgvAljUR79aCtPw=.a2511f9f-298f-44ef-9bae-34d314edb59b@github.com> Message-ID: <9NCWD3Zoetg_qCr99O_lfsVTKp1exm4KXrA7JsOjzPo=.9b8991f0-a8cc-4298-98c7-6fd04a7f23a9@github.com> On Sat, 23 Nov 2019 01:20:04 GMT, Marcus Hirt wrote: > 6642: Ignoring dependency reduced poms and js-libraries > > ---------------- > > Commits: > - 07b633b9: 6642: Ignoring dependency reduced poms and js-libraries > > Changes: https://git.openjdk.java.net/jmc/pull/7/files > Webrev: https://webrevs.openjdk.java.net/jmc/7/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6642 > Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jmc/pull/7.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/7/head:pull/7 Very good change! ---------------- Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/7 From hirt at openjdk.java.net Sun Nov 24 00:07:38 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sun, 24 Nov 2019 00:07:38 GMT Subject: [Integrated] RFR: 6642: Ignoring dependency reduced poms and js-libraries In-Reply-To: <7uEMZZJRLZWSt4w7XQ2C3Jo7epNlJgvAljUR79aCtPw=.a2511f9f-298f-44ef-9bae-34d314edb59b@github.com> References: <7uEMZZJRLZWSt4w7XQ2C3Jo7epNlJgvAljUR79aCtPw=.a2511f9f-298f-44ef-9bae-34d314edb59b@github.com> Message-ID: <72c10ecc-7fc0-409d-90ad-e6c5adae0a43@openjdk.org> Changeset: 1d04ea0c Author: Marcus Hirt Date: 2019-11-24 00:06:34 +0000 URL: https://git.openjdk.java.net/jmc/commit/1d04ea0c 6642: Ignoring dependency reduced poms and js-libraries Reviewed-by: hdafgard ! .gitignore From hirt at openjdk.java.net Wed Nov 27 21:43:48 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 21:43:48 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code Message-ID: Note that you need to run with -Puitests to include the uitests for the spotless analysis. ---------------- Commits: - ca9cbb8b: Spotless for the uitests - f00eae06: Enabling spotless for everything but uitests (coming next) - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup Changes: https://git.openjdk.java.net/jmc/pull/8/files Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 22:53:36 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 22:53:36 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java line 127: > 126: IPath lastFolder = lastPathStr.isEmpty() ? IDESupportToolkit.getDefaultRecordingFolder() > 127: : Path.fromOSString(lastPathStr).removeLastSegments(1); > 128: I actually kind of like this one. Can spotless be configured to allow separating ternary operations like the old style? If they can't be on one line or three then maybe they should be expanded to if/else statements? Having it on just two lines makes it a little bit harder to see what's going on. PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 22:57:54 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 22:57:54 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 110: > 109: * @param percentile > 110: * - the percentile, as a {@link UnitLookup#NUMBER} > 111: * @return a pair with the computed duration as a {@link UnitLookup#TIMESPAN}, and item count as Do we want to remove the hyphen here while we're at it? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 143: > 142: * @param duration > 143: * - the specified duration quantity > 144: * @return the lowest duration equivalent to the supplied argument As above? PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 22:59:01 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 22:59:01 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 91: > 90: UnitLookup.NUMBER_UNITY.quantity(99.9), UnitLookup.NUMBER_UNITY.quantity(99.99), > 91: UnitLookup.NUMBER_UNITY.quantity(99.999), UnitLookup.NUMBER_UNITY.quantity(100.0),}; > 92: Do we want to consider allowing longer list literals to all have entries on separate lines? PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 22:59:19 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 22:59:19 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: <_sMYjD4lMrFpO8qcAOdVQsQRqf_dDSFk8ynuBddQX1k=.a40239d5-6a01-4785-bf5c-cb6ffe61f6bb@github.com> On Wed, 27 Nov 2019 22:53:36 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java line 127: > >> 126: IPath lastFolder = lastPathStr.isEmpty() ? IDESupportToolkit.getDefaultRecordingFolder() >> 127: : Path.fromOSString(lastPathStr).removeLastSegments(1); >> 128: > > I actually kind of like this one. Can spotless be configured to allow separating ternary operations like the old style? If they can't be on one line or three then maybe they should be expanded to if/else statements? Having it on just two lines makes it a little bit harder to see what's going on. There are a few cases where the formatting gets a bit worse, agreed. Not too many, and it usually has to do with line breaks. I think the two choices for these are to either make the formatter weaker (i.e. not touch explicit line breaks the user has entered), or increase the maximum line length. PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 23:00:11 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 23:00:11 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 130: > 129: * @param typeId > 130: * - the event type ID used to match events belonging to this series > 131: */ Hyphens. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:03:15 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:03:15 GMT Subject: [Rev 01] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - f02fa2c2: Cleaning up javadocs Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/ca9cbb8b..f02fa2c2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:03:18 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:03:18 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 22:57:54 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 110: > >> 109: * @param percentile >> 110: * - the percentile, as a {@link UnitLookup#NUMBER} >> 111: * @return a pair with the computed duration as a {@link UnitLookup#TIMESPAN}, and item count as > > Do we want to remove the hyphen here while we're at it? > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 143: > >> 142: * @param duration >> 143: * - the specified duration quantity >> 144: * @return the lowest duration equivalent to the supplied argument > > As above? Done! (Not that it's really part of this work, but always leave the camping ground cleaner. ;) ) PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:04:58 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:04:58 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 22:59:01 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 91: > >> 90: UnitLookup.NUMBER_UNITY.quantity(99.9), UnitLookup.NUMBER_UNITY.quantity(99.99), >> 91: UnitLookup.NUMBER_UNITY.quantity(99.999), UnitLookup.NUMBER_UNITY.quantity(100.0),}; >> 92: > > Do we want to consider allowing longer list literals to all have entries on separate lines? For places where we really want finer control, we can use // @formatter:off ... // @formatter:on PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:11:05 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:11:05 GMT Subject: [Rev 02] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - feac6473: Prettifying formatting - formatter off example Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/f02fa2c2..feac6473 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.01-02 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 11 lines in 1 file changed: 7 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:11:08 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:11:08 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: <2_yad28c3FxlxQrGUlw26MSQmIP7m04FqXEdt_Qvqv4=.60370610-1a31-468a-ac1a-6d9a10567b0f@github.com> On Wed, 27 Nov 2019 23:04:58 GMT, Marcus Hirt wrote: > On Wed, 27 Nov 2019 22:59:01 GMT, Henrik Dafg?rd wrote: > >> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: >> >>> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >>> >>> ---------------- >>> >>> Commits: >>> - ca9cbb8b: Spotless for the uitests >>> - f00eae06: Enabling spotless for everything but uitests (coming next) >>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >>> >>> Changes: https://git.openjdk.java.net/jmc/pull/8/files >>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 >> >> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 91: >> >>> 90: UnitLookup.NUMBER_UNITY.quantity(99.9), UnitLookup.NUMBER_UNITY.quantity(99.99), >>> 91: UnitLookup.NUMBER_UNITY.quantity(99.999), UnitLookup.NUMBER_UNITY.quantity(100.0),}; >>> 92: >> >> Do we want to consider allowing longer list literals to all have entries on separate lines? > > For places where we really want finer control, we can use > // @formatter:off > ... > // @formatter:on Added an example. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:11:08 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:11:08 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 23:00:11 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 130: > >> 129: * @param typeId >> 130: * - the event type ID used to match events belonging to this series >> 131: */ > > Hyphens. Hm. Not sure. But I'll clean up this one. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:13:33 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:13:33 GMT Subject: [Rev 03] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: <80xd2Cak-mLM0XeJ-nfVRbLkqy9OS2ngmIsR-Yp0bJ4=.79c47760-3262-455f-98b5-1c614b1a7889@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 433f1d13: More javadoc cleanup Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/feac6473..433f1d13 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.03 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.02-03 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 17 lines in 1 file changed: 0 ins; 2 del; 15 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:15:08 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:15:08 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: <_sMYjD4lMrFpO8qcAOdVQsQRqf_dDSFk8ynuBddQX1k=.a40239d5-6a01-4785-bf5c-cb6ffe61f6bb@github.com> References: <_sMYjD4lMrFpO8qcAOdVQsQRqf_dDSFk8ynuBddQX1k=.a40239d5-6a01-4785-bf5c-cb6ffe61f6bb@github.com> Message-ID: On Wed, 27 Nov 2019 22:59:19 GMT, Marcus Hirt wrote: > On Wed, 27 Nov 2019 22:53:36 GMT, Henrik Dafg?rd wrote: > >> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: >> >>> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >>> >>> ---------------- >>> >>> Commits: >>> - ca9cbb8b: Spotless for the uitests >>> - f00eae06: Enabling spotless for everything but uitests (coming next) >>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >>> >>> Changes: https://git.openjdk.java.net/jmc/pull/8/files >>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 >> >> application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java line 127: >> >>> 126: IPath lastFolder = lastPathStr.isEmpty() ? IDESupportToolkit.getDefaultRecordingFolder() >>> 127: : Path.fromOSString(lastPathStr).removeLastSegments(1); >>> 128: >> >> I actually kind of like this one. Can spotless be configured to allow separating ternary operations like the old style? If they can't be on one line or three then maybe they should be expanded to if/else statements? Having it on just two lines makes it a little bit harder to see what's going on. > > There are a few cases where the formatting gets a bit worse, agreed. Not too many, and it usually has to do with line breaks. I think the two choices for these are to either make the formatter weaker (i.e. not touch explicit line breaks the user has entered), or increase the maximum line length. I think I can live with this one. Let me know if you disagree! PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:25:30 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:25:30 GMT Subject: [Rev 04] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 0577cb79: Cleaner formatting Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/433f1d13..0577cb79 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.04 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.03-04 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 23:26:26 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 23:26:26 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/WelcomePageTest.java line 50: > 49: /** > 50: * Open and close the Welcome page > 51: */ Can spotless be configured for javadoc to either require that a sentence start with lowercase or ends with a period? PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 23:28:05 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 23:28:05 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > Note that you need to run with -Puitests to include the uitests for the spotless analysis. > > ---------------- > > Commits: > - ca9cbb8b: Spotless for the uitests > - f00eae06: Enabling spotless for everything but uitests (coming next) > - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup > > Changes: https://git.openjdk.java.net/jmc/pull/8/files > Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java line 58: > 57: {251007, 223, 41055, 3533}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6}, > 58: {251007, 223, 43519, 6},}; > 59: Here I'd definitely like to keep the old structure. application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java line 58: > 57: {999292927, 7, 1814527, 4}, {999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1}, > 58: {999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1},}; > 59: As above. PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 23:30:51 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 23:30:51 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: <_sMYjD4lMrFpO8qcAOdVQsQRqf_dDSFk8ynuBddQX1k=.a40239d5-6a01-4785-bf5c-cb6ffe61f6bb@github.com> Message-ID: On Wed, 27 Nov 2019 23:15:08 GMT, Marcus Hirt wrote: > On Wed, 27 Nov 2019 22:59:19 GMT, Marcus Hirt wrote: > >> On Wed, 27 Nov 2019 22:53:36 GMT, Henrik Dafg?rd wrote: >> >>> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: >>> >>>> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - ca9cbb8b: Spotless for the uitests >>>> - f00eae06: Enabling spotless for everything but uitests (coming next) >>>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >>>> >>>> Changes: https://git.openjdk.java.net/jmc/pull/8/files >>>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >>>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >>>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 >>> >>> application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java line 127: >>> >>>> 126: IPath lastFolder = lastPathStr.isEmpty() ? IDESupportToolkit.getDefaultRecordingFolder() >>>> 127: : Path.fromOSString(lastPathStr).removeLastSegments(1); >>>> 128: >>> >>> I actually kind of like this one. Can spotless be configured to allow separating ternary operations like the old style? If they can't be on one line or three then maybe they should be expanded to if/else statements? Having it on just two lines makes it a little bit harder to see what's going on. >> >> There are a few cases where the formatting gets a bit worse, agreed. Not too many, and it usually has to do with line breaks. I think the two choices for these are to either make the formatter weaker (i.e. not touch explicit line breaks the user has entered), or increase the maximum line length. > > I think I can live with this one. Let me know if you disagree! I can live with that one, but the matrices are a bit harder to accept. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:33:59 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:33:59 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 23:26:26 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/WelcomePageTest.java line 50: > >> 49: /** >> 50: * Open and close the Welcome page >> 51: */ > > Can spotless be configured for javadoc to either require that a sentence start with lowercase or ends with a period? I don't think so, but I'd like to keep it so that if it has been formatted from within Eclipse, it should pass. We can add more sophisticated stuff, including XML file formatting, later. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:37:55 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:37:55 GMT Subject: [Rev 05] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 5c2d7dcc: Special formatting Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/0577cb79..5c2d7dcc Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.05 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.04-05 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:41:57 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:41:57 GMT Subject: [Rev 06] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 153278f2: Adding missing full-stop Changes: - all: https://git.openjdk.java.net/jmc/pull/8/files - new: https://git.openjdk.java.net/jmc/pull/8/files/5c2d7dcc..153278f2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/8/webrev.06 - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.05-06 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:55:36 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:55:36 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: <_sMYjD4lMrFpO8qcAOdVQsQRqf_dDSFk8ynuBddQX1k=.a40239d5-6a01-4785-bf5c-cb6ffe61f6bb@github.com> Message-ID: On Wed, 27 Nov 2019 23:30:51 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 23:15:08 GMT, Marcus Hirt wrote: > >> On Wed, 27 Nov 2019 22:59:19 GMT, Marcus Hirt wrote: >> >>> On Wed, 27 Nov 2019 22:53:36 GMT, Henrik Dafg?rd wrote: >>> >>>> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: >>>> >>>>> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - ca9cbb8b: Spotless for the uitests >>>>> - f00eae06: Enabling spotless for everything but uitests (coming next) >>>>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >>>>> >>>>> Changes: https://git.openjdk.java.net/jmc/pull/8/files >>>>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >>>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >>>>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >>>>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 >>>> >>>> application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java line 127: >>>> >>>>> 126: IPath lastFolder = lastPathStr.isEmpty() ? IDESupportToolkit.getDefaultRecordingFolder() >>>>> 127: : Path.fromOSString(lastPathStr).removeLastSegments(1); >>>>> 128: >>>> >>>> I actually kind of like this one. Can spotless be configured to allow separating ternary operations like the old style? If they can't be on one line or three then maybe they should be expanded to if/else statements? Having it on just two lines makes it a little bit harder to see what's going on. >>> >>> There are a few cases where the formatting gets a bit worse, agreed. Not too many, and it usually has to do with line breaks. I think the two choices for these are to either make the formatter weaker (i.e. not touch explicit line breaks the user has entered), or increase the maximum line length. >> >> I think I can live with this one. Let me know if you disagree! > > I can live with that one, but the matrices are a bit harder to accept. They should now be fixed. PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Wed Nov 27 23:55:36 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 27 Nov 2019 23:55:36 GMT Subject: RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 23:28:05 GMT, Henrik Dafg?rd wrote: > On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt wrote: > >> Note that you need to run with -Puitests to include the uitests for the spotless analysis. >> >> ---------------- >> >> Commits: >> - ca9cbb8b: Spotless for the uitests >> - f00eae06: Enabling spotless for everything but uitests (coming next) >> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup >> >> Changes: https://git.openjdk.java.net/jmc/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JMC-6639 >> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod >> Patch: https://git.openjdk.java.net/jmc/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 > > application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java line 58: > >> 57: {251007, 223, 41055, 3533}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6}, >> 58: {251007, 223, 43519, 6},}; >> 59: > > Here I'd definitely like to keep the old structure. > > application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java line 58: > >> 57: {999292927, 7, 1814527, 4}, {999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1}, >> 58: {999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1},}; >> 59: > > As above. Yep. PR: https://git.openjdk.java.net/jmc/pull/8 From hdafgard at openjdk.java.net Wed Nov 27 23:59:59 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 27 Nov 2019 23:59:59 GMT Subject: [Approved] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 23:41:57 GMT, Marcus Hirt wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 153278f2: Adding missing full-stop > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/8/files > - new: https://git.openjdk.java.net/jmc/pull/8/files/5c2d7dcc..153278f2 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/8/webrev.06 > - incr: https://webrevs.openjdk.java.net/jmc/8/webrev.05-06 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jmc/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8 Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/8 From hirt at openjdk.java.net Thu Nov 28 00:03:40 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 00:03:40 GMT Subject: [Integrated] RFR: 6639: Adding spotless for the rest of the java code In-Reply-To: References: Message-ID: Changeset: 3caaf739 Author: Marcus Hirt Date: 2019-11-28 00:02:51 +0000 URL: https://git.openjdk.java.net/jmc/commit/3caaf739 6639: Adding spotless for the rest of the java code Reviewed-by: hdafgard ! .gitignore ! application/coverage/pom.xml ! application/l10n/org.openjdk.jmc.alert.ja/pom.xml ! application/l10n/org.openjdk.jmc.alert.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.docs.ja/pom.xml ! application/l10n/org.openjdk.jmc.docs.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.zh_CN/pom.xml ! application/l10n/pom.xml ! application/org.openjdk.jmc.alert/pom.xml ! application/org.openjdk.jmc.alert/src/main/java/org/openjdk/jmc/alert/AlertDialog.java ! application/org.openjdk.jmc.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalConnectionDescriptor.java ! application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java ! application/org.openjdk.jmc.browser.jdp/pom.xml ! application/org.openjdk.jmc.browser/pom.xml ! application/org.openjdk.jmc.commands/pom.xml ! application/org.openjdk.jmc.console.jconsole/pom.xml ! application/org.openjdk.jmc.console.pde/pom.xml ! application/org.openjdk.jmc.console.persistence/pom.xml ! application/org.openjdk.jmc.console.twitter/pom.xml ! application/org.openjdk.jmc.console.ui.diagnostic/pom.xml ! application/org.openjdk.jmc.console.ui.mbeanbrowser/pom.xml ! application/org.openjdk.jmc.console.ui.notification/pom.xml ! application/org.openjdk.jmc.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.console.ui/pom.xml ! application/org.openjdk.jmc.docs/pom.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.feature.console/pom.xml ! application/org.openjdk.jmc.feature.core/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/pom.xml ! application/org.openjdk.jmc.feature.ide.launch/pom.xml ! application/org.openjdk.jmc.feature.ide/pom.xml ! application/org.openjdk.jmc.feature.jconsole/pom.xml ! application/org.openjdk.jmc.feature.joverflow/pom.xml ! application/org.openjdk.jmc.feature.license/pom.xml ! application/org.openjdk.jmc.feature.pde/pom.xml ! application/org.openjdk.jmc.feature.rcp.update/pom.xml ! application/org.openjdk.jmc.feature.rcp/pom.xml ! application/org.openjdk.jmc.feature.twitter/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/events/IEventConfiguration.java ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/EventConfiguration.java ! application/org.openjdk.jmc.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxConstants.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java ! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxVersionUtil.java ! application/org.openjdk.jmc.flightrecorder.flameview/pom.xml ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java ! application/org.openjdk.jmc.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.flightrecorder.pde/pom.xml ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/DataPageDescriptor.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrPropertySheet.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ClassLoadingPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/CodeCachePage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/FileIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/MemoryLeakPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/RecordingPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/SocketIOPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/AttributeComponentConfiguration.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java ! application/org.openjdk.jmc.greychart.ui/pom.xml ! application/org.openjdk.jmc.greychart/pom.xml ! application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/GreyChartPanel.java ! application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultVerticalIndexRenderer.java ! application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultXYGreyChart.java ! application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/providers/AveragingSampleBuffer.java ! application/org.openjdk.jmc.ide.jdt/pom.xml ! application/org.openjdk.jmc.ide.launch/pom.xml ! application/org.openjdk.jmc.ide.ui/pom.xml ! application/org.openjdk.jmc.jdp/pom.xml ! application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/ConfigurationFactory.java ! application/org.openjdk.jmc.joverflow.ui/pom.xml ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowUi.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/JavaThingItem.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/MemoryStatisticsItem.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelLoader.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelLoaderListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ObjectCluster.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferenceChain.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItem.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItemBuilder.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/BaseArcAttributeProvider.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/ColorIndexedArcAttributeProvider.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/AncestorViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ClusterGroupViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingTreeViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTableViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/PieChartViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTreeViewer.java ! application/org.openjdk.jmc.joverflow/pom.xml ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/batch/BatchProblemRecorder.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/batch/ReferencedObjCluster.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/descriptors/ConcurrentHashMapDescriptorForJdk8.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/JavaClass.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/JavaHeapObject.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/package-info.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/stats/DetailedStatsCalculator.java ! application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/support/DupStringStats.java ! application/org.openjdk.jmc.osgi.extension/pom.xml ! application/org.openjdk.jmc.pde/pom.xml ! application/org.openjdk.jmc.rcp.application/pom.xml ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/AddRepositoriesJob.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/p2/P2Toolkit.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/scripting/ControlContentAdapter.java ! application/org.openjdk.jmc.rcp.intro/pom.xml ! application/org.openjdk.jmc.rcp.product.feature/pom.xml ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/IFlightRecorderService.java ! application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/IRecordingDescriptor.java ! application/org.openjdk.jmc.rjmx.ui/pom.xml ! application/org.openjdk.jmc.rjmx/pom.xml ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/IServerHandle.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/MCMBeanServerConnection.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/RJMXConnection.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/package-info.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/Jdk11CommercialFeaturesService.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/package-info.java ! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/package-info.java ! application/org.openjdk.jmc.ui.common/pom.xml ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IIDESupport.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/SecurityManagerFactory.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/Environment.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/IDisconnectable.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/MCVersion.java ! application/org.openjdk.jmc.ui/pom.xml ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/MCPathEditorInput.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/IChartInfoVisitor.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/RendererToolkit.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/SpanRenderer.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/SubdividedQuantityRange.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/dial/DialDevice.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/AwtCanvas.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/FilterEditor.java ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/FormatToolkit.java ! application/org.openjdk.jmc.updatesite.ide/pom.xml ! application/org.openjdk.jmc.updatesite.rcp/pom.xml ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/impl/SampleBufferTest.java ! application/tests/org.openjdk.jmc.ide.launch.test/pom.xml ! application/tests/org.openjdk.jmc.jdp.test/pom.xml ! application/tests/org.openjdk.jmc.joverflow.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrTestSuite.java ! application/tests/org.openjdk.jmc.rjmx.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/AllRJMXTests.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/BasicCommunicationTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/DefaultServicesTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/RJMXConnectionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/TabularDataBeanTestMBean.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeValueTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/CompositeDataSubscriptionTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MRIMetadataServiceTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/ConsoleAttributeInfoManagerTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/SyntheticNotificationTest.java ! application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationTriggerAndRuleTest.java ! application/tests/org.openjdk.jmc.ui.common.test/pom.xml ! application/tests/org.openjdk.jmc.ui.common.test/src/test/java/org/openjdk/jmc/ui/common/jvm/JVMCommandLineToolkitTest.java ! application/tests/org.openjdk.jmc.ui.test/pom.xml ! application/tests/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/src/test/java/org/openjdk/jmc/browser/uitest/CustomConnectionsTest.java ! application/uitests/org.openjdk.jmc.console.jconsole.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/src/test/java/org/openjdk/jmc/console/persistence/uitest/PersistenceTest.java ! application/uitests/org.openjdk.jmc.console.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/AccessibilityTest.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsoleMemoryLeakTest.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/ConsolePreferencesTest.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/MBeanBrowserTabTest.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/WelcomePageTest.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/Mbean2Runner.java ! application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/Testable.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/pom.xml ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/ControlRecordingsTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrRecordingTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrThreadsPageTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/JfrWizardTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/OldRecordingsVerificationTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/StackTraceComponentTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/TemplateManagerTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/jvmflags/DynamicEnablementTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/IOPageTestBase.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java ! application/uitests/org.openjdk.jmc.rcp.application.uitest/pom.xml ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/MCJemmyTestBase.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/base/wrappers/MCJemmyBase.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrNavigator.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrUi.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JvmBrowser.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCButton.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCCCombo.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCChartCanvas.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCDialog.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCForm.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCMenu.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTabFolder.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTable.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCText.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCToolBar.java ! application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/misc/wrappers/MCTree.java ! application/uitests/pom.xml ! core/coverage/pom.xml ! core/pom.xml ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-2018-12/pom.xml ! releng/platform-definitions/platform-definition-2019-03/pom.xml ! releng/platform-definitions/platform-definition-2019-06/pom.xml ! releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml ! releng/pom.xml ! releng/third-party/pom.xml From hirt at openjdk.java.net Thu Nov 28 08:32:57 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 08:32:57 GMT Subject: RFR: 6639: Fixing whitespace error on Mac Message-ID: 6639: Fixing whitespace error on Mac ---------------- Commits: - 60c08c09: 6639: Fixing whitespace error on Mac Changes: https://git.openjdk.java.net/jmc/pull/9/files Webrev: https://webrevs.openjdk.java.net/jmc/9/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 253 lines in 1 file changed: 0 ins; 0 del; 253 mod Patch: https://git.openjdk.java.net/jmc/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/9/head:pull/9 PR: https://git.openjdk.java.net/jmc/pull/9 From hirt at openjdk.java.net Thu Nov 28 10:22:39 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 10:22:39 GMT Subject: [Rev 01] RFR: 6639: Fixing whitespace error on Mac In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 5d49d378: Another whitespace fix Changes: - all: https://git.openjdk.java.net/jmc/pull/9/files - new: https://git.openjdk.java.net/jmc/pull/9/files/60c08c09..5d49d378 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/9/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/9/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6639 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/9/head:pull/9 PR: https://git.openjdk.java.net/jmc/pull/9 From hdafgard at openjdk.java.net Thu Nov 28 12:00:20 2019 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 28 Nov 2019 12:00:20 GMT Subject: [Approved] RFR: 6639: Fixing whitespace error on Mac In-Reply-To: References: Message-ID: On Thu, 28 Nov 2019 10:22:39 GMT, Marcus Hirt wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 5d49d378: Another whitespace fix > > Changes: > - all: https://git.openjdk.java.net/jmc/pull/9/files > - new: https://git.openjdk.java.net/jmc/pull/9/files/60c08c09..5d49d378 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jmc/9/webrev.01 > - incr: https://webrevs.openjdk.java.net/jmc/9/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JMC-6639 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jmc/pull/9.diff > Fetch: git fetch https://git.openjdk.java.net/jmc pull/9/head:pull/9 Approved by hdafgard (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/9 From hirt at openjdk.java.net Thu Nov 28 12:58:40 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 12:58:40 GMT Subject: [Integrated] RFR: 6639: Fixing whitespace error on Mac In-Reply-To: References: Message-ID: <09b5f293-de0a-4132-ac5c-3a262f406968@openjdk.org> Changeset: 44a9a676 Author: Marcus Hirt Date: 2019-11-28 12:58:22 +0000 URL: https://git.openjdk.java.net/jmc/commit/44a9a676 6639: Fixing whitespace error on Mac Reviewed-by: hdafgard ! application/org.openjdk.jmc.alert/src/main/java/org/openjdk/jmc/alert/AlertDialog.java ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java From hirt at openjdk.java.net Thu Nov 28 23:52:00 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 23:52:00 GMT Subject: RFR: 6640: Run spotless and tests as part of the workflow Message-ID: Running the tests on Linux, Mac OS X and Windows. Holding off a bit on the UI-tests for now. ---------------- Commits: - d312b938: Want scripts - 6c2b8533: Installing core before the formatting check - 7158f059: More windows fun - 5a0b675e: Fixing windows formatting script - b08ef9a3: Adding scripts for checking formatting and running tests - 1aea5e6e: Better name - 80d352f3: Testing Changes: https://git.openjdk.java.net/jmc/pull/10/files Webrev: https://webrevs.openjdk.java.net/jmc/10/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6640 Stats: 106 lines in 8 files changed: 105 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/10/head:pull/10 PR: https://git.openjdk.java.net/jmc/pull/10 From hirt at openjdk.java.net Thu Nov 28 23:55:40 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 28 Nov 2019 23:55:40 GMT Subject: [Rev 01] RFR: 6640: Run spotless and tests as part of the workflow In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - a11c6c31: Cleanup Changes: - all: https://git.openjdk.java.net/jmc/pull/10/files - new: https://git.openjdk.java.net/jmc/pull/10/files/d312b938..a11c6c31 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/10/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/10/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JMC-6640 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/10/head:pull/10 PR: https://git.openjdk.java.net/jmc/pull/10 From hirt at openjdk.java.net Fri Nov 29 00:22:50 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 29 Nov 2019 00:22:50 GMT Subject: [Rev 02] RFR: 6640: Run spotless and tests as part of the workflow In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 0e59ae91: Optimizations and windows bugfix Changes: - all: https://git.openjdk.java.net/jmc/pull/10/files - new: https://git.openjdk.java.net/jmc/pull/10/files/a11c6c31..0e59ae91 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/10/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/10/webrev.01-02 Issue: https://bugs.openjdk.java.net/browse/JMC-6640 Stats: 14 lines in 4 files changed: 5 ins; 2 del; 7 mod Patch: https://git.openjdk.java.net/jmc/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/10/head:pull/10 PR: https://git.openjdk.java.net/jmc/pull/10 From hirt at openjdk.java.net Fri Nov 29 00:37:39 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 29 Nov 2019 00:37:39 GMT Subject: [Rev 03] RFR: 6640: Run spotless and tests as part of the workflow In-Reply-To: References: Message-ID: <0smZG6UNE2OlCrfIlRMAEJ_Tr522vYRs2EkPc8J1ZCE=.e4f85bd8-a066-4ca3-9e33-474ec3ea0e60@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - e2d8a1d7: Windows and I are not friends Changes: - all: https://git.openjdk.java.net/jmc/pull/10/files - new: https://git.openjdk.java.net/jmc/pull/10/files/0e59ae91..e2d8a1d7 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/10/webrev.03 - incr: https://webrevs.openjdk.java.net/jmc/10/webrev.02-03 Issue: https://bugs.openjdk.java.net/browse/JMC-6640 Stats: 8 lines in 1 file changed: 4 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/10/head:pull/10 PR: https://git.openjdk.java.net/jmc/pull/10 From hirt at openjdk.java.net Fri Nov 29 13:22:47 2019 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 29 Nov 2019 13:22:47 GMT Subject: [Rev 04] RFR: 6640: Run spotless and tests as part of the workflow In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - c41f5c0f: Making the .gitignore better whilst forcing a rerun to ensure that passing on all platforms was more than a lucky break Changes: - all: https://git.openjdk.java.net/jmc/pull/10/files - new: https://git.openjdk.java.net/jmc/pull/10/files/e2d8a1d7..c41f5c0f Webrevs: - full: https://webrevs.openjdk.java.net/jmc/10/webrev.04 - incr: https://webrevs.openjdk.java.net/jmc/10/webrev.03-04 Issue: https://bugs.openjdk.java.net/browse/JMC-6640 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/10/head:pull/10 PR: https://git.openjdk.java.net/jmc/pull/10