[Rev 01] RFR: 6632: Tighten up english rule messages

[Henrik Dafgård]

On Fri, 22 Nov 2019 20:40:49 GMT, Dan Benamy <github.com+16651846+dbenamydd at openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - 5348b73f: Fix typos
> 
> Changes:
>   - all: https://git.openjdk.java.net/jmc/pull/3/files
>   - new: https://git.openjdk.java.net/jmc/pull/3/files/36815004..5348b73f
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jmc/3/webrev.01
>  - incr: https://webrevs.openjdk.java.net/jmc/3/webrev.00-01
> 
>   Issue: https://bugs.openjdk.java.net/browse/JMC-6632
>   Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
>   Patch: https://git.openjdk.java.net/jmc/pull/3.diff
>   Fetch: git fetch https://git.openjdk.java.net/jmc pull/3/head:pull/3

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 404:

> 403: # {0} is a size in bytes, {1} is a size in bytes
> 404: LongGcPauseRuleFactory_TEXT_INFO_MX=The application ran with a live set of {0} and a heap size of {1}. Decreasing the heap size may decrease the garbage collection pause times.
> 405: LongGcPauseRuleFactory_TEXT_INFO_REFERENCES=Processing reference objects was a considerable part of the garbage collector pauses. You may be able to decrease this by reducing the amount of references or by enabling parallel reference processing with '-XX:+ParallelRefProcEnabled'.

blocking

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 614:

> 613: TlabAllocationRatioRuleFactory_TEXT_OK_NO_OUTSIDE=No object allocations outside of TLABs detected.
> 614: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO=The recording was performed on a JVM that had Experimental VM Options enabled.
> 615: UnlockExperimentalVMOptionsRuleFactory_TEXT_INFO_LONG=Experimental VM options may be unreliable and should not be used in a production environment. Unless you have to use an experimental option, you should avoid the '-XX:+UnlockExperimentalVMOptions' command line option.

> ...and isn't usually needed.

This part feels a little awkward to me.

PR: https://git.openjdk.java.net/jmc/pull/3