RFR: 6639: Adding spotless for the rest of the java code
Marcus Hirt
hirt at openjdk.java.net
Wed Nov 27 23:03:18 UTC 2019
On Wed, 27 Nov 2019 22:57:54 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>
>> Note that you need to run with -Puitests to include the uitests for the spotless analysis.
>>
>> ----------------
>>
>> Commits:
>> - ca9cbb8b: Spotless for the uitests
>> - f00eae06: Enabling spotless for everything but uitests (coming next)
>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup
>>
>> Changes: https://git.openjdk.java.net/jmc/pull/8/files
>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00
>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639
>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod
>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff
>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 110:
>
>> 109: * @param percentile
>> 110: * - the percentile, as a {@link UnitLookup#NUMBER}
>> 111: * @return a pair with the computed duration as a {@link UnitLookup#TIMESPAN}, and item count as
>
> Do we want to remove the hyphen here while we're at it?
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java line 143:
>
>> 142: * @param duration
>> 143: * - the specified duration quantity
>> 144: * @return the lowest duration equivalent to the supplied argument
>
> As above?
Done! (Not that it's really part of this work, but always leave the camping ground cleaner. ;) )
PR: https://git.openjdk.java.net/jmc/pull/8
More information about the jmc-dev
mailing list