RFR: 6639: Adding spotless for the rest of the java code

Marcus Hirt hirt at openjdk.java.net
Wed Nov 27 23:11:08 UTC 2019


On Wed, 27 Nov 2019 23:04:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> On Wed, 27 Nov 2019 22:59:01 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
> 
>> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> 
>>> Note that you need to run with -Puitests to include the uitests for the spotless analysis.
>>> 
>>> ----------------
>>> 
>>> Commits:
>>>  - ca9cbb8b: Spotless for the uitests
>>>  - f00eae06: Enabling spotless for everything but uitests (coming next)
>>>  - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup
>>> 
>>> Changes: https://git.openjdk.java.net/jmc/pull/8/files
>>>  Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00
>>>   Issue: https://bugs.openjdk.java.net/browse/JMC-6639
>>>   Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod
>>>   Patch: https://git.openjdk.java.net/jmc/pull/8.diff
>>>   Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8
>> 
>> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java line 91:
>> 
>>> 90: 			UnitLookup.NUMBER_UNITY.quantity(99.9), UnitLookup.NUMBER_UNITY.quantity(99.99),
>>> 91: 			UnitLookup.NUMBER_UNITY.quantity(99.999), UnitLookup.NUMBER_UNITY.quantity(100.0),};
>>> 92: 
>> 
>> Do we want to consider allowing longer list literals to all have entries on separate lines?
> 
> For places where we really want finer control, we can use 
> // @formatter:off
> ...
> // @formatter:on

Added an example.

PR: https://git.openjdk.java.net/jmc/pull/8


More information about the jmc-dev mailing list